diff options
| author | Andrew Tridgell <tridge@samba.org> | 2010-09-15 11:21:43 +1000 |
|---|---|---|
| committer | Andrew Tridgell <tridge@samba.org> | 2010-09-15 15:39:36 +1000 |
| commit | 0212800de8c6367c9da7939fc43a1fa23c7da2bf (patch) | |
| tree | 1a6f1281cc46b41ec8edcc4d1c239c115a99dfa0 /upgrading-samba4.txt | |
| parent | 0009d1771a757c1df152693840991ecc57564f34 (diff) | |
| download | samba-0212800de8c6367c9da7939fc43a1fa23c7da2bf.tar.gz samba-0212800de8c6367c9da7939fc43a1fa23c7da2bf.tar.bz2 samba-0212800de8c6367c9da7939fc43a1fa23c7da2bf.zip | |
tsocket: we return -1 on error, not fd
the code used this pattent:
if (fd < 0) {
...various cleanups...
return fd;
}
it is much clearer to do this:
if (fd < 0) {
...various cleanups...
return -1;
}
as otherwise when reading the code you think this function may return
a fd.
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
Diffstat (limited to 'upgrading-samba4.txt')
0 files changed, 0 insertions, 0 deletions