diff options
| -rw-r--r-- | source4/libcli/util/dom_sid.c | 2 | ||||
| -rw-r--r-- | source4/torture/rpc/lsa.c | 54 |
2 files changed, 55 insertions, 1 deletions
diff --git a/source4/libcli/util/dom_sid.c b/source4/libcli/util/dom_sid.c index 9b8b45e302..0ca4cd731f 100644 --- a/source4/libcli/util/dom_sid.c +++ b/source4/libcli/util/dom_sid.c @@ -79,7 +79,7 @@ struct dom_sid *dom_sid_parse_talloc(TALLOC_CTX *mem_ctx, const char *sidstr) return NULL; } sidstr++; - ret->sub_auths[i] = strtol(sidstr, &p, 10); + ret->sub_auths[i] = strtoul(sidstr, &p, 10); if (p == sidstr) { return NULL; } diff --git a/source4/torture/rpc/lsa.c b/source4/torture/rpc/lsa.c index e3c603da17..44e1564992 100644 --- a/source4/torture/rpc/lsa.c +++ b/source4/torture/rpc/lsa.c @@ -181,6 +181,56 @@ static BOOL test_LookupSids(struct dcerpc_pipe *p, return True; } +static BOOL test_many_LookupSids(struct dcerpc_pipe *p, + TALLOC_CTX *mem_ctx, + struct policy_handle *handle) +{ + struct lsa_LookupSids r; + struct lsa_TransNameArray names; + uint32_t count; + NTSTATUS status; + struct lsa_SidArray sids; + int i; + + printf("\nTesting LookupSids with lots of SIDs\n"); + + names.count = 0; + names.names = NULL; + + sids.num_sids = 10000; + + sids.sids = talloc_array_p(mem_ctx, struct lsa_SidPtr, sids.num_sids); + + for (i=0; i<sids.num_sids; i++) { + const char *sidstr = "S-1-5-32-545"; + sids.sids[i].sid = dom_sid_parse_talloc(mem_ctx, sidstr); + } + + count = sids.num_sids; + + r.in.handle = handle; + r.in.sids = &sids; + r.in.names = &names; + r.in.level = 1; + r.in.count = &names.count; + r.out.count = &count; + r.out.names = &names; + + status = dcerpc_lsa_LookupSids(p, mem_ctx, &r); + if (!NT_STATUS_IS_OK(status) && !NT_STATUS_EQUAL(status, STATUS_SOME_UNMAPPED)) { + printf("LookupSids failed - %s\n", nt_errstr(status)); + return False; + } + + printf("\n"); + + if (!test_LookupNames(p, mem_ctx, handle, &names)) { + return False; + } + + return True; +} + static BOOL test_LookupPrivName(struct dcerpc_pipe *p, TALLOC_CTX *mem_ctx, struct policy_handle *handle, @@ -766,6 +816,10 @@ BOOL torture_rpc_lsa(int dummy) ret = False; } + if (!test_many_LookupSids(p, mem_ctx, &handle)) { + ret = False; + } + if (!test_CreateAccount(p, mem_ctx, &handle)) { ret = False; } |