diff options
| -rw-r--r-- | source4/scripting/python/samba/samba3.py | 11 | ||||
| -rw-r--r-- | source4/scripting/python/samba/tests/samba3.py | 6 | ||||
| -rw-r--r-- | source4/scripting/python/samba/upgrade.py | 2 |
3 files changed, 9 insertions, 10 deletions
diff --git a/source4/scripting/python/samba/samba3.py b/source4/scripting/python/samba/samba3.py index 809fd012a6..987367990d 100644 --- a/source4/scripting/python/samba/samba3.py +++ b/source4/scripting/python/samba/samba3.py @@ -509,7 +509,7 @@ class TdbSam(TdbDatabase): """Samba 3 TDB passdb backend reader.""" def _check_version(self): self.version = fetch_uint32(self.tdb, "INFO/version\0") or 0 - assert self.version in (0, 1, 2, 3) + assert self.version in (0, 1, 2) def usernames(self): """Iterate over the usernames in this Tdb database.""" @@ -592,11 +592,10 @@ class TdbSam(TdbDatabase): for entry in hours: for i in range(8): user.hours.append(ord(entry) & (2 ** i) == (2 ** i)) - # FIXME (reactivate also the tests in tests/samba3.py after fixing this) - #(user.bad_password_count, data) = unpack_uint16(data) - #(user.logon_count, data) = unpack_uint16(data) - #(user.unknown_6, data) = unpack_uint32(data) - #assert len(data) == 0 + (user.bad_password_count, data) = unpack_uint16(data) + (user.logon_count, data) = unpack_uint16(data) + (user.unknown_6, data) = unpack_uint32(data) + assert len(data) == 0 return user diff --git a/source4/scripting/python/samba/tests/samba3.py b/source4/scripting/python/samba/tests/samba3.py index 8128c51fa8..71e08bdd7f 100644 --- a/source4/scripting/python/samba/tests/samba3.py +++ b/source4/scripting/python/samba/tests/samba3.py @@ -122,15 +122,15 @@ class TdbSamTestCase(unittest.TestCase): user.logoff_time = 2147483647 user.acct_desc = "" user.group_rid = 1001 - # FIXME user.logon_count = 0 - # FIXME user.bad_password_count = 0 + user.logon_count = 0 + user.bad_password_count = 0 user.domain = "BEDWYR" user.munged_dial = "" user.workstations = "" user.user_rid = 1000 user.kickoff_time = 2147483647 user.logoff_time = 2147483647 - # FIXME user.unknown_6 = 1260L + user.unknown_6 = 1260L user.logon_divs = 0 user.hours = [True for i in range(168)] other = self.samdb["root"] diff --git a/source4/scripting/python/samba/upgrade.py b/source4/scripting/python/samba/upgrade.py index 3c45245113..205b43cf07 100644 --- a/source4/scripting/python/samba/upgrade.py +++ b/source4/scripting/python/samba/upgrade.py @@ -411,7 +411,7 @@ def upgrade_provision(samba3, setup_dir, message, credentials, session_info, hostname=netbiosname, machinepass=machinepass, serverrole=serverrole) - # FIXME: import_wins(Ldb(result.paths.winsdb), samba3.get_wins_db()) + import_wins(Ldb(result.paths.winsdb), samba3.get_wins_db()) # FIXME: import_registry(registry.Registry(), samba3.get_registry()) |