diff options
Diffstat (limited to 'source3/CodingSuggestions')
| -rw-r--r-- | source3/CodingSuggestions | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/source3/CodingSuggestions b/source3/CodingSuggestions index 48c51281f5..1ff3e01c1c 100644 --- a/source3/CodingSuggestions +++ b/source3/CodingSuggestions @@ -59,6 +59,11 @@ Here are some other suggestions: 6) explicitly add const qualifiers on parm passing in functions where parm is input only (somewhat controversial but const can be #defined away) +7) when passing a va_list as an arg, or assigning one to another, check + for HAVE_VA_COPY, and use it if it exists. + reason: on some platforms, va_list is a struct that must be + initialized in each function...can SEGV if you don't. + 8) discourage use of threads reason: portability (also see architecture.doc) |