diff options
Diffstat (limited to 'source3/rpcclient')
| -rw-r--r-- | source3/rpcclient/cmd_lsarpc.c | 11 | ||||
| -rw-r--r-- | source3/rpcclient/rpcclient.c | 4 |
2 files changed, 8 insertions, 7 deletions
diff --git a/source3/rpcclient/cmd_lsarpc.c b/source3/rpcclient/cmd_lsarpc.c index 597c950a24..3fca535ff0 100644 --- a/source3/rpcclient/cmd_lsarpc.c +++ b/source3/rpcclient/cmd_lsarpc.c @@ -192,6 +192,7 @@ static NTSTATUS cmd_lsa_lookup_sids(struct cli_state *cli, TALLOC_CTX *mem_ctx, char **names; uint32 *types; int i; + int nsids = atoi(argv[2]); if (argc == 1) { printf("Usage: %s [sid1 [sid2 [...]]]\n", argv[0]); @@ -207,22 +208,22 @@ static NTSTATUS cmd_lsa_lookup_sids(struct cli_state *cli, TALLOC_CTX *mem_ctx, /* Convert arguments to sids */ - sids = TALLOC_ARRAY(mem_ctx, DOM_SID, argc - 1); + sids = TALLOC_ARRAY(mem_ctx, DOM_SID, nsids); if (!sids) { printf("could not allocate memory for %d sids\n", argc - 1); goto done; } - for (i = 0; i < argc - 1; i++) - if (!string_to_sid(&sids[i], argv[i + 1])) { + for (i = 0; i < nsids; i++) + if (!string_to_sid(&sids[i], argv[1])) { result = NT_STATUS_INVALID_SID; goto done; } /* Lookup the SIDs */ - result = cli_lsa_lookup_sids(cli, mem_ctx, &pol, argc - 1, sids, + result = cli_lsa_lookup_sids(cli, mem_ctx, &pol, nsids, sids, &domains, &names, &types); if (!NT_STATUS_IS_OK(result) && NT_STATUS_V(result) != @@ -233,7 +234,7 @@ static NTSTATUS cmd_lsa_lookup_sids(struct cli_state *cli, TALLOC_CTX *mem_ctx, /* Print results */ - for (i = 0; i < (argc - 1); i++) { + for (i = 0; i < nsids; i++) { fstring sid_str; sid_to_string(sid_str, &sids[i]); diff --git a/source3/rpcclient/rpcclient.c b/source3/rpcclient/rpcclient.c index acb65b7f7c..85d1d848bf 100644 --- a/source3/rpcclient/rpcclient.c +++ b/source3/rpcclient/rpcclient.c @@ -100,7 +100,7 @@ static char **completion_fn(const char *text, int start, int end) static char* next_command (char** cmdstr) { - static pstring command; + static char command[10000]; char *p; if (!cmdstr || !(*cmdstr)) @@ -109,7 +109,7 @@ static char* next_command (char** cmdstr) p = strchr_m(*cmdstr, ';'); if (p) *p = '\0'; - pstrcpy(command, *cmdstr); + strncpy(command, *cmdstr, sizeof(command)); if (p) *cmdstr = p + 1; else |