diff options
Diffstat (limited to 'source3')
| -rw-r--r-- | source3/smbd/posix_acls.c | 14 |
1 files changed, 13 insertions, 1 deletions
diff --git a/source3/smbd/posix_acls.c b/source3/smbd/posix_acls.c index dc3585d81b..4ceb0f0452 100644 --- a/source3/smbd/posix_acls.c +++ b/source3/smbd/posix_acls.c @@ -3824,9 +3824,11 @@ NTSTATUS append_parent_acl(files_struct *fsp, Reply to set a security descriptor on an fsp. security_info_sent is the description of the following NT ACL. This should be the only external function needed for the UNIX style set ACL. + We make a copy of psd_orig as internal functions modify the elements inside + it, even though it's a const pointer. ****************************************************************************/ -NTSTATUS set_nt_acl(files_struct *fsp, uint32 security_info_sent, const struct security_descriptor *psd) +NTSTATUS set_nt_acl(files_struct *fsp, uint32 security_info_sent, const struct security_descriptor *psd_orig) { connection_struct *conn = fsp->conn; uid_t user = (uid_t)-1; @@ -3841,6 +3843,7 @@ NTSTATUS set_nt_acl(files_struct *fsp, uint32 security_info_sent, const struct s bool set_acl_as_root = false; bool acl_set_support = false; bool ret = false; + struct security_descriptor *psd = NULL; DEBUG(10,("set_nt_acl: called for file %s\n", fsp_str_dbg(fsp))); @@ -3850,6 +3853,15 @@ NTSTATUS set_nt_acl(files_struct *fsp, uint32 security_info_sent, const struct s return NT_STATUS_MEDIA_WRITE_PROTECTED; } + if (!psd_orig) { + return NT_STATUS_INVALID_PARAMETER; + } + + psd = dup_sec_desc(talloc_tos(), psd_orig); + if (!psd) { + return NT_STATUS_NO_MEMORY; + } + /* * Get the current state of the file. */ |