Age | Commit message (Collapse) | Author | Files | Lines |
|
metze
|
|
And do some more error checks.
metze
|
|
The results of some read(2) and write(2) calls are assigned into a
variable that is never used. Presumably this used to avoid compiler
warnings or similar.
However, from (approximately) GCC 4.6 this produces some warnings:
[ 609/3910] Compiling lib/tevent/tevent_signal.c
../lib/tevent/tevent_signal.c: In function ‘tevent_common_signal_handler’:
../lib/tevent/tevent_signal.c:85:10: warning: variable ‘res’ set but not used [-Wunused-but-set-variable]
../lib/tevent/tevent_signal.c: In function ‘signal_pipe_handler’:
../lib/tevent/tevent_signal.c:183:10: warning: variable ‘res’ set but not used [-Wunused-but-set-variable]
The simplest thing to do is remove the variables and cast the function
return to void. There is already a comment above each call.
Signed-off-by: Martin Schwenke <martin@meltin.net>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
|
|
Signed-off-by: Theresa Halloran <thallora@linux.vnet.ibm.com>
Signed-off-by: Andrew Tridgell <tridge@samba.org>
Autobuild-User: Andrew Tridgell <tridge@samba.org>
Autobuild-Date: Thu Nov 10 06:04:22 CET 2011 on sn-devel-104
|
|
Signed-off-by: Theresa Halloran <thallora@linux.vnet.ibm.com>
Signed-off-by: Andrew Tridgell <tridge@samba.org>
|
|
this fixes error checking. Test failures were not being detected
otherwise
Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
|
|
this is the attribute the admin needs for other commands
Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
|
|
Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
|
|
Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
|
|
this allows for:
subunitrun -D lib/ldb/tests/python api
which makes this easier for developers
|
|
it was failing previously, but the failure wasn't being noticed
|
|
this makes it much faster to run 1 test
Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
|
|
get() now takes a default value and an idx, allowing for much easier
usage
Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
|
|
|
|
|
|
|
|
pair programmed with Jelmer Vernooij
Add search to include secrets.ldb
|
|
Append '$' to name provided by user to search for a machine account
when necessary
|
|
Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
|
|
return NT_STATUS_NOT_FOUND instead of a segfault
Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
|
|
Signed-off-by: Andrew Tridgell <tridge@samba.org>
|
|
Signed-off-by: Andrew Tridgell <tridge@samba.org>
|
|
Signed-off-by: Andrew Tridgell <tridge@samba.org>
|
|
this allows for more sophisticated testing of samba-tool
Signed-off-by: Andrew Tridgell <tridge@samba.org>
|
|
This servicePrincipalName is incorrect (windows does not use that
servicePrincipalName, as it targets the server it is updating, not the
root of the DNS tree), and now that we have multiple DNS backends that
use the internal database, it is quite incorrect (as it cannot exist
on more than one account).
Andrew Bartlett
Autobuild-User: Andrew Bartlett <abartlet@samba.org>
Autobuild-Date: Thu Nov 10 01:11:46 CET 2011 on sn-devel-104
|
|
This may help to ensure we consistantly crash on an incorrect de-reference.
Andrew Bartlett
|
|
*pp_rmap may be NULL or un-initialised data.
This was introduced by 995d1567265be178b4e45f79ea4562a7041ffa52.
Andrew Bartlett
|
|
It is important to consider the result level regarding error
information. Windows 2000 seems to send us back v2, all other
implementations v3. Consider post "Joining W2k AD domain"
Reviewed-by: abartlet
Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org>
Autobuild-Date: Wed Nov 9 23:37:08 CET 2011 on sn-devel-104
|
|
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Nov 9 21:17:09 CET 2011 on sn-devel-104
|
|
Autobuild-User: Jelmer Vernooij <jelmer@samba.org>
Autobuild-Date: Wed Nov 9 19:43:07 CET 2011 on sn-devel-104
|
|
|
|
|
|
header files.
|
|
Skip the transaction for the upgrade code, if the database
is already at code-level.
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Nov 9 15:06:59 CET 2011 on sn-devel-104
|
|
Autobuild-User: Andreas Schneider <asn@cryptomilk.org>
Autobuild-Date: Wed Nov 9 13:31:27 CET 2011 on sn-devel-104
|
|
The first fix for bug #8357 intruduced a regression, so that we no
longer grant credits for real async interim responses with
STATUS_PENDING.
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Nov 9 11:56:29 CET 2011 on sn-devel-104
|
|
Otherwise we may get unexpected results.
This is a fix that was missing in commit 95595dd93fd04999fcf56ecaab7c29b064d021f8
(s3:libsmb: fix cli_write_and_x() against OS/2 print shares (bug #5326))
metze
Autobuild-User: Stefan Metzmacher <metze@samba.org>
Autobuild-Date: Wed Nov 9 10:13:32 CET 2011 on sn-devel-104
|
|
this allows easy comparison between windows and samba ldap trees
Autobuild-User: Amitay Isaacs <amitay@samba.org>
Autobuild-Date: Wed Nov 9 08:27:46 CET 2011 on sn-devel-104
|
|
|
|
Autobuild-User: Michael Adam <obnox@samba.org>
Autobuild-Date: Wed Nov 9 02:36:36 CET 2011 on sn-devel-104
|
|
|
|
|
|
smb2_oplock_create()
|
|
smb2_oplock_create()
|
|
smb2_lease_create_share()
|
|
smb2_oplock_create_share()
|
|
parameter
|
|
parameter
|
|
sharemode as parameter
|
|
util.c for re-use
|