| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
(This used to be commit b824245c4e04353f0d3fd0ccf6bc5776a601daed)
|
|
Jeremy.
(This used to be commit b9980bddf5ee74b2887196d6d1a0cf393720ba3a)
|
|
Jeremy.
(This used to be commit 94e869d9c6d1a1c1df0d072530bf8d4452bd10bb)
|
|
Fix Coverity # 214.
Volker
(This used to be commit 4a75edf9deca2be18670d7f9f2e383ed0898512c)
|
|
in the code explicit - but this was a false positive (CID #16).
Jeremy.
(This used to be commit 43a0e869f2aee9b4e22d0d7fc92051e82f7536ad)
|
|
Jeremy.
(This used to be commit af0ade470f2fac3509a44207b4572e279ba30e34)
|
|
mean the ttl instead.
Jeremy.
(This used to be commit ccb2a52e29de7e2847ccd93aa99236f63202a4af)
|
|
Jeremy.
(This used to be commit ead13ca522d7b8cbb47d660d3cb73c3582088985)
|
|
Not a bug, but better to remove false positives.
Jeremy.
(This used to be commit f9a75d76546bc4618736f0d48646e77d7572db25)
|
|
Jeremy
(This used to be commit 7c6e274cd578521192a0b0c4e6a4fb5dc7d722ac)
|
|
Jeremy.
(This used to be commit b9de6c926953b3321fa3850d501c807c6eabf230)
|
|
if we use ./configure --prefix=dir && make install
Vendors might use ./configure --with-rootsbindir=/sbin && make
DESTDIR=/var/tmp/samba/ install if they use a buildroot.
Thanks to Björn Jacke for pointing me at the stderr output of the build
farm.
(This used to be commit 75c95d149a22eba4a5afedcec7ba5e2a28cccf01)
|
|
Jeremy.
(This used to be commit d993797191865878ebfd2ff9028d341017605cd6)
|
|
(This used to be commit 6dc79e6b12e221e9af85a1edf487b5fb5aae222b)
|
|
problems. Ensure that if the parse succeeds on UNMARSHALL
we have a valid (although possibly empty) RPC_BUFFER returned.
Jeremy.
(This used to be commit d319cc9c08bfa865a6431a8631a9c609f589be1f)
|
|
Thanks,
Volker
(This used to be commit 86f62484dd7db43e036d9edf29e459b8bd0e5fbe)
|
|
(This used to be commit 0a2aa3a48bd5fd7e5a9aa06068ddd621b19c1dbe)
|
|
(This used to be commit 08d7fd31ab250bc6ba3922b36aa7b0cfef1e5bf1)
|
|
(This used to be commit 303067ba3bdf34ab501f0d99e386cfdb6ab10233)
|
|
Thanks,
Volker
(This used to be commit 49043a756dfa6a973d5605f42068df351a4a9ab5)
|
|
checking for
!= NULL. Coverity #149.
Volker
(This used to be commit d38e05329a77650d8fbb8611ca148964f62c9ba4)
|
|
If we use free(data.dptr) and then the subsequent tdb_open
fails in _reg_perfcount_get_counter_data() then data.dptr
is left as a non-zero pointer that has been freed. This would
cause it to be reused later on. Coverity bug #162.
Jeremy.
(This used to be commit 053efc20981e0280c6af0ebb9e17cea07da85fe8)
|
|
between Realloc and realloc_array.
Jeremy.
(This used to be commit 841c9b1847ae12656b827e3d35b8bf0c3f68b8b4)
|
|
in the pointer aliasing once realloc could change
a pointer. This was in the bugzilla.samba.org database
as #687 but we never figured out what it was !
Jeremy.
(This used to be commit 8d183441403524fe39e79af843d6cfe65898f7d3)
|
|
(This used to be commit 217d3fbe7923115ae610a39e586ceb93df7683f5)
|
|
with an existing account.
Guenther
(This used to be commit e4c12ab167ee83772a2bdd1946b8d73613fc0d7e)
|
|
(This used to be commit 598513d1d3e23cc71ea0fd53230d393b6724b534)
|
|
Fix machine accounts (should not have valid shells) and users with no
home directory (were getting previous user's directory).
(This used to be commit f629f8a7b972f09fe959c68843b9cd5a03abfc76)
|
|
Not a bug in the strictest sense, more a clarification. This whole routine
assumes new_gid != NULL anyway, so there's no point in checking.
Volker
(This used to be commit dfbf09c772b9588271e2d8e053c7494bb087c544)
|
|
This code was not used anyway :-)
Volker
(This used to be commit bbfb20569380529d60e3c61cd0be63a09eecfd17)
|
|
(This used to be commit cbf894c0e37964df57bd6a91ac10dfff571b1b3c)
|
|
(This used to be commit 6bf879bee3c59ba54b1b4c465c777e3dd0043f83)
|
|
(This used to be commit fb76390c6ae5928a2a222d61cbadf825611999ef)
|
|
(This used to be commit 426c8fe0bdacbf218d4cf4a10af789afbc0e53f2)
|
|
Guenther
(This used to be commit 7e80d5358eb181c3515acb732a3594e80391261b)
|
|
still
lurking...
Volker
(This used to be commit 1345a52794f4f55173ed677af3d0714e88bf17c6)
|
|
realloc can return NULL in one of two cases - (1) the realloc failed,
(2) realloc succeeded but the new size requested was zero, in which
case this is identical to a free() call.
The error paths dealing with these two cases should be different,
but mostly weren't. Secondly the standard idiom for dealing with
realloc when you know the new size is non-zero is the following :
tmp = realloc(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
However, there were *many* *many* places in Samba where we were
using the old (broken) idiom of :
p = realloc(p, size)
if (!p) {
return error;
}
which will leak the memory pointed to by p on realloc fail.
This commit (hopefully) fixes all these cases by moving to
a standard idiom of :
p = SMB_REALLOC(p, size)
if (!p) {
return error;
}
Where if the realloc returns null due to the realloc failing
or size == 0 we *guarentee* that the storage pointed to by p
has been freed. This allows me to remove a lot of code that
was dealing with the standard (more verbose) method that required
a tmp pointer. This is almost always what you want. When a
realloc fails you never usually want the old memory, you
want to free it and get into your error processing asap.
For the 11 remaining cases where we really do need to keep the
old pointer I have invented the new macro SMB_REALLOC_KEEP_OLD_ON_ERROR,
which can be used as follows :
tmp = SMB_REALLOC_KEEP_OLD_ON_ERROR(p, size);
if (!tmp) {
SAFE_FREE(p);
return error;
} else {
p = tmp;
}
SMB_REALLOC_KEEP_OLD_ON_ERROR guarentees never to free the
pointer p, even on size == 0 or realloc fail. All this is
done by a hidden extra argument to Realloc(), BOOL free_old_on_error
which is set appropriately by the SMB_REALLOC and SMB_REALLOC_KEEP_OLD_ON_ERROR
macros (and their array counterparts).
It remains to be seen what this will do to our Coverity bug count :-).
Jeremy.
(This used to be commit 1d710d06a214f3f1740e80e0bffd6aab44aac2b0)
|
|
I think this is actually a false warning, but as I've seen it with high gcc
warning levels, lets fix it :-)
Volker
(This used to be commit 3f671033bca7a025f9639728a0a0a0adede6ed35)
|
|
WBFLAG_PAM_CONTACT_TRUSTDOM. This
can not work for NTLM auth, where we only have a workstation account for our
own domain. For the PAM Kerberos login we need to find a better way to do
this, probably using Dsr_GetDCName and some winbind-crafted krb5.conf.
Volker
(This used to be commit bf7c608147bcbbedd89b3dcd24a929ea3e601bc8)
|
|
think is a direct bug, but some code that needs clarification :-).
Jeremy.
(This used to be commit 61901a3f10de64a72b655d9aa884424a4fc88a44)
|
|
if rrec can be null make sure we *never* deref it.
Jeremy.
(This used to be commit d6d7a5ac62b6ee08e365c5982302b1d8dc69a78f)
|
|
Jeremy.
(This used to be commit 46e10980927f1dfa4a1995e778df880cf823cbdb)
|
|
Jeremy.
(This used to be commit dd47e0ef1175a57ec2e9b797ac942cb79f4a5d05)
|
|
Jeremy.
(This used to be commit f4bf550b5757024b41062784b185b52a1a0e11f4)
|
|
exit path.
Jeremy.
(This used to be commit 95ef857c89a330ef4012ba3c10d2bbbbab112b34)
|
|
Jeremy.
(This used to be commit 0dc37dd2d85d59e7287cebcb7019194cf6754074)
|
|
(This used to be commit c803e1b2afdfc5bd983f046c976c01adebcfa1ad)
|
|
Jeremy.
(This used to be commit 0f1dffb2f2ce5ace1b3216f578ab115c976624c7)
|
|
part of the changes I made but something that's been there
a while.... Coverity bugid #41.
Jeremy.
(This used to be commit 2f6cf810eae124820a073258ffe62aace7a92d9c)
|
|
Guenther
(This used to be commit 0ae3fddf95a95ec8a2f4d52e1276c1721b33ddfd)
|
