summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2011-05-04Convert safe_strXX to strlXXX. Clean up off-by-ones.Jeremy Allison1-31/+17
2011-05-04Remove magic numbers. Standardize on macro. Move from safe_strcat to strlcat.Jeremy Allison1-7/+7
2011-05-04Cope with +1 change on moving from safe_strcat to strlcat.Jeremy Allison1-3/+3
2011-05-04Fold null terminator into listlen length, change to strlcpy.Jeremy Allison1-6/+4
2011-05-04Fix the only place we reply on the NULL handling for the source in safe_strcpy.Jeremy Allison1-10/+18
2011-05-04Fix off-by-one when used with safe_strcpy.Jeremy Allison1-1/+1
2011-05-04sasl_secret_t ends in a char [1] size. This means the extra character is ↵Jeremy Allison1-2/+2
implicit in the safe_strcpy. When changing to strlcpy ensure we allocate an extra char for it. This fixes a bug where secret->len+1 used with safe_strcpy could actually write into secret->len+2.
2011-05-04Simple +1 changes in hardcoded lengths when changing from safe_strcpy to ↵Jeremy Allison4-9/+9
strlcpy.
2011-05-04BUGFIX when converting from safe_strcpy to strlcpy.Jeremy Allison1-1/+5
We must have a blob legth > 0 in order to safely copy the (possibly) 16 bytes + 1 byte zero character safely.
2011-05-04Remove overmalloc_safe_strcpy - can be simple strlcpy.Jeremy Allison3-10/+2
2011-05-04Remove obvious use of safe_strcpy + safe_strcat -> strlcpy + strlcat.Jeremy Allison1-10/+10
2011-05-04Change safe_strcpy_base to strlcpy_base. Note the size doesn't change here ↵Jeremy Allison4-10/+10
as the original macro auto-added the -1.
2011-05-04Fix simple uses of safe_strcpy -> strlcpy. Easy ones where we just remove -1.Jeremy Allison14-26/+26
2011-05-04s3-torture: Add a test for notify upon read&xVolker Lendecke5-1/+304
This makes sure that when a file is brought online by a read call we notify the client for FILE_NOTIFY_CHANGE_ATTRIBUTES. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed May 4 21:09:22 CEST 2011 on sn-devel-104
2011-05-04Always build before commit ... :-)Volker Lendecke1-1/+1
2011-05-04Remove unused function parse_add_domuser().Jeremy Allison2-26/+0
Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed May 4 20:05:42 CEST 2011 on sn-devel-104
2011-05-04s3-waf: add vfs_gpfs_hsm_notify to the build.Günther Deschner2-0/+14
Volker, can you please check this is correct ? Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Wed May 4 19:03:45 CEST 2011 on sn-devel-104
2011-05-04RHEL-CTDB: Build vfs_gpfs_hsm_notifyVolker Lendecke1-1/+2
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed May 4 17:12:14 CEST 2011 on sn-devel-104
2011-05-04vfs_gpfs: Properly notify the offline->online changesVolker Lendecke3-0/+117
This needs to be a separate module that cooperates with vfs_gpfs. If aio_fork is used early in the module chain it (correctly) does not propagate the aio ops down, so vfs_gpfs does not see them. This slim module must come early in the chain for notifies to work properly.
2011-05-04vfs_gpfs: Block sendfile for offline filesVolker Lendecke1-0/+12
2011-05-04vfs_gpfs: Store the winattrs in st.vfs_privateVolker Lendecke1-5/+12
This avoids a considerable amount of gpfs_winattr calls
2011-05-04s3: Properly deal with exited winbind childrenVolker Lendecke1-0/+5
When a winbind child exits, we need to immediately close the socket. If not, the next request to that child will be sent to a socket without a listener, leading to a failed request. This failed request will then trigger a proper re-init. This patch avoids the one failed request. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed May 4 13:32:16 CEST 2011 on sn-devel-104
2011-05-04s3-vfs: make vfswrap_llistxattr and vfswrap_flistxattr static.Günther Deschner2-8/+2
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Wed May 4 12:31:10 CEST 2011 on sn-devel-104
2011-05-04s3: Filter out duplicates in name_query()Volker Lendecke1-2/+18
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed May 4 00:03:47 CEST 2011 on sn-devel-104
2011-05-03s3-includes: when MADVISE support was reverted back in 2009, someone forgot ↵Günther Deschner1-4/+0
this hunk. Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Tue May 3 22:06:20 CEST 2011 on sn-devel-104
2011-05-03s3-includes: move enum flush_reason_enum to smb.hGünther Deschner2-16/+16
Guenther
2011-05-03s3-includes: remove ipv6 related prototype which is already defined in ↵Günther Deschner1-5/+0
../lib/util/util_net.h. Guenther
2011-05-03s3-system: move LOCK_ defines to lib/system.cGünther Deschner2-9/+9
Guenther
2011-05-03s3: Handle EINTR from sys_poll correctlyVolker Lendecke1-1/+4
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Tue May 3 18:06:48 CEST 2011 on sn-devel-104
2011-05-03s3-proto: move remaining krb5 protos to krb5_protos.hGünther Deschner2-7/+6
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Tue May 3 15:38:40 CEST 2011 on sn-devel-104
2011-05-03s3-ctdb Fix duplicate function name due to packet -> ctdb_packet rename.Andrew Bartlett3-3/+3
Signed-off-by: Günther Deschner <gd@samba.org>
2011-05-03s3: reply_readbraw_error needs an sconn as argument also in the non-LFS code ↵Björn Jacke1-1/+1
path Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User: Björn Jacke <bj@sernet.de> Autobuild-Date: Tue May 3 13:04:11 CEST 2011 on sn-devel-104
2011-05-03ѕ3/configure: move out generic CPPFLAGS in the solaris case hereBjörn Jacke1-3/+4
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-05-03ѕ3/configure: move out generic LDFLAGS in the solaris case hereBjörn Jacke1-3/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2011-05-03lib/util make string_wrappers.h a public headerAndrew Bartlett1-1/+1
This isn't a very good public header, but util.h includes it, so we don't have much choice in the short term. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Tue May 3 08:37:22 CEST 2011 on sn-devel-104
2011-05-03s4-param Rename secrets_init() -> randseed_init()Andrew Bartlett3-10/+10
This only sets up the random number generator callback these days, so use a different database for that. (All secrets data in Samba4 is in secrets.ldb) Andrew Bartlett
2011-05-03lib/util Use lib/util/util_str.c in common, including strequal()Andrew Bartlett4-89/+4
strequal() is now implemented in terms of strcasecmp_m() which is tested in smbtorture and which does not talloc() for ASCII or non-ASCII comparions, and has an ASCII fast-path. Andrew Bartlett
2011-05-03lib/util Use compiler-checked safe string macros in top level code.Andrew Bartlett2-35/+27
This brings the 'safe' macros to the top level code, and removes duplication of the safe_strcpy() and safe_strcat() functions. Andrew Bartlett
2011-05-03s4: fix arguments to safe_strcpy()Andrew Bartlett2-7/+7
Found by the s3-derivied safe_strcpy() macro. Andrew Bartlett
2011-05-03s4-socket: rename allow_access() to socket_allow_access()Andrew Tridgell3-8/+8
this prevents a symbol collision with s3 Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-05-03lib/util/charset Use push_string and talloc_strupper/strlower from common codeAndrew Bartlett6-145/+12
The only caller of push_string() (not to be confused with push_string_check()) in the common code was encode_pw_buffer(), and it didn't use the alignment or STR_UPPER flags. The talloc_strupper() and talloc_strlower() functions are tested in smbtorture, and are next_codepoint() based. Andrew Bartlett
2011-05-03s3-lib make push_ucs2() staticAndrew Bartlett2-2/+1
2011-05-03Remove strlower_m() and strupper_m() from source4 and common code.Andrew Bartlett12-150/+135
This function is problematic because a string may expand in size when changed into upper or lower case. This will then push characters off the end of the string in the s3 implementation, or panic in the former s4 implementation. Andrew Bartlett
2011-05-03s4-param: use new roles.hAndrew Tridgell1-5/+1
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-05-03s3-include: use new roles.hAndrew Tridgell2-9/+2
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-05-03libds: added roles.h for server rolesAndrew Tridgell2-0/+43
this will allow us to move the server roles in common, which will make it much easier to mix s3/s4 calls in the one C file Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-05-03libcli/raw: use a different ifdef than s3 smb.hAndrew Tridgell1-3/+3
this allows both headers to be included in 1 C file Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-05-03s4-messaging Rename messaging -> imessagingAndrew Bartlett46-266/+266
This avoid symbol and structure conflicts between Samba3 and Samba4, and chooses a less generic name. Andrew Bartlett
2011-05-03s4-libcli Remove resolve_name() as it conflicts with Samba3.Andrew Bartlett9-25/+27
This was just a wrapper around resolve_name_ex(), so just call that instead. Andrew Bartlett
2011-05-03s4-torture Remove unused and uncompleated testAndrew Bartlett1-54/+0