summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2010-02-10Fix bad use when freeing linked list. Todd Stecher (Original author) please ↵Jeremy Allison1-6/+8
check ! Jeremy.
2010-02-10test:local added LOCAL-DLINKLIST testsuiteAndrew Tridgell3-0/+132
(cherry picked from commit 95a5bee2c30a67a35604b0456ab7836f6dc67702)
2010-02-10util: rewrite dlinklist.h so that DLIST_ADD_END() is O(1)Andrew Tridgell4-179/+334
This changes the meaning of the ->prev pointer in our doubly linked lists to point at the end of the list from the front of the list. That allows us to implement DLIST_ADD_END() and related functions in O(1) time, which can be a huge saving in many places in Samba. This also means that the 'type' argument to various DLIST_*() macros is no longer needed, but I have left it in for now to keep the patchset small, which will make it easier to revert if any problems are found. In the future we should remove the 'type' arguments. (jra. Move the one use of DLIST_TAIL over to the new macros).
2010-02-10s3-smbd: update to use new DLIST macrosAndrew Tridgell2-6/+5
(cherry picked from commit 365b408c458c848a818637d9b36a0423aeb1ba54)
2010-02-10s3-registry: update to use new DLIST macrosAndrew Tridgell1-2/+2
(cherry picked from commit 3437713ad7e5bccafde30553a8232119fd2a9eb9)
2010-02-10s3-perfcount: update to use new DLIST macrosAndrew Tridgell2-3/+2
(cherry picked from commit a13b507f2d8be7f90c8872094cd0732926a6fcbb)
2010-02-10s3-locking: update to use DLIST_ADD_AFTER()Andrew Tridgell1-5/+1
(cherry picked from commit 6c6df527e14514027cbcaa6deac25adf04363926)
2010-02-10s3-libsmb: update libsmb to use new DLIST macrosAndrew Tridgell2-23/+25
manipulating p->prev directly is not safe any more (cherry picked from commit 3c650ac1e3e1cdbbabecfddcd29325f20b5dcb48)
2010-02-10s3-memcache: update memcache to use new DLIST macrosAndrew Tridgell1-18/+3
we don't need a separate lru pointer any more (cherry picked from commit 4ffd7aca3e38728077bd80c2a65c4efbcfd216fc)
2010-02-10s3-ldb: update the old ldb in s3 to use new DLIST macrosAndrew Tridgell2-30/+4
(cherry picked from commit a7d8bfd373392eecf4fff33d39b85e1b55ad901d)
2010-02-10s3-nmbd: update nmbd to use new DLIST_ macrosAndrew Tridgell4-73/+9
(cherry picked from commit 4d23d777bc6d4fad20d0f3084fe658635812bee9)
2010-02-10s4-ldb: update ldb_tdb to use new DLIST_ macrosAndrew Tridgell1-15/+3
(cherry picked from commit 6ede911654566a7e21ded70dacac68df3b6a1bca)
2010-02-10s4-dsdb: update repl_meta_data.c to use new DLIST_ macrosJeremy Allison1-3/+2
2010-02-10Temporary changes to dlinklist to keep the implementation static whilstJeremy Allison3-0/+48
uses of (list)->prev are moved over to DLIST_PREV. This will be replaced when the final (new) version of the dlinklist.h header is added. Jeremy.
2010-02-10Revert "Change the default of "nmbd bind explicit broadcast" to "no""Jeremy Allison2-5/+6
This reverts commit 84fba3c1bc962804259f201d465acfdf0cd3c6a8. Now we have a "processed packet queue" in nmbd we can go back to doing this by default. Jeremy.
2010-02-10More of the fix for bug #7118 - nmbd problems with socket address.Jeremy Allison1-0/+89
Add a simple "processed packet queue" cache to stop nmbd responding to packets received on the broadcast and non-broadcast socket (which it has opened when "nmbd bind explicit broadcast = yes"). This is a very simple packet queue - it only keeps the packets processed during a single call to listen_for_packets() (i.e. one select call). This means that if the delivery notification for a packet received on both broadcast and non-broadcast addresses is done in two different select calls, the packet will still be processed twice. This is a very rare occurrance and we can just live with it when it does as the protocol is stateless. If this is ever flagged as a repeatable problem then we can add a longer lived cache, using timeout processing to clear etc. etc. But without storing all packets processed we can never be *sure* we've eliminated the race condition so I'm going to go with this simple solution until someone proves a more complex one is needed :-). Jeremy.
2010-02-10Change the default of "nmbd bind explicit broadcast" to "no"Jeremy Allison2-6/+5
until the double processing problem in bug #7118 is fixed. Jeremy.
2010-02-10testprogs: add more error codes for spoolss test.Günther Deschner1-0/+2
Guenther
2010-02-10s3: change ldap filter to what really was intendedBjörn Jacke1-1/+1
2010-02-10tdb: fix recovery reuse after crashRusty Russell1-4/+10
If a process (or the machine) dies after just after writing the recovery head (pointing at the end of file), the recovery record will filled with 0x42. This will not invoke a recovery on open, since rec.magic != TDB_RECOVERY_MAGIC. Unfortunately, the first transaction commit will happily reuse that area: tdb_recovery_allocate() doesn't check the magic. The recovery record has length 0x42424242, and it writes that back into the now-valid-looking transaction header) for the next comer (which happens to be tdb_wipe_all in my tests). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2010-02-10tdb: give a name to the invalid recovery area constant (0)Rusty Russell3-4/+5
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2010-02-10s4:provision Just 'do the right thing' with empty smb.conf filesAndrew Bartlett2-2/+26
For some reason, JHT keeps on creating an empty smb.conf file, expecting it to be the same as a non-existant one. It is easier to just realise what he meant. Andrew Bartlett
2010-02-10s4-smbtorture: use test_GetPrinter_level in RPC-SPOOLSS-NOTIFY.Günther Deschner2-45/+27
Guenther
2010-02-09Fix bug #7122 - Reading a large browselist fails (server returns invalid ↵Jeremy Allison2-3/+6
values in subsequent SMBtrans replies) There are two problems: 1). The server is off-by-one in the end of buffer space test. 2). The server returns 0 in the totaldata (smb_vwv1) and totalparams (smb_vwv0) fields in the second and subsequent SMBtrans replies. This patch fixes both. Jeremy.
2010-02-09Missed one check on the memcpy for bug #7063.Jeremy Allison1-1/+1
Jeremy.
2010-02-09Second part of fix for bug 7063 - Samba 3.4.5 on ubuntu 8.04 64 bit - Core ↵Jeremy Allison1-1/+4
dumps. Ensure we have no naked memcpy calls. This isn't a crash bug (it's already checked in the data_blob_talloc_zero() above, but I want to get into the pattern of having all memcpy's covered by safety checks. Jeremy.
2010-02-09Fix off-by-one error in working out the limit of the NetServerEnum comment.Jeremy Allison1-1/+1
Jeremy.
2010-02-09s3:smbd: use StrCaseCmp() instead of strcasecmpStefan Metzmacher1-4/+3
metze
2010-02-09s3:smbd: Fix really ugly bool vs. int bug!!!Stefan Metzmacher1-2/+2
A comparison function for qsort needs to return an 'int'! Otherwise you'll get random results depending on the compiler and the architecture... metze
2010-02-09check_python.m4 - Raise the minimum python version up to 2.4Matthias Dieter Wallnöfer1-0/+5
This is needed since we at the s4 side have some code which requires this. I think everybody should be fine since we got no complaints on the mailing list about this change. Patch template: Jelmer Vernooij <jelmer@samba.org>
2010-02-09pidl - Remove "Py_RETURN_NONE" compatibility codeMatthias Dieter Wallnöfer1-4/+0
This was needed only by Python 2.3 which we no longer support.
2010-02-09s4:Remove "Py_RETURN_NONE" compatibility codeMatthias Dieter Wallnöfer11-44/+0
This was needed only by Python 2.3 which we no longer support.
2010-02-09s3-docs: Fix make manpages3.Karolin Seeger1-1/+1
Karolin
2010-02-09s3-docs: Add missing para end tag.Karolin Seeger1-0/+1
Karolin (cherry picked from commit b78de63ef3cde53e3aabbe46654aac5a335f16a8)
2010-02-09testprogs: regenerate printlib prototypes for spoolss test.Günther Deschner1-27/+39
Guenther
2010-02-09testprogs: print job info levels in EnumJobs() spoolss tests.Günther Deschner2-0/+101
Guenther
2010-02-09testprogs: print datatypes info levels in EnumPrintProcessorDatatypes() ↵Günther Deschner2-0/+42
spoolss tests. Guenther
2010-02-09testprogs: print printprocessor info levels in EnumPrintProcessors() spoolss ↵Günther Deschner2-0/+35
tests. Guenther
2010-02-09testprogs: print monitor info levels in EnumMonitors() spoolss tests.Günther Deschner2-0/+45
Guenther
2010-02-09testprogs: print port info levels in EnumPorts() spoolss tests.Günther Deschner2-0/+79
Guenther
2010-02-09testprogs: print form info levels in EnumForms(),GetForm() spoolss tests.Günther Deschner2-0/+67
Guenther
2010-02-09s3:selftest: make selftest requires bash for nowStefan Metzmacher1-1/+1
So force bash until we removed the dependency to bash. metze
2010-02-09s3:passdb: only use gid_to_sid() result if the result is a group of our ↵Stefan Metzmacher1-4/+16
local sam Otherwise retry with pdb_gid_to_sid(). metze
2010-02-09s3: fix some wrong newlines in de translation stringsBjörn Jacke1-8/+8
2010-02-09vfs_catia: fix return type warningsBjörn Jacke1-2/+2
2010-02-09s4-torture: allow host-only in unc lists in smbtortureAndrew Tridgell2-4/+7
Allow UNC lists like this: 192.168.2.1 192.168.2.2 192.168.2.3 the share name will be taken from the command line
2010-02-08Make "nmbd bind explicit broadcast" on by default.Jeremy Allison3-6/+12
Fix a comment typo. Jeremy.
2010-02-08Fix bug #6876 for acl_tdb module.Jeremy Allison1-2/+1
As pointed out by bj@sernet.de, the rmdir module initializer was duplicated. Fix this properly. Jeremy.
2010-02-08s3:libsmb: fix NetServerEnum3 rap calls.Stefan Metzmacher1-5/+19
metze
2010-02-08s3:smbd: implement api_RNetServerEnum3Stefan Metzmacher1-1/+212
This is needed to support large browse lists. metze
generated by cgit (git 2.34.1) at 2024-11-08 19:36:02 +0000