summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2011-05-10s3-printing: Fix double free of cups request.Günther Deschner1-4/+0
We never free the request in our cups api usage except for here. The reason is probably htis (from the cupsDoConnect API docs): "This function sends the IPP request to the specified server, retrying and authenticating as necessary. The request is freed with ippDelete() after receiving a valid IPP response." Revert "Fix a memory leak in cups_pull_comment_location" This reverts commit fee2664dad37536b05ce8bdae3e74d45b257f632. Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Tue May 10 17:32:58 CEST 2011 on sn-devel-104
2011-05-10s3-printing: very obvious fix for cups_pull_comment_location().Günther Deschner1-1/+1
This has been in there since 2008... Guenther
2011-05-10s3-events: tevent_internal.h is not a public headerAndrew Tridgell1-1/+1
We need to use the "foo.h" form instead of the <foo.h> form for headers that are not installed publicly. Otherwise when an external version of tevent is used we won't find the header and the build will fail. Note that this creates a structure dependency between the tevent structures in the external library and the headers in our source tree. That is not ideal, but is currently OK as the waf build will only use the external library if it is at least the same version as the internal tree, which means it will actually be the same version, as we release the external version from our tree. We should come up with a better solution, but for now this allows openchange to build again. Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Tue May 10 16:06:40 CEST 2011 on sn-devel-104
2011-05-10s3: Use tevent_req_ntstatus properly in a few placesVolker Lendecke30-98/+49
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Tue May 10 13:11:10 CEST 2011 on sn-devel-104
2011-05-10s3: Use tevent_req_ntstatus properly in a few placesVolker Lendecke1-58/+29
2011-05-10async_smb.c: convert cli->timeout properlyRusty Russell1-1/+2
I have a test failure on my 32-bit Ubuntu system, in that samba3.smbtorture_s3.plain(s3dc).LOCK9 immediately times out (rather than waiting 5 seconds for the child). Debugging revealed this code: timeout is in ms and is set to > 1000 in various places. The code dates from 2002, and other perturbations didn't reveal why it breaks now, but fix it anyway. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Autobuild-User: Rusty Russell <rusty@rustcorp.com.au> Autobuild-Date: Tue May 10 12:09:07 CEST 2011 on sn-devel-104
2011-05-10tdb_wrap.h: not a public header.Rusty Russell1-1/+0
It is a private library, and OpenChange has their own which they use, so it's not for them either. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Autobuild-User: Rusty Russell <rusty@rustcorp.com.au> Autobuild-Date: Tue May 10 05:21:19 CEST 2011 on sn-devel-104
2011-04-19gencache: don't use CLEAR_IF_FIRST as fallback.Rusty Russell2-17/+6
CLEAR_IF_FIRST only works if *all* openers use that flag. So just truncate the file: it's racy, but that's what we're doing anyway. We'd really need a TDB_OPENCHECK_OR_CLEAR flag to do this properly (or in TDB2, a open hook at the right point). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-05-10Add -fno-common where supported (WAF only)Rusty Russell1-1/+1
Normally under UNIX, uninitialized non-static global variables get placed in the "common" section, where they are merged at link time. This means if two C files define "int debug", they will end up referring to the same variable. Or if one does "float level" and the other does "int level" you'll get an accidental union. Such bugs can be hard to track down; fortunately GCC offers -fno-common to disable this feature. It didn't reveal any places which need fixing, however). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2011-05-09build: Remove --disable-s3build so we can rely on these subsystemsAndrew Bartlett4-21/+4
This will make it easier to write code that uses the whole codebase. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Mon May 9 12:25:33 CEST 2011 on sn-devel-104
2011-05-09s3-build: Move generated config.h and config.h.in to include/autoconfAndrew Bartlett6-11/+16
This ensures that these are not found by the waf build, which causes issues when the wrong config.h is used by the recursive smbtorture build Andrew Bartlett
2011-05-09tevent: Fix a typoVolker Lendecke1-1/+1
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Mon May 9 08:17:08 CEST 2011 on sn-devel-104
2011-05-09s3: Fix a typoSamba-JP oota1-1/+1
2011-05-09selftest: Test both users created in plugin_s4_dc environmentAndrew Bartlett1-0/+1
Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Mon May 9 06:10:52 CEST 2011 on sn-devel-104
2011-05-09selftest: don't override just-added username in plugin_s4_dc testAndrew Bartlett1-2/+0
This will allow us to test a user added via smbpasswd as well as the administrator added by provision. Andrew Bartlett
2011-05-08nsswitch: Fix build check logicKai Blin1-1/+1
Only build pam_winbind.so if we want pam modules _and_ have the libs Autobuild-User: Kai Blin <kai@samba.org> Autobuild-Date: Sun May 8 23:56:33 CEST 2011 on sn-devel-104
2011-05-08selftest: Polish selftest-vars.sh a little so it can be used againKamen Mazdrashki1-10/+14
Autobuild-User: Kamen Mazdrashki <kamenim@samba.org> Autobuild-Date: Sun May 8 22:50:01 CEST 2011 on sn-devel-104
2011-05-08s4-selftest Add tests for proxy_samba4_dcAndrew Bartlett1-0/+1
Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Sun May 8 20:03:45 CEST 2011 on sn-devel-104
2011-05-08selftest: Make the ncalrpc dir common between Samba4 and Samba3.Andrew Bartlett2-7/+7
This also avoids creating the directory, as the startup routines will create it with the correct permissions. Andrew Bartlett
2011-05-08ncalrpc: Force ncalrpc dir to be mode 755 in all usersAndrew Bartlett2-2/+9
This allows this directory to be shared between Samba3 and Samba4 in a Franky-style setup easily. Andrew Bartlett
2011-05-08selftest: Add plugin_s4_dc environmentAndrew Bartlett2-0/+107
This environment uses pdb_samba4 and auth_samba4 to plug these critical subsystems into a mixed Samba3/Samba4 DC, in a similar way to the 'Franky' proposal. Andrew Barltett
2011-05-08s3-auth Add auth_samba4 moduleAndrew Bartlett2-0/+141
This module makes a direct call into the Samba4 auth stack to authenticate Samba4 uses in a Samba3 file server. The direct call avoids the need to obtain schannel credentials. Andrew Bartlett Pair-Programmed-With: Andrew Tridgell <tridge@samba.org>
2011-05-08s3-passdb: added pdb_samba4Andrew Bartlett3-0/+2126
This uses direct LDB operations and calls to the dsdb library to allow passdb operations (such as pdbedit and smbpasswd) offline, and uses transactions internally for database consistency. Pair-Programmed-With: Andrew Tridgell <tridge@samba.org>
2011-05-08s3-passdb Redirect domain GUID and SID queries to the passdb stackAndrew Bartlett1-0/+58
This is done if the passdb module supports PDB_ADS, and ensures that a random SID is never made up locally for these directories. This is only enabled when in the waf build, due to dependency issues. Andrew Bartlett
2011-05-08s4-dsdb Add transactions to dsdb modify helpersAndrew Bartlett1-0/+18
2011-05-08s4-samr Remove incorrect transaction_cancel() in error pathAndrew Bartlett1-1/+0
The transactions are now handled entirely within dsdb_add_user() Andrew Bartlett
2011-05-08s4-param cope with doulbe-parsing of -foo and +foo listsAndrew Bartlett1-3/+9
For some reason these lists are parsed twice, and so any -foo was failing as it was already removed the first time. Andrew Bartlett
2011-05-08build: Allow the C code to know if this is a waf buildAndrew Bartlett2-0/+2
This allows addition of functionality that can't be handled (for example, due to dependencies) in the autoconf build. Andrew Bartlett
2011-05-08s4-interfaces: keep interfaces in the order they were declaredAndrew Tridgell1-1/+5
the spoolss notify test depends on the interfaces order Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Sun May 8 13:57:58 CEST 2011 on sn-devel-104
2011-05-08s3-test: build smbtorture with --enable-developerAndrew Tridgell1-1/+1
this makes debugging of tests much easier, as we get debug symbols
2011-05-08lib/socket: Remove outdated commentAndrew Bartlett1-11/+0
The autoconf and waf tests for interfaces logic are in libreplace now.
2011-05-08s4-interfaces Rename interfaces code so not to conflict with source3/Andrew Bartlett29-116/+116
The iface_count, iface_n_bcast, and load_interfaces functions conflicted with functions of the same name in source3, so the source4 functions were renamed. Hopefully we can actually wrap one around the other in future. Andrew Bartlett
2011-05-08s3-lib Use common lib/socket code for get_interfaces() et alAndrew Bartlett7-354/+7
2011-05-08lib/socket move interfaces code to the top levelAndrew Bartlett6-25/+63
2011-05-08s4-lib/socket Samba4 is not IPv6 compatibleAndrew Bartlett1-0/+5
Don't add IPv6 interfaces until we actually support them. I'll soon have IPv6 service at home, and then I'll make it my buisness to sort this out once and for all. Andrew Bartlett
2011-05-08s4-lib merge get_interfaces() from Samba3 to Samba4Andrew Bartlett3-100/+375
2011-05-08s3-smbd: expose smbd_set_server_fd()Andrew Tridgell3-29/+30
this allows the fd to be setup by subsystems that want to use the s3 server core code Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Sun May 8 12:01:13 CEST 2011 on sn-devel-104
2011-05-08s3-waf: expose the server_exit code in the smbd_base libraryAndrew Tridgell1-1/+2
these functions are called from the rest of smbd_base
2011-05-08build: allow s3 libraries to be built with no undefined symbolsAndrew Tridgell1-2/+4
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-05-08s4-param Don't set variables such as the debuglevel unless globalAndrew Bartlett1-2/+18
This ensures that when a second lp_ctx is created, that it does not set global variables such as the debug level, log file etc, potentially overriding the settings created by another context. In particular this matters when loading Samba4 modules into Samba3. Andrew Bartlett
2011-05-08Improve debug messages when creating socket directoriesAndrew Bartlett3-7/+15
This makes clear what the permissions error and directory name actually is Andrew Bartlett
2011-05-08libds: moved enum security_types to a common headerAndrew Tridgell4-5/+5
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-05-08s3-utils Set dyn_CONFIGFILE from -c on smbpasswd command lineAndrew Bartlett1-0/+1
This is similar to the code in popt_common and allows the smb.conf to be re-loaded from this file later in the code (or for Samba4 plugins to attempt to parse the same smb.conf). Andrew Bartlett
2011-05-08selftest Use die() less often, as it fails to allow cleanupAndrew Bartlett2-9/+30
2011-05-08auth: allow auth_common.h to be included multiple times without errorAndrew Bartlett1-0/+5
2011-05-08s4-auth Rename auth -> auth4 to avoid conflict with s3 authAndrew Bartlett23-78/+80
2011-05-08s4-ntvfs: Rename brl_*() -> brlock_*() to avoid conflict with brlock_init in s3Andrew Bartlett7-24/+24
2011-05-08s4-auth: remove unused prototypeAndrew Tridgell1-4/+1
2011-05-07s3: Fix including libsmb/proto.h without prior ads.hVolker Lendecke1-0/+2
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sat May 7 11:38:11 CEST 2011 on sn-devel-104
2011-05-07Fix Samba3 on OpenIndiana.Gordon Ross4-7/+49
I'd like Samba to use the native OpenLDAP and MIT Kerberos libs. Attached are some patches to do that. (relative to git master) It does not build for me without these. (OpenIndiana is an off-shoot of OpenSolaris See http://www.openindiana.org) Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sat May 7 02:20:14 CEST 2011 on sn-devel-104