summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2012-06-15s3:smbd: change smb2_read.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-6/+6
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: change smb2_notify.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-2/+2
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: change smb2_lock.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-6/+6
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: change smb2_ioctl.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-2/+2
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: change smb2_getinfo.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-4/+4
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: change smb2_flush.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-2/+2
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: change smb2_find.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-2/+2
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: change smb2_close.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-2/+2
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: change smb2_break.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-6/+6
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: change reply.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-50/+50
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: change pipes.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-3/+3
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: change oplock.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-5/+5
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: change open.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-4/+4
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: change nttrans.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-3/+5
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: change files.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-2/+2
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: change fake_file.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-2/+2
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: change blocking.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-14/+15
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: change aio.c to use fsp_fnum_dbg() for logging fsp->fnum.Michael Adam1-2/+2
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:vfs_default: use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-6/+10
Note: it is actually wrong to access the fsp->fnum at all here, since the fnum is part of the smb layer that should not be used in the vfs layer. But this is subject be separated more cleanly in later commits. This change only unifies the logging of fsp->fnum. Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:locking: change locking.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-8/+8
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:locking: change brlock.c to use fsp_fnum_dbg() for fsp->fnum logging.Michael Adam1-4/+4
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:lib: add a utility function "fsp_fnum_dbg" for logging the fnum of an fspMichael Adam2-0/+29
This is to unify logging of an files_struct. Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:lib: elaborate the comment for fsp_str_debug a bit.Michael Adam1-1/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:lib: remove part of a comment for fsp_str_dbg that does not apply any more.Michael Adam1-2/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: change FNUM_FIELD_INVALID from -1 to 0Michael Adam1-1/+1
This is in preparation for changing the type of files_struct.fnum to unit64_t. This can safely be done, since all checks have been converted to using FNUM_FIELD_INVALID and fsp->fnum is only ever set to either FNUM_FIELD_INVALID or some i + FILE_HANDLE_OFFSET with i >= 0 and FILE_HANDLE_OFFSET > 0. Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: use FNUM_FIELD_INVALID instead of literal -1Michael Adam4-9/+13
This is in preparation of changing fnum to uint64_t Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:include: define FNUM_FIELD_INVALID - the invalid value for the fnumMichael Adam1-0/+2
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:files: factor fsp_free() out of file_free()Michael Adam2-20/+28
To be reused in the durable reconnect code. Pair-Programmed-With: Volker Lendecke <vl@samba.org>
2012-06-15s3:files: reorder file_free() a bitMichael Adam1-16/+18
Pair-Programmed-With: Volker Lendecke <vl@samba.org> Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
2012-06-15s3:smbd: refactor fsp_new() out of file_new()Michael Adam2-34/+57
Pair-Programmed-With: Volker Lendecke <vl@samba.org> Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
2012-06-15waf: Update to newer upstream snapshot.Jelmer Vernooij1-9/+11
Autobuild-User(master): Jelmer Vernooij <jelmer@samba.org> Autobuild-Date(master): Fri Jun 15 03:12:35 CEST 2012 on sn-devel-104
2012-06-15update-waf.sh: make mktemp happy by including anything Xes.Jelmer Vernooij1-1/+1
2012-06-15lib/util: Fix typo in comment.Jelmer Vernooij1-1/+1
2012-06-14make librpc/build_idl.sh more portableBjörn Jacke1-1/+2
Autobuild-User(master): Björn Jacke <bj@sernet.de> Autobuild-Date(master): Thu Jun 14 23:57:40 CEST 2012 on sn-devel-104
2012-06-14s3:smbd: use fsp_persistent_id() as persistent_file_id part for SMB2 (bug #8995)Stefan Metzmacher3-6/+9
It seems to be important to have unique persistent file ids, because windows clients seem to index files by server_guid + persistent_file_id. Which may break, if we just have a 16-bit range per connection and the client connects multiple times. Based on code from Ira Cooper. Use fsp->fh->gen_id as the persistent fileid in SMB2. metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Thu Jun 14 22:04:13 CEST 2012 on sn-devel-104
2012-06-14s3:smbd: add a fsp_persistent_id() functionStefan Metzmacher2-0/+25
This calculates a 64-bit value that most likely uniquely identifies the files_struct globally to the server. * 32-bit random gen_id * 16-bit truncated open_time * 16-bit fnum (valatile_id) Based on code from Ira Cooper. Use fsp->fh->gen_id as the persistent fileid in SMB2. Pair-Programmed-With: Michael Adam <obnox@samba.org> metze
2012-06-14s3:smbd: only set fsp->fh->gen_id for a client connectionStefan Metzmacher1-1/+2
For faked connections, like dfs and printing, we leave it as 0. metze
2012-06-14s3:smbd: try to make fsp->fh->gen_id as globally unique as possibleStefan Metzmacher1-1/+19
This makes sure the value is never 0, it's between 1 and UINT32_MAX. While fsp->fh->gen_id is 'unsigned long' currently (which might by 8 bytes), there's some oplock code which truncates it to uint32_t (using IVAL()). Which means we could reuse fsp->fh->gen_id as persistent file id until we have a final fix, which uses database. See bug #8995 for more details. Based on code from Ira Cooper. Ensure fsp->fh->gen_id starts from a random point. We will use this as the SMB2 persistent_id. metze
2012-06-14s3: Simplify tdb_data_is_cstr a bitVolker Lendecke1-1/+1
The original code contained rawmemchr for performance reasons. I would expect the very common strlen routine to be not much worse performance-wise than rawmemchr. On top, for me this patch simplifies the expression a bit. Signed-off-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Thu Jun 14 16:55:58 CEST 2012 on sn-devel-104
2012-06-14tdb2: remove unused debug_fprintf() macro that breaks the buildStefan Metzmacher1-2/+0
The IRIX compiler doesn't support '...' in a macro. metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Thu Jun 14 11:26:15 CEST 2012 on sn-devel-104
2012-06-14tdb: remove unused debug_fprintf() macro that breaks the buildStefan Metzmacher1-2/+0
The IRIX compiler doesn't support '...' in a macro. metze
2012-06-14lib/replace: define HAVE_WORKING_STRPTIME instead of REPLACE_STRPTIMEStefan Metzmacher3-10/+16
That makes the logic in 'wscript' simpler. metze
2012-06-14lib/replace: execute strptime.c testsStefan Metzmacher1-0/+1
They need runtime verification. metze
2012-06-14Revert "replace: use replace for non 'samba' compliant strptime"Stefan Metzmacher1-19/+0
This reverts commit 4ea7d4694a8353fc55ecd12cb09b9c91ffde7b3f. A better fix will follow. metze
2012-06-14lib/replace: add more condition to add snprintf.cStefan Metzmacher1-1/+3
metze
2012-06-14Revert "lib/replace: Fix snprintf() override for systems with a broken ↵Stefan Metzmacher1-1/+1
snprintf()" This reverts commit bbc1b0c9853322da10483f72c020fe0dd83b28fa. A more generic fix will follow. metze
2012-06-14lib/replace: s/execute=1/execute=TrueStefan Metzmacher1-1/+1
metze
2012-06-14s3: Fix a commentVolker Lendecke1-15/+13
The fd count is implicit Signed-off-by: Jeremy Allison <jra@samba.org> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu Jun 14 01:53:17 CEST 2012 on sn-devel-104
2012-06-13replace: fix unused variable warningBjörn Jacke1-3/+6
e2747fc62c2acbab143c4971469e0a4fc36d8789 fixed ... Autobuild-User(master): Björn Jacke <bj@sernet.de> Autobuild-Date(master): Wed Jun 13 23:57:58 CEST 2012 on sn-devel-104
2012-06-13Revert "replace: fix unused variable warning"Björn Jacke1-5/+4
This reverts commit e2747fc62c2acbab143c4971469e0a4fc36d8789. one line slipped into a wrong ifndef ...