summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2010-06-10tevent: Fix maxfd calculation in tevent_selectVolker Lendecke1-1/+2
When doing fd1 = tevent_add_fd(ev, ev, 2, 0, NULL, NULL); fd2 = tevent_add_fd(ev, ev, 3, 0, NULL, NULL); TALLOC_FREE(fd2); fd2 = tevent_add_fd(ev, ev, 1, 0, NULL, NULL); we end up with select_ev->maxfd==1. This is wrong. An alternative fix might be to make select_ev->maxfd an unsigned int and make EVENT_INVALID_MAXFD==UINT_MAX. But in theory we might end up with an fd of UINT_MAX. std_event_add_fd() contains exactly the same piece of code, so I'm directly pushing it. Volker
2010-06-10s3-smbd: Fix typo in comment.Karolin Seeger1-1/+1
Karolin
2010-06-10s3-passdb: Fix typo in comment.Karolin Seeger1-1/+1
Karolin
2010-06-09Rename "allow_smb2" -> "using_smb2" and make the usage clearer.Jeremy Allison9-24/+33
2010-06-09Split out the "finished write processing" code into a function so it can be ↵Jeremy Allison1-40/+62
called by both sync and async code. Jeremy.
2010-06-09Ensure we don't send SMB1 keepalives on an SMB2 connection.Jeremy Allison1-0/+6
Jeremy.
2010-06-09Split out the "finished read processing" code into a function so it can be ↵Jeremy Allison1-36/+75
called by both sync and async code. Jeremy.
2010-06-09s3-winbind: Fixed setting default sequence number.Andreas Schneider1-1/+1
2010-06-09s3: fix calculation of st_blocks in streams_xattrBjörn Jacke1-3/+3
Thanks to Joachim Schmitz for finding that miscalculation.
2010-06-09s3: fix calculation of st_blocks in init_stat_ex_from_statBjörn Jacke1-1/+1
this is just relevant for the very rare systems that don't have the st_blocks struct member. This is a fixup of the fix for bug 7474. Thanks to Joachim Schmitz for spotting this!
2010-06-09Added guids for the validated writes.Nadezhda Ivanova1-0/+7
2010-06-09s3: Fix bug 7253Volker Lendecke1-1/+8
acct_ctrl is 32 bit in LOGIN_CACHE, but "w" as a format specifier for tdb_unpack only writes 16 bits. Okay on x86, not okay on Solaris. Thanks to Vladimir.Marek@Sun.COM! Volker
2010-06-08Fix a valgrind error found by SMB2-COMPOUND test.Jeremy Allison3-0/+31
If a file is closed we must also NULL out all chained_fsp pointers when the fsp is freed to prevent invalid pointer access. Jeremy.
2010-06-08Second part of fix for 7501 - SMB2: CREATE request replies getting mangled.Jeremy Allison1-67/+67
Based on code from Ira Cooper <samba@ira.wakeful.net>, and also advice on refactoring the patch into a function call. outbuf vectors can be reallocated by smb2 processing code, so when returning interim responses we must not make assumptions about vector size. Jeremy
2010-06-08Fix for bug 7501 - SMB2: CREATE request replies getting mangled.Ira Cooper1-3/+1
Code for dup_smb2_req() was duplicating the wrong vector (i, instead of i+2) when returning a non-minimal SMB2 response.
2010-06-08s3-selftest: disable domain creds smbclient_s3 tests for now.Günther Deschner1-2/+2
Not sure they were ever working before. With this patch, make selftest is down to 4 failures from 259 tests. (two times LOCK9 from s3 smbtorture, one spoolss notify test and samba3.posix_s3.unix.info2). Guenther
2010-06-08s3-netdomjoin-gui: Fix Bug #7500. Fix 'not a string literal' warning in ↵Günther Deschner1-1/+1
netdomjoin-gui. Patch from Buchan Milne <bgmilne@mandriva.org>. Thanks! Guenther
2010-06-08Revert "s3:smbd Fix segfault if register_existing_vuid() fails"Volker Lendecke1-12/+4
This reverts commit 8f1cec5faf4e26de8b9797777059e99f2a66558b.
2010-06-08Revert "s3:smbd Give the kerberos session key a parent"Volker Lendecke1-2/+0
This reverts commit 4a7f45b7e1cef13bc28d7ee50dd4b5519bdec397.
2010-06-08Revert "s3:auth Change auth_ntlmssp_server_info API to return NTSTATUS"Volker Lendecke5-18/+13
This reverts commit edba46ce94c335411ab337eeb4ef6f88fb3aae80. Conflicts: source3/auth/auth_ntlmssp.c
2010-06-08s3-waf: fix the the waf build.Günther Deschner1-2/+3
Guenther
2010-06-07Make aio_ex owned by a talloc context, not neccessarily on the null context.Jeremy Allison1-8/+12
2010-06-07Move "write_though" into aio_ex struct.Jeremy Allison1-5/+5
2010-06-07s3:smbd add utility function to check if there are open pipesSimo Sorce3-8/+16
2010-06-07s3:rpc make num_pipe_handles get an actual pipe as argumentSimo Sorce3-6/+6
Let the function abstract out how handles are counted
2010-06-07s3:rpc handles are used by all pipes, use better nameSimo Sorce2-1/+1
2010-06-07s3:rpc fix potential out of bound memory accessSimo Sorce1-1/+1
memcpy copies memory unconditionally, we are passing "" in some cases here. Use strncpy which will stop reading from src if the null byte is found and will fill with nulls the destination.
2010-06-07s3: fix build on platforms without st_blocks and st_blksize stat struct membersBjörn Jacke1-0/+9
This fixes bug 7474.
2010-06-07ldb:pyldb.c - we cannot use "ldb_dn_compare" if both message DNs are NULL in ↵Matthias Dieter Wallnöfer1-3/+5
"py_ldb_msg_compare" Discovered by the testcase.
2010-06-07s4 python: add more unit tests to verify the compare testsMatthieu Patou1-0/+19
2010-06-07s4:objectclass_attrs LDB module - move the single-valued attribute check ↵Matthias Dieter Wallnöfer2-45/+13
into this module It seems to me more consistent (and also to keep the same behaviour on all backends). Also the DRS hack should therefore not be needed anymore since the "repl_meta_data" module launches requests behind "objectclass_attrs".
2010-06-07s4:rdn_name LDB module - move the "distinguishedName" write prevent check hereMatthias Dieter Wallnöfer2-7/+6
In my eyes it fits better here than in the TDB backend code.
2010-06-07s3:auth add hooks to indicate if signing or sealing is desired with NTLMSSPAndrew Bartlett3-0/+33
This allows the right hooks to be called in GENSEC when s3compat implements the auth_ntlmssp interface. Otherwise, we can't do the signing or sealing as we have not negoitated it's use. Andrew Bartlett
2010-06-07s3:auth Change auth_ntlmssp_server_info API to return NTSTATUSAndrew Bartlett5-13/+18
It's nicer to have an NTSTATUS return, and in s3compat there may be a reason other than 'no memory' why this can fail. Andrew Bartlett
2010-06-07s3:named pipe proxy Improve error messages when named pipes fail to forwardAndrew Bartlett1-3/+6
I hope this helps the next person who needs to debug this. Andrew Bartlett
2010-06-07s3:smbd Give the kerberos session key a parentAndrew Bartlett1-0/+2
I can't see what would free this, so this should prevent a memory leak. Andrew Bartlett
2010-06-07named_pipe_auth Always lower case the incoming pipe nameAndrew Bartlett1-1/+7
Windows connects to an upper case NETLOGON pipe, and we can't find the socket to connect to until we lower case the name. Andrew Bartlett
2010-06-07s3:smbd Fix segfault if register_existing_vuid() failsAndrew Bartlett1-4/+12
The register_existing_vuid() call will handle both the ntlmssp_end and vuid invalidation internally, so we don't want to do it again. Andrew Bartlett
2010-06-07s3:auth Rename user_info->domain -> user_info->mapped.domain_nameAndrew Bartlett10-38/+37
This is closer to the structure I want for a common struct auth_usersupplied_info. Andrew Bartlett
2010-06-07s3:auth Rename user_info->client_domain -> user_info->client.domain_nameAndrew Bartlett6-9/+9
This is closer to the structure I want for a common struct auth_usersupplied_info. Andrew Bartlett
2010-06-07s3:auth fix header comment for internal_username -> mapped.account_nameAndrew Bartlett1-1/+1
2010-06-07s3:auth Rename user_info->internal_username -> user_info->mapped.account_nameAndrew Bartlett12-31/+31
This is closer to the structure I want for a common struct auth_usersupplied_info. Andrew Bartlett
2010-06-07s3:auth Rename user_info->smb_name -> user_info->client.account_nameAndrew Bartlett11-30/+32
This is closer to the structure I want for a common struct auth_usersupplied_info. Andrew Bartlett
2010-06-07s4:samba_dsdb LDB module - fix typosMatthias Dieter Wallnöfer1-2/+2
2010-06-07s4:samba_dsdb LDB module - enhance/fix module rule commentsMatthias Dieter Wallnöfer1-3/+5
2010-06-07s3:auth make sure the primary group sid is usableSimo Sorce1-13/+30
This function was previously performed under the cover by converting back and forth from info3 to samu and then later from samu to info3. Since we now shortcircuit that in some cases, check explicitly using get_primary_group_sid() Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-06-07s3:auth return the full passwd struct from check_accountSimo Sorce1-12/+6
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-06-07s3:passdb Export function to calculate the proper primary group sidSimo Sorce3-86/+136
Don't keep it buried in passdb, this function need to be available for use in places where we do not want to construct an artificial samu struct just to play tricks. Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-06-07s3:auth remove unused structure memberSimo Sorce3-110/+2
sids are now completely handled using info3, remove dead code that fills server info sids and the structure members themselves Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2010-06-07s3:auth create nt token from info3 directlySimo Sorce3-38/+167
Signed-off-by: Andrew Bartlett <abartlet@samba.org>