Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2010-03-10 | s3: Fix a long-standing problem with recycled PIDs | Volker Lendecke | 20 | -38/+602 | |
When a samba server process dies hard, it has no chance to clean up its entries in locking.tdb, brlock.tdb, connections.tdb and sessionid.tdb. For locking.tdb and brlock.tdb Samba is robust by checking every time we read an entry from the database if the corresponding process still exists. If it does not exist anymore, the entry is deleted. This is not 100% failsafe though: On systems with a limited PID space there is a non-zero chance that between the smbd's death and the fresh access, the PID is recycled by another long-running process. This renders all files that had been locked by the killed smbd potentially unusable until the new process also dies. This patch is supposed to fix the problem the following way: Every process ID in every database is augmented by a random 64-bit number that is stored in a serverid.tdb. Whenever we need to check if a process still exists we know its PID and the 64-bit number. We look up the PID in serverid.tdb and compare the 64-bit number. If it's the same, the process still is a valid smbd holding the lock. If it is different, a new smbd has taken over. I believe this is safe against an smbd that has died hard and the PID has been taken over by a non-samba process. This process would not have registered itself with a fresh 64-bit number in serverid.tdb, so the old one still exists in serverid.tdb. We protect against this case by the parent smbd taking care of deregistering PIDs from serverid.tdb and the fact that serverid.tdb is CLEAR_IF_FIRST. CLEAR_IF_FIRST does not work in a cluster, so the automatic cleanup does not work when all smbds are restarted. For this, "net serverid wipe" has to be run before smbd starts up. As a convenience, "net serverid wipedbs" also cleans up sessionid.tdb and connections.tdb. While there, this also cleans up overloading connections.tdb with all the process entries just for messaging_send_all(). Volker | |||||
2010-03-10 | s3: Make TLDAP_IS_ALPHA and TLDAP_IS_ADH static functions | Volker Lendecke | 1 | -5/+12 | |
2010-03-10 | s3-passdb: Fix typo in debug message. | Karolin Seeger | 1 | -1/+1 | |
Karolin | |||||
2010-03-10 | s4-spoolss: remove unsed iconv handle from dcesrv_spoolss_GetPrinterData(). | Günther Deschner | 1 | -1/+0 | |
Guenther | |||||
2010-03-10 | s4:winreg RPC - don't crash when incoming data wasn't correctly specified | Matthias Dieter Wallnöfer | 1 | -2/+8 | |
Also found by the WINREG torture test enhancements by gd. | |||||
2010-03-10 | s4:lib/registry/ldb.c - fix up registry backend to be more robust | Matthias Dieter Wallnöfer | 1 | -9/+5 | |
This should let the new WINREG tests written by gd at least pass against us. | |||||
2010-03-09 | Fix the shell script in the root case. When run as root, make test now ↵ | Jeremy Allison | 1 | -4/+4 | |
detects CAP_DAC_OVERRIDE being left on in error. Jeremy. | |||||
2010-03-10 | s4-smbtorture: disable winreg QueryValue test for today. | Günther Deschner | 1 | -2/+2 | |
wow, both s3 and s4 crash on full coverage winreg QueryValue testing. Guenther | |||||
2010-03-10 | s4-smbtorture: fix some build warnings in RPC-SPOOLSS test. | Günther Deschner | 1 | -8/+8 | |
Guenther | |||||
2010-03-09 | Add tests which, when run as root, will ensure we can't write | Jeremy Allison | 3 | -11/+154 | |
into a read-only directory, or read a owner-read-only file. Jeremy. | |||||
2010-03-10 | s4-smbtorture: on HKLM hive test the well known CurrentVersion value. | Günther Deschner | 1 | -0/+17 | |
Guenther | |||||
2010-03-10 | s4-smbtorture: add full coverage test for winreg QueryValue calls. | Günther Deschner | 1 | -0/+101 | |
Guenther | |||||
2010-03-10 | s4-smbtorture: rework test_winreg_QueryValue in RPC-SPOOLSS-PRINTER once again. | Günther Deschner | 1 | -3/+8 | |
Guenther | |||||
2010-03-10 | s4-smbtorture: add tests for set and delete value in RPC-WINREG. | Günther Deschner | 1 | -0/+52 | |
Guenther | |||||
2010-03-09 | Fix typo and convert spaces to tabs | Simo Sorce | 1 | -4/+4 | |
2010-03-09 | Fix typo | Simo Sorce | 1 | -2/+2 | |
2010-03-09 | Allow "make test" to complete as root. Obviously only safe on tightly | Jeremy Allison | 1 | -0/+16 | |
controlled developer machines. Jeremy. | |||||
2010-03-09 | s3: Fix a NULL pointer dereference | Volker Lendecke | 1 | -1/+10 | |
Found by Laurent Gaffie <laurent.gaffie@gmail.com>. Thanks! Volker | |||||
2010-03-09 | s4:ldb fix escape parsing | Simo Sorce | 1 | -2/+24 | |
sscanf can return also on short reads, in this case an invalid escape sequence like '\1k' would be accepted, returning 1 as value and swallowing the 'k'. Use an auxiliar function to validate and convert hex escapes. | |||||
2010-03-09 | s3:tldap add own filter parsing | Simo Sorce | 2 | -114/+614 | |
Also add torture test to check filter parsing. | |||||
2010-03-09 | s4:winbind - use "unsigned" variables where possible | Matthias Dieter Wallnöfer | 5 | -27/+27 | |
2010-03-09 | s4:winbind/wb_cmd_getgroups.c - fix up warnings | Matthias Dieter Wallnöfer | 1 | -8/+16 | |
Also fix some indentations. | |||||
2010-03-09 | s4:unittest Fix unittest to reflect that wbinfo -r no longer fail | Matthieu Patou | 1 | -1/+2 | |
Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de> | |||||
2010-03-09 | s4:winbind: stub implementation of WINBINDD_PAM_LOGOFF | Matthieu Patou | 2 | -2/+29 | |
Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de> | |||||
2010-03-09 | s4:winbind: Fix a misplaced returned info | Matthieu Patou | 1 | -4/+2 | |
libwbclient expect to have in auth.exra_data the INFO3_TXT and in auth.unix_username the username Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de> | |||||
2010-03-09 | s4:winbind Implement logic for getgroups to work | Matthieu Patou | 3 | -17/+273 | |
This function is called by the system everytime we do a id user or when we do wbinfo -r Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de> | |||||
2010-03-09 | s4:winbind: implement calls for allowing getent groups | Matthieu Patou | 5 | -2/+379 | |
This is to say getgrent and setgrent, and the associated technical objects (states, build directives,...) needed. Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de> | |||||
2010-03-09 | s4:torture/rpc/netlogon.c - "LogonGetDomainInfo" test - make it compatible ↵ | Matthias Dieter Wallnöfer | 1 | -18/+100 | |
against Windows Server 2008 This is a reworked version of the mentioned test which passes against Windows Server 2008. The previous version, also mainly written by me passed only against Windows Server <= 2003. | |||||
2010-03-09 | s4:netlogon RPC - "LogonGetDomainInfo" - make the call compatible with >= ↵ | Matthias Dieter Wallnöfer | 1 | -23/+62 | |
Windows 2008 Add more security checks and other corrections to imitate Windows Server >= 2008. | |||||
2010-03-09 | libcli/auth/schannel_state_tdb.c - fix an obviously wrong error handling | Matthias Dieter Wallnöfer | 1 | -1/+0 | |
2010-03-09 | s4-smbtorture: fix uninitialized variable in winreg QueryValue call. | Günther Deschner | 1 | -0/+1 | |
Guenther | |||||
2010-03-09 | s3: Fix a typo. Thanks to Christian Ambach for pointing me at it :-) | Volker Lendecke | 21 | -21/+21 | |
2010-03-09 | A helper function to get the Infrastructure DN. | Nadezhda Ivanova | 1 | -0/+12 | |
2010-03-09 | Fixed a bug in acl tests - python error when we create user/group/ou with a ↵ | Nadezhda Ivanova | 1 | -23/+23 | |
descriptor. | |||||
2010-03-09 | Added a check for permissions to modify the RDN attribute on rename. | Nadezhda Ivanova | 2 | -0/+44 | |
Necessary because rdn module will be moved lower than acl in the stack. | |||||
2010-03-09 | s4:dsdb/dns: change callers of samba_runcmd() | Stefan Metzmacher | 1 | -36/+68 | |
metze | |||||
2010-03-09 | lib/util: change samba_runcmd() to use tevent_req _send/_recv | Stefan Metzmacher | 2 | -146/+188 | |
metze | |||||
2010-03-08 | Revert "Fix bug #7067 - Linux asynchronous IO (aio) can cause smbd to fail ↵ | Karolin Seeger | 3 | -71/+5 | |
to respond to a read or write." This reverts commit a6ae7a552f851a399991262377cc0e062e40ac20. This fixes bug #7222 (All users have full rigths on all shares) (CVE-2010-0728). (cherry picked from commit 1c9494c76cc9686c61e0966f38528d3318f3176f) | |||||
2010-03-09 | s3:build: Fix automatic building of vfs_tsmsm if gpfs and dmapi are present. | Michael Adam | 1 | -1/+1 | |
Michael | |||||
2010-03-08 | s3:release-scripts: fix create-tarball to treat vendor patch level correctly | Michael Adam | 1 | -1/+1 | |
2010-03-08 | samba: remove Linux cifs-utils files from samba master branch | Jeff Layton | 12 | -4182/+7 | |
This patch removes all of the files from the samba tree that should now be provided by the cifs-utils package. It also drops a "README.cifs-utils" into the topdir with a URL to the main cifs-utils webpage. This is for people who don't want the lists and might be taken by surprise by the change. That's optional, but I think it's a good idea for a least a release or two. Signed-off-by: Jeff Layton <jlayton@samba.org> | |||||
2010-03-08 | s4:"dns_update_list" file: install it properly into the private directory | Matthias Dieter Wallnöfer | 2 | -7/+10 | |
This is what the "samba_dnsupdate" script requests (line 220). | |||||
2010-03-08 | Revert "s4:script/installmisc.sh - install "dns_update_list" to target setup ↵ | Matthias Dieter Wallnöfer | 1 | -1/+0 | |
folder" This reverts commit b49276e291274652d46eed39249c07531e32b591. | |||||
2010-03-08 | LDB:asq module - change counters to "unsigned" where appropriate | Matthias Dieter Wallnöfer | 1 | -4/+5 | |
2010-03-08 | LDB:sort module - change counters to "unsigned" where appropriate | Matthias Dieter Wallnöfer | 1 | -4/+5 | |
2010-03-08 | LDB:rdn name module - change counters to "unsigned" where appropriate | Matthias Dieter Wallnöfer | 1 | -2/+3 | |
2010-03-08 | LDB:paged searches module - change counters to "unsigned" where appropriate | Matthias Dieter Wallnöfer | 1 | -2/+2 | |
2010-03-08 | LDB:paged results module - change counters to "unsigned" where appropriate | Matthias Dieter Wallnöfer | 1 | -4/+4 | |
2010-03-08 | s3: add missing Makefile.in changes for vfs_crossrename | Björn Jacke | 1 | -0/+5 | |
2010-03-08 | s3: add man page for vfs_crossrename | Björn Jacke | 1 | -0/+115 | |