summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2013-02-22s3-spoolss: Don't leak memory.Andreas Schneider1-1/+3
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22s3-net: Don't leak username.Andreas Schneider1-1/+2
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22s4-client: Don't leak file descriptor.Andreas Schneider1-0/+7
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22s4-client: Don't leak resource handle.Andreas Schneider1-0/+2
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22torture: Make sure we don't overrun the buffer.Andreas Schneider1-1/+1
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22torture: Fix memcmp of short buffer.Andreas Schneider1-2/+2
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22torture: Fix array access in spoolss test.Andreas Schneider1-2/+2
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22pdb: Fix array overrun by one.Andreas Schneider1-3/+4
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22s4-libcli: Check return value of smbcli_request_setup().Andreas Schneider3-0/+15
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22pyauth: Check return value of lpcfg_from_py_object().Andreas Schneider1-0/+4
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22ndrdump: Check return value of ndr_pull_init_blob().Andreas Schneider1-0/+12
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22s4-libcli: Check return code of smbcli_request_setup().Andreas Schneider1-0/+3
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22librpc: Add NULL check for ndr functions for epm bindings.Andreas Schneider1-1/+6
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22s3-tldap: Make sure we don't deref a null pointer.Andreas Schneider1-0/+3
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22s4-libcli: Add null check for ndr functions in rap.Andreas Schneider1-0/+8
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22nmbd: Fix request data data processing.Andreas Schneider1-2/+2
answers->rdata is an array and will never be NULL. Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22torture: Fix samsync domain_name checks.Andreas Schneider1-4/+45
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22libsmb: Fix possible null pointer dereference.Andreas Schneider1-2/+2
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22ndr: Comparing an array to null is always true.Andreas Schneider1-1/+1
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22winbind: Correctly cast name to messaging_send_buf().Andreas Schneider1-3/+3
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22winbind: Use uint8_t type and use const where needed.Andreas Schneider1-7/+7
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22messages: Use uint8_t type.Andreas Schneider1-2/+2
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22winbind: Make domain_name const in wcache_ndr_key().Andreas Schneider1-1/+1
Reviewed-by: Alexander Bokovoy <ab@samba.org>
2013-02-22build: use -fstack-protector if availableBjörn Jacke1-0/+3
Signed-off-by: Bjoern Jacke <bj@sernet.de> Reviewed-by: Matthieu Patou <mat@samba.org> Autobuild-User(master): Björn Jacke <bj@sernet.de> Autobuild-Date(master): Fri Feb 22 15:38:21 CET 2013 on sn-devel-104
2013-02-22Revert "wafbuild: use -Wstack-protector if available"Björn Jacke1-3/+0
This reverts commit e6643fbf48afccd0acedb65fbe24d3ce84d44c40. Signed-off-by: Bjoern Jacke <bj@sernet.de> Reviewed-by: Matthieu Patou <mat@samba.org>
2013-02-22build/autoconf: put ld check variable in quotesBjörn Jacke1-1/+1
Signed-off-by: Bjoern Jacke <bj@sernet.de> Reviewed-by: Stefan Metzmacher <metze@samba.org>
2013-02-22dsdb-descriptor: Avoid segfault copying an SD without an owner or groupAndrew Bartlett1-4/+12
This is an unusual SD, but it does exist is some very old upgraded databases. Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Fri Feb 22 11:06:17 CET 2013 on sn-devel-104
2013-02-22dsdb-descriptor: Spell out security descriptor flags as constantsAndrew Bartlett2-2/+2
Reviewed-by: Stefan Metzmacher <metze@samba.org>
2013-02-22torture-drs: Fix comment in replica_sync testAndrew Bartlett1-1/+1
Reviewed-by: Stefan Metzmacher <metze@samba.org>
2013-02-22torture-drs: Make the samba4.drs.repl_schema.python emit failures, not ↵Andrew Bartlett1-1/+5
errors on add failure This then allows this particular failure to be masked with a knownfail. Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
2013-02-22ldb: Add missing dependency on replace for ldbAndrew Bartlett1-1/+1
This brings in rep_timegm() on Solaris for example. Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
2013-02-22build: Remove includes.h dep in winbind client librariesAndrew Bartlett1-1/+0
Our LGPL winbind client libs do not link against our server-side code, and should not use the server-side includes.h. This removes a build-time dep on talloc that was brought in via includes.h as this code also does not use talloc. Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
2013-02-22build: Remove unused includes.h reference to avoid build-time talloc depAndrew Bartlett1-1/+0
talloc is not a dependency of this library, but is required by includes.h. By not including includes.h, we avoid needing to add an otherwise false talloc dep. (this comes up if talloc.h is not installed as a system package). Andrew Bartlett Reviewed-by: Stefan Metzmacher <metze@samba.org>
2013-02-21build:autoconf: fix output of syslog-facility checkBjörn Jacke1-1/+4
thanks to Thomas Bork for reporting! Signed-off-by: Bjoern Jacke <bj@sernet.de> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Thu Feb 21 00:00:06 CET 2013 on sn-devel-104
2013-02-20s3:rpc_client fix a crashChristian Ambach1-1/+1
state->cli->dc does not have to be set (e.g. when running net rpc join against an older Samba PDC), so check it before dereferencing it This fixes Bug 9669 - net rpc join crashes against a Samba 3.0.33 PDC Bug: https://bugzilla.samba.org/show_bug.cgi?id=9669 Signed-off-by: Christian Ambach <ambi@samba.org> Reviewed-by: Andreas Schneider <asn@samba.org> Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Wed Feb 20 19:00:52 CET 2013 on sn-devel-104
2013-02-20ntdb: switch between secrets.tdb and secrets.ntdb depending on 'use ntdb'Rusty Russell19-29/+59
Since we open with dbwrap, it auto-converts old tdbs (which it will rename to secrets.tdb.bak once it's done). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Reviewed-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User(master): Rusty Russell <rusty@rustcorp.com.au> Autobuild-Date(master): Wed Feb 20 07:09:19 CET 2013 on sn-devel-104
2013-02-20param: 'use ntdb' flag (off by default).Rusty Russell5-0/+35
For simplicity, we use this in the caller to choose between filenames. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-02-20tdb_wrap: prevent tdbs called ".ntdb" or without extensions.Rusty Russell1-0/+8
This is another belt-and-braces check in case someone decides to turn on the fancy new .ntdb extension, and we haven't converted it to ntdb. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-02-20dbwrap_local_open: never open the .tdb if there is an .ntdbRusty Russell1-0/+5
This provides an extra safety check that everyone is using one or the other: you can't create a tdb file if there's an ntdb file. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-02-20dbwrap_local_open: open NTDB if extension is .ntdbRusty Russell1-5/+157
This switches dbwrap_local_open() based on the extension of the database name, so it handles both TDB and NTDB files. Moreover, if asked to open a .ntdb, and there's no ntdb file but there's a .tdb file, it converts that then moves it to .tdb.bak before opening, and turn the .tdb file into a dangling symlink to make sure it's never accidentally re-created or used: $ ls -l secrets.tdb lrwxrwxrwx 1 rusty rusty 23 Feb 11 11:31 secrets.tdb -> This is now in an NTDB This provides transparent upgrade if people decide to use NTDB on a database. Downgrade would be manual, eg: ntdbdump foo.ntdb | tdbrestore foo.tdb && mv foo.ntdb foo.ntdb.bak Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-02-20source3: explicitly disable NTDB support.Rusty Russell1-0/+1
The next patch make dbwrap_local_open() call the ntdb backend for ntdb files, but we don't want to add ntdb support to the old autoconf build. It's cleaner to use the existing DISABLE_NTDB flag rather than test for _SAMBA_BUILD_ in dbwrap_local_open.c. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-02-20dbwrap: dbwrap_ntdb.cRusty Russell3-10/+734
This is a dbwrap backend for ntdb. It's a fairly straight conversion from the tdb version. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-02-20ntdb: fix database corruption when transaction doesn't change anything.Rusty Russell3-15/+91
ntdb's transaction code has an optimization which tdb's doesnt: it only writes the parts of blocks whose contents have changed. This means we can actually have a transaction which turns out to need no recovery region. This breaks the recovery setup logic, which sets the current recovery size to 0 if there's no recovery area, and assumes that we'll always create a new recovery area since the recovery will always need > 0 bytes. In fact, if we really haven't changed anything, we can skip the transaction commit altogether: since this happens at least once with Samba, it's worth doing. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Reviewed-by: Andrew Bartlett <abartlet@samba.org>
2013-02-20s3:selftest: generate ${SELFTESTPREFIX}/subunit with the raw outputStefan Metzmacher1-1/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org> Autobuild-User(master): Michael Adam <obnox@samba.org> Autobuild-Date(master): Wed Feb 20 01:33:50 CET 2013 on sn-devel-104
2013-02-19s3:torture: call fault_setup() to get usage backtracesStefan Metzmacher1-0/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-02-19s3:include: avoid TEVENT_COMPAT_DEFINESStefan Metzmacher1-1/+0
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-02-19s3:lib: s/event_add_timed/tevent_add_timerStefan Metzmacher1-1/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-02-19s3:nmbd: s/event_add_timed/tevent_add_timerStefan Metzmacher1-1/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-02-19s3:modules: s/event_add_timed/tevent_add_timerStefan Metzmacher1-2/+2
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
2013-02-19s3:rpc_server: s/event_add_timed/tevent_add_timerStefan Metzmacher1-1/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org> Reviewed-by: Michael Adam <obnox@samba.org>
generated by cgit (git 2.34.1) at 2024-11-29 15:27:18 +0000