Age | Commit message (Collapse) | Author | Files | Lines |
|
Do not re-add them. These macros are unsafe as they are not understood.
Change all TNG code using them to correct '&' and '|' please.
IS_BITS_SET_ALL was being used in cmd_interp.c when IS_BITS_SET_SOME
should have been used.
Jeremy.
(This used to be commit be4e5eeb4f808c1d8ac4030e8886a83a37914c57)
|
|
(This used to be commit 604f6a34effb8aeed7701345a4219749a6a97892)
|
|
Marshalling code path now uses spoolss_smb_io_unistr()
also caught a NULL pointer case.
i'll update TNG later.
(This used to be commit bd4c83eb40a14baf447ac88886d4eafe7b9a309f)
|
|
(This used to be commit 9af82423d2e5c6f873a906097a56c8ac6c5f8297)
|
|
(This used to be commit bc065f9597654666e2f26ec046e058e44247d6e3)
|
|
[got confused with which way dirdiff was going :)].
... but you forgot to update TNG's lib/cmd_interp.c...
(This used to be commit 8fe195df0b5826af7048ef6c87e4b55dfd336cf8)
|
|
please do not remove IS_BITS_SET_XXX macros just because you happen
"not to like them". whilst still working on merging, you are not
responsible for this code, therefore do not hinder its development
whilst people are attempting to do merges. after the merge from
TNG to cvs main is completed, you can do what the hell you like.
thank you.
jerry,
please could you consider adding underlying routines (in this case
get_safe_smb_errstr()) instead of reverting to a [less secure]
previous coding method. thanks.
(This used to be commit b2e044f89de7cb12fd14540d5d7d5070951ce2fb)
|
|
jerry
(This used to be commit 95355d2cf26f51b1f928b8a020a4a731483be0b8)
|
|
to use spool_smb_io_unistr() as this does not call prs_align()
befrore parsing the UNISTR.
Parsing a void* buffer from an RPC should not be aligned
on 4 byte boundaries. Don't think this change affects
any marshalling code, only unmarshalling...
jerry
(This used to be commit bc154e8522a75540a8504195c1e6f45739167e6b)
|
|
as it was throwing things off when parsing buffers passed in SPOOLSS
RPCs
fixed the unmarshalling of UNISTR arrays to be double NULL terminated
jerry
(This used to be commit 236f19659cea87cc35128990954d30c43114b889)
|
|
of 0 bytes.
jerry
(This used to be commit 3fcc59ba928250759bbf3ef46d7c118950a5ba6f)
|
|
jerry
(This used to be commit ce2d20395ae3d41d55030427f4b7b44ce87c605e)
|
|
jerry
(This used to be commit 8e95aae1709a9be28d6e25ff6f0fdc729dc09274)
|
|
memory access.
Tridge, I don't think using 0xdeadbeef for size allocations
of 0 is going to work. I ended up having to use NULL
as much code that works on UNISTR checks to see if the buffer ptr
is NULL. So valid code ends up with a seg fault.
Rather than rewriting it all, I added a DEBUG_TALLOC
#ifdef in talloc.h that sets a macro BAD_PTR.
This is the value assigned to ptr for an allocation of 0 bytes.
jerry
(This used to be commit 233b9cffa2350552d9f775f791d5d5e0464a1ed4)
|
|
jerry
(This used to be commit f806881e6c2c94c03fb7e70d92cd0a5a3fc30fbd)
|
|
(This used to be commit 3361c144f5ba2a87a469436f670ab35189021d49)
|
|
The smb_io_unistr() code called a prs_align, this was not being
counted in the size or taken account of in the offset calculation.
Fixed size_ calculation to always return a size a multiple of 4
and also set the offset correctly. This fixes the problem I saw
and will hopefully fix the problem HP reported. JF please check
this change.
Jeremy.
(This used to be commit ceba9f3dcdb4bddae17ec0024692c9074086302d)
|
|
If libsmb/namequery.c:name_query() times out while doing a non-broadcast
query, I mark that WINS server 'dead'. Note that I don't try the new
WINS server. I think I can get that working too.
This is only for queries, not registrations. The biggest problem is that
I may have to fiddle with the UNICAST SUBNET, but I need to check talk
that over with someone (Jeremy?) before I hack at it.
I can't actually test the above change, I'm 'fraid. I'm getting:
4 errors detected in the compilation of "rpc_server/srv_spoolss_nt.c".
in head branch.
Chris -)-----
(This used to be commit 40ae638866e3d826ccd5d827672634959c31b039)
|
|
depending on where it came from.
Jeremy.
(This used to be commit cfbf78085d48671e5be382e7486953a85a893be1)
|
|
Patch from John Reilly <jreilly@hp.com>.
Jeremy.
(This used to be commit 76a5713bd3fad18ec60d12fc3f965f3e9717c159)
|
|
Jeremy.
(This used to be commit e466c863f5540e13776f4477b6d58e3fbfe7276d)
|
|
Thanks to Elrond for pointing this out.
Jeremy.
(This used to be commit 1d9a5494f8214b8d6171073f4090687a8535d78c)
|
|
dependentfiles.
jery
(This used to be commit 206565368b887ba83791efe018f24175e6f31137)
|
|
struct. Not wuite there.
jerry
(This used to be commit 1a145977f09654fc51ebcd40ef7a2aa69aa96cfb)
|
|
jerry
(This used to be commit 4bc5b8aa345b963e1247c6a364ba48a08fbd9764)
|
|
jerry
(This used to be commit 26a73a70e282a5e46cc2b6fe7bc09b406724c9dd)
|
|
jerry
(This used to be commit cfa4c878a2ccaf346940f8f4a201737e185f76d6)
|
|
jerry
(This used to be commit df51dc32f6ffc4fe2cebfaae5079417aad1ff34d)
|
|
on a Samba host. Also needed to add an option to pass the share
name (printer name) on the command line.
And fixed the checking of the return code for spoolss_r_addprinterex()
jerry
(This used to be commit 880e81161640cd38540b06d982c592cbada51d40)
|
|
in the ACE's the same thing must be done in the desired access or they will
never match. This took me a while to find... :-).
Jeremy.
(This used to be commit 066520979b2b5d967e6e1d77f16185a5fb19dc0c)
|
|
(This used to be commit ad74885e4730da2a15ff00e13f490f3f0b1be10d)
|
|
Also fixed init_unistr() to deal with a NULL source character string.
-jerry
(This used to be commit 8ecd5dd52a6bd867f5d117352048ee43ce7254d9)
|
|
Added debug messages to se_access_check().
Added FULL_ACCESS acl to default acl on printers.
Jeremy.
(This used to be commit 7507f6f408cf8b0f8d7e2b3da54ce5fb5ef5343b)
|
|
(This used to be commit 0d00d2ec258b36d73e865f06d5d11745d7cdafa9)
|
|
(This used to be commit 1342f2e5be28d1582ab39ec837392fbf9e721014)
|
|
any user in that list can do anything to a printer
(This used to be commit 7b5912be150dd590d6195be40b0976305b8716ba)
|
|
jerry
(This used to be commit 39d025693eadf4ca1c4fe17dd9110bb8a647f361)
|
|
(This used to be commit 16afa46797a4cdaa6e3b668caf6d910c08bec9b4)
|
|
unbecome_root() - typo.
Jeremy.
(This used to be commit ebb160663ed55e44e44f1c3d17eb077a32c2ffb9)
|
|
Jeremy.
(This used to be commit b3a1038ac1bfb0c32e64f6cb26e5e46fbda794a2)
|
|
Jeremy.
(This used to be commit 5a4a7cd4727df5d1b5e71d343e776c7df52dc515)
|
|
(This used to be commit 74074072cf244d221f8f9b09302d0cbc85d689d4)
|
|
--jerry
(This used to be commit 1e00ac19cd001024fa8007eff5137aac877796fa)
|
|
- cleaned up some code
- Fixed a few memory leaks of my own making
- Add AddPrinterDriver(); I'm missing some of the semantics
here as the call is done correctly, but I'm not getting all
the information right in the DRIVER_INFO_3 struct I think.
Will work on it tomorrow some more...
--jerry
(This used to be commit 3bf9a29f34ee4ade5180c5a0b0b9ff4aca7f0f08)
|
|
Fixed missing )
j-
(This used to be commit 7b69cbbde36e51f8f7b74691428a04e8871d8b4a)
|
|
Replaced with a memcpy()
Forgot to commit this a few moments ago
j-
(This used to be commit 34d4fb54c3121d31cb8b29193f71d5e7b5471cdc)
|
|
Thanks :-)
j-
(This used to be commit 4ecd15cd5851e94808756e3da0ce6a066f0a0cd7)
|
|
(This used to be commit b87c47cc8638a1930e55a45a126a778b188ce688)
|
|
(This used to be commit 8de3786f5ad473aab90bb3fbf7e6ca2714f91751)
|
|
(This used to be commit dfd6b51bc7fb61d25af3074c386ce51cf3bc86f4)
|