summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r16241: Fix Klocwork #106 and others like it.Jeremy Allison9-650/+385
Make 2 important changes. pdb_get_methods() returning NULL is a *fatal* error. Don't try and cope with it just call smb_panic. This removes a *lot* of pointless "if (!pdb)" handling code. Secondly, ensure that if samu_init() fails we *always* back out of a function. That way we are never in a situation where the pdb_XXX() functions need to start with a "if (sampass)" test - this was just bad design, not defensive programming. Jeremy. (This used to be commit a0d368197d6ae6777b7c2c3c6e970ab8ae7ca2ae)
2007-10-10r16230: Fix Klocwork #861 and others. localtime and asctimeJeremy Allison16-141/+276
can return NULL. Ensure we check all returns correctly. Jeremy. (This used to be commit 6c61dc8ed6d84f310ef391fb7700e93ef42c4afc)
2007-10-10r16222: Fix DEBUG statements.Günther Deschner2-2/+2
Guenther (This used to be commit 5ecfaf7d505e6acc23a06dd64d00f5e6fb8efe6f)
2007-10-10r16221: No need for friednly error messages at log level 10.Günther Deschner1-27/+26
Guenther (This used to be commit 58a7c0900325065cc969eb4f2f4c85d41e27bc89)
2007-10-10r16219: BUG 3836, 3837, 3004: compile warning fixes from Jason Mader.Gerald Carter3-4/+4
(This used to be commit 6c1f1c091f5e87bf9464fe8ad7eb2cb683819a62)
2007-10-10r16216: Add debug messages to make it possible to try andJeremy Allison1-8/+31
debug why a job pause or resume command is not being done. Jeremy. (This used to be commit e6aacb1426bd04c4006f7be66228f9f8d9a7065d)
2007-10-10r16213: Fix Klocwork #852. iface_n_ip can potentiallyJeremy Allison2-2/+16
return NULL. Ensure we don't deref. Jeremy. (This used to be commit c2f0ea2ff2f6ad925cee9c85110c6ad828ffb7a9)
2007-10-10r16209: Klocwork bug #66, ensure no null deref.Jeremy Allison1-1/+8
Jeremy. (This used to be commit 79e693798cf322071ea64a4014a01ad9eaba73e8)
2007-10-10r16207: Ensure we don't allocate an OID string unlessJeremy Allison1-3/+11
we know we don't have an error. Klocwork #6. Jeremy. (This used to be commit 2c1a2d7b40e7ef353461f97f5c69c2079b5670ab)
2007-10-10r16206: Don Meyer <dlmeyer@uiuc.edu> pointed out that RHEL4 rpms use 'Epoch: ↵Gerald Carter1-0/+1
0' so work around that (This used to be commit 304b7913cd25a024269fecdd541af06836816f68)
2007-10-10r16205: Fix 'make install' when srcdir != builddirGerald Carter1-6/+6
(This used to be commit 44d4bab991d5fc88005a542d2490ae3254a0f5b5)
2007-10-10r16204: Fix Klocwork # 14Volker Lendecke1-3/+5
localtime() can return NULL. Volker (This used to be commit 07c5dcb8633e6fadb596dc5a22d8d31b2e16a3ef)
2007-10-10r16203: Fix potentially writing one result of strtok beyond the end of alt_path.Volker Lendecke1-1/+2
Found by Klocwork, ID 653. Volker (This used to be commit 4cb8cf221f986b15de3ac608b173310c14248533)
2007-10-10r16202: Fix Klocwork #3. Strange - was already fixed in HEAD.Jeremy Allison1-2/+7
Jeremy. (This used to be commit 319f80bbf0455cfaf80eab51313a56db4ed04ac5)
2007-10-10r16201: Fix Klocwork 439Volker Lendecke1-1/+3
(This used to be commit b369d0891afe8b777b837eaac317131232568ca7)
2007-10-10r16199: Fix Klocwork #1 - ensure we test the firstJeremy Allison1-10/+12
strtok for NULL. Jeremy. (This used to be commit 98751e8190317416de56b4a19a489c5f4b7d6bc9)
2007-10-10r16198: Fix Klocwork 1023Volker Lendecke1-1/+0
(This used to be commit 3a7d01afbebe5c4c36935b6128998e1327c8f856)
2007-10-10r16197: Fix Klocwork id 1338Volker Lendecke1-2/+3
(This used to be commit 963ae5bd144b90e71331a88029698a1a6dc52190)
2007-10-10r16196: A bit of defensive programming:Volker Lendecke1-1/+1
Klocwork ID 1773 complained about oldest being dereferenced in line 2275 where it could be NULL. I think you can construct extreme racy conditions where this actually could happen. Volker (This used to be commit b5602cc4f1d77ed48ddca0f7f42b28706160c923)
2007-10-10r16195: starting development for 3.0.24pre1Gerald Carter1-2/+2
(This used to be commit 1b64f9a48bbb5a88c2029585e208865b41f2f423)
2007-10-10r16193: fix packaging dependency on RH platforms for the Unicode::MapUTF8 ↵Gerald Carter3-3/+4
perl module (caused by upgarde in smbldap-tools) (This used to be commit abca3b12e78814a395b806a9969a8f12b3230dfd)
2007-10-10r16192: Fix timeformats in the winbind response struct.Günther Deschner1-8/+8
(pam_winbind users were forced to change a password inappropriately) Guenther (This used to be commit 65643d31725a4e3fe157d66e9ecad03a65a484e2)
2007-10-10r16190: Fix more memleaks.Günther Deschner1-1/+6
Guenther (This used to be commit dfebcc8e19bee06b7c03f88845314e9cfd6f398a)
2007-10-10r16187: Fix memleak.Günther Deschner1-9/+12
Guenther (This used to be commit e7d2b84aba2f2f5d844ba6a5fdcce35c3750d0b2)
2007-10-10r16156: Fix storing NULL in the wrong place. Klocwork id's 127 and 128.Volker Lendecke1-2/+2
Volker (This used to be commit 7674a4f8361d3f3b649245118b82d8a074a2760e)
2007-10-10r16155: Janitor for jelmer.Jeremy Allison1-1/+1
Fix typo in DEBUG() Jeremy. (This used to be commit da768bf9c2761884cc97f690133d6897ed353e15)
2007-10-10r16154: Fix winbind function table typo.Günther Deschner1-1/+1
Guenther (This used to be commit aeff1f0c47992ce3941e27e63f9b1516c4918963)
2007-10-10r16153: Fix possible NULL dereference found by Klocwork # 252Volker Lendecke1-0/+4
(This used to be commit 128260527b90d77ca3dfc900e012018ef00ba9e0)
2007-10-10r16150: Fix possible NULL dereference found by Klocwork ID # 17Volker Lendecke1-3/+2
(This used to be commit 3159bd3a4e3ad70c60fea4cacc892be9f1d71ab9)
2007-10-10r16141: Dummy commit to make the build farm re-test against Samba4 16140Volker Lendecke1-2/+1
(This used to be commit a1fcacf75683e4c08236bb4cc4164678ea1a1ce4)
2007-10-10r16138: By default, rootsbindir relies on SBINDIR so import it hereAlexander Bokovoy1-0/+1
(This used to be commit a18af427d7ea7b5a04d7006d10299d9e43317ae4)
2007-10-10r16136: By default, rootsbindir relies on SBINDIR so import it hereAlexander Bokovoy1-0/+1
(This used to be commit 5ffb424641bfc71ce396800a6e426015b11fd6ba)
2007-10-10r16131: fix RedHat 9 spec filesGerald Carter1-0/+2
(This used to be commit 1ffb0f06adeb1658fa1f5eed747841c6ff1e5665)
2007-10-10r16130: fix a shell portability issue for Solaris sh in installman.shGerald Carter1-2/+2
(This used to be commit 9be3e07884e7f8121bc64766e7d036495cd94a15)
2007-10-10r16126: Janitor for Volker..... This looks correct to me.Jeremy Allison1-20/+15
Jeremy. Fix a parsing error that became apparent in 'make test': If we have no group rids in the info3 we set the array buffer pointer to "1" but fail to actually ship the array. Volker. (This used to be commit ee1b9207d3119c2b3e7c1c4e59250dbd323eae6a)
2007-10-10r16122: As we use 'inetOrgPerson' as structural objectclass for new accounts forGünther Deschner2-0/+3
eDir, we already add 'sn' as required attribute on LDAP add operations. When we modify an entry, we need to request 'sn' as well in our attribute lists, so that we don't try to add it a second time. Guenther (This used to be commit e018ea3d1d70e68e6802843f88b3245dc09244c9)
2007-10-10r16121: Fix a eDir related memory leak.Günther Deschner1-2/+9
Guenther (This used to be commit 322f1664df553d95fcdfc24f19bd7f34ce9b834b)
2007-10-10r16117: Make winbindd work again in security=ads.Günther Deschner1-2/+6
We still used the old HOST/* UPN to get e.g. users, now we need samaccountname$@REA.LM. Guenther (This used to be commit f6516a799aec2db819f79b9a1e641637422a9b4c)
2007-10-10r16116: Hoist the slow CLOCK_REALTIME message inside the branch so we neverJames Peach1-5/+5
confuse an uninitialised __profile_clock with CLOCK_REALTIME. Flip the condition argument to SMB_WARN around so that it's correct (though completely non-intuitive). (This used to be commit 60b5f9618b77afb397f96c1ff406c8cd3a4648f3)
2007-10-10r16115: Make "net ads changetrustpw" work again.Günther Deschner2-11/+7
(adapt to the new UPN/SPN scheme). Guenther (This used to be commit 8fc70d0df0c93c29b49f924bac9ff5d9857cfd9d)
2007-10-10r16114: Make winbindd's group enumeration (set|get|endgrent) work again (whenGünther Deschner1-1/+1
enabled). Do not bail out when a group just has 0 members. Jeremy, please check, this has been removed with r13915. Guenther (This used to be commit 3a738a855d335e44e167351e6396bf3fe81a03af)
2007-10-10r16112: Added Volker's fix for extra odd byte at the endJeremy Allison1-1/+1
of UNIX_BASIC infolevel. Checked client implementations (cifsfs and libsmb) and they ignore it. Thanks Volker. Jeremy. (This used to be commit 6cd1cb5c9deba2aa0d7a3251c8142834cbaba6d1)
2007-10-10r16111: Patch from Björn JACKE <samba@j3e.de>.James Peach3-20/+123
This fixes a problem where the clock definition for clock_gettime() is present at compile time, but is not available on the running system. In this case, we fall back to less-preferred clocks until we find one that we can use. (This used to be commit fc6ed6a1aa2225ccde04c4ecaf0777dc0de4f1cb)
2007-10-10r16103: Properly rebuild timelimit on systems with executable extensions.Paul Green1-2/+4
Paul (This used to be commit f5be3e12e2dc42a2092b71c9e4cab6f5d0ef8860)
2007-10-10r16080: Re-add accidentially excluded in-forest domain trusts (fixes bug #3823).Günther Deschner1-1/+1
Guenther (This used to be commit 8759a00fedfe5d8d789c8b707c924d8116da1102)
2007-10-10r16079: How embarassing. :-( Broke the build.Gerald Carter1-1/+0
I will *always* compile before checking in... I will *always* compile before checking in... I will *always* compile before checking in... I will *always* compile before checking in... I will *always* compile before checking in... (This used to be commit f3bd1c8c7de93917787e7341f759699c8399f006)
2007-10-10r16078: Patch from Aleksey Fedoseev <fedoseev@ru.ibm.com> to correctlyGerald Carter1-3/+3
set the type of 'acl compatibility from string to integer after the changes in r14207. (This used to be commit b01f289f1a788fe8f62a213b67a73a9bfee01bb1)
2007-10-10r16076: Fix for machine password timeout overflow from Shlomi YaakobovichJeremy Allison2-2/+2
<Shlomi@exanet.com>. Jeremy. (This used to be commit 5cd234a1fff1e9d025eea6600649e56c997eafc2)
2007-10-10r16065: Re-add a strlower_m(account) in samr_create_user that was dropped for noVolker Lendecke1-0/+2
reason but to increase fidelity with W2k3. Tom Bork has raised valid concerns that Unix scripts might rely on the account names being lower-case, so keep that. We might later decide to only lower-case the unix name passed to 'add [user|group] script' but keep the passdb entry upper-case. But there are enough user-visible changes in 3_0 already so that we should push this off to a later date. Tom, waiting for more bug reports from you ;-)) Thanks for insisting! Volker (This used to be commit bc78cca290559c5ca7623b9f6d9933e32668b9c4)
2007-10-10r16064: Bug fix for another one Tom Bork has reported:Volker Lendecke1-3/+23
'valid users = +unixgroup' failed with smbpasswd if 'unixgroup' has a (non-algorithmic) group mapping. Thanks a lot! People out there listening, please test current code, this release is **BIG** :-) Volker (This used to be commit 8f9ba5f96c9b506623ef97b7ed3d84f39d914a3c)