summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2000-07-26Found out that we are crashing spoolss in enumprinterdata.Jean-François Micouleau4-14/+32
So fixed enumprinterdatas in rpcclient to debug the server code, and found that the parsing code was missing 2 prs_align(). We are not crashing NT anymore. :-) J.F. (This used to be commit 883f7402d495182aeff85152216cc8b3cfc18bef)
2000-07-26Fixed memory leaks in root and non-root password changing.Tim Potter1-7/+20
(This used to be commit f3a4f81a5e51e411f1c7c6245597cca01e9ad5b2)
2000-07-26Fixed memory leaks in _spoolss_addprinterdriver()Tim Potter1-5/+9
(This used to be commit 1f49788442b0d1264c70166e727b8588b936e6ec)
2000-07-26Fixed memory leak in modify_trust_password()Tim Potter1-0/+4
(This used to be commit 7145689bf55b9f3100632badac486fde30ee4972)
2000-07-25Fixed up error checking and move printer file code. Fixed a memory leak.Jeremy Allison3-12/+38
Jeremy. (This used to be commit 5130dd0f8b80aed5fb3c0df290b627057cc9b825)
2000-07-25make protoGerald Carter1-0/+5
--jerry (This used to be commit 1f65b13dd56fbe41320f6c4e8f391ce739509e45)
2000-07-25some initial code for AddPrinterEx() project. Most is ifdef'd outGerald Carter3-3/+149
'cause it's not all written. -jerry (This used to be commit 2c0f6bcc8f926ee9c17de12671075e8a9239bb94)
2000-07-25if the sids are not the same pointer and either of the sids are NULLAndrew Tridgell1-0/+3
then the two sids are not equal (This used to be commit 9ccf3b1dc5baf0e00d032d8b932ab0fb5b1e11b1)
2000-07-25Added some error checking and returns to the new 'move' code.Jeremy Allison4-16/+53
Jeremy. (This used to be commit 0bd88d304cd773e0bbf3e6f7fedcb3b544d41cbe)
2000-07-25A rather big change set ! (listed in no particular order)Jean-François Micouleau9-306/+494
- changed the default forms flag to 2 - all short architecture name are uppercased - get_short_archi() is now case unsensitive - the drivers TDB is indexed by archi/version/name - implemented code to move drivers from the upload area to the download area. Someone else need to look at that code. - don't return anymore a default driver if it doesn't exist in the TDB. Instead return an error. - cleaned prs_unistr. - #ifdef out jeremy's new SD parsing in printer_info_2 - removed the unused MANGLE_CODE - #ifdef out the security checking in update_printer() as it doesn't work for me. Zap your ntdrivers.tdb, it won't work anymore. J.F. (This used to be commit ac0a145acc0953a6f362497abbf4dfe70aa522a6)
2000-07-25Fix for mounting a printer as a share. Not that there's anythingTim Potter1-0/+5
specifically wrong with this, but Samba is fooled by the client into thinking the printer is a file share. Files copied to the share gather dust in the spool directory and aren't printed. This patch has the effect of not allowing printers to be mounted as file shares. Not sure whether this is the correct solution or not. {Jeremy,JF,Tridge} please check! (This used to be commit dcf3249bb9fef2a05b376e9c8c1a0a7d602d8a2e)
2000-07-25Tidy up code to add printer. Always index in tdb by sharename. ThisJeremy Allison1-5/+33
is beginning to come together... Jeremy. (This used to be commit 614bf56186b5836020a7813855a5108da0ee8433)
2000-07-24Run main server loop with sys_select() instead of sys_select_intr(). TheTim Potter1-2/+13
main daemon was not catching sighup and reloading the service file. (This used to be commit f026a897e9296a71fb5c4d5f6e1b4d3287689bde)
2000-07-24Test for reloading smb.conf after SIGHUP. Needs to be run as root.Tim Potter1-0/+107
(This used to be commit db54e72d2f67b07d42bff16c64fbadf0d031e365)
2000-07-22Fixed open handle code in printers - 3 functions were always being doneJeremy Allison5-155/+171
in order - moved them into open_printer_hnd(). Added saving of comment field. Jeremy. (This used to be commit a0ee774fe92e5d0bc84d1d6729e8c538c67e8aba)
2000-07-21make protoGerald Carter1-0/+13
(This used to be commit e4af400ed6580c04bcaf3a28fe8aeaa0cdbd4dcf)
2000-07-21* Added EnumPorts()Gerald Carter2-3/+137
* Fixed an off-by-one bug noticed by JF in GetPrinterDriverDirectory() jerry (This used to be commit a9522f560da64045d928dabedeacdef0a6c3db51)
2000-07-21Added EnumPorts() and fixed up some problemsGerald Carter1-48/+27
with the other spoolss client calls. Also cleaned up output for 'help' command. jerry (This used to be commit a0e8a55c279af50c1f770c7b913262094b9b593a)
2000-07-21Added EnumPorts() and fixed up some problemsGerald Carter3-0/+96
with the other spoolss client calls. Also cleaned up output for 'help' command. jerry (This used to be commit 56ce247977c05ef37888c2572e679c44346e5568)
2000-07-21Added functions for enumerating ports on remote print server.Gerald Carter1-6/+48
Tim, You should also look at new_smb_io_printer_info_2() and see if the change from NULL to &i regarding the secdesc is ok. jerry (This used to be commit a2205c6646aa677090908a4e1532ed8590adc0e0)
2000-07-20make protoGerald Carter1-0/+10
(This used to be commit 1246728eb9013948d17ad44263501d1e1bb49e8f)
2000-07-20readded util_list.c (just to the RPCCLIENT_OBJ). I need to splitGerald Carter1-1/+1
the file up i think. Later. --jerry (This used to be commit ed54a9f4d154ac56330b23255108447036cbd192)
2000-07-20Fixed unitilized secdesc pointer which was causing spoolgetprinterGerald Carter2-2/+7
rpcclient command to fail on shared printers. jerry (This used to be commit c8abc31187dbfe6076277896b029fa11443e43bd)
2000-07-19Modified the patch to look in the tdb *first* - thus allowing legacy textJeremy Allison1-75/+91
filed to be ignored when an upload is done. Modified to code to goto err on problems, simplifies it. Jeremy. (This used to be commit 9157a6ab2646c035a731d53aa3be010488ccf51a)
2000-07-19Code from John Reilly <jreilly@hp.com> to add tdb lookups into the Win95Jeremy Allison3-7/+100
printer driver download if looking for the default driver files fail. Jeremy. (This used to be commit 1192d867c4e863471f9bc12afceb68a23ba2142e)
2000-07-19Instead of handing back a string (which might be a DNS name or an IPChristopher R. Hertel5-48/+99
string), the wins_srv module now hands back a struct in_addr when it's called. It caches the IP address once it has been looked up. The IP is cleared (and must be looked up again) if the 'wins server' parameter is reread, or if the node is marked 'dead'. A dead node will not be re-tried for 10 minutes (per a #define in wins_srv.c). As it was, the code was reading the WINS server name or IP directly from lp_wins_server. That's okay, except that if the value was expressed as a name, then a DNS lookup would be done every time the client wanted to talk to the server. I still need to work out the implications of failover regarding the 'unicast subnet' list. Chris -)----- (This used to be commit 73aa188320fd3bf10b5dfc057323f40aff2c13bd)
2000-07-19First cut toward adding WINS server failover.Christopher R. Hertel7-17/+250
*Note: failover doesn't actually work yet!* It's just that the code I'm adding provides all of the pieces necessary. I do have one big question. Something that I'll have to ask Jeremy, I'm thinkin'. In nmbd/nmbd_subnetdb.c the IP of the WINS server is used to set up the Unicast subnet. ...so what happens if the WINS server changes? My guess is either: a) nothing. b) I'd have to change the unicast subnet entry whenever the WINS server changes. Urq. BTW, the lp_wins_server() function no longer returns the WINS server name or IP. It returns the list of WINS servers entered in smb.conf. To get the currently 'live' WINS server, use the wins_srv() function. Fun, eh? Chris -)----- (This used to be commit cc08bdc74f4cd111fdc582ee7babef47ed8a950d)
2000-07-18Removed the sanity check on the WINS SERVER parameter because it simplyChristopher R. Hertel1-17/+0
checked to see that only one server was listed. As I am working on an enhancement that allows multiple servers to be listed...this was a bit contrary. ;) (This used to be commit 1b718f67675e52520f193a8c71c110246e70723f)
2000-07-18rpc_parse/parse_prs.c: Removed extraneous ()'s.Jeremy Allison3-43/+45
rpc_parse/parse_spoolss.c: Fixed the security descriptor marshalling in a INFO_2 struct. for some reason SD's should be done inline after the info2, not as the last buffer marshall. rpc_server/srv_spoolss_nt.c: Removed extraneous ()'s. Jeremy. (This used to be commit f038a24e9f624fdb04cd52769d45783248ce8a38)
2000-07-18remove util_list from LIB_OBJS since it broke smbd buildGerald Carter1-1/+1
(undefined references in link). This is a quick fix. I'll resolve things later. Sorry everyone. jerry (This used to be commit ea64f2525d649c0952af52c2ba21a3bac57b322e)
2000-07-18Added lib/util_list.[c|o] to Makefile.inGerald Carter1-1/+1
--jerry (This used to be commit 94967b31bbc913d9b45274d9eed846f871b66b6f)
2000-07-18Fixed some more client SPOOLSS functions. The followingGerald Carter8-361/+445
functions work now: - spoolenum - spoolopen - spoolgetprinter - spoolgetprinterdriver Items todo: - track down memory bug with spoolenumdata - fix spoolgetprinterdriverdir - fix spoolgetdata - fix display_job_info_ctr in spooljobs All part of the ongoing rpcclient work. Also included a new generic list ADT. Cleaner and simplier than the stuff in util_array.c i think (but then that's why I wrote it). --jerry (This used to be commit 381aba2c9a63faa53728f0520ac316478bc7a1c3)
2000-07-18fixed a bug (my own) in create_ntc_from_cli_state()Gerald Carter1-2/+2
--jerry (This used to be commit f7bc6df3befb8d0981dbd96f353039a5913321d7)
2000-07-18I really didn't like the way generic arrays (lists) wereGerald Carter1-0/+321
implemented in util_array.c so I wrote a smaller (and simplier package). I would like to replace the use of util_array.c functions in the rest of the source tree if no one objects. This will be an interface change, but not really a difference in the functionality provided. --jerry (This used to be commit 0863ce3a31e4c76c8356850ac128f6d96ea54917)
2000-07-18grab functions that return RPC_HND_NODE (declaredGerald Carter1-1/+1
in include/util_list.h) -- jerry (This used to be commit ccebd70df2c096de1b183ae072c2c720e2277c6f)
2000-07-18Fixed some more client SPOOLSS functions. The followingGerald Carter3-76/+80
functions work now: - spoolenum - spoolopen - spoolgetprinter - spoolgetprinterdriver Items todo: - track down memory bug with spoolenumdata - fix spoolgetprinterdriverdir - fix spoolgetdata - fix display_job_info_ctr in spooljobs All part of the rpcclient work. Jeremy, this check includes emthods for associating POLICY_HNDs and client states. See the RpcHndList_...() function calls (implemented in lib/util_list.c) --jerry (This used to be commit 84349394a988213724ca138e9692b3bc44fa0cb8)
2000-07-18Fixed some more SPOOLSS functions. The followingGerald Carter1-5/+4
functions work now: - spoolenum - spoolopen - spoolgetprinter - spoolgetprinterdriver Items todo: - track down memory bug with spoolenumdata - fix spoolgetprinterdriverdir - fix spoolgetdata - fix display_job_info_ctr in spooljobs --jerry (This used to be commit 15b35912713557119aba5d0cd59605997d6b5ee9)
2000-07-17Missing var.Tim Potter1-1/+1
(This used to be commit 5c1c5622269c54dca89eb178ca25981ab7928e75)
2000-07-17Reverted changes from rpcclient merge - contains memory leak!Tim Potter1-2/+9
(This used to be commit dea06ad7a554089a7394cdcb6bf5a766e8e8a6c3)
2000-07-17Free security descriptor after access check in update_printer_sec()Tim Potter1-3/+7
(This used to be commit bc5f9c00be5b8c2f6d258f0c95ed3b4fc0201b87)
2000-07-17Initialise current time to time(NULL) in add_a_printer_2()Tim Potter1-1/+4
Added get and free security old descriptor in nt_printing_setsec() after access checking was moved up to rpc level. (This used to be commit a5b7cafc87e14ca3f28dcfc1ed6bcc6f47e79639)
2000-07-17make protoTim Potter1-84/+0
(This used to be commit df0ef98d7ed41899ce97d20163ab49081347ae83)
2000-07-17make protoTim Potter1-339/+338
(This used to be commit 4443a8b6e698a6572152e575c41dfb760b9888a9)
2000-07-17Allow job owner to delete own print job.Tim Potter1-13/+28
(This used to be commit 90b1857c81627e587a7395ee2bdb51b26ea46512)
2000-07-17Moved access check for nt_printing_setsec() up into rpc function.Tim Potter1-36/+59
Use sid + rid instead of lp_workgroup()/Administrator for printer owner sid as per JF's advice. Default printer owner is either the administrator of the pdc workgroup or Everyone depending on whether winbindd is running. Still the subject of some debate... Renamed se_access_check() parameters. (This used to be commit e92e161a813ac0793897ffe3d33b01054912d4c7)
2000-07-17Renamed arguments to se_access_check()Tim Potter1-4/+28
(This used to be commit 714b50b47dab46f5cdde49d7c200b353c2e0398a)
2000-07-17Renamed a parameter in init_request() function.Tim Potter1-10/+19
Initialise response structure correctly. (This used to be commit 587c8e58fdd79dce47fb59ce702596ea58c8b4a6)
2000-07-17Added some debugs.Tim Potter1-13/+27
Changed interface to se_access_check to take a user struct instead of each bit as a separate parameter. (This used to be commit ff7938310d0636b165b03a2b0a15e51494b2459f)
2000-07-15I committed this change to the cliffs archive a while back and have heardChristopher R. Hertel1-5/+20
no complaints. ;) Basically, instead of ignoring single-line C-style comments in IDL source files this change allows token.awk to ignore both single- and multi-line C-style comments. Chris -)----- (This used to be commit 34f69f09f840b8990b718e8585785e2a6ad7c314)
2000-07-15Lots of changes but no real progress in functionality.Gerald Carter3-146/+92
more changes to remove the ncarpc_l_* stuff. Fixed some cut and paste errors from TNG There are very subtle bugs in this code. I'll work on simplifying them in round two or three. --jerry (This used to be commit f8509356178deb7e78836d1f5aceb96677ac738b)