summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2012-04-27libcli/smb: move SMB2_IOCTL_FLAG_IS_FSCTL to smb2_constants.hStefan Metzmacher2-3/+3
metze
2012-04-27s4:ntvfs/ipc: don't echo back the smb2 ioctl input_bufferStefan Metzmacher1-1/+1
metze
2012-04-26s3: oplock_timeout is a talloc child of fspVolker Lendecke1-3/+0
Jeremy, I know you like it explicit, but I stumbled across this explicit TALLOC_FREE and asked myself about a potentially wrong talloc hierarchy. Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Thu Apr 26 23:00:03 CEST 2012 on sn-devel-104
2012-04-26s3: Remove code TALLOC_FREE already doesVolker Lendecke1-5/+1
2012-04-26torture: change dfs tests now that we return a level 4 when level 4 is requestedMatthieu Patou1-3/+2
Autobuild-User: Matthieu Patou <mat@samba.org> Autobuild-Date: Thu Apr 26 21:25:37 CEST 2012 on sn-devel-104
2012-04-26dfs_server: fix the response to please XP and Windows 2008R2 doing so avoid ↵Matthieu Patou1-4/+12
continious DFS requests from W2K8R2
2012-04-26replace: Fix use of mktempSimo Sorce1-2/+2
mktemp always returns the template, so checking for NULL doesn't cactch any error. Errors are reported by turning the template into an empty string. Autobuild-User: Simo Sorce <idra@samba.org> Autobuild-Date: Thu Apr 26 16:14:24 CEST 2012 on sn-devel-104
2012-04-26addns: clean up headersSimo Sorce1-33/+0
All this stuff is already included properly in the replace headers on top.
2012-04-26s3: Remove an unused variableVolker Lendecke1-1/+0
Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Thu Apr 26 12:17:14 CEST 2012 on sn-devel-104
2012-04-26s4-torture: never return false in the raw.composite torture testAndrew Bartlett1-39/+7
We must use torture_assert() macros to ensure that the failure is recorded in the subunit stream correctly, rather than being returned as an unknown 'error'. (We cannot handle error results as knownfail). Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Thu Apr 26 04:00:16 CEST 2012 on sn-devel-104
2012-04-26selftest: push --target selection into plansmbtorturetestsuiteAndrew Bartlett1-3/+4
2012-04-26s4:torture: add a rpc.samba3.smb-reauth2 testMichael Adam1-0/+145
* Open session. * Reauth to anon. * Open lsa pipe. * Do lsa get username. * Rauth to original user. * Do lsa get username again. expected result: the getusername works and shows 'NT AUTHORITY\ANONYMOUS LOGON' in both calls. Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Thu Apr 26 02:27:12 CEST 2012 on sn-devel-104
2012-04-25s4:torture: add a rpc.samba3.smb-reauth1 testMichael Adam1-0/+165
It does reauth while using an rpc pipe: * open session * open lsa pipe * do lsa getusername * reauth to anonymous * do lsa getusername again * reauth back to original user * do reauth again result: lsa getusername is always possible and always gives the first (authenticated user)
2012-04-25s4:torture: add a raw.session suite with a raw.session.reauth testGregor Beck3-1/+92
Signed-off-by: Michael Adam <obnox@samba.org>
2012-04-25Fix bug reported by Dina_Fine@Dell.com.Jeremy Allison1-16/+19
Don't ask the DC for an IP list when locating kdc's. Ask for the name and use getaddrinfo to get all possible addresses instead. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Apr 25 22:01:18 CEST 2012 on sn-devel-104
2012-04-25libcli: Use data_blob_nullVolker Lendecke1-1/+1
Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Wed Apr 25 18:54:51 CEST 2012 on sn-devel-104
2012-04-25selftest: remove printserver.enum_printers_servername from flappingMichael Adam1-1/+0
Signed-off-by: Andreas Schneider <asn@samba.org> Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Wed Apr 25 17:18:28 CEST 2012 on sn-devel-104
2012-04-25selftest: remove samba3.rpc.spoolss.*printserver.openprinter_badnamelist ↵Michael Adam1-1/+0
from flapping Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25selftest: mark the driver_info_winreg tests knownfail.Michael Adam1-0/+2
They only get executed when driver files are around. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25selftest: mark failing print_tests more specificallyMichael Adam1-1/+1
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25selftest: remove .*printer.*print_test_extended from flappingMichael Adam1-1/+0
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25selftest: remove the "rpc.spoolss.printer" test from flappingMichael Adam1-1/+0
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: replace call to reg_openkey() in reg_createkey() by accesscheck.Michael Adam1-8/+10
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: remove a superfluous fill_subkey_cache() in reg_createkey()Michael Adam1-5/+0
Pair-Programmed-With: Gregor Beck <gbeck@sernet.de> Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: use fill_subkey_cache to check exsistence in ↵Michael Adam1-11/+2
regkey_open_onelevel(). Pair-Programmed-With: Gregor Beck <gbeck@sernet.de> Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: let fill_subkey_cache return WERR_BADFILE when the subkey list ↵Michael Adam1-1/+1
could not be loaded WERR_NO_MORE_ITEMS seems inappropriate. Pair-Programmed-With: Gregor Beck <gbeck@sernet.de> Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: convert reg_openkey() to use talloc instead of SMB_STRDUP etcMichael Adam1-15/+12
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry untangle an assignment from the check in regkey_open_onelevel()Michael Adam1-1/+2
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: untangle assignment from check in regkey_open_onelevel()Michael Adam1-1/+2
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: fix seqnum race in regdb_fetch_keys_internalMichael Adam1-3/+22
This prevents race between fetching seqnum and key content. Because there is currently no way to atomically fetch the record along with the seqnum, I use a loop. This is far from optimal and should should ideally be done differently. But for now it fixes the race. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: fix seqnum race in fetch_values_internalMichael Adam1-3/+21
This prevents race between fetching seqnum and key content. Because there is currently no way to atomically fetch the record along with the seqnum, I use a loop. This is far from optimal and should should ideally be done differently. But for now it fixes the race. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: update the seqnum in the subkey cache at the end of ↵Michael Adam1-1/+5
regval_store_keys The purpose is to prevent next reads from going to disk. Note that this will currently only be effective with local tdbs, not with ctdb: For tdb, store and delete bump the seqnum while transaction commit does not. For ctdb, transaction commit bumps the seqnum, while store and delete don't... This needs fixing (in ctdb). Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry:db: update the value container seqnum after storing/deleting to ↵Michael Adam1-1/+22
prevent next read from going to disk if possible Note that this will currently only be effective in the local TDB implementation. For CTDB, this wont work since seqnum currently works differently there (needs fixing): For tdb, store and delete operations bump the db seqnum, while transaction commits don't. For ctdb, the seqnum is bumped by the transaction commit but not by store and delete operations. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: wrap reg_deletekey() into a transactionMichael Adam1-2/+25
This is wrong layering but fixes a race condition. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: wrap reg_createkey() in a transactionMichael Adam1-6/+30
This is wrong layering (calling into regdb_transaction* in the reg_api code) but fixes a potential race. It makes the multi-step create procedure atomic. This should completely be done in the backend. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: untangle assignments from checks in reg_createkey()Michael Adam1-2/+6
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: wrap reg_deletevalue() in a transactionMichael Adam1-4/+30
This is at the wrong layer, but if fixes a race potentially causing data corruption by concurrent access. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: untangle assignment from check in reg_deletevalue()Michael Adam1-1/+2
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: fix race in reg_setvalue that could lead to data corruptionMichael Adam1-6/+33
(there was no lock around fetching the values and storing them) The layering is wrong in that it uses regdb transactions in reg_api Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: untangle assignment from check and add a debugmessage in ↵Michael Adam1-1/+3
reg_setvalue() Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: don't leak the old contents when updating the value cacheMichael Adam1-0/+1
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: fix debug message in regdb_store_values_internal()Michael Adam1-1/+1
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: improve log message in regdb_unpack_values()Michael Adam1-1/+2
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: fix a debug message typoMichael Adam1-1/+1
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: add a new function regval_ctr_value_byname()Michael Adam2-0/+20
This is like regval_ctr_key_exists() but does not return bool, but the regval_blob instead, if found, and NULL if not found. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: rename regval_ctr_key_exists() to regval_ctr_value_exists()Michael Adam3-4/+4
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s4:torture:rpc:spoolss: also initialize driverName before checking it in ↵Michael Adam1-0/+1
test_PrinterData_DsSpooler() Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry:reg_api: fix reg_queryvalue to not fail when values are modified ↵Michael Adam1-1/+45
while it runs Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: make regdb_values_need_update() staticMichael Adam2-2/+1
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-25s3:registry: make regdb_subkeys_need_update() staticMichael Adam2-2/+1
Signed-off-by: Andreas Schneider <asn@samba.org>