Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2010-01-07 | s3:auth:check_sam_security: improve calling and logging of ↵ | Michael Adam | 1 | -4/+16 | |
pdb_update_sam_account Log what went wrongl, and also call pdb_update_sam_account inside become_root/unbecome_root: do the logging outside. Michael | |||||
2010-01-07 | s3:auth:check_sam_security: fix a leading tab/ws mixup | Michael Adam | 1 | -1/+1 | |
Michael | |||||
2010-01-07 | s3:auth:check_sam_security: create (and use) a common exit point | Michael Adam | 1 | -11/+7 | |
for use after sam_password_ok() has been called. Michael | |||||
2010-01-07 | s3:auth:check_sam_security: null out sampass after it has been stolen. | Michael Adam | 1 | -0/+1 | |
So that a later talloc_free would not harm. I could have used talloc_move instead of talloc steal in make_server_info_sam(), but this would have required a change of the signature. Michael | |||||
2010-01-07 | s3:auth:sam_password_ok: take username, acct_ctrl and nt/lm hashes, not sampass | Michael Adam | 1 | -14/+20 | |
This is in preparation to extending check_sam_security to also check against the password history before updating the bad password count. This way, sam_password_ok can more easily be reused for that purpose. Michael | |||||
2010-01-07 | s3:auth: use data_blob_null instead of data_blob(NULL, 0) in sam_password_ok() | Michael Adam | 1 | -2/+2 | |
This way it is more explicit that there is no allocated data here that may leak. Michael | |||||
2010-01-07 | s3:auth:sam_password_ok: fix allocation of a data blob. | Michael Adam | 1 | -1/+1 | |
data_blob(mem_ctx, 16) does not use mem_ctx as a talloc ctx but copies 16 bytes from mem_ctx into the newly allocated data blob. This can not have been intentional. A blank uint8_t array of length 16 is allocated by passing NULL instead of mem_ctx. And using data_blob_talloc(mem_ctx, NULL, 16) adds the allocated blank 16 byte array to mem_ctx - so this is what must have been intended. Michael | |||||
2010-01-07 | s3:auth:sam_password_ok: enhance readability (imho) by adding some pointers | Michael Adam | 1 | -17/+24 | |
and removing bool variables and several checks. Michael | |||||
2010-01-07 | s3:check_sam_security: untangle assignment from statement | Michael Adam | 1 | -1/+2 | |
Michael | |||||
2010-01-07 | s3: Factor password_in_history() out of check_passwd_history() | Volker Lendecke | 2 | -25/+44 | |
2010-01-07 | Simplify E_md5hash a bit | Volker Lendecke | 1 | -6/+2 | |
2010-01-07 | s3: Simplify pdb_set_plaintext_passwd: pwhistory==NULL can not happen anymore | Volker Lendecke | 1 | -24/+19 | |
2010-01-07 | s3: Simplify pdb_set_plaintext_passwd: pwHistLen==0 was checked above | Volker Lendecke | 1 | -2/+4 | |
2010-01-07 | s3: Add a paranoia check to pdb_set_plaintext_passwd() | Volker Lendecke | 1 | -0/+5 | |
2010-01-07 | s3: Simplify pdb_set_plaintext_passwd() by removing a redundant condition | Volker Lendecke | 1 | -22/+11 | |
if (current_history_len != pwHistLen) { if (current_history_len < pwHistLen) { } } The second "if" is a bit pointless here | |||||
2010-01-07 | s3: Simplify pdb_set_plaintext_passwd: memcpy deals fine with 0 bytes | Volker Lendecke | 1 | -5/+2 | |
2010-01-07 | s3: Simplify pdb_set_plaintext_passwd by using talloc_zero_array | Volker Lendecke | 1 | -5/+2 | |
2010-01-07 | s3: Make use of talloc_array in pdb_set_plaintext_passwd() | Volker Lendecke | 1 | -2/+3 | |
2010-01-07 | s3: Simplify pdb_set_plaintext_passwd() a bit | Volker Lendecke | 1 | -66/+63 | |
Remove an indentation by the early return in + if (pwHistLen == 0) { + /* Set the history length to zero. */ + pdb_set_pw_history(sampass, NULL, 0, PDB_CHANGED); + return true; + } | |||||
2010-01-07 | s3: Simplify pdb_set_plaintext_passwd() slightly | Volker Lendecke | 1 | -56/+83 | |
No functional change, this just removes an indentation level by the early "return True;" in + if ((pdb_get_acct_ctrl(sampass) & ACB_NORMAL) == 0) { + /* + * No password history for non-user accounts + */ + return true; + } Volker | |||||
2010-01-07 | s3: Fix a typo | Volker Lendecke | 1 | -1/+1 | |
2010-01-07 | s3: Avoid a memset(, 0, ) call | Volker Lendecke | 1 | -2/+1 | |
2010-01-07 | s3:pdb_set_pw_history: free the old history before setting the new. | Michael Adam | 1 | -0/+1 | |
This is not strictly necessary, since this only leaks into the struct samu, and this is not so long-lived in the code path that changes the password, but it definitely correct and does not harm. Michael | |||||
2010-01-07 | s3:pdb_ldap:init_sam_from_ldap: untangle an assignment from the check | Michael Adam | 1 | -3/+3 | |
to enhance readability and denbuggability. Michael | |||||
2010-01-06 | s4/torture: fix small bug in lock test | Steven Danneman | 1 | -0/+1 | |
Cleanup path should unlock, not cancel existing locked range. | |||||
2010-01-06 | s4/torture: add more lock cancellation tests | Steven Danneman | 1 | -2/+95 | |
* Test the SMB1 behavior when multiple lock ranges are requested, pend, and then are cancelled. The entire LockingAndX request fails. | |||||
2010-01-07 | s3:lib/time: remove TIME_T_MIN/MAX defines | Björn Jacke | 1 | -8/+0 | |
we already get them from lib/util/time.h | |||||
2010-01-07 | lib/util: move TIME_T_MIN/MAX defines into header file | Björn Jacke | 2 | -14/+14 | |
2010-01-07 | ѕ3:lib/time: replace make_dos_ and put_dos_ functions with those from lib/util/ | Björn Jacke | 1 | -89/+6 | |
2010-01-07 | s3:lib/time: remoce null_mtime() - use null_time() | Björn Jacke | 2 | -14/+2 | |
2010-01-07 | s3:lib/time: remove unused nt_time_equals | Björn Jacke | 2 | -9/+0 | |
we have nt_time_equal doing the same in lib/util/ | |||||
2010-01-06 | Second part of the fix for bug #7020 - smbd using 2G memory. | Jeremy Allison | 1 | -0/+7 | |
There was a second leak in the processing of the out_data.frag prs_struct. It needs freeing once the current pdu has been returned asynchronously. Jeremy. | |||||
2010-01-06 | s4-smbtorture: add test_ChangeID to RPC-SPOOLSS. | Günther Deschner | 1 | -0/+179 | |
This tests ChangeID consistency between spoolss_GetPrinterData, spoolss_GetPrinterDataEx and spoolss_GetPrinter (level 0). Guenther | |||||
2010-01-06 | s4-smbtorture: add test_SetPrinter to RPC-SPOOLSS. | Günther Deschner | 1 | -0/+26 | |
Guenther | |||||
2010-01-06 | s4-smbtorture: refactor test_GetPrinter in RPC-SPOOLSS. | Günther Deschner | 1 | -28/+50 | |
Guenther | |||||
2010-01-06 | ѕ3:configure: use gettimeofday check from lib/util/ | Björn Jacke | 1 | -9/+1 | |
2010-01-06 | vfs_commit: print warning when no fsync support is there | Björn Jacke | 1 | -0/+2 | |
this one was part of an old patch from jpeach. | |||||
2010-01-06 | tdb: fix standalone 'make installdocs' | Stefan Metzmacher | 2 | -3/+4 | |
metze | |||||
2010-01-06 | tdb: create symbol links to shared libraries see ↵ | Brian Lu | 1 | -0/+4 | |
https://bugzilla.samba.org/show_bug.cgi?id=6991 for details Signed-off-by: Stefan Metzmacher <metze@samba.org> | |||||
2010-01-06 | talloc: create symbol links to shared libraries see ↵ | Brian Lu | 1 | -0/+5 | |
https://bugzilla.samba.org/show_bug.cgi?id=6991 for details Signed-off-by: Stefan Metzmacher <metze@samba.org> | |||||
2010-01-06 | tevent: create symbol links to shared libraries see ↵ | Brian Lu | 1 | -0/+4 | |
https://bugzilla.samba.org/show_bug.cgi?id=6991 for details Signed-off-by: Stefan Metzmacher <metze@samba.org> | |||||
2010-01-06 | s4: Fix result check for getaddrinfo() | Kamen Mazdrashki | 1 | -6/+11 | |
I think this completes commit 50feca550eed7828198b7c0fc5f0e5ddc863313d. Now result should be handled correctly both for systems that support EAI_NODATA but returns EAI_NONAME (as my Ubuntu 9.x) and systems that doesn't support EAI_NODATA at all. Signed-off-by: Stefan Metzmacher <metze@samba.org> | |||||
2010-01-05 | Fix bug #7020 - smbd using 2G memory. | Jeremy Allison | 1 | -0/+10 | |
When deferring an async pipe writeX and readX transfer the outstanding request struct onto the conn struct. This needs freeing after the packet is finally processed. Jeremy. | |||||
2010-01-05 | s4:SAMLDB LDB module - Fix trailing whitespaces | Matthias Dieter Wallnöfer | 1 | -17/+17 | |
2010-01-05 | s4:SAMLDB LDB module - Rework to allow checks for wrong ↵ | Matthias Dieter Wallnöfer | 1 | -50/+96 | |
"defaultObjectCategory" attributes This allows a stricter check for "defaultObjectCategory" attributes which is performed when the "relax" control isn't specified. Additional note: As the added comment points out this isn't complete. And I personally think that moving this at some point to the "objectclass" module is a better idea to make this fully work (since there we have direct access to the schema). If someone has a good idea how to do this please inform me. Anyway, the SAMLDB module does require some restructure since at the moment it's very overloaded and therefore a bit a mess. In the meantime I started to work on a new approach to realise it in a better way. | |||||
2010-01-05 | s4:schema_load.c - Typo | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
2010-01-05 | s4:ldap_schema.py - add an additional check for validity of ↵ | Matthias Dieter Wallnöfer | 1 | -0/+25 | |
"defaultObjectCategory" | |||||
2010-01-05 | s4:ldap_schema.py - Move generated attributes check | Matthias Dieter Wallnöfer | 1 | -15/+15 | |
Make more clear that they're created before the "schemaUpdateNow". | |||||
2010-01-06 | s3: List trusted domains from wcache when domain is offline. | Bo Yang | 1 | -24/+139 | |
Signed-off-by: Bo Yang <boyang@samba.org> | |||||
2010-01-06 | s3: Make winbindd_cache.c aware of domain offline to avoid unnecessary ↵ | Bo Yang | 2 | -4/+265 | |
backend query. Signed-off-by: Bo Yang <boyang@samba.org> |