summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2009-05-10Use bool instead of int for a boolean variableDerrell Lipman1-1/+1
2009-05-10Optimize smb_thread_once usage by not calling it if known already calledDerrell Lipman1-2/+6
- The macro SMB_THREAD_ONCE now tests whether the "once" variable is already set, and if so avoids calling smb_thread_once(). Derrell
2009-05-10Panic upon mutex lock or unlock failureDerrell Lipman1-2/+2
- It's a serious error if we can't lock or unlock a mutex in smb_thread_once(). Panic instead of just displaying a DEBUG message. Derrell
2009-05-10Provide a libsmbclient interface for programs requiring threadsDerrell Lipman4-1/+288
- This adds two functions: smbc_thread_posix() which provides access to the internal threading implementation using pthread; and smbc_thread_impl() where the user provides each of the functions required by Samba, to give access to the thread implementation's native capabilities. Derrell
2009-05-10Don't require external use of internal enum smb_thread_lock_typeDerrell Lipman1-3/+4
- Internally, when locking or unlocking a mutex, we'll pass one of the values of enum smb_thread_lock_type. That enum is not available to users providing a thread implementation. Externally, we'll document the integer values which will be passed to their lock_mutex function, but not require them to access our internal header file. Derrell
2009-05-10Replace external thread "once" with an internal implementationDerrell Lipman3-22/+66
Jeremy, please check... - I'm in the process of providing an interface in libsmbclient to the recently-added threading capabilities. In the process, I discovered that different thread implementations have varying types for the variable passed to the thread_impl_once() function. pthreads, for example, uses type pthread_once_t. Since Samba needs to internally declare these variables, it would need to know the exact type required by each thread implementation's function. After considering multiple methods of obtaining an appropriately sized variable, I decided that for the basic "once" functionality required by Samba, it would be much simpler to just implement our own "once" functionality. We don't require cancellation points et all. This commit adds an smb_thread_once() function that is implemented using an internal mutex. The mutex itself uses the implementation's create_mutex function. This eliminates the need for the user to provide a smb_thread_once function pointer and the entire issue of that function's first parameter. Derrell
2009-05-10Fix an unitialized variable warningVolker Lendecke1-0/+3
2009-05-09wb_int_trans -> wb_simple_trans in wbclient.cVolker Lendecke1-148/+24
2009-05-09Add wb_simple_trans_send/recvVolker Lendecke2-1/+137
2009-05-09Pass also sername to check password scriptSimo Sorce1-4/+12
2009-05-09Fix the mangle1 testVolker Lendecke1-1/+1
2009-05-09Do not call SMB_VFS_GET_REAL_FILENAME if the name is mangledVolker Lendecke1-6/+11
The GPFS get_real_file name does not know about mangled names. Tim, if onefs does not either, you need this bugfix :-) In case onefs does 8.3 names, we need to pass the mangled flag down to SMB_VFS_GET_REAL_FILENAME to give GPFS a chance say ENOTSUPP and do the fallback.
2009-05-09s3:libsmb: fix layering of cli_ntrename_internal and its callersStefan Metzmacher1-29/+35
It's easier to have cli_ntrename_internal as a semetric async tevent_req function. cli_ntrename() and cli_nt_hardlink() should be callers on top of cli_ntrename_internal(). metze
2009-05-08s3: Fix chained sesssetupAndX/tconn messagesTim Prouty1-0/+7
A sesssetupAndX chained with a tconn will not correctly set the TID in the response header. I'm seeing an XP client send this chained sesssetup/tconn when samba has security = share. Samba's current behavior is to return a TID of 0 in the smb header rather than the actual TID. This patch also updates the UID in the header as well.
2009-05-09s4-smbtorture: avoid secdesc test on connect handle in RPC-SAMR-USERS for ↵Günther Deschner1-1/+3
Samba3. With this, I think, we pass RPC-SAMR-USERS. Guenther
2009-05-09s3-samr: Fix SetUserInfo level 16 and 21 w.r.t. ACB_AUTOLOCK acct_flag.Günther Deschner1-0/+10
It is not allowed to *set* this flag remotely if it has been not set already. Found by torture test. Guenther
2009-05-09s3-samr: Fix SetUserInfo level 7 when there has been no name change.Günther Deschner1-0/+6
Found by torture test. Guenther
2009-05-08s3-selftest: enable running RPC-SAMR-USERS against Samba3.Günther Deschner1-1/+1
Guenther
2009-05-08s4-smbtorture: skip unsupported ACB bits for Samba3 in RPC-SAMR-USER.Günther Deschner1-4/+10
Guenther
2009-05-08s3-samr: more accurateness in _samr_SetDomainInfo().Günther Deschner1-3/+3
Guenther
2009-05-08s4-smbtorture: Support timestamp handling for Samba3 in RPC-SAMR-USERS.Günther Deschner1-8/+23
Timestamps in passdb (currently) only have second granularity. Guenther
2009-05-08Fix bug #6330 - DFS doesn't work on AIX. Jeremy.Jeremy Allison3-0/+47
2009-05-08Expand the comment explaining why user_in_group_sid isJeremy Allison1-1/+6
not reliable for winbindd users from foreign domains. Jeremy.
2009-05-08s3:smbd: fix posix acls when setting an ACL without explicit ACE for the ↵Stefan Metzmacher1-3/+18
owner (bug#2346) The problem of bug #2346 remains for users exported by winbindd, because create_token_from_username() just fakes the token when the user is not in the local sam domain. This causes user_in_group_sid() to give totally wrong results. In uid_entry_in_group() we need to check if we already have the full unix token in the current_user struct. If so we should use the current_user unix token, instead of doing a very complex user_in_group_sid() which doesn't give reliable results anyway. metze
2009-05-08s3:smbd: fix the fix for mapped IPv4 address handling in release_ip().Michael Adam1-2/+2
It was too late... Thanks Metze for noticing. Michael
2009-05-08s3-selftest: run RPC-LSA-GETUSER against Samba 3.Günther Deschner1-1/+2
Guenther
2009-05-08s4-smbtorture: Fix printf info-level mismatch in RPC-SAMR.Günther Deschner1-1/+1
Guenther
2009-05-08s3-samr: implement more info levels in _samr_QueryDomainInfo().Günther Deschner1-0/+82
Gets us closer to pass RPC-SAMR. Guenther
2009-05-08s3-samr: Fix potential memory leak in _samr_ChangePasswordUser().Günther Deschner1-1/+2
Guenther
2009-05-08s4:loadparm: fix a comment typo. and line wrapping.Michael Adam1-1/+2
Michael
2009-05-08s4:loadparm: fix brace indentation and add brace for clarityMichael Adam1-2/+4
Michael
2009-05-08s3: make release_ip() call (ctdb) cope with IPv4 mapped addressesMichael Adam1-1/+8
Michael
2009-05-08s3-selftest: finally enable RPC-SAMR-PASSWORDS which samba3 now passes.Günther Deschner1-1/+1
Guenther
2009-05-08s4-smbtorture: avoid acct_flags check at the end of RPC-SAMR-PASSWORDS for ↵Günther Deschner1-1/+4
Samba3. I don't get this, why would the account suddenly get ACB_PWNOTREQ ? Guenther
2009-05-08s3-selftest: need to enable lanman auth in order make RPC-SAMR-PASSWORDS pass.Günther Deschner3-0/+6
Guenther
2009-05-08s3-samr: Do not leak information whether a user exist or not in pwd change ↵Günther Deschner1-0/+11
calls. Found by torture test. Guenther
2009-05-08s3-samr: implement _samr_ChangePasswordUser().Günther Deschner1-10/+106
This is vastly copied from samba4 samr server. Guenther
2009-05-08s3-samr: implement _samr_OemChangePasswordUser2().Günther Deschner1-10/+48
Guenther
2009-05-08s3-samr: disable check for ACB_DISABLED in check_oem_password().Günther Deschner1-1/+4
It is a bad idea to just tell everyone that an account is disabled without really having checked the password first. Found by torture test. Guenther
2009-05-08s3-samr: rework check_oem_password() to take a struct samu, not to return one.Günther Deschner1-39/+27
Guenther
2009-05-08s4-smbtorture: prepare for running RPC-SAMR-USERS against samba3.Günther Deschner1-16/+24
In Samba 3 there are no pdb calls to store comments, codepages and countrycodes (yet). Guenther
2009-05-08s3-samr: Let _samr_TestPrivateFunctionsUser() return not supported.Günther Deschner1-1/+0
This is to get us closer to pass RPC-SAMR-USERS. Guenther
2009-05-08s3-samr: Do not return users in _samr_QueryDisplayInfo() for builtin domain.Günther Deschner1-0/+5
Found by torture test. Guenther
2009-05-08s3-samr: let set_user_info_16 and 20 follow the same pattern as all other ↵Günther Deschner3-29/+40
levels. Guenther
2009-05-08s3-samr: support some more info levels in samr_SetUserInfo calls.Günther Deschner3-0/+468
Guenther
2009-05-08s3-samr: support some more info levels in samr_QueryUser calls.Günther Deschner1-0/+266
Guenther
2009-05-08s3/ldap: also handle DirX return codesBjörn Jacke1-0/+2
2009-05-08s3:configure: "test" only takes one "="Björn Jacke1-1/+1
2009-05-07Fix some type-punned warningsVolker Lendecke3-7/+13
2009-05-07Remove a misleading commentVolker Lendecke1-2/+0