Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2009-05-04 | s3 torture: Fix comparison is always true warning | Tim Prouty | 1 | -2/+2 | |
2009-05-04 | libcli: Fix shadowed variable warning | Tim Prouty | 1 | -2/+2 | |
2009-05-04 | Fix bug #6315 smbd crashes doing vfs_full_audit on IPC$ close event. | Jeremy Allison | 1 | -3/+44 | |
The underlying problem is that once SMBulogoff is called, all server_info contexts associated with the vuid should become invalid, even if that's the context being currently used by the connection struct (tid). When the SMBtdis comes in it doesn't need a valid vuid value, but the code called inside vfs_full_audit always assumes that there is one (and hence a valid conn->server_info pointer) available. This is actually a bug inside the vfs_full_audit and other code inside Samba, which should only indirect conn->server_info on calls which require AS_USER to be set in our process table. I could fix all these issues, but there's no guarentee that someone might not add more code that fails this assumption, as it's a hard assumption to break (it's usually true). So what I've done is to ensure that on SMBulogoff the previously used conn->server_info struct is kept around to be used for print debugging purposes (it won't be used to change to an invalid user context, as such calls need AS_USER set). This isn't strictly correct, as there's no association with the (now invalid) context being freed and the call that causes conn->server_info to be indirected, but it's good enough for most cases. The hard part was to ensure that once a valid context is used again (via new sessionsetupX calls, or new calls on a still valid vuid on this tid) that we don't leak memory by simply replacing the stored conn->server_info pointer. We would never actually leak the memory (as all conn->server_info pointers are talloc children of conn), but with the previous patch a malicious client could cause many server_info structs to be talloced by the right combination of SMB calls. This new patch introduces free_conn_server_info_if_unused(), which protects against the above. Jeremy. | |||||
2009-05-04 | s3/packaging: Add keyutils-devel to build requires. | Karolin Seeger | 1 | -1/+1 | |
This should fiy bug #5853. Thanks to D.L. Meyer <dlmeyer [at] uiuc.edu> for reporting. Karolin | |||||
2009-05-04 | s3/docs: Fix typo. | Karolin Seeger | 1 | -1/+1 | |
Karolin | |||||
2009-05-04 | Do not crash in ctdbd_traverse if ctdbd is not around | Volker Lendecke | 1 | -0/+5 | |
2009-05-04 | Increase debug level of "create_connection_server_info failed" message | Volker Lendecke | 1 | -1/+1 | |
I don't think we should unconditionally send every refused connection attempt to a share to syslog, that's where all debug level 0 messages end up. | |||||
2009-05-04 | s3-printing: Fix driver upload for Xerox 4110 PS printer driver. | Günther Deschner | 1 | -0/+2 | |
We need to allow to set filesystem capabilities from the default vfs in create_conn_struct() in order to find mixed-case filenames. Thanks Volker! This one was hard to find, so a little longer explanation: When a Windows client tries to upload e.g. the Xerox 4110 PS driver, the client first uploads the driver files to the [print$] share. Some of them (in this case the Windows Postscript drivers) are with uppercase filenames while some of them (like the PPD file) are in lowercase. After the driver upload the client issues the spoolss_AddPrinterDriverEx() call with level 6. There the client tries to add the PPD file with an uppercase filename (while having stored it in lowercase on the server). The internal spoolss add driver functions then could not find the appropriate filename while trying to move them to the version subdirectory (in this case W32X86/3) and fails then entire spoolss_AddPrinterDriverEx() call. With this fix, the convert_unix_name() name finds the correct file and the spoolss_AddPrinterDriverEx() succeeds. Guenther | |||||
2009-05-03 | Fix Coverity ID 913 (NEGATIVE_RETURNS) -- gd, please check! | Volker Lendecke | 1 | -2/+2 | |
2009-05-03 | Fix an invalid type warning | Volker Lendecke | 1 | -1/+1 | |
2009-05-03 | Fix some warnings due to uint16_t!=-1 always being true | Volker Lendecke | 3 | -6/+6 | |
2009-05-03 | Fix a bunch of type-punned warnings -- gd, please fix properly :-) | Volker Lendecke | 1 | -15/+30 | |
2009-05-03 | Fix bug 6136: New AFS syscall conventions | Geza Gemes | 3 | -4/+24 | |
Haven't checked this myself, but as I've already got several reports that Samba won't compile against current OpenAFS anymore, I just believe Geza Gemes. This patch only affects AFS code, so it should not hurt anything else. Volker | |||||
2009-05-03 | Clean up after Tridge's util_strlist changes | Volker Lendecke | 2 | -25/+30 | |
2009-05-03 | s3/docs: Fix typos. | Karolin Seeger | 1 | -4/+5 | |
That fixes bug #4247. Thanks to David McNeill <davemc [at] mcpond.co.nz> for reporting! Karolin | |||||
2009-05-03 | s3/docs: Fix typo. | Karolin Seeger | 1 | -1/+1 | |
This fixes bug #4245. Thanks to David McNeill <davemc [at] mcpond.co.nz> for reporting! Karolin | |||||
2009-05-02 | Of course, s_addr is a #define somewhere else .... (Solaris...) | Volker Lendecke | 1 | -3/+3 | |
2009-05-02 | Fix a warning on host "gwen" | Volker Lendecke | 1 | -2/+3 | |
cc: "../librpc/ndr/ndr_basic.c", line 572: warning 604: Pointers are not assignment-compatible. Apparently in_addr.s_addr is not compatible to uint32_t, maybe a 32-bit signed int. | |||||
2009-05-02 | Attempt to fix the build on SerNet-sles8 | Volker Lendecke | 1 | -3/+6 | |
That compiler does not like #if embedded into the macro NT_STATUS_IS_OK. | |||||
2009-05-02 | Explicitly link in pthreads for lib/pthreadpool if required | Volker Lendecke | 1 | -0/+3 | |
No idea why it works on my Linux without -lpthread ... :-) | |||||
2009-05-02 | Fix Coverity 911: FORWARD_NULL. Metze, please check! | Volker Lendecke | 1 | -1/+2 | |
2009-05-02 | Attempt to fix the merged build on OpenSuSE 10.2 | Volker Lendecke | 1 | -0/+1 | |
Python.h 2.5 on that platform does not #include the necessary headers to see uintptr_t. | |||||
2009-05-02 | Fix a malloc/talloc mixup | Volker Lendecke | 1 | -1/+1 | |
2009-05-02 | Fix dependency on the attributes file. | Jelmer Vernooij | 1 | -4/+4 | |
2009-05-02 | Remove unused entries from clean. | Jelmer Vernooij | 1 | -2/+2 | |
2009-05-02 | Remove rules for unused epstopdf. | Jelmer Vernooij | 3 | -5/+0 | |
2009-05-02 | Remove XSLT script to generate image dependencies, instead rely on make | Jelmer Vernooij | 2 | -89/+18 | |
given that the number of image formats we use is limited. | |||||
2009-05-02 | Remove text chunks support. Was never built by any of the main targets, | Jelmer Vernooij | 2 | -20/+0 | |
and one of the reasons the complex dependency system exists. | |||||
2009-05-01 | Attempt to the build on NetBSD5 and a few others | Volker Lendecke | 1 | -0/+3 | |
2009-05-01 | find_unused_doc: Strip spaces in configuration names, just like the parser does. | Jelmer Vernooij | 1 | -4/+9 | |
2009-05-01 | Use <example> + <smbconfblock> rather than nonexistant element | Jelmer Vernooij | 2 | -2/+8 | |
<smbconfexample>. | |||||
2009-05-01 | Ignore docs-xml/output directory and its contents as well as png files | Jelmer Vernooij | 1 | -0/+29 | |
generated run-time from versioned svg files. | |||||
2009-05-01 | Fix a couple of invalid DocBook XML usages in the Samba3 Developers Guide. | Jelmer Vernooij | 2 | -24/+25 | |
2009-05-01 | Fix most of the invalid usages of DocBook in the Samba 3 HOWTO. | Jelmer Vernooij | 10 | -26/+25 | |
make check FTW! | |||||
2009-05-01 | Fix a bunch of XML validation errors. | Jelmer Vernooij | 10 | -62/+64 | |
2009-05-01 | Remove broken XSL-FO translation code; this has been broken for a while | Jelmer Vernooij | 5 | -28/+1 | |
and the output was never used. | |||||
2009-05-01 | Add more output generated by the documentation build process to .gitignore. | Jelmer Vernooij | 1 | -0/+3 | |
2009-05-01 | Move expansion of Samba-specific XML elements out of xslt/latex.xsl into a | Jelmer Vernooij | 2 | -159/+153 | |
separate file, for better readability. xslt/latex.xsl now only contains tweaks to the dblatex configuration. | |||||
2009-05-01 | Explicitly mention licenses in all stylesheets | Jelmer Vernooij | 13 | -16/+26 | |
2009-05-01 | Remove the DTD for the removed pdb-xml backend. | Jelmer Vernooij | 1 | -46/+0 | |
2009-05-01 | Generate pdf documents in-place rather than copying them from . to output/ | Jelmer Vernooij | 1 | -9/+5 | |
2009-05-01 | Remove unused and unsubstituted variables from Makefile.settings.in. | Jelmer Vernooij | 1 | -10/+0 | |
2009-05-01 | Remove references to dia now that we use inkscape for diagrams. | Jelmer Vernooij | 2 | -21/+0 | |
2009-05-01 | Fix build of the PostScript documents. | Jelmer Vernooij | 1 | -1/+1 | |
2009-05-01 | Fix dependencies on images for pdf and ps files. | Jelmer Vernooij | 1 | -2/+2 | |
2009-05-01 | Remove unnecessary checks for apps now used through dblatex. | Jelmer Vernooij | 3 | -16/+1 | |
2009-05-01 | Remove use of unicode quotes, as it confuses LaTeX. | Jelmer Vernooij | 1 | -1/+1 | |
2009-05-01 | Use standard LaTeX book document class rather than custom samba class. | Jelmer Vernooij | 1 | -0/+6 | |
2009-05-01 | Trim the requirements for building the docs, remove outdated instructions | Jelmer Vernooij | 1 | -26/+12 | |
for db2latex. | |||||
2009-05-01 | Move test image to test/images/, consistent with the other books. | Jelmer Vernooij | 1 | -0/+0 | |