summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2010-03-10s4-smbtorture: check for non existing value under version key in RPC-WINREG.Günther Deschner1-0/+2
Guenther
2010-03-10s3: Fix a long-standing problem with recycled PIDsVolker Lendecke20-38/+602
When a samba server process dies hard, it has no chance to clean up its entries in locking.tdb, brlock.tdb, connections.tdb and sessionid.tdb. For locking.tdb and brlock.tdb Samba is robust by checking every time we read an entry from the database if the corresponding process still exists. If it does not exist anymore, the entry is deleted. This is not 100% failsafe though: On systems with a limited PID space there is a non-zero chance that between the smbd's death and the fresh access, the PID is recycled by another long-running process. This renders all files that had been locked by the killed smbd potentially unusable until the new process also dies. This patch is supposed to fix the problem the following way: Every process ID in every database is augmented by a random 64-bit number that is stored in a serverid.tdb. Whenever we need to check if a process still exists we know its PID and the 64-bit number. We look up the PID in serverid.tdb and compare the 64-bit number. If it's the same, the process still is a valid smbd holding the lock. If it is different, a new smbd has taken over. I believe this is safe against an smbd that has died hard and the PID has been taken over by a non-samba process. This process would not have registered itself with a fresh 64-bit number in serverid.tdb, so the old one still exists in serverid.tdb. We protect against this case by the parent smbd taking care of deregistering PIDs from serverid.tdb and the fact that serverid.tdb is CLEAR_IF_FIRST. CLEAR_IF_FIRST does not work in a cluster, so the automatic cleanup does not work when all smbds are restarted. For this, "net serverid wipe" has to be run before smbd starts up. As a convenience, "net serverid wipedbs" also cleans up sessionid.tdb and connections.tdb. While there, this also cleans up overloading connections.tdb with all the process entries just for messaging_send_all(). Volker
2010-03-10s3: Make TLDAP_IS_ALPHA and TLDAP_IS_ADH static functionsVolker Lendecke1-5/+12
2010-03-10s3-passdb: Fix typo in debug message.Karolin Seeger1-1/+1
Karolin
2010-03-10s4-spoolss: remove unsed iconv handle from dcesrv_spoolss_GetPrinterData().Günther Deschner1-1/+0
Guenther
2010-03-10s4:winreg RPC - don't crash when incoming data wasn't correctly specifiedMatthias Dieter Wallnöfer1-2/+8
Also found by the WINREG torture test enhancements by gd.
2010-03-10s4:lib/registry/ldb.c - fix up registry backend to be more robustMatthias Dieter Wallnöfer1-9/+5
This should let the new WINREG tests written by gd at least pass against us.
2010-03-09Fix the shell script in the root case. When run as root, make test now ↵Jeremy Allison1-4/+4
detects CAP_DAC_OVERRIDE being left on in error. Jeremy.
2010-03-10s4-smbtorture: disable winreg QueryValue test for today.Günther Deschner1-2/+2
wow, both s3 and s4 crash on full coverage winreg QueryValue testing. Guenther
2010-03-10s4-smbtorture: fix some build warnings in RPC-SPOOLSS test.Günther Deschner1-8/+8
Guenther
2010-03-09Add tests which, when run as root, will ensure we can't writeJeremy Allison3-11/+154
into a read-only directory, or read a owner-read-only file. Jeremy.
2010-03-10s4-smbtorture: on HKLM hive test the well known CurrentVersion value.Günther Deschner1-0/+17
Guenther
2010-03-10s4-smbtorture: add full coverage test for winreg QueryValue calls.Günther Deschner1-0/+101
Guenther
2010-03-10s4-smbtorture: rework test_winreg_QueryValue in RPC-SPOOLSS-PRINTER once again.Günther Deschner1-3/+8
Guenther
2010-03-10s4-smbtorture: add tests for set and delete value in RPC-WINREG.Günther Deschner1-0/+52
Guenther
2010-03-09Fix typo and convert spaces to tabsSimo Sorce1-4/+4
2010-03-09Fix typoSimo Sorce1-2/+2
2010-03-09Allow "make test" to complete as root. Obviously only safe on tightlyJeremy Allison1-0/+16
controlled developer machines. Jeremy.
2010-03-09s3: Fix a NULL pointer dereferenceVolker Lendecke1-1/+10
Found by Laurent Gaffie <laurent.gaffie@gmail.com>. Thanks! Volker
2010-03-09s4:ldb fix escape parsingSimo Sorce1-2/+24
sscanf can return also on short reads, in this case an invalid escape sequence like '\1k' would be accepted, returning 1 as value and swallowing the 'k'. Use an auxiliar function to validate and convert hex escapes.
2010-03-09s3:tldap add own filter parsingSimo Sorce2-114/+614
Also add torture test to check filter parsing.
2010-03-09s4:winbind - use "unsigned" variables where possibleMatthias Dieter Wallnöfer5-27/+27
2010-03-09s4:winbind/wb_cmd_getgroups.c - fix up warningsMatthias Dieter Wallnöfer1-8/+16
Also fix some indentations.
2010-03-09s4:unittest Fix unittest to reflect that wbinfo -r no longer failMatthieu Patou1-1/+2
Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
2010-03-09s4:winbind: stub implementation of WINBINDD_PAM_LOGOFFMatthieu Patou2-2/+29
Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
2010-03-09s4:winbind: Fix a misplaced returned infoMatthieu Patou1-4/+2
libwbclient expect to have in auth.exra_data the INFO3_TXT and in auth.unix_username the username Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
2010-03-09s4:winbind Implement logic for getgroups to workMatthieu Patou3-17/+273
This function is called by the system everytime we do a id user or when we do wbinfo -r Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
2010-03-09s4:winbind: implement calls for allowing getent groupsMatthieu Patou5-2/+379
This is to say getgrent and setgrent, and the associated technical objects (states, build directives,...) needed. Signed-off-by: Matthias Dieter Wallnöfer <mwallnoefer@yahoo.de>
2010-03-09s4:torture/rpc/netlogon.c - "LogonGetDomainInfo" test - make it compatible ↵Matthias Dieter Wallnöfer1-18/+100
against Windows Server 2008 This is a reworked version of the mentioned test which passes against Windows Server 2008. The previous version, also mainly written by me passed only against Windows Server <= 2003.
2010-03-09s4:netlogon RPC - "LogonGetDomainInfo" - make the call compatible with >= ↵Matthias Dieter Wallnöfer1-23/+62
Windows 2008 Add more security checks and other corrections to imitate Windows Server >= 2008.
2010-03-09libcli/auth/schannel_state_tdb.c - fix an obviously wrong error handlingMatthias Dieter Wallnöfer1-1/+0
2010-03-09s4-smbtorture: fix uninitialized variable in winreg QueryValue call.Günther Deschner1-0/+1
Guenther
2010-03-09s3: Fix a typo. Thanks to Christian Ambach for pointing me at it :-)Volker Lendecke21-21/+21
2010-03-09A helper function to get the Infrastructure DN.Nadezhda Ivanova1-0/+12
2010-03-09Fixed a bug in acl tests - python error when we create user/group/ou with a ↵Nadezhda Ivanova1-23/+23
descriptor.
2010-03-09Added a check for permissions to modify the RDN attribute on rename.Nadezhda Ivanova2-0/+44
Necessary because rdn module will be moved lower than acl in the stack.
2010-03-09s4:dsdb/dns: change callers of samba_runcmd()Stefan Metzmacher1-36/+68
metze
2010-03-09lib/util: change samba_runcmd() to use tevent_req _send/_recvStefan Metzmacher2-146/+188
metze
2010-03-08Revert "Fix bug #7067 - Linux asynchronous IO (aio) can cause smbd to fail ↵Karolin Seeger3-71/+5
to respond to a read or write." This reverts commit a6ae7a552f851a399991262377cc0e062e40ac20. This fixes bug #7222 (All users have full rigths on all shares) (CVE-2010-0728). (cherry picked from commit 1c9494c76cc9686c61e0966f38528d3318f3176f)
2010-03-09s3:build: Fix automatic building of vfs_tsmsm if gpfs and dmapi are present.Michael Adam1-1/+1
Michael
2010-03-08s3:release-scripts: fix create-tarball to treat vendor patch level correctlyMichael Adam1-1/+1
2010-03-08samba: remove Linux cifs-utils files from samba master branchJeff Layton12-4182/+7
This patch removes all of the files from the samba tree that should now be provided by the cifs-utils package. It also drops a "README.cifs-utils" into the topdir with a URL to the main cifs-utils webpage. This is for people who don't want the lists and might be taken by surprise by the change. That's optional, but I think it's a good idea for a least a release or two. Signed-off-by: Jeff Layton <jlayton@samba.org>
2010-03-08s4:"dns_update_list" file: install it properly into the private directoryMatthias Dieter Wallnöfer2-7/+10
This is what the "samba_dnsupdate" script requests (line 220).
2010-03-08Revert "s4:script/installmisc.sh - install "dns_update_list" to target setup ↵Matthias Dieter Wallnöfer1-1/+0
folder" This reverts commit b49276e291274652d46eed39249c07531e32b591.
2010-03-08LDB:asq module - change counters to "unsigned" where appropriateMatthias Dieter Wallnöfer1-4/+5
2010-03-08LDB:sort module - change counters to "unsigned" where appropriateMatthias Dieter Wallnöfer1-4/+5
2010-03-08LDB:rdn name module - change counters to "unsigned" where appropriateMatthias Dieter Wallnöfer1-2/+3
2010-03-08LDB:paged searches module - change counters to "unsigned" where appropriateMatthias Dieter Wallnöfer1-2/+2
2010-03-08LDB:paged results module - change counters to "unsigned" where appropriateMatthias Dieter Wallnöfer1-4/+4
2010-03-08s3: add missing Makefile.in changes for vfs_crossrenameBjörn Jacke1-0/+5