Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2009-12-18 | s4-dsdb: return an error if samAccountName is not specified when creating a ↵ | Brendan Powers | 1 | -0/+7 | |
user. Makes sure samAccountName has been specified before adding a user. This happened while I was trying to add a user with the posixAccount objectclass. I forgot to specify the user objectClass, and samba segfaulted. It now returns LDB_ERR_CONSTRAINT_VIOLATION. Signed-off-by: Andrew Bartlett <abartlet@samba.org> | |||||
2009-12-18 | s4-dsdb: Move get_last_structural class from descriptor.c to util.c | Brendan Powers | 3 | -16/+30 | |
It can now also be used by objectclass.c get_last_structural_class now ignores AUX classes, because they are not structural Signed-off-by: Andrew Bartlett <abartlet@samba.org> | |||||
2009-12-18 | s4-dsdb: Add a check to prevent acl_modify from debuging a NULL message | Brendan Powers | 1 | -1/+5 | |
Check to see if there were any messages passed to acl_modify before debugging the first one. I think I caused this by some malformed LDIF. Signed-off-by: Andrew Bartlett <abartlet@samba.org> | |||||
2009-12-18 | Return NULL in strlower_talloc if src is NULL | Brendan Powers | 1 | -0/+4 | |
Prevents strlower_talloc from segfaulting if you pass it a NULL string. Signed-off-by: Andrew Bartlett <abartlet@samba.org> | |||||
2009-12-18 | s4:provision Give a more useful error message in guess_names | Andrew Bartlett | 1 | -3/+11 | |
The problem here is that as we start to get 'real users' they still decide to do silly things, like load empty but existing smb.conf files. Let's give them a better chance to discover what they did wrong. Andrew Bartlett | |||||
2009-12-17 | Always map EMFILE to ERRDOS, ERRnofids, *NOT* NT_STATUS_TOO_MANY_OPENED_FILES. | Jeremy Allison | 1 | -0/+4 | |
This is what W2KR3 does for NTCreateX and openX calls. May be the correct fix for bug 6837 - "Too many open files" when trying to access large number of files. Jeremy. | |||||
2009-12-17 | Vector correctly through reply_openerror() (which uses the same logic). | Jeremy Allison | 1 | -6/+1 | |
Jeremy. | |||||
2009-12-17 | s4 torture: RAW-STREAMS-NAMES Make sure the create time of the streams are ↵ | Tim Prouty | 1 | -0/+24 | |
different from the base file | |||||
2009-12-17 | s4 torture: Add RAW-STREAMS-RENAME3 to show error when trying to overwrite a ↵ | Tim Prouty | 1 | -0/+92 | |
stream with an open handle A normal file overwrite in this case would return NT_STATUS_ACCESS_DENIED, but if a stream is the target NT_STATUS_INVALID_PARAMETER is returned. | |||||
2009-12-17 | s4 torture: Parameterize streams delete behavior rather than commenting out ↵ | Tim Prouty | 1 | -3/+7 | |
the check. | |||||
2009-12-17 | s4 torture: RAW-STREAMS-CREATEDISP Use a normal deny mode | Tim Prouty | 1 | -1/+1 | |
2009-12-17 | s4 torture: close handle instead of using exit | Tim Prouty | 1 | -1/+1 | |
2009-12-17 | Update default with correct value. Add a note about Win7 behavior | Jeremy Allison | 1 | -9/+12 | |
here. Jeremy. | |||||
2009-12-17 | Fix bug #6939 - mangling method = hash breaks long filenames. | Jeremy Allison | 1 | -1/+4 | |
We were returning the wrong sense of the bool. must_mangle() has to return !NT_STATUS_IS_OK, not NT_STATUS_IS_OK. Jeremy. | |||||
2009-12-17 | s4:"samdb_set_password" - remove delete instructions | Matthias Dieter Wallnöfer | 1 | -7/+2 | |
They won't work when the LDB change is done using "samdb_replace" (consider "samr_password.c" functions). I think this has been a relict which has been useful before the "password_hash" module existed. Basically it itself does now the updates. | |||||
2009-12-17 | s4-smbtorture: skip GetAliasMembership against s4. | Günther Deschner | 1 | -0/+4 | |
It returns NT_STATUS_INTERNAL_DB_CORRUPTION for unknown sids and I could not figure out why. Guenther | |||||
2009-12-17 | Fixed incorrect checking of PRINCIPAL_SELF permissions. | Nadezhda Ivanova | 3 | -16/+139 | |
If an ace has the PRINCIPAL_SELF as trustee, this sid has to be replaced with the onjectSid of the object being checked. PRINCIPAL_SELF is the way to grant rights to an account over itself. | |||||
2009-12-17 | s4-smbtorture: add a samr_GetAliasMembership test to RPC-SAMR. | Günther Deschner | 1 | -0/+47 | |
Guenther | |||||
2009-12-17 | tdbtool: avoid using c++ reserved words. | Günther Deschner | 1 | -2/+2 | |
Guenther | |||||
2009-12-17 | s3: Run RPC-SAMBA3-GETALIASMEMBERSHIP-0 in make test | Volker Lendecke | 1 | -0/+1 | |
2009-12-17 | s4:dsdb/common/util - make NTTIME attribute wrappers use a "const" message | Matthias Dieter Wallnöfer | 1 | -4/+6 | |
There is no reason to have the message non-const here. | |||||
2009-12-17 | s3: Fix bug 6992, make test for getgrouplist cacheable | Jonas Gorski | 1 | -3/+3 | |
2009-12-17 | s4-smbtorture: fix smbtorture after setprinter IDL fixes. | Günther Deschner | 1 | -4/+4 | |
Guenther | |||||
2009-12-17 | s3-spoolss: fix rpcclient after setprinter IDL fixes. | Günther Deschner | 1 | -2/+2 | |
Guenther | |||||
2009-12-17 | spoolss: more mork on SetPrinterInfo() levels. | Günther Deschner | 4 | -82/+102 | |
Guenther | |||||
2009-12-17 | s4-ntvfs: check if pvfs is NULL in pvfs_logoff | brendan powers | 1 | -0/+5 | |
pvfs can be NULL if the directory a share points to does not exist. In this case, there would be no open files, so it is safe to just return from the function. Signed-off-by: Andrew Tridgell <tridge@samba.org> | |||||
2009-12-16 | s4:gensec: allow clearing local and remote address by passing NULL | Stefan Metzmacher | 1 | -0/+10 | |
metze | |||||
2009-12-16 | s4-gensec: Remove obsolete socket_address vars and fns. | Andreas Schneider | 2 | -35/+0 | |
2009-12-16 | s4-gensec: Replace gensec_get_peer_addr with new tsocket based fn. | Andreas Schneider | 8 | -32/+29 | |
2009-12-16 | s4-gensec: Replace gensec_set_peer_addr with new tsocket based fn. | Andreas Schneider | 3 | -12/+1 | |
2009-12-16 | s4-gensec: Replace gensec_get_my_addr with new tsocket based fn. | Andreas Schneider | 3 | -23/+24 | |
2009-12-16 | s4-gensec: Replace gensec_set_my_addr() with new tsocket based fn. | Andreas Schneider | 3 | -27/+1 | |
2009-12-16 | s4-gensec: Added remote and local setter/getter using tsocket. | Andreas Schneider | 3 | -4/+127 | |
2009-12-16 | Final part of the fix for 6837 - "Too many open files" when trying to access ↵ | Jeremy Allison | 1 | -12/+12 | |
large number of files Win7 needs a min of 16k file handles to work against a server. Jeremy. | |||||
2009-12-16 | Add helpful debug of DACL for errors on ACL access. | Jeremy Allison | 1 | -2/+10 | |
Jeremy. | |||||
2009-12-16 | spoolss: add spoolss_DriverInfo7. | Günther Deschner | 4 | -0/+245 | |
Guenther | |||||
2009-12-16 | s3-pdbedit: allow to call "pdbedit -N description -u user" without ↵ | Günther Deschner | 1 | -2/+4 | |
specifiyng "-r". Guenther | |||||
2009-12-16 | s4-dsdb: also mark the relax control non-critical when done | Andrew Tridgell | 1 | -5/+3 | |
2009-12-16 | s4-dsdb: it is a better pattern to mark a control as done than remove it | Andrew Tridgell | 3 | -21/+7 | |
removing a control means it can't be seen by any other modules, which is usually not what is wanted. Better to just mark it non-critical, which means anyone else who wants to look at it can, but if nobody does its not an error. | |||||
2009-12-16 | s4-dsdb: when the SD_FLAGS control is set, don't remove nTSecurityDescriptor | Andrew Tridgell | 1 | -10/+19 | |
2009-12-16 | s4-dsdb: don't actually remove the sd_flags control, just mark it non-critical | Andrew Tridgell | 1 | -14/+10 | |
For controls that need to be seen by more than one module, it is best to just mark them non-critical when handled, instead of removing them. Otherwise lower modules can't see them. In this case we want the operational module to see the SD_FLAGS control | |||||
2009-12-16 | s4-ldb: show the OID of any unhandled critical controls | Andrew Tridgell | 1 | -4/+9 | |
It isn't very useful just saying that a control is not supported, without saying which one is the problem Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> | |||||
2009-12-16 | s4-ldb: fixed a transaction error on prepare_commit | Andrew Tridgell | 1 | -2/+2 | |
when a prepare commit fails, we need to give a cancel to all modules, not a commit! Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> | |||||
2009-12-16 | s4-ldb: added --show-deactivated-link command line option | Andrew Tridgell | 1 | -1/+8 | |
this adds the SHOW_DEACTIVATED_LINK control | |||||
2009-12-16 | ldap: give a debug error when we don't know a control | Andrew Tridgell | 1 | -0/+2 | |
This interface should really have a proper error interface, but at least a DEBUG() gives the user a chance of finding the error Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> | |||||
2009-12-16 | s4-dsdb: added dsdb_get_deleted_objects_dn() | Andrew Tridgell | 1 | -0/+22 | |
This is based on the code from Eduardo Lima <eduardoll@gmail.com>, but uses the new helper functions added in the last couple of commits Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> | |||||
2009-12-16 | s4-dsdb: added dsdb_find_nc_root() | Andrew Tridgell | 1 | -0/+64 | |
This is based on the function of the same name from Eduardo Lima <eduardoll@gmail.com>, but using ldb_dn_compare, to give us comparisons consistent with what the rest of the code uses. We will use this function in combination with dsdb_wellknown_dn() to find the Deleted Objects container for any object. Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> | |||||
2009-12-16 | s4-dsdb: added dsdb_wellknown_dn() | Andrew Tridgell | 1 | -0/+32 | |
This finds a wellknown object given its GUID Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> | |||||
2009-12-16 | libds: added GUIDs for wellknown AD objects | Andrew Tridgell | 1 | -0/+13 | |
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> | |||||
2009-12-16 | s4-dsdb: added a dsdb_module_rename() call | Andrew Tridgell | 1 | -0/+43 | |
This will be used by the replmd_delete() code Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> |