summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2012-04-13Wrong assertion/comparison: Compare value not pointerOlaf Flebbe1-2/+2
Signed-off-by: Jeremy Allison <jra@samba.org> Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Apr 13 02:23:36 CEST 2012 on sn-devel-104
2012-04-12We never cancel SMB1 aio, only SMB2 aio - and in this case we always return ↵Jeremy Allison1-12/+7
a value. So pass_cancel is no longer needed.
2012-04-12Remove cancel_aio_by_fsp(). It can never work and could lead to memory ↵Jeremy Allison3-43/+18
corruption as outstanding IO's complete. Also we never have any aio's on a call to close_normal_file() with close_type ERROR_CLOSE.
2012-04-12Fix return_fn when aio was cancelled. We need to return -1, errno = ECANCELED.Jeremy Allison3-0/+15
2012-04-12Move the counting of outstanding_aio_calls into the lifecycle of the ↵Jeremy Allison1-6/+2
aio_extra struct. This way we can't end up with a mismatch between outstanding events and the counter. We may still have problems with canceling and not correctly freeing the aio struct, but at least the counter won't get out of sync anymore.
2012-04-12Fix the same bug reported by Kirill Malkin ↵Jeremy Allison1-4/+24
<kirill.malkin@starboardstorage.com> and fixed by Volker for vfs_aio_fork as ref 0aacdbfada46329e0ad9dacfa90041a1c7dbf3e8. From that change: aio_suspend does not signal the main process with a signal, it just waits. The aio_fork module does not use the signal at all, it directly calls back into the main smbd by calling smbd_aio_complete_aio_ex. This is an abstraction violation, but the alternative would have been to use signals where they are not needed. However, in wait_for_aio_completion this bites us: With aio_fork we call handle_aio_completed twice on the same aio_ex struct: Once from the call to handle_aio_completion within the aio_fork module and once from the code in wait_for_aio_completion. Fix this differently here by not calling directly back into smbd, but using a new function aio_linux_setup_returns() to setup the return values that wait_for_aio_completion() in the main smbd will pick up by calling handle_aio_completd().
2012-04-12s3: Fix a typoVolker Lendecke1-1/+1
Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Thu Apr 12 23:38:24 CEST 2012 on sn-devel-104
2012-04-12s3: Fix a segfault with debug level 3 on SolarisVolker Lendecke1-1/+2
printf can not deal with NULL strings
2012-04-12s4-libnet: split export_keytab in a separate python module to avoid pulling ↵Alexander Bokovoy8-48/+165
in HDB dependency Signed-off-by: Andreas Schneider <asn@samba.org> Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Thu Apr 12 15:23:19 CEST 2012 on sn-devel-104
2012-04-12WAF: Add support for stopping processing before end of wscript{_*}Alexander Bokovoy1-0/+5
WAF scripts are written in Python and Python has no simple way to stop program execution other than using exceptions. This change adds WscriptCheckSkipped exception and its handling in core WAF code. When any of wscript{_*} throws WscriptCheckSkipped exception, WAF simply continues to process next wscript in queue rather than breaking build. WscriptCheckSkipped exception can be used to perform early bail out of configuration/build target checks if certain dependency is not available when the default checks are way more numerous than a check for this particular dependency. This is to avoid 'if ...' indenting for large blocks of existing code which also muddens git history for nothing. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12clikrb5: Move pure krb wrapper functions from libads to clikrb5.Simo Sorce4-143/+145
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12gse: Remove unnecessary header.Simo Sorce1-1/+0
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12srv_keytab: Pass krb5_context directly, it's all we use anyways.Simo Sorce3-18/+14
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12krb5_wrap: krb5_string_to_key / krb5_encrypt_block are deprecated.Simo Sorce3-24/+12
Remove checks and replace with krb5_c_string_to_key(). Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12auth-krb: Move pac related util functions in a single place.Simo Sorce13-93/+85
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12auth-krb: Make functions static.Simo Sorce6-105/+73
The remaining gssapi_parse functions were used exclusively in gensec_krb5. Move them there and make them static. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12auth-krb: Use simpler method to extract keytype.Simo Sorce1-19/+12
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12auth-krb: Nove oid packet check to gensec_util.Simo Sorce8-86/+51
This is clearly a utiliy function generic to gensec. Also the 3 callers had identical implementations. Provide a generic implementation for all of them and avoid duplicating the code everywhere. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12s4-auth-krb: Remove dependency on credentials too.Simo Sorce3-14/+11
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12s4-auth-krb: Remove unneded dependency on kerberos_util.Simo Sorce5-44/+68
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12s4-auth-krb: Simplify salt_princ handling.Simo Sorce6-296/+250
This allows us to make parse_principal static in kerbeors_util again and avoid a silly game where we alloc containers and set destrcutors only to release the whole thing at the end of the function. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12s4-auth-krb: Move function to db-glue.c and make it static.Simo Sorce3-20/+21
kerberos_enctype_to_bitmap is not used anywhere else, so just move it there and make it static, one less dependency to worry about. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12s4-auth-krb: Move keytab functions in a separate file.Simo Sorce8-710/+754
Confine ldb dependency. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12s4-auth-krb: Streamline and cleanup code to make it readable.Simo Sorce1-190/+256
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12s4-auth-krb: streamline and rename enctype functionsSimo Sorce1-11/+12
better express what is being done in the function name.
2012-04-12s4-auth-krb: Make kerberos_enctype_bitmap_to_enctype static.Simo Sorce2-3/+1
It's a helper function not used anywhere else. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12s4-auth-krb: Make kerberos_enctype_bitmap_to_enctypes static.Simo Sorce1-1/+7
It is not used anywhere else. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12s4-auth-krb: Move function into more appropriate header.Simo Sorce2-8/+8
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12s4-auth-krb: Make cli_credentials_invalidate_client_gss_creds static.Simo Sorce2-2/+4
It's not used anywhere else. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12s4-auth-krb: Make impersonate_principal_from_credentials static.Simo Sorce2-6/+1
It's not used anywhere else. Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12gensec_gssapi: keep private header file close to the actual codeSimo Sorce2-7/+6
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12krb5_wrap: remove duplicate declaration and dead ifdefSimo Sorce2-8/+0
Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12s4-ldb: use KRB5_KEY macros to access key elements.Günther Deschner1-8/+8
Guenther Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12wafsamba: point out that local heimdal paths are not included whenGünther Deschner1-0/+1
USING_SYSTEM_KRB5 gets set. Guenther Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12waf: when USING_SYSTEM_KRB5 environment variable is set, dont configure localGünther Deschner1-1/+2
heimdal. Guenther Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12waf: when building with system krb5, we do not need to build local heimdal.Günther Deschner1-1/+2
Guenther Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12s3-waf: remove requirement of having --enable-developer for running system ↵Günther Deschner1-1/+1
krb5 checks. When you know about "with_mit_krb5_checks" you are most likely a developer already. Guenther Signed-off-by: Andreas Schneider <asn@samba.org>
2012-04-12Remove overly complex attemt to define blkcnt_t and blksize_t. AC_CHECK_TYPE ↵Jeremy Allison2-18/+2
should just do it. Still trying to fix the buildfarm. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu Apr 12 04:28:29 CEST 2012 on sn-devel-104
2012-04-11Try and fix autoconf on the build farm. Always include sys/types.h when ↵Jeremy Allison1-0/+2
working out sizeof(blkcnt_t).
2012-04-11s3:smbd only care about missing level2 support if kernel oplocks are enabledChristian Ambach1-4/+10
if kernel oplocks are not enabled for that share, we can grant level2 oplocks Signed-off-by: Jeremy Allison <jra@samba.org> Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Apr 11 22:45:21 CEST 2012 on sn-devel-104
2012-04-11s3:smbd only initialize kernel oplocks if they are enabled for a shareChristian Ambach1-0/+4
Signed-off-by: Jeremy Allison <jra@samba.org>
2012-04-11s3:smbd add seperate function to initialize kernel oplocksChristian Ambach2-3/+8
Signed-off-by: Jeremy Allison <jra@samba.org>
2012-04-11docs: update kernel oplocks documentationChristian Ambach1-2/+7
Signed-off-by: Jeremy Allison <jra@samba.org>
2012-04-11s3:param convert kernel oplocks to share parameterChristian Ambach4-9/+7
Signed-off-by: Jeremy Allison <jra@samba.org>
2012-04-11build: Fix spelling of teventAndrew Bartlett1-1/+1
Found by metze. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Wed Apr 11 17:36:19 CEST 2012 on sn-devel-104
2012-04-11build: use include paths for pkg-config found librariesAndrew Bartlett3-15/+23
2012-04-11lib/tdb_compat: Do not define BUILD_TDB2 if we are not building tdb2Andrew Bartlett1-3/+1
The simple fact that this was defined at all, even to false, caused some of the tdb2 build code to run. Andrew Bartlett
2012-04-11s4-smb2: Fix a talloc crash bug.Andreas Schneider1-2/+2
The talloc context needs to be initialzed or NULL. So move talloc_steal() to the position where req is initialized. Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Wed Apr 11 15:59:39 CEST 2012 on sn-devel-104
2012-04-11Simplify the logic around doing an immediate event reschedule.Jeremy Allison1-23/+7
We don't need to do a talloc here, we already have a long-lived pointer we can pass in as the private data. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Apr 11 08:05:47 CEST 2012 on sn-devel-104
2012-04-11s4:dsdb/samdb/ldb_modules/schema.c - move "get_last_structural_class()" into ↵Matthias Dieter Wallnöfer6-83/+46
"util.c" And remove this helper module - it does not have much sense keeping it. Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Wed Apr 11 06:31:51 CEST 2012 on sn-devel-104