summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2008-06-22Remove the "exists" parameter from create_msdfs_linkVolker Lendecke3-17/+14
Jeremy, setting "exists" to True in _dfs_Add prevented the initial creation of a new symlink for me, because the SMB_VFS_UNLINK failed. This also exists in 3.2. I only check it into 3.3 as I would like you to look at it first. Thanks, Volker (This used to be commit f58b098a4172949018e84c4d0c722d6eb9bba514)
2008-06-22Check for sec_initial_uid() instead of uid==0 in dfs managementVolker Lendecke1-2/+2
(This used to be commit 948607f16112f6529f3a54cd6bbe978e8a600bc8)
2008-06-22Reduce memory usage in form_junctions() a little bitVolker Lendecke1-0/+1
(This used to be commit d031e6d8cabe2dd0b29e90d173d45843e145176a)
2008-06-22Fix an abort in junction_to_local_pathVolker Lendecke1-1/+1
(This used to be commit 587bd636cb70d09600111ced040adaa55af35d0f)
2008-06-22Fix a crash in _dfs_EnumVolker Lendecke2-1/+3
(cherry picked from commit 4a996476297963d4cb300b4d45c23e83a493c339) (This used to be commit 86cae83a7db87063ecd6e58eaa15f11441c45040)
2008-06-22Fix an uninitialized variable access in callers of parse_msdfs_symlinkVolker Lendecke1-1/+2
At least form_junctions() does not initialize refcount, and I don't see it in get_referred_path(). For the latters, the callers might initialize it. But even if they did, I think parse_msdfs_symlink() should unconditionally return the number of referrals it found. I don't think it makes sense to count them up from somewhere else. (This used to be commit 73172113484a2c6c9af014f59e84707716c61a7d)
2008-06-21Fix a double-closedir() in form_junctions()Volker Lendecke1-1/+0
(This used to be commit 1d7ad0dea7ebf7a46af6e695797e5132264307d6)
2008-06-21Attempt to fix the darwin buildVolker Lendecke1-1/+1
(This used to be commit c919f5146990fa4b1b0cde79d55e5e3008b94e3f)
2008-06-21Use "init_shared_module" instead of "init_module" for initializing .so'sVolker Lendecke3-6/+8
(This used to be commit 0c2fd687b25e32d446ef799927db6933bc61223d)
2008-06-21Make pipes_struct its own talloc ctxVolker Lendecke4-43/+16
(This used to be commit 829b1ad4697f2f1ea008377d591456722dccd025)
2008-06-21Fix a SAFE_FREE/TALLOC_FREE mixupVolker Lendecke1-1/+1
(This used to be commit b39852f51313059899630ba63509fee904ba3613)
2008-06-21net: Don't crash on invalid command line options.Kai Blin2-8/+1
This backs out the workaround Jerry added in 4c3bfea9f8d238f9100eaa264b9b2941dff5a6dd. Thanks for the catch. (This used to be commit 20e0bb4800938863cb0aac1a19473748132043fc)
2008-06-20Fix bug #5531 - fix conversion of ns units when converting from nttime to ↵Jeremy Allison1-2/+6
timespec. Fix from hkurma@datadomain.com. Jeremy. (This used to be commit 8c87a4319cc83f55fb105cae81a8efbc3fb5b98b)
2008-06-20Fix bug #5533. Winbindd fails to cope correctly with a workgroup name ↵Jeremy Allison1-9/+3
containing a '.'. Jeremy. (This used to be commit 96325ff44dc404a68d4ebd423cf78210ec3ff902)
2008-06-19net: Fix crash when specifying invalid options on the command lineroot1-0/+8
(This used to be commit 4c3bfea9f8d238f9100eaa264b9b2941dff5a6dd)
2008-06-19Remove current_user references from nttrans.cVolker Lendecke1-3/+2
(This used to be commit 5f8a5e68ea166fbeda3af6e5ec381ec09d06f0f6)
2008-06-19Remove current_user references from trans2.cVolker Lendecke6-11/+37
This involved replacing the CHECK_NTQUOTA_HANDLE_OK macro by a function. (This used to be commit 5595cdf837edb82db69a3e57bcf3108be7feeeb8)
2008-06-19Remove some current_user references from trans2.cVolker Lendecke1-19/+25
(This used to be commit 4c31cc0b62f532eafdc44398b29b773ad8cb0646)
2008-06-19Remove reference to current_user from reply.cVolker Lendecke1-4/+3
(This used to be commit e895e44cc7d675d128430fb53c138e5e8736e59f)
2008-06-19Wrap the unix token info in a unix_user_token in auth_serversupplied_infoVolker Lendecke19-86/+86
No functional change, this is a preparation for more current_user ref removal (This used to be commit dcaedf345e62ab74ea87f0a3fa1e3199c75c5445)
2008-06-19Remove the "current_user" arg from fsp_belongs_connVolker Lendecke3-6/+6
fsp_belongs_conn only used the vuid struct member anyway, and this is available in the smb_request structure as well. (This used to be commit 64e9372ab997739d46669c0cc4a4c6edb11d5e64)
2008-06-19Remove the "current_user" arg from check_fspVolker Lendecke4-26/+26
check_fsp only used the vuid struct member anyway, and this is available in the smb_request structure as well. (This used to be commit 8d364c4c3311b406847158fc37e9208d298cf8ba)
2008-06-19loadparm: use the return value of the special handlers in lp_load().Michael Adam1-2/+2
Up to now, the bool return value was silently ignored. Michael (This used to be commit c65d425fec964bc0b8778b596615a8bcce0378aa)
2008-06-19loadparm: don't treat a missing include file as an error in handle_include().Michael Adam1-1/+1
Michael (This used to be commit a8ef8870beb91fcd2745aa59de6c59b49ea00e39)
2008-06-19testsuite: enable the testparm_s3 tests.Michael Adam1-0/+7
Michael (This used to be commit 0f5c13e5735990f4325f98156a7dc410276372fe)
2008-06-19testsuite: add a testparm_s3 test script.Michael Adam1-0/+90
This is a first testparm/lp_load test that runs testparm on a couple of configuration files. The main purpose for now is to test the options that have special handlers (to check whether the handlers succeed). In particular, all the Macro expansions that are available via alloc_sub_basic() are tested with the include handler. This is to catch such crashbugs as #5548 where %m expansion led to a segfault. The tests now are very simple. Just check if testparm completes successfully on the given config files. This can (and should) be elaborated in the future. Michael (This used to be commit eb28146d40b8a8bc2c20b8d222abf191ea178d5a)
2008-06-19testsuite: update introductory comment to test_net_regsistry.shMichael Adam1-1/+2
This is now used to test rpc and local access depending on command line parameters. Michael (This used to be commit 73c17b630317b5019e5d5f2b989b8de081a73e07)
2008-06-19Remove current_user_info reference from vfs_recycle.cVolker Lendecke1-3/+1
(This used to be commit fdc03c0a5ba0da4fbc4610880e06150c11d4c737)
2008-06-19Remove current_user_info reference from vfs_fake_perms.cVolker Lendecke1-6/+4
(This used to be commit a227181e8d2ed0824a323a3d4b4cfda5e438f8ce)
2008-06-19Remove current_user_info reference from vfs_expand_msdfs.cVolker Lendecke1-3/+1
(This used to be commit 05a66980a9b5a7c6222ceb038d819d23fd172186)
2008-06-19current_user is not used in vfs_aixacl2.cVolker Lendecke1-1/+0
(This used to be commit 407136abdf45ad832382dba44e1c9a3b4f253f09)
2008-06-19RWX on a file does not imply DELETE accessVolker Lendecke1-1/+1
Without this the changed checks in can_delete_file_in_directory give DELETE access where there is none. So we can end up granting the ntcreate&x preparing the unlink where we should not, which leads to a NT_STATUS_ACCESS_DENIED at close time later, which in turn does *not* give the access denied error message in the Windows GUI. can_delete_file_in_directory will grant access now by looking at the directory permissions. (This used to be commit 51b5364c2afb3a18df4bec2bc1624760ccc01676)
2008-06-19Fix checks in can_delete_file_in_directory()Volker Lendecke1-6/+15
With at least NFSv4 ACLs around the write permission for the owner is a bogus check if we can delete a file in a directory. Like in Windows, there are two ways which can grant us such: First, the DELETE permission on the file itself, or if that does not help, the DELETE_CHILD permission on the directory. It might be a bit more code that runs, but essentially we should end up with the same set of syscalls in the non-acl case. (This used to be commit daa9b056645a45edfb3a70e3536011ebe5678970)
2008-06-19Remove some codeVolker Lendecke1-12/+4
Did not measure it, but I think a single write is better than a read and a conditional branch (This used to be commit abe1bed665ad8d1dbf9177dcbb9344b25df9594c)
2008-06-19Fix typoVolker Lendecke1-1/+1
(This used to be commit 2eef2c682c18ad37b78214c755b9dd7c8b607cb8)
2008-06-19Fix the build on FreeBSD 4.6.2Volker Lendecke1-4/+5
(This used to be commit 4f50cb63e9b565ae0747127baa651a1a1874298b)
2008-06-18Fix 'make distclean'. delheaders: no longer exists as a dependency.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 8b26afdcddc75d3b9a97309757a97314b406cb59)
2008-06-18Remove prototype of unimplemented smbc_chown() function.Derrell Lipman1-26/+0
(This used to be commit 0e84e3bb800cec2b63df4692afbf9c40850b108f)
2008-06-18Revert "Fix a memleak in svcctl_init_keys()"Volker Lendecke1-10/+1
This reverts commit b1afb31f3cadd4749bf6e3eb5d8935588bf8ebfc. This one is very strange: I need to investigate why valgrind showed it as leaking, and why in my initial tests this did not fail. (cherry picked from commit 24730f5981efb920811e7929a9483bd72bb0984c) (This used to be commit b1e8e5d173cdaa3fb9c1fb1d9aacf8e665bc5d61)
2008-06-18Fix Bug #5548 (segfauls in handle_include with %m macro expansion).Michael Adam1-1/+4
In alloc_sub_basic, when expanding '%m', substitute "" instead of NULL for remote_machine when this is NULL. Else a NULL string is returned. Michael (This used to be commit c65b456c6a145d15b7fd27a2a3440a0709fc3277)
2008-06-18file_access: add a function header comment for can_access_file_acl().Michael Adam1-0/+3
Michael (This used to be commit 7d5fb873bde0a84de522650945effeaf602c759e)
2008-06-18smbd/dir.c: remove unneeded stat buf parameter from user_can_read_file()Michael Adam1-4/+2
This is not needed anymore since user_can_access_file_acl() ist used. Michael (This used to be commit 3c349f773a52e3de693d3bb79f5060c9f1e01e41)
2008-06-17file_access: remove unneeded stat buf parameter from can_access_file_acl().Michael Adam3-5/+5
This is a security descriptor level function only. Michael (This used to be commit 5931540fa1681f026fed42df387d17e43c493c47)
2008-06-17net sam: fix typo in commentMichael Adam1-1/+1
Michael (This used to be commit b9f6904044889328ded229b7ff04d31218f4fef8)
2008-06-17net sam: fix typo in debug message.Michael Adam1-1/+1
Michael (This used to be commit 6d7f64c3481d3aa7ec6b0d468f3d6218f62cd92e)
2008-06-17testsuite: give admin rights to testuser only for the "net rpc registry" test.Michael Adam1-0/+41
Remove the user from BUILTIN\Administrators at the end of the tests. Note: BUILTIN\Administrators is not deletet at the end because that functionality is not implemented. Michael (This used to be commit 1734f9305a38eff05f0147d9c7391ef34085e7b2)
2008-06-17testsuite: don't give the testuser administrative rights globally.Michael Adam1-9/+0
It breaks RPC-SAMBA3-GETUSERNAME for reasons I have not quite understood yet. Somhow loosing rights fails when the user belogns to BUILTIN\Administrators at some point. Michael (This used to be commit 9fe99c69f35b005b66c1eacb5d999cc73f1bb521)
2008-06-17Fix a brown paper bag segfault in clitarVolker Lendecke2-2/+2
Thanks to "No Body is Perfect" from gmail, whoever that is :-) Volker (cherry picked from commit 679d8dfa390601f777bfb43c02cd921eae5edcf4) (This used to be commit b8e1d62b8e8f724b855c8ab9801abee0b2791e36)
2008-06-17rpcclient: add more generic internal dscracknames call.Günther Deschner1-26/+57
Guenther (This used to be commit 2351b0845ca78707901daca6a6d0425959c6f28e)
2008-06-17netapi: use NetUserEnum filter in example code.Günther Deschner1-1/+1
Guenther (This used to be commit ad105177686da823ef9cce1c1bedaf0f84a49b8c)