Age | Commit message (Collapse) | Author | Files | Lines |
|
- Ensured that all public functions have documentation in libsmbclient.h
- Reformatted for "proper" indentation
- Re-added temporarily-disabled alternate authentication function capability
Derrell
(This used to be commit 64b7150d92849a1e1e2416b9dcc12fae8d6bea99)
|
|
Given the tacit (if that) approval by some people, and clear disapproval by
others for my proposed clean-up and reorganization of libsmbclient, I've come
up with a slightly different approach. This commit changes back to the
original libsmbclient.h SMBCCTX structure which will maintain ABI
compatibility. I retain, here, the setter and getter functions which all new
code should use. Older programs already compiled should continue to work
fine. Older programs being recompiled will encounter compile-time errors
(intentionally!) so that the code can be corrected to use the setter/getter
interfaces.
Although this doesn't clean up the interface in the way I had wanted, the code
reorganization and requirement for new programs to use the setters and getters
allows future progress to be made on libsmbclient without further muddying up
the interface, while retaining the ABI compatibility that was the big issue
causing disapproval. I hope that this compromise is adequate.
Derrell
(This used to be commit 56429a3d60b2a48963342f6340b3c01469a892c6)
|
|
The libsmbclient interface has suffered from difficulty of improvement and
feature enrichment without causing ABI breakage. Although there were a number
of issues, the primary ones were:
(a) the user of the library would manually manipulate the context structure
members, meaning that nothing in the context structure could change other
than adding stuff at the end;
(b) there were three methods of setting options: setting bits in a flags field
within the context structure, setting explicit options variables within an
options structure in the context structure, and by calling the
smbc_option_set() function;
(c) the authentication callback did not traditionally provide enough
information to the callee which required adding an option for a callback
with a different signature, and now there are requests for even more
information at the callback, requiring yet a third signature and option to
set it (if we implement that feature).
This commit provides a reorganization of the code which fixes (a) and (b).
The context structure is now entirely opaque, and there are setter and getter
functions for manipulating it. This makes maintaining ABI consistency much,
much easier.
Additionally, the options setting/getting has been unified into a single
mechanism using smbc_option_set() and smbc_option_get().
Yet to be completed is a refactoring of the authentication callback (c).
The test programs in examples/libsmbclient have been modified (if necessary;
some applications require no changes at all) for the new API and a few have
been minimally tested.
Derrell
(This used to be commit d4b4bae8ded824d06ad5ab0e219f71187ee5c771)
|
|
Guenther
(This used to be commit aa9c0f587718f4d647e87b9662acbedba042b9cb)
|
|
This reverts commit ae254cb61f4b9331755848c47ebc34e90dd80390.
(This used to be commit 030bef7f22f7a73466204b7860f397dbca9f2ab0)
|
|
This reverts commit f5356825698a02df2d400b51dd95d1f857c83e81.
(This used to be commit 5f53a62be8a21b8d92ac44b18d202882500356e8)
|
|
This reverts commit 844a163458c7585e4306a21ffdae5d08e03d6e4d.
(This used to be commit 5ab1cfda500de07ff3c712442ab2fc74eecc8886)
|
|
This reverts commit 719527f55e88f0c5fdceda5c807475aba299c79f.
(This used to be commit ac301fada257e2d3b50148109a3d44fa1421b0b4)
|
|
This reverts commit 9a966e5593ae4474014aec5d8c68c489ac8ce0c9.
(This used to be commit 413695e8d0d8232a9c35e693f9a4a8009418ede4)
|
|
On a fresh install with no existing registry.tdb, make sure we are able to
create our initial top-level entries.
Michael, Volker, please check.
Guenther
(This used to be commit 956bc602062825493e1c357e2388fee1e5514b50)
|
|
Jeremy, in 3.0 we allowed get_mydnsdomname and get_mydnsfullname to fail
without filling in anything useful. Worked fine. Without this patch and a empty
/etc/hosts and no DNS configured, session setup would return
NT_STATUS_BAD_NETWORK_NAME. This is confusing at best, BAD_NETWORK_NAME afaik
is only ever returned from tcon normally.
This restores the 3.0 behaviour.
Comments?
Volker
(This used to be commit 2bd3b7d474768f842921945d283eac10da2a1684)
|
|
(This used to be commit f2c67803792f1fd3929e922c1f626f8247e08992)
|
|
Guenther
(This used to be commit 5f592d030b7e94331a634e0d625aefc60cfb1f70)
|
|
Guenther
(This used to be commit 2f1bc7ddad97b9137ae4cce696bf4e08f9b7ca20)
|
|
That commit message was just too silly, this happens to me during interactive
rebase all the time...
This reverts commit ab687104c1371c84c510eca7ef2caad7c21ea8fc.
(This used to be commit a3a1edab0d5ac07d42e64a5a82dd71fe0c3fdfeb)
|
|
(This used to be commit ab687104c1371c84c510eca7ef2caad7c21ea8fc)
|
|
Guenther
(This used to be commit 4e93301ca4931908a7d1994be45c57002f8c6fea)
|
|
Guenther
(This used to be commit 6d543b1a1a5a7af98affc9aea2edf650cb476379)
|
|
v3-2-test
(This used to be commit e7406822d32d5b36d3706144efbd1eaa7c44cead)
|
|
Jeremy.
(This used to be commit fa12667ec284fdda45b79cbf6bf548ab0faae34f)
|
|
in the registry.
Guenther
(This used to be commit f673bbd300d972dd7ae2d092b3b1e642ed29cfd2)
|
|
(This used to be commit 9a966e5593ae4474014aec5d8c68c489ac8ce0c9)
|
|
Gunther
(This used to be commit d7346e9360ffa97e44fa781293d32c707436193b)
|
|
"Invalid read of size 1" errors.
Jeremy.
(This used to be commit d954a4954ba8ed6cb2c6074176a6008cfa398dd7)
|
|
Michael
(This used to be commit ee4810099c2d26a0ebab3c41a95bc6b57921683d)
|
|
This reverts commit 79c199d16e565eabd9fd971247f8df62689bb92a.
Revert this until pidl is capable of doing decent dependency tracking
itself (importing types from imported idls).
Michael
(This used to be commit 1fb69ad1f5c79dd77f73a5fee266e1e363e6974d)
|
|
This reverts commit 9b47a7329091b2bfe7cd9b2112ac8fa652ed9f60.
libnet_join.idl should not be processed along with the other idl files
since it should not produce server and client code, just the header.
Michael
(This used to be commit 2967b29f23e04f24a62ea576b0b6c948055689d0)
|
|
(This used to be commit eff3d3bad5a8860b99375cc0be9dc24f3679e416)
|
|
smbget needs libwbclient.
Michael
(This used to be commit 78bc496ecf72b5c2474911302e81a90c488e3070)
|
|
Guenther
(This used to be commit 55e85ccd3ec59afc05b955f1458d9fc655cee752)
|
|
(This used to be commit 364d87a5e41045808ebd28f46c5c0c93bd13a7da)
|
|
This hopefully fixes the build on HP-UX.
metze
(This used to be commit 5fb7533e37b6c682e019b1c3515dc6befc8bda09)
|
|
It was only used in configure, but lib/replace already
has a much better version of it.
metze
(This used to be commit c9b60b75b4763c37cfa63741b4f055e4ea488e92)
|
|
This is used for two purposes:
First, I'm using it to test the async I/O code. In the forked process it is
pretty easy to delay a reply for a random amount of time. See the
BUILD_FARM_HACKS snippet.
Second, there are systems around that claim to have Posix AIO but which is
broken. This might be some help for those systems.
Also add tests how to pass file descriptors
(This used to be commit b0e52cecf2009d4c7f29412dadf17910e54e4327)
|
|
Forgot to git add Makefile.in before doing git commit --amend
in previous commit...
Michael
(This used to be commit 7cf645cdae8ce17705036951538991b0a9dbefaf)
|
|
Michael
(cherry picked from commit 0aff54a12e20d5e91fcdec7aaec103fb9a371a23)
(This used to be commit 77b7d7c0417e498340d1c9364fbbb8671c175477)
|
|
Michael
(cherry picked from commit 54cc0df4dbf6d63a9b94e1ac6af4ec7f7803bc30)
(This used to be commit 1ff0b616a9cb029040031f797b52112d4973e1eb)
|
|
Michael
(cherry picked from commit 0cbb87453beb52c6b0bc3a48791f49678f4030c5)
(This used to be commit 34d906ef44d1a5c3452097a9cac438d721fe35c1)
|
|
Michael
(cherry picked from commit 523626908d25f974fd1ae6d7306b1d4bc8414162)
(This used to be commit 0906120a6e4fe0eb66f3c3fd99c625b30672cb2b)
|
|
Michael
(cherry picked from commit f8243cfc47c7414bab7f249d0e5d1c85e8ca7d64)
(This used to be commit 3c1843f931b896dd3bb142346ecb44c0fb9202d6)
|
|
Michael
(cherry picked from commit 29818a07de826fd687003ff25865d77939ecaa9a)
(This used to be commit 1d906d346ed90b87895772a64c7613324ef8b682)
|
|
Don't fail when there is no address assigned to the interface.
Put NULL into the ifaddrs structure instead.
Michael
(cherry picked from commit ee170c85e0e76411bd752de5fe51db6940dab929)
(This used to be commit 650cc1da4b4404880389c583dbb07ce86df48576)
|
|
Michael
(cherry picked from commit a2a506ff0eae2a64ebe2ddbb81a6c2a5fa7fe3da)
(This used to be commit c5932414fdf0b568cbfe6cdefaec41c8afc8ca6b)
|
|
Michael
cherry-picked from libreplace-part of 9d2bab09aac22c00fe23f1e1265a2dbd0901e9ce
and adapted replacetort creation
(This used to be commit 52d79ad4872a20cf55f31aba97629c2561bfc16c)
|
|
Guenther
(This used to be commit 405ef74d7e9ef614ea39b7cfd1d57307d9490545)
|
|
Guenther
(This used to be commit bc2d3d51449831146a9faf6e809e7a91d174659c)
|
|
access_desired.
Guenther
(This used to be commit 63894e5c93ef0663fc58bcc191777cd1aca7e21c)
|
|
Thanks metze for the fix.
Guenther
(This used to be commit dcffb885bc5d16e795b71d95e0790d3d7d70cf3c)
|
|
Guenther
(This used to be commit 7d88cb2e8db8789b923d8f9979b5c9f65664d3eb)
|
|
Tested with nt4 and w2k3.
metze
(This used to be commit 490d0c52bb117561227cbc59a15b15b688814fe2)
|