summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2000-08-23Added code to do SID to uid/gid conversion. Needed for ACL support.Jeremy Allison5-26/+266
Jeremy. (This used to be commit 81c5380f91839b6416c8a42739dadf00e7388528)
2000-08-22Patch from John Reilly <jreilly@hp.com> for not processing duplicate filesTim Potter1-0/+8
when moving printer driver to download area. (This used to be commit 6e0c9079c385a4f0e61d9f1b1e0351bc4dbc3151)
2000-08-21Fix for safe_free freeing static strings. From Robert August Vincent, II.Jeremy Allison1-5/+6
Jeremy. (This used to be commit bd844fcd3023ab956eb7ab369475955a88bcca14)
2000-08-18oops. must return "" string and length zero when strlen(filebuf) == 0Luke Leighton1-13/+16
(This used to be commit d3bc7cca99e47ce89035a03022d7c3ec69e01636)
2000-08-18fixed an off by one error where I was tromping on memoryGerald Carter1-1/+1
when initializing a driver_info_3 struct. See spoolss_addprinterdriver() jerry (This used to be commit 4fad1fc28a0396443e4723d2065860feb283a785)
2000-08-18fixed initialization errors (again!) I must have forgot toGerald Carter1-0/+6
check these in before. jerry (This used to be commit e682d6a599934e5460abe0d30cb2465fa80c7937)
2000-08-18getfileline() - line with length of zero -> filebuf[strlen(filebuf)-1]Luke Leighton1-10/+13
is NOT ok. (This used to be commit 24e0c8ef70dc59bfaaa113c3d44befbccbcba15f)
2000-08-18changing some debug message levelsGerald Carter1-12/+12
j- (This used to be commit facef51be4e3f3be75613f39c8dfedfa7410552c)
2000-08-17Fix for Win9x driver downloads when information isGerald Carter1-83/+153
stored in the TDB. See the message I posted about this on samba-technical * If the admin does not desire the new NT print driver support, nothing needs to be done. All existing parameters work the same. * If the admin wants to take advantage of NT printer driver support but does not want to migrate the 9x drivers to the new setup, the leave the existing printers.def file. When smbd attempts to locate a 9x driver for the printer in the TDB and fails it will drop down to using the printers.def (and all associated parameters). The make_printerdef tool will also remain for backwards compatibility but will be moved to the "this tool is the old way of doing it" pile. * If the admin installs a 9x driver for a printer on a Samba host (in the printing TDB), this information will take precedence and the three old printing parameters will be ignored (including print driver location). * If an admin wants to migrate the printers.def file into the new setup, I can write a script to do this using rpcclient. The main problem is the driver namespace (we need the NT driver name first in order to be consistent). jerry (This used to be commit ac049f8bf348810dc068382fdbc6635a2015d36a)
2000-08-17added comment for my own memory purposesGerald Carter1-0/+1
jerry (This used to be commit b64ddbd1aaba8811641e502e96f3bbef01171f52)
2000-08-16hack for unmarshalling unistr's on machines with BIG_ENDIAN archGerald Carter1-2/+19
I think we have a lot more of these bugs lurking (i'm fairly confident of it). jerry (This used to be commit 3b14487c7e5218ff3e0ff3118ca1afd706e05247)
2000-08-16- fixed memcpy bug in copy_unistr2()Gerald Carter1-7/+21
- init_unistr2_from_unistr() does not NULL terminate the buffer --jerry (This used to be commit 65ee5f9b6ed3c4ad33fefd3c879f2649496fd3f3)
2000-08-16fixed unitialized struct bug in enum_users (whatever it is called)Gerald Carter1-1/+5
jerry (This used to be commit a606131508592d72f3fd8a0dd63073e9c559062f)
2000-08-16fixed typo.Gerald Carter1-1/+1
jerry (This used to be commit f00a330b3e7900bc325802b2a252a392a16a8b2a)
2000-08-15fixed error in [public] spotted by Ron Alexander <rcalex@home.com>Gerald Carter1-2/+1
changed to read only = yes jerry (This used to be commit e17753c532ab6d5ae628c6e6f6d5b810638cb314)
2000-08-15Merge of uninitialised variable fix from APPLIANCE_HEAD.Tim Potter1-4/+1
(This used to be commit 20a7fefee8c85f02f6a0e2a02c0df04a8b22b7cb)
2000-08-15Tidied up extra ()'s.Jeremy Allison1-12/+12
Jeremy (This used to be commit f94f37dcab2bc2b68e2b6b4ca440ad53a60e8117)
2000-08-14Reverted the change Luke made. Removed IS_BITS_SET_XX macros.Jeremy Allison2-18/+7
Do not re-add them. These macros are unsafe as they are not understood. Change all TNG code using them to correct '&' and '|' please. IS_BITS_SET_ALL was being used in cmd_interp.c when IS_BITS_SET_SOME should have been used. Jeremy. (This used to be commit be4e5eeb4f808c1d8ac4030e8886a83a37914c57)
2000-08-14Merge.Tim Potter1-2/+2
(This used to be commit 604f6a34effb8aeed7701345a4219749a6a97892)
2000-08-14fixed a few bugs in new_smb_io_relarraystr().Gerald Carter1-2/+5
Marshalling code path now uses spoolss_smb_io_unistr() also caught a NULL pointer case. i'll update TNG later. (This used to be commit bd4c83eb40a14baf447ac88886d4eafe7b9a309f)
2000-08-14NT printer permissions test program.Tim Potter3-0/+433
(This used to be commit 9af82423d2e5c6f873a906097a56c8ac6c5f8297)
2000-08-14restored IS_BITS_SET_xxx macros.Luke Leighton1-0/+5
(This used to be commit bc065f9597654666e2f26ec046e058e44247d6e3)
2000-08-14hey, jerry: turns out you _have_ converted to get_safe_nt_errmsg!!!Luke Leighton1-2/+4
[got confused with which way dirdiff was going :)]. ... but you forgot to update TNG's lib/cmd_interp.c... (This used to be commit 8fe195df0b5826af7048ef6c87e4b55dfd336cf8)
2000-08-14jeremy,Luke Leighton1-11/+15
please do not remove IS_BITS_SET_XXX macros just because you happen "not to like them". whilst still working on merging, you are not responsible for this code, therefore do not hinder its development whilst people are attempting to do merges. after the merge from TNG to cvs main is completed, you can do what the hell you like. thank you. jerry, please could you consider adding underlying routines (in this case get_safe_smb_errstr()) instead of reverting to a [less secure] previous coding method. thanks. (This used to be commit b2e044f89de7cb12fd14540d5d7d5070951ce2fb)
2000-08-14minor formatting fixes.Gerald Carter1-9/+9
jerry (This used to be commit 95355d2cf26f51b1f928b8a020a4a731483be0b8)
2000-08-14fix for new_smb_io_relarraystr() and new_smb_io_relstr()Gerald Carter1-2/+2
to use spool_smb_io_unistr() as this does not call prs_align() befrore parsing the UNISTR. Parsing a void* buffer from an RPC should not be aligned on 4 byte boundaries. Don't think this change affects any marshalling code, only unmarshalling... jerry (This used to be commit bc154e8522a75540a8504195c1e6f45739167e6b)
2000-08-12removed the prs_align in spoolss_smb_io_unistr() (JF, please check)Gerald Carter1-3/+36
as it was throwing things off when parsing buffers passed in SPOOLSS RPCs fixed the unmarshalling of UNISTR arrays to be double NULL terminated jerry (This used to be commit 236f19659cea87cc35128990954d30c43114b889)
2000-08-12fixes to prs_unistr UNMARSHALLING only. Problem was due to talloc'sGerald Carter1-29/+37
of 0 bytes. jerry (This used to be commit 3fcc59ba928250759bbf3ef46d7c118950a5ba6f)
2000-08-12FIxed some unmarshalling problems with relstr and unistr arraysGerald Carter3-200/+163
jerry (This used to be commit ce2d20395ae3d41d55030427f4b7b44ce87c605e)
2000-08-12fixed unistr_to_ascii to deal with NULL src stringsGerald Carter1-14/+14
jerry (This used to be commit 8e95aae1709a9be28d6e25ff6f0fdc729dc09274)
2000-08-12reworked talloc() to in order to help track down invalidGerald Carter2-25/+32
memory access. Tridge, I don't think using 0xdeadbeef for size allocations of 0 is going to work. I ended up having to use NULL as much code that works on UNISTR checks to see if the buffer ptr is NULL. So valid code ends up with a seg fault. Rather than rewriting it all, I added a DEBUG_TALLOC #ifdef in talloc.h that sets a macro BAD_PTR. This is the value assigned to ptr for an allocation of 0 bytes. jerry (This used to be commit 233b9cffa2350552d9f775f791d5d5e0464a1ed4)
2000-08-12removed (void) typecast from SMB_ASSERTGerald Carter1-1/+1
jerry (This used to be commit f806881e6c2c94c03fb7e70d92cd0a5a3fc30fbd)
2000-08-12Updated by Patrick Powell <papowell@lprng.org>John Terpstra1-106/+195
(This used to be commit 3361c144f5ba2a87a469436f670ab35189021d49)
2000-08-11Fixed the problem with UNISTR marshalling in a buffer5 struct.Jeremy Allison2-53/+25
The smb_io_unistr() code called a prs_align, this was not being counted in the size or taken account of in the offset calculation. Fixed size_ calculation to always return a size a multiple of 4 and also set the offset correctly. This fixes the problem I saw and will hopefully fix the problem HP reported. JF please check this change. Jeremy. (This used to be commit ceba9f3dcdb4bddae17ec0024692c9074086302d)
2000-08-11First shot at actually *doing* WINS failover.Christopher R. Hertel1-1/+8
If libsmb/namequery.c:name_query() times out while doing a non-broadcast query, I mark that WINS server 'dead'. Note that I don't try the new WINS server. I think I can get that working too. This is only for queries, not registrations. The biggest problem is that I may have to fiddle with the UNICAST SUBNET, but I need to check talk that over with someone (Jeremy?) before I hack at it. I can't actually test the above change, I'm 'fraid. I'm getting: 4 errors detected in the compilation of "rpc_server/srv_spoolss_nt.c". in head branch. Chris -)----- (This used to be commit 40ae638866e3d826ccd5d827672634959c31b039)
2000-08-11Fix case where volumename could be returned as UNIX charset or DOS codepageJeremy Allison1-2/+6
depending on where it came from. Jeremy. (This used to be commit cfbf78085d48671e5be382e7486953a85a893be1)
2000-08-10Added "add_printer_hook" call to update printer for Win9x clients.Jeremy Allison1-62/+68
Patch from John Reilly <jreilly@hp.com>. Jeremy. (This used to be commit 76a5713bd3fad18ec60d12fc3f965f3e9717c159)
2000-08-10Tidied up security rights definitions.Jeremy Allison7-39/+30
Jeremy. (This used to be commit e466c863f5540e13776f4477b6d58e3fbfe7276d)
2000-08-10Removed requirement that sid have an owner before being interpreted.Jeremy Allison1-18/+9
Thanks to Elrond for pointing this out. Jeremy. (This used to be commit 1d9a5494f8214b8d6171073f4090687a8535d78c)
2000-08-10Working on spoolss_getprinterdriver() as it does not display all theGerald Carter2-6/+21
dependentfiles. jery (This used to be commit 206565368b887ba83791efe018f24175e6f31137)
2000-08-10working on the unmarshalling of dependentfiles to a DRIVER_INFO_3Gerald Carter1-2/+9
struct. Not wuite there. jerry (This used to be commit 1a145977f09654fc51ebcd40ef7a2aa69aa96cfb)
2000-08-10code formatting cleanupGerald Carter1-6/+0
jerry (This used to be commit 4bc5b8aa345b963e1247c6a364ba48a08fbd9764)
2000-08-10deal with allocation size of 0 in prs_unistr when UNMARSHALLINGGerald Carter1-24/+30
jerry (This used to be commit 26a73a70e282a5e46cc2b6fe7bc09b406724c9dd)
2000-08-10Deal will NULL UNISTR in unistr_to_asciiGerald Carter1-13/+21
jerry (This used to be commit cfa4c878a2ccaf346940f8f4a201737e185f76d6)
2000-08-10talloc returns 0xdeadbeef when asked to allocate 0 bytesGerald Carter1-19/+29
jerry (This used to be commit df51dc32f6ffc4fe2cebfaae5079417aad1ff34d)
2000-08-10Needed to add the SHARED attribute bit when creating a printerGerald Carter2-10/+15
on a Samba host. Also needed to add an option to pass the share name (printer name) on the command line. And fixed the checking of the return code for spoolss_r_addprinterex() jerry (This used to be commit 880e81161640cd38540b06d982c592cbada51d40)
2000-08-09Fixed bug in new printer access check code. If PRINTER_ALL_ACCESS is changedJeremy Allison1-0/+10
in the ACE's the same thing must be done in the desired access or they will never match. This took me a while to find... :-). Jeremy. (This used to be commit 066520979b2b5d967e6e1d77f16185a5fb19dc0c)
2000-08-09make protoGerald Carter1-2/+2
(This used to be commit ad74885e4730da2a15ff00e13f490f3f0b1be10d)
2000-08-09More work on AddPrinterDriver() and AddPrinterEx() client RPC'sGerald Carter6-64/+74
Also fixed init_unistr() to deal with a NULL source character string. -jerry (This used to be commit 8ecd5dd52a6bd867f5d117352048ee43ce7254d9)
2000-08-09Fixed memory leak with NT tokens.Jeremy Allison4-50/+103
Added debug messages to se_access_check(). Added FULL_ACCESS acl to default acl on printers. Jeremy. (This used to be commit 7507f6f408cf8b0f8d7e2b3da54ce5fb5ef5343b)