summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2011-04-11s3: Fix Coverity ID 2473, UNINITVolker Lendecke1-2/+1
Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-11s3: Fix timeout calculation in event_add_to_poll_argsVolker Lendecke1-1/+1
In the initial phase nmbd does not yet have timed events. This led to nmbd not correctly registering its names in make test and certainly everywhere else. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Mon Apr 11 14:35:45 CEST 2011 on sn-devel-104
2011-04-11s3-modules: Fix debug messageBjörn Baumbach1-1/+1
Print child descriptor instead of parent. Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Mon Apr 11 11:48:42 CEST 2011 on sn-devel-104
2011-04-09Fix bug 8072 - PANIC: create_file_acl_common frees handle two times.Jeremy Allison1-51/+48
Caused by premature optimisation storing the parent ACL on the module handle instead of (correctly) on the file fsp. Previous code wasn't reentrant safe. This is less optimal but doesn't crash in the specific case :-). Jeremy. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sat Apr 9 02:05:15 CEST 2011 on sn-devel-104
2011-04-08Subtle change. Microsoft SMB2 tests return different access mask than for ↵Jeremy Allison1-1/+12
SMB1 with raw.acls.
2011-04-08s3:net idmap check: fix output of an invalid recordMichael Adam1-1/+6
Only print the value number for hwm, version and seqnum keys. Pair-Programmed-With: Gregor Beck <gbeck@sernet.de> Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Fri Apr 8 17:29:31 CEST 2011 on sn-devel-104
2011-04-08s3-net: "idmap check" ignore __db_sequence_number__Gregor Beck1-1/+7
Signed-off-by: Michael Adam <obnox@samba.org>
2011-04-08talloc/testsuite: avoid memory leak reported by valgrindStefan Metzmacher1-1/+1
metze Signed-off-By: Andrew Tridgell <tridge@samba.org> Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Fri Apr 8 10:15:41 CEST 2011 on sn-devel-104
2011-04-08talloc/testsuite: test more talloc_pool related thingsStefan Metzmacher1-0/+55
metze Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08talloc: include valgrind headers if availableStefan Metzmacher1-0/+9
metze Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08talloc: add TC_INVALIDATE_POOL marcoStefan Metzmacher1-3/+38
metze Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08talloc: add TC_UNDEFINE_GROW_CHUNK() marcoStefan Metzmacher1-0/+21
metze Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08talloc: add TC_INVALIDATE_SHRINK_CHUNK() marcoStefan Metzmacher1-0/+28
This invalidates the unused bytes if we shrink memory. metze Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08talloc: add TC_INVALIDATE_FULL_CHUNK() macroStefan Metzmacher1-12/+36
This makes it easier to mark a talloc pointer as invalid. metze Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08talloc: use VALGRIND_MAKE_MEM_UNDEFINED() before memmove()Stefan Metzmacher1-0/+12
metze Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08talloc: optimize talloc_free() and talloc_realloc() for talloc poolsStefan Metzmacher1-22/+138
metze Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08talloc: add TC_POOL_FIRST_CHUNK() macroStefan Metzmacher1-2/+5
metze Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08talloc: add TC_POOL_SPACE_LEFT() macroStefan Metzmacher1-2/+5
metze Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08talloc: add TC_ALIGN16() macroStefan Metzmacher1-2/+3
metze Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08talloc: use TC_HDR_SIZE instead of sizeof(struct talloc_chunk)Stefan Metzmacher1-1/+1
As this includes the padding to 16 bytes. metze Signed-off-By: Andrew Tridgell <tridge@samba.org>
2011-04-08ldb:ldb/common/ldb_modules.c - change the request counter type to be "unsigned"Matthias Dieter Wallnöfer1-1/+1
Just for consistency since all other LDB counters are unsigned as well. And also the debug output specifier has been chosen to be "%u" - so it really should be unsigned. Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org> Autobuild-Date: Fri Apr 8 09:17:47 CEST 2011 on sn-devel-104
2011-04-08ldb:ldb/common/ldb_modules.c - trivial - fix integer output specifiersMatthias Dieter Wallnöfer1-2/+2
2011-04-07s3:net rpc trust: fix two C++ implicit void * cast warningsMichael Adam1-2/+5
Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Thu Apr 7 17:52:28 CEST 2011 on sn-devel-104
2011-04-07s3:passdb:pdb_ipa: fix a C++ implicit void * cast warningsMichael Adam1-1/+2
2011-04-07s3:net idmap check: fix a couple of c++ implicit void * cast warningsMichael Adam1-5/+5
2011-04-07packaging(RHEL-CTDB): fix configure.rpm (honour additional cmdline parameters)Michael Adam1-1/+1
2011-04-07ldb:ldb_msg.c - make "ldb_msg_find_attr_as_*" more robust against invalid valuesMatthias Dieter Wallnöfer1-19/+106
- Integer handling was modeled after validate code from "schema_syntax.c". - Double handling was modeled similar, but with a dynamic buffer. I don't know if there is a maximum literal length for double values but an allocation shouldn't a problem here since doubles are rare. - String handlind is enhanced with a terminating "0" test for safety. Reviewed-by: abartlet + metze Autobuild-User: Matthias Dieter Wallnöfer <mdw@samba.org> Autobuild-Date: Thu Apr 7 16:38:57 CEST 2011 on sn-devel-104
2011-04-07ldb:ldb_msg_check_sanity - clean it up from unneeded stuffMatthias Dieter Wallnöfer1-4/+0
2011-04-07dsdb:schema/schema_syntax.c - correctly check error code of ↵Matthias Dieter Wallnöfer1-2/+1
"ldb_string_utc_to_time" This one doesn't set ERRNO. An error happens if the result is "0". Reviewed-by: abartlet
2011-04-07dsdb:schema/schema_syntax.c - add some empty value checks on validate functionsMatthias Dieter Wallnöfer1-0/+9
They are needed since the check in "ldb_msg_sanity_check" will be removed. Reviewed-by: abartlet
2011-04-07s4:objectclass LDB module - "ldb_msg_sanity_check" call not really neededMatthias Dieter Wallnöfer1-5/+0
This call should only be performed at the beginning of a request. "ldb_msg_sanity_check" checks for DN validity (which should already have been done at the beginning of the request) and empty attributes (which should be done by the "objectclass_attrs" LDB module). Hence it is superflous here. Reviewed-by: abartlet
2011-04-07ldb:ldbadd/modify tool - return error code when at least one operation has ↵Matthias Dieter Wallnöfer2-5/+8
failed This is required to better detect failures and should raise the compatiblity to "ldapadd"/"ldapmodify". Reviewed-by: abartlet
2011-04-07ldb:tests - "init.ldif" - deactivate empty "seeAlso" attributeMatthias Dieter Wallnöfer1-1/+2
2011-04-07ldb:ldb/common/ldb_modules.c - always use LDB error codes if possibleMatthias Dieter Wallnöfer1-6/+7
The callers do compare against LDB error codes - hence don't give back "-1". Reviewed-by: Tridge + abartlet
2011-04-07ldb:common/*.c - check for some OOM conditionsMatthias Dieter Wallnöfer2-0/+7
Reviewed-by: abartlet
2011-04-07s4:objectclass LDB module - fix a comment - add a ")"Matthias Dieter Wallnöfer1-1/+1
Reviewed-by: abartlet
2011-04-07selftest:Samba4: setup DC_* variables in provision_rpc_proxy()Stefan Metzmacher1-0/+7
The "rpc_proxy" should behave like "member", just with a different configuration. metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Thu Apr 7 15:52:25 CEST 2011 on sn-devel-104
2011-04-07s4-smbtorture: fix lsa forest trust test.Günther Deschner1-1/+1
lsa_lsaRSetForestTrustInformation takes a policy handle obtained from lsaopenpolicy/lsaopenpolicy2 and not a trusted domain handle (MS-LSAD 3.1.4.7.16 LsarSetForestTrustInformation (Opnum 74)). Sumit, please check. Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Thu Apr 7 14:52:52 CEST 2011 on sn-devel-104
2011-04-07lsa: use lsa_TrustedAccessMask in some more places in the lsa IDL.Günther Deschner1-3/+3
Guenther
2011-04-07s3-net: document "idmap check"Gregor Beck1-0/+92
Signed-off-by: Michael Adam <obnox@samba.org> Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Thu Apr 7 13:58:13 CEST 2011 on sn-devel-104
2011-04-07s3-net: fix the usage output of "net idmap check"Gregor Beck1-4/+5
Signed-off-by: Michael Adam <obnox@samba.org>
2011-04-07s4-samba_dnsupate Fix syntax errorAndrew Bartlett1-2/+1
This particular sub-part of the script isn't tested in 'make test' due to it making real changes to DNS. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Thu Apr 7 08:51:11 CEST 2011 on sn-devel-104
2011-04-07Revert "s3-test: disable ktest for now"Andrew Bartlett1-1/+0
This reverts commit 77820d59fe517168db5cb79b05214ae9fd6b4467. I beleive this is now reliable, after the changes to wait for an actual connection at startup and to use the fake DNS file. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Thu Apr 7 07:20:03 CEST 2011 on sn-devel-104
2011-04-07s3-selftest actually wait for smbclient to connectAndrew Bartlett1-2/+14
This means that we actually have a working smbd. The previous code didn't know if it worked or not, and so created flaky tests. Andrew Bartlett
2011-04-07s3-selftest Fix use of the 'fake DNS' fileAndrew Bartlett2-2/+2
This ensures we don't use netbios before the hosts file and that we do fill in the fake DNS zone correctly for the way we invoke smbtorture4. Currently this works because the realm in client.conf is "", if this changes then this will need to change too (perhaps an additional entry). Andrew Bartlett
2011-04-07wintest Allow setting of the firewall to failAndrew Bartlett1-1/+1
This is also required to allow a telnet connection as non-admin. Andrew Bartlett
2011-04-07s3-wintest Add test of 'net use' against the Samba3 memberAndrew Bartlett2-5/+18
2011-04-07wintest Allow changing the telnet settings to fail, we might not be adminAndrew Bartlett1-1/+1
This allows us to test logging in as non-admin users over telnet
2011-04-07samba_dnsupdate: Don't use subprocess.check_call, it isn't in python 2.4Andrew Bartlett1-1/+8
RHEL5 and clones use python 2.5
2011-04-07s3-test: disable ktest for nowAndrew Tridgell1-0/+1
the ktest tests are currently flakey. Once andrew has found the problem they can be re-enabled Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Thu Apr 7 03:36:36 CEST 2011 on sn-devel-104