summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r16307: Make sure we know we must pass a valid pointer here.Jeremy Allison1-3/+2
Klocwork #1129. Jeremy. (This used to be commit e8d86362ba8762a5e4180e7320f5ac8bb37c203d)
2007-10-10r16306: Error handling in this asn1 code *sucks*. Fix a genericJeremy Allison2-8/+39
class of memory leak bugs on error found by Klocwork (#123). Many of these functions didn't free allocated memory on error exit. Jeremy. (This used to be commit 8ef11a7c6de74024b7d535d959db2d462662a86f)
2007-10-10r16301: Fix a memleakVolker Lendecke1-0/+2
(This used to be commit 21aaede518503e6722ba5ccfdb2c77007d12ddee)
2007-10-10r16299: Fix another "dereferencing type-punned pointer will breakJeremy Allison1-2/+7
strict-aliasing rules" gcc4 warning. Jeremy. (This used to be commit ee77dde9b6375423f95f31455d06cef7303400be)
2007-10-10r16298: On request of jiri sasek - Sun Microsystems - Prague Czech Republic ↵Jeremy Allison1-6/+6
<Jiri.Sasek@Sun.COM> change priv_op and priv_info to names that don't conflict with the solaris namespace. Jeremy. (This used to be commit db5b4e3f13bceeb2f078f412bdd4666516eedc5c)
2007-10-10r16295: Fix gcc4 "warning: dereferencing type-punned pointer will breakJeremy Allison1-20/+20
strict-aliasing rules" warning. Jeremy. (This used to be commit 7ac5aee88cae3400fb6400b3628544da2e474560)
2007-10-10r16294: Fix syntax error.Lars Müller1-1/+1
Credits to Andreas Schwab from SUSE Linux for this fix. (This used to be commit da4c5c3b75e6fd4f9e661cbcbe7d38024a02d344)
2007-10-10r16290: Fix Coverity bugs 298 and 298Volker Lendecke1-4/+4
(This used to be commit b96808bb623c01f2515fdbdede8b4e9edebff23b)
2007-10-10r16289: Fix smbclient test hang. This is caused by readline refusing to believeJames Peach1-3/+11
the end of file it receives when reading from a pipe after we force interactive mode. (This used to be commit 3eee12645883df21efa5175b10854a965fc90422)
2007-10-10r16287: Use intptr_t to return an integer of an unknown type castJeremy Allison2-0/+7
to void *. Jeremy. (This used to be commit e24361ecddef8a48a42a356775b93ce5c4027fae)
2007-10-10r16285: On a 64-bit box, size_t != uint32. Ensure we useJeremy Allison1-2/+4
the right parameter type. Jeremy. (This used to be commit 938545f5352161b4fe195c2a826a26db5236f851)
2007-10-10r16284: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsignedJeremy Allison6-13/+13
int in a format string. Jeremy. (This used to be commit face01ef01e1a3c96eae17c56cadf01020d4cb46)
2007-10-10r16281: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsignedJeremy Allison1-1/+1
int in a format string. Jeremy. (This used to be commit c49ad9200bf3fdd8b9404d93182c2e04e662190a)
2007-10-10r16280: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != unsignedJeremy Allison1-2/+2
int in a format string. Jeremy. (This used to be commit 45d5cad8c2438c032d9f11c62a50a04d0637bf6c)
2007-10-10r16277: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != ↵Jeremy Allison1-2/+2
unsigned int in a format string. Jeremy. (This used to be commit 3a15fff21988b426a514ad28060eaf0ddc17ef6b)
2007-10-10r16275: Start fixing up gcc4 -O6 warnings on an x86_64 box. size_t != ↵Jeremy Allison1-4/+4
unsigned int in a format string. Jeremy. (This used to be commit 952547471f03bd2da1eda0247471b17aa1ff15de)
2007-10-10r16274: Fix the smbclient prompting behaviour for both systems that haveJames Peach4-33/+68
libreadline and those that don't. We always use the built-in readline replacement for non-interactive mode. Interactive prompts are always emitted to stdout and non-interactive mode never prompts at all. Introduce x_fdup to avoid spuriously closing stdout when a logfile is specified on the command line and setup_logging is called a second time. (This used to be commit 848ac756f651a4be231e5635580c0fd5f3d3fa0e)
2007-10-10r16273: Add smbclient tests to verify thatJames Peach2-2/+57
in interactive mode, smbclient always prompts on stdout in non-interactive mode, smbclient never prompts (This used to be commit dff1eba81ed4bdd6dbf2df6e7c28b0da74a39615)
2007-10-10r16272: Fix memleak.Günther Deschner1-1/+2
Guenther (This used to be commit afdb1189029e01a132f16fea48624126ec65cd77)
2007-10-10r16270: Fix Klocwork #706 - ensure sscanf has correct formatJeremy Allison1-4/+5
specifier. Jeremy. (This used to be commit dc53d35b0a1491da94e231943a81547be4c75631)
2007-10-10r16269: Fix the build.Günther Deschner2-3/+6
Guenther (This used to be commit 546710d58c07acdaa175caa48cec4d3f2bc657ad)
2007-10-10r16268: Add TCP fallback for our implementation of the CHANGEPW kpasswd calls.Günther Deschner3-105/+237
This patch is mainly based on the work of Todd Stecher <tstecher@isilon.com> and has been reviewed by Jeremy. I sucessfully tested and valgrinded it with MIT 1.4.3, 1.3.5, Heimdal 0.7.2 and 0.6.1rc3. Guenther (This used to be commit 535d03cbe8b021e9aa6d74b62d81b867c494c957)
2007-10-10r16267: Fix Klocwork #401, #402 - ensure format specifierJeremy Allison2-16/+67
limited. Fix memleak in printing gencache contents. Jeremy. (This used to be commit 81731e1f68cdf4af80733338238aeae0a7d108c0)
2007-10-10r16261: Smaller fixes for net ads password.Günther Deschner1-2/+2
Guenther (This used to be commit 689ae22c80a890278610d9ada1eb4fa5e37bd5ce)
2007-10-10r16255: Fix 'net ads join' when the workgroup is set incorrectlyGerald Carter1-6/+9
in smb.conf. This did work before the join rewrite. Samba will have problems if you try to run any of the daemons with an incorrect workgroup but it should not fail to join. The summary is that a member server should always use it's own machine name when setting up schannel since that is the only account it has. Thanks to Volker for the discussion. (This used to be commit 95763b94f709fe1ad9e381dbc6b364c2f3759024)
2007-10-10r16253: Fix another host/ UPN case in (the currently unused)Günther Deschner1-2/+2
cli_rpc_pipe_open_krb5. Guenther (This used to be commit fa19099112490daa085bb310f2f4ed877bb22b40)
2007-10-10r16252: Fix Klocwork ID 1119, 1121.Volker Lendecke1-0/+10
Volker (This used to be commit 678bbcf06109b276d3e4514c3788a9fb31348de0)
2007-10-10r16251: for i in `seq 1 1000`Volker Lendecke2-2/+2
do echo "I will always compile before commit :-)" done Also fix Klokwork ID 806. Volker (This used to be commit 4974c598c00abc20cfb73eee12a7c49c279e0f54)
2007-10-10r16250: Fix Klokwork IDs 148, 151, 152, 154.Volker Lendecke1-4/+4
Volker (This used to be commit d7a75ee94db009085165c062f73b68162a8b6da8)
2007-10-10r16249: Fix Klokwork ID 130Volker Lendecke1-1/+1
(This used to be commit 09586824f6568fb3305e3e59ba6bc8f5f632fb56)
2007-10-10r16248: Fix Coverity ID 297Volker Lendecke1-0/+5
(This used to be commit e56e3c19e1244e2b7409d57a030ca8b7ec446932)
2007-10-10r16247: Fix Coverity ID 296Volker Lendecke1-1/+1
(This used to be commit b82c95cb438b57bb8910e26657f8ffb590fe02df)
2007-10-10r16245: Cope with string being zero len. Klocwork bug #410.Jeremy Allison1-2/+4
Jeremy. (This used to be commit afe2d4c49333309b940cec8408ccd37ed3747cb7)
2007-10-10r16243: Fix Klocwork bugs #581 and #706, ensure we checkJeremy Allison1-616/+667
the end of array first in the loop. Reformat to modern standards. Jeremy. (This used to be commit 66275bd3bc56e67759dbabe77cb2ba019c6f4887)
2007-10-10r16241: Fix Klocwork #106 and others like it.Jeremy Allison9-650/+385
Make 2 important changes. pdb_get_methods() returning NULL is a *fatal* error. Don't try and cope with it just call smb_panic. This removes a *lot* of pointless "if (!pdb)" handling code. Secondly, ensure that if samu_init() fails we *always* back out of a function. That way we are never in a situation where the pdb_XXX() functions need to start with a "if (sampass)" test - this was just bad design, not defensive programming. Jeremy. (This used to be commit a0d368197d6ae6777b7c2c3c6e970ab8ae7ca2ae)
2007-10-10r16230: Fix Klocwork #861 and others. localtime and asctimeJeremy Allison16-141/+276
can return NULL. Ensure we check all returns correctly. Jeremy. (This used to be commit 6c61dc8ed6d84f310ef391fb7700e93ef42c4afc)
2007-10-10r16222: Fix DEBUG statements.Günther Deschner2-2/+2
Guenther (This used to be commit 5ecfaf7d505e6acc23a06dd64d00f5e6fb8efe6f)
2007-10-10r16221: No need for friednly error messages at log level 10.Günther Deschner1-27/+26
Guenther (This used to be commit 58a7c0900325065cc969eb4f2f4c85d41e27bc89)
2007-10-10r16219: BUG 3836, 3837, 3004: compile warning fixes from Jason Mader.Gerald Carter3-4/+4
(This used to be commit 6c1f1c091f5e87bf9464fe8ad7eb2cb683819a62)
2007-10-10r16216: Add debug messages to make it possible to try andJeremy Allison1-8/+31
debug why a job pause or resume command is not being done. Jeremy. (This used to be commit e6aacb1426bd04c4006f7be66228f9f8d9a7065d)
2007-10-10r16213: Fix Klocwork #852. iface_n_ip can potentiallyJeremy Allison2-2/+16
return NULL. Ensure we don't deref. Jeremy. (This used to be commit c2f0ea2ff2f6ad925cee9c85110c6ad828ffb7a9)
2007-10-10r16209: Klocwork bug #66, ensure no null deref.Jeremy Allison1-1/+8
Jeremy. (This used to be commit 79e693798cf322071ea64a4014a01ad9eaba73e8)
2007-10-10r16207: Ensure we don't allocate an OID string unlessJeremy Allison1-3/+11
we know we don't have an error. Klocwork #6. Jeremy. (This used to be commit 2c1a2d7b40e7ef353461f97f5c69c2079b5670ab)
2007-10-10r16206: Don Meyer <dlmeyer@uiuc.edu> pointed out that RHEL4 rpms use 'Epoch: ↵Gerald Carter1-0/+1
0' so work around that (This used to be commit 304b7913cd25a024269fecdd541af06836816f68)
2007-10-10r16205: Fix 'make install' when srcdir != builddirGerald Carter1-6/+6
(This used to be commit 44d4bab991d5fc88005a542d2490ae3254a0f5b5)
2007-10-10r16204: Fix Klocwork # 14Volker Lendecke1-3/+5
localtime() can return NULL. Volker (This used to be commit 07c5dcb8633e6fadb596dc5a22d8d31b2e16a3ef)
2007-10-10r16203: Fix potentially writing one result of strtok beyond the end of alt_path.Volker Lendecke1-1/+2
Found by Klocwork, ID 653. Volker (This used to be commit 4cb8cf221f986b15de3ac608b173310c14248533)
2007-10-10r16202: Fix Klocwork #3. Strange - was already fixed in HEAD.Jeremy Allison1-2/+7
Jeremy. (This used to be commit 319f80bbf0455cfaf80eab51313a56db4ed04ac5)
2007-10-10r16201: Fix Klocwork 439Volker Lendecke1-1/+3
(This used to be commit b369d0891afe8b777b837eaac317131232568ca7)
2007-10-10r16199: Fix Klocwork #1 - ensure we test the firstJeremy Allison1-10/+12
strtok for NULL. Jeremy. (This used to be commit 98751e8190317416de56b4a19a489c5f4b7d6bc9)