Age | Commit message (Collapse) | Author | Files | Lines |
|
Start removing unneeded "BOOL ok" from this reply.c
(this logic is old, old, old..... :-).
Jeremy.
(This used to be commit 3d52268095c605a80dfcd371769198a332baa0a5)
|
|
(This used to be commit db93c1b98d5445071ad0af229afed1f11ab0a862)
|
|
(This used to be commit c16ce9ebaab0175e7f1dc13798d5599388fa35d6)
|
|
(This used to be commit 1ef910f423a9ec69af6abf5a4e2137e8a4e81755)
|
|
create disposition of FILE_CREATE then there's no need
to check can_delete_file_in_directory().
Jeremy.
(This used to be commit eb32b60efc4c332295ff6fc7e5d575f4b40e8ff6)
|
|
go back to normal. Sorry about that.
Jeremy.
(This used to be commit d4127034fb89185fe7464d57c9f56f7914da6141)
|
|
to go...
Jeremy.
(This used to be commit 89f03a8db40365f99c6755ff19a4bfbf8d1bd316)
|
|
Jeremy.
(This used to be commit c5be0082ef60cd041121a9c36f4af934cd60562d)
|
|
The only difference between the two trees now w.r.t file
serving are the changes to smbd/open.c in this branch I need
to review.
Jeremy.
(This used to be commit f4474edf6a0c71001dbd01429ef70bafad6abd74)
|
|
The patch fixes the behaviour of GPFS sharemodes when
the access mask is no_access.
(This used to be commit 799967c66879b4d6e28f1af6ba27c67f0b1deaeb)
|
|
(This used to be commit d78c18a9fa494a2b3ef48db0abd987c740556e50)
|
|
fires, it
might be possible that we hang in the receive_smb() although that socket is
not the reason for the select() to return.
This immediately reacts to the fam socket to become readable, and goes into
the select loop again. This fixes delays in files showing up in Windows.
Jeremy, James please review this and merge to 3_0_24 if appropriate.
Thanks,
Volker
(This used to be commit c846153b2ed2f9aca82491888e391ccbe239e88a)
|
|
James, can you please confirm this and merge it to 3_0_24? For me it fixes the
segfault.
Thanks,
Volker
(This used to be commit a841b7659ba7b76b2da7993e1f4402aa0e11716f)
|
|
Jeremy.
(This used to be commit 66cca893e1aa035fa0aa05c0d542848f084fac31)
|
|
comparisons here, not unsigned as we're eventually
casting into what it normall a signed 32 bit
value. Guenther please check (but I think I'm right here).
Jeremy.
(This used to be commit 31f8e0edc0c3e76654728b2c204faa70830e1f1b)
|
|
Just try to log on in offline mode without the fix: all accounts are expired,
although they are set to never expire in the PAC/info3.
NTTIME "Never" needs to get (time_t) -1.
We were casting a uint64 to time_t before
comparing, and we should have been doing it
the other way around.
Guenther please check this fixes things.
Jeremy.
(This used to be commit f4e898b6224fd82d9805da771ef6040065de7b12)
|
|
The problem occurs like this:
1) running smbd as a domain member without winbindd
2) client1 connects, during auth smbd-1 calls update_trustdom_cache()
3) smbd-1 takes the trustdom cache timestamp lock, then starts
enumerate_domain_trusts
4) enumerate_domain_trusts hangs for some unknown reason
5) other clients connect, all block waiting for read lock on trustdom
cache
6) samba is now hung
The problem is the lock, and really its just trying to avoid a race
where the cure is worse than the problem. A race in updating the
trutdom cache is not a big issue. So I've just removed the lock.
It is still an open question why enumerate_domain_trusts() can
hang. Unfortunately I've not in a position to get a sniff at the site
that is affected. I suspect a full fix will involve ensuring that all
the rpc code paths have appropriate timeouts.
(This used to be commit ab8d41053347a5b342ed5b59a0b0dd4983ca91e6)
|
|
In case a user authenticated sucessfully and his password just expired
while beeing disconnected, we should allow a user to logon (given a
clear warning). We currently forced the user into a password change
dialogue in that scenario; this did not make much sense while offline.
Guenther
(This used to be commit 668b278653acfc4de7807834988f7af557e608a5)
|
|
coverity warnings.
(This used to be commit 5f86d006debd880ec35db4ebe7db0663c5cb220f)
|
|
(This used to be commit 82ce272b2464f06e8bcbed6452621daa05e12b5d)
|
|
(This used to be commit aa122be8f7a33ebceeb43e4f0c5362047560b199)
|
|
(This used to be commit 9cecd62654d22b47d938a44a8aed63c558d511ad)
|
|
--with-smbmount.
(This used to be commit ee12348cf1e93d0e75714f3883bfea6525797dc1)
|
|
"never" as
key words for -1 as policy values for net sam policy.
Volker
(This used to be commit b6347751d8f67dcaac5c1bcbc07f03073278f6fb)
|
|
We were incorrectly calculating the days until the password expires and
we also need to look at the info3 pass_must_change_time for expiry
calculation.
Guenther
(This used to be commit 22d79237127a064a934928d175182adecc6300de)
|
|
for the hint.
(This used to be commit f1f5d035db067b85e55b1c4009407b47dedcf975)
|
|
(This used to be commit a174b49173e7185abb89e605e667e64e8dd87454)
|
|
wcard unlink if bad_path was set. The error
returned here is almost certainly incorrect
and will need testing properly with smbtorture,
but I don't want to forget about this path
(yes Volker I know this is currently incorrect :-).
Jeremy.
(This used to be commit 06e20c287898d21e437ab117eb5eeeaf2420ba78)
|
|
starts to make
sense. Until then, remove it from the tree to keep the diff between 3_0_24 and
3_0 small.
Volker
(This used to be commit f146a85e74c84e78a11e616a1cbeaeef4693a0e0)
|
|
particular the NT_STATUS_INVALID_PARAMETER thing was badly wrong. Remove the
changes based on it. Using gentest is much more effective in this respect, but
it will take a while to figure out the wildcard error handling of W2k3.
Volker
(This used to be commit 58b8a242a7f08c1292d24fc73df170dbcd68c10d)
|
|
Guenther
(This used to be commit 3bb94a081888eca69796b14057b551b078ee9a77)
|
|
that we've
taken care of above.
Volker
(This used to be commit 5e1da363bb3f2675beb9fd9240301bb432e5239b)
|
|
doing early
returns.
Volker
(This used to be commit 614651c6a72742173de5fa8723403880acc37c09)
|
|
(This used to be commit 9d0a789e32e6a6501421edb25bc8197c9e06846d)
|
|
anymore
(This used to be commit 1798987128be579a1a4574294a7c3094040ebaf2)
|
|
reply_unlink
under Linux we returned NT_STATUS_NOT_A_DIRECTORY. This is because in the
bad_path==True condition lstat(2) returns ENOTDIR and not ENOENT.
Not sure if we want to necessarily replicate the INVALID_PARAMETER here, but
this is what W2k3 does.
Jeremy, I tried to call you, but you were not around. So I'll leave it up to
you to merge this.
Volker
(This used to be commit b1edc3d053104204b966eed67d070ad5da40f17b)
|
|
(This used to be commit c86fbdf8cc8f6f17b23e647bd1f4714c6095b860)
|
|
(This used to be commit 7e444e1612fa49f7db4de3256e6c67025db28806)
|
|
set_bad_path_error
is equivalent to UNIX_ERROR. Expand the last reference. Lets see if I can kill
that as well :-)
Volker
(This used to be commit 794d5d38f19601bb5b30b965b41b844aacf1caeb)
|
|
bad_path==True argument
being handled further up.
Volker
(This used to be commit 358673c36697a16aa87f9cebbace34abf16ed28e)
|
|
(This used to be commit 60d7b349dbc12288a3da0486b571a1d83401d0b7)
|
|
unix error mapping table
(This used to be commit 816c19aaeb812a94fd5669174c9beec60ce1a73f)
|
|
(This used to be commit cea9a01434490fb8a17c3f12db7a092efda21186)
|
|
I'm checking in micro-steps to make them independently checkable. This code
just very severely needs cleanup, but I don't want to break anything. So, be
patient with me, please :-)
Volker
(This used to be commit c16775486baa89901f0d5126cb926c9e5a807743)
|
|
(This used to be commit f19db8f33ed3749f6b72ae3a4cee83574c606e88)
|
|
(This used to be commit 44f9d25a9026df29fcaae8723ef52b1d3101628b)
|
|
(This used to be commit e4dea0e64747912da899e846b944c24804772259)
|
|
Volker
(This used to be commit 33b5950bec407e295b2c6139e21d062e376df330)
|
|
(This used to be commit e4a2e63272dc5b20413597179d06b0185c4a6817)
|
|
(This used to be commit 244f96388c843fd629478d0069f68550a2006d06)
|