summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2000-12-15Never free anything in the rpc_parse/prs_XXX functions. Do it in the enclosingJeremy Allison3-26/+21
function. lib/util_unistr.c: Check lengths *before* reading source - prevent uninitialised memory reads. Jeremy. (This used to be commit ce4f461965c872fbfc9fe5f6b98aed58bb3dd67a)
2000-12-15Added lock backouts on fail.Jeremy Allison5-65/+43
When chaining together long lines of bloody "if" statements, which should logically be separated, and one of them allocates memory, remember to *free* it *WHETHER OR NOT THE IF STATEMENTS SUCCEEDED* !!!! Yes I do consider this a bug in the coding style of Tridge, Rusty, Tim et al. :-). I'm just pissed 'cos this took 4 hours to track down even with an insure error report stating me in the face and also Ben Woodward looking over the code with me :-). Jeremy. (This used to be commit 506b5e34c3ba16768dbc82ba21044787de160c45)
2000-12-15lib/util_unistr.c:Jean-François Micouleau7-45/+89
rewrote unistr2_to_ascii() to correct a bug seen on SGI boxes. rpc_parse/parse_misc.c: rpc_parse/parse_prs.c: rewrote of BUFFER5 handling to NOT byteswap when it was already in network byte order. rpc_parse/parse_samr.c: cleanup of samr_io_q_lookup_domain(), remove the over-parsing by 2 bytes. rpc_server/srv_lsa.c: UNISTR2 strings need to be NULL terminated to pleased W2K. rpc_server/srv_spoolss_nt.c: use snprintf instead of safe_strcpy as we want the string truncated at 32 chars. That should fix SUN and SGI box not able to act as printserver and the problem with joining from a W2K wks. J.F. (This used to be commit 69fe739303b105f2c488f266f13977da1b6b201d)
2000-12-15Fixed memory leak in JOB_INFO_2 code.Jeremy Allison1-3/+2
Jeremy. (This used to be commit d0d31eead3367485bbac684d881839029010975d)
2000-12-15Fixed memory leaks in lsa_XX calls. Fixed memory leaks in smbcacls. MergedJeremy Allison16-87/+148
in fixes from appliance-head and 2.2. Fixed multiple connection.tdb open problem. Jeremy. (This used to be commit 0a40bc83e14c69a09948ec09bb6fc5026c4f4c14)
2000-12-14Changes from APPLIANCE_HEAD:David O'Neill1-1/+9
- add some debugs for comparing two security descriptors. (source/rpc_parse/parse_sec.c) (This used to be commit 505a8a2277f2bc761bd2b170fafbcb3afd982d92)
2000-12-14Updates from appliance-head.Jeremy Allison1-8/+47
Jeremy. (This used to be commit 15ae2c335b52e34c06d8f4f9ebad28078292b208)
2000-12-14Renamed parameters and variables called acl to the_acl as it conflictsTim Potter3-28/+28
with a Solaris system call. (This used to be commit 5e547ddcb526be5562db9213c5b36e505e735a2e)
2000-12-14Updated smbcacls documentation.Tim Potter3-28/+237
(This used to be commit bd87398b5a9421add8db8b455d02ccd6b2624f58)
2000-12-14Cache lsa connection and policy handle for resolving names and sids.Tim Potter1-48/+56
(This used to be commit 09d2d972fd6f70bdf62f25936494968ef597b98b)
2000-12-13inverted dword valueGerald Carter1-1/+1
jerry (This used to be commit 0e5c1df2841ee0dd44bb5c52af90ca98649a4d55)
2000-12-13Changes from APPLIANCE_HEAD:David O'Neill2-15/+20
- trivial typo in definition of enum_printing[] (source/param/loadparm.c) - fixed printer status display bug. When no jobs existed in queue, the clients were not properly notified of printer status. This caused native tools for pausing/unpausing a print queue to not work. (source/printing/printing.c) (This used to be commit c533e77f1912618230a938458980a9339924fe06)
2000-12-13Added proto definition for new RPC calls.Jeremy Allison3-33/+31
Added printing fix from appliance-head. Jeremy. (This used to be commit f4c7f9ddb906b67ee4397e7707309356085476d1)
2000-12-13I think it's time to go home.Tim Potter1-5/+6
(This used to be commit fde66badf143cde40af35e86d55acb48dc754cdd)
2000-12-13OK so I shouldn't have added cli_pipe.o to LIBSMB_OBJ.Tim Potter1-2/+3
(This used to be commit a724850eb83e61450f112c0b2e6e3492c2a72863)
2000-12-13Add libsmb/cli_lsarpc.o and rpc_client/cli_pipe.o to LIBSMB_OBJ. Not soTim Potter1-2/+3
sure about the latter... Modified SMBCACLS_OBJ (This used to be commit c130d5b0f6a23b4fe19accad8a49ac58a1a8b0b1)
2000-12-13Convert names to sids when modifying ACLs. Convert sids to names whenTim Potter1-10/+68
displaying ACLs. (This used to be commit 5001bbc64be62af1597eb334e5b530b415d62a6b)
2000-12-13Lightweight rpc client library. Uses only routines in libsmb andTim Potter1-0/+370
rpc_client/cli_pipe.c Only cli_lsa_open_policy(), cli_lsa_close(), cli_lsa_lookup_names() and cli_lsa_lookup_sids() implemented so far. (This used to be commit 129d5a155a73d926868d74f8447c1e93b429388d)
2000-12-13Server side changes for dynamic names in lsa_lookup_namesTim Potter2-20/+10
(This used to be commit 5c5c3a8a08efe8c2f36a55b1383e9d3dd9eca4a5)
2000-12-13make protoTim Potter3-19/+37
Updates for dynamic sized lookup names/sids (This used to be commit 34743c157632b1784bd15e3ca97380b1f9754e46)
2000-12-13Wrong length for unistr2 in init_q_lookup_names()Tim Potter2-27/+36
Removed some more static arrays and replaced with tallocated memory blocks. (This used to be commit 1db0f31ae00bf9c91eb7d02c96bf766d04c7bdef)
2000-12-13Two tdb bugfixes. First one - ensure that traverse lock is moved before deletingJeremy Allison1-45/+58
dead records, else the record is just marked for deletion, not actually deleted. Second, ensure allocated record is marked as "in use" before free list lock is released, else other processes in the freelist merge code may try and merge it. Jeremy. (This used to be commit dd959fa325c5df8ce0407d8debea76602c8e71cf)
2000-12-13Added support for SERVICESF shared variable to change configuration fileTim Potter1-1/+4
used in lp_load(). (This used to be commit 4d80ee4f41ac3d61579c9cf23cb815d7fe5da5db)
2000-12-12Fixed bug noticed by JF. se_access_check needs user SID as first in token.Jeremy Allison1-10/+23
Jeremy. (This used to be commit f0d7867801e3f78bfc55fdb36ca965e35457f51b)
2000-12-12Fixed processing of dfree script (was truncating).Jeremy Allison1-2/+0
Jeremy. (This used to be commit 1e719a807669876b4d11f4653e9712f25fcba20b)
2000-12-12Brief documentation on using the virtual printer codeDavid O'Neill1-2/+35
(This used to be commit 03dd90ab923ec88cdada8c5d725d9482bd9826f2)
2000-12-12more fixes from Simo. Also fixed the password expiration fieldGerald Carter1-134/+59
in the tdbsam to never expire (we don't support this yet). jerry (This used to be commit 3b7d0fe7eb3a9275d2713d7b3325de0ab510ea62)
2000-12-12Don't print out the security descriptor type as it is automaticallyTim Potter1-7/+1
calculated by the new make_sec_desc() function. (This used to be commit 6fd5dc81458317e106f5ea24958cefe4146c90a6)
2000-12-12Better error checking for ACL parsing.Tim Potter1-7/+21
Print an error when attempting to delete a non-existent ACL. (This used to be commit d119782d0d8d2738650da47fa11134d26134ce17)
2000-12-12Fix error string.Tim Potter1-1/+1
(This used to be commit 73b237e639717019c596954c745b7e4d038ddc8c)
2000-12-12Fixed some accidentally reversed patches.Tim Potter1-115/+411
(This used to be commit fa604bc85ea6989c794747f668be8a4e62527b79)
2000-12-12Compile fix for new arg to create_nt_token()Tim Potter2-3/+7
(This used to be commit 806185ca8cc8d28f16745a1db9427f52eb8d22e4)
2000-12-12Merged in Tim's changes : Removed static limit of MAX_LOOKUP_SIDS in rpc ↵Jeremy Allison6-486/+276
server and client lsa_lookup_names() and lsa_lookup_sids(). Jeremy. (This used to be commit 9e9c71c8b3194b7cd02fea0b6a000d4f2940d905)
2000-12-12Removed the special casing of SIDs in se_access_check. This is now done ↵Jeremy Allison6-434/+555
(correctly) when the NT_USER_TOKEN is *created*. Jeremy. (This used to be commit 27d72ed1cf8ece2bede812341279ba5a7262ace4)
2000-12-12Owner always has READ_CONTROL and WRITE_DAC access.Jeremy Allison1-1/+3
Jeremy. (This used to be commit 05fcb124dfbb1a257828e9dc6a7793fc3dc73c4b)
2000-12-12Sorry Gerald, I think the original code was better (plus safer as I'm sureJeremy Allison1-7/+10
it's working :-). Jeremy. (This used to be commit e18c104ee35d00dcbe2e73e6c9699300a3947364)
2000-12-12Extra part of fix that Gerald missed (sorry).Jeremy Allison1-1/+1
Jeremy. (This used to be commit ebf754400f443452948020d68e29f597f1b2d60c)
2000-12-11subtle bug where files which missed the stat_cache but were addedGerald Carter1-10/+7
to the cache during the look returned a blank stat struct. Made weird occurrences such as... $ smbclient //pogo/print$ smb:\ > cd w32x86 ERROR: Invalid path smb:\ > cd w32x86 smb:\w32x86\ > (This used to be commit 8938dc183112b039c21a5a0beadb60068a8c5b00)
2000-12-11Fix for short names not being returned correctly with non-mangled shares.Jeremy Allison1-1/+2
Jeremy. (This used to be commit bcf0a5c316ee8cf333d9d838b041e44a11cb5f1b)
2000-12-11Fixed very subtle bug returning correct error on an open, when we haveJeremy Allison2-10/+91
a choice of invalid share mode and access denied. We must return the access denied by preference, but also remember to break the oplocks... This is needed for multi-user MS-Access. Jeremy. (This used to be commit 7eb7241442ea0f1e065b009c3cccd5821b89a8b6)
2000-12-11Adding in debug for SD's.Jeremy Allison2-0/+48
Jeremy. (This used to be commit a19f936b644fedc4c59ada5f12172abed9894910)
2000-12-11code review of rpcclientGerald Carter1-159/+140
o added some comments o abstracted a few code bits o cleaned up some code by removing unused code paths -- jerry (This used to be commit 679453af36c06ae9c82dd20742a56272ec73f427)
2000-12-11type for client_info structGerald Carter1-2/+2
(This used to be commit 2c03b91d6041082bba6ba4322ed41b4378af7ef3)
2000-12-11new version of Get_Pwnam()Gerald Carter1-52/+50
o check the username in all lowercase o check the username as transmitted if this would be a different case o check the username in all upper case if this is a new version -- jerry (This used to be commit 059f4fee5d8ad72cd699995c660263ed2cc4f25f)
2000-12-11return NULL instead of return False in char *prs_mem_get();Tim Potter1-1/+1
(This used to be commit 71e5e802b78b22af9be7d3e84e869f311937e542)
2000-12-11Added Tim's fix for read-only crashes.Jeremy Allison1-0/+2
Jeremy. (This used to be commit cfc62fecdf4c5579ee643df3e701cf6f1fe553ee)
2000-12-11new prototypesAndrew Tridgell2-482/+384
(This used to be commit 2258a62365e6fa3f08fd3b911e13b391515eaa46)
2000-12-11added support for browsing the list of workgroups at the top level inAndrew Tridgell2-57/+77
smbw (This used to be commit 8f97d59186ee3b52f623d30dfb7b195ec721ec0c)
2000-12-11exposed the broadcast name resolution routine outside namequery.cAndrew Tridgell1-4/+4
(This used to be commit 7d1d867acdc0f316d8de787e1f7fa27667ec4a6a)
2000-12-09group rid assignment cut and paste errorGerald Carter1-2/+2
--jerry (This used to be commit bb48b02d5f2118470a415d5f1f92305688e6b432)