Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2010-02-14 | s3-lib: use TYPESAFE_QSORT() in s3 interfaces code | Andrew Tridgell | 1 | -1/+1 | |
2010-02-14 | lib: use TYPESAFE_QSORT() in lib/ and libcli/ | Andrew Tridgell | 2 | -6/+6 | |
2010-02-14 | s3-includes: enable TYPESAFE_QSORT() in s3 | Andrew Tridgell | 1 | -0/+1 | |
2010-02-14 | s4-ldb: use TYPESAFE_QSORT() in the rest of the ldb code | Andrew Tridgell | 6 | -12/+23 | |
2010-02-13 | s4:loadparm.c - prevent memory leaks | Matthias Dieter Wallnöfer | 1 | -0/+3 | |
If a "logfile" was already set, free the content up before setting a new location. This can happen on a loadparm reload. | |||||
2010-02-13 | s4:loadparm.c - the logfile parameter value needs to be duplicated | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
Otherwise the "logfile" pointer tracks all changes of "pszParmValue" which content is only temporal. This was the cause of bug #6212. | |||||
2010-02-13 | s4:popt_common.c - fix intendation | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
2010-02-13 | s4:util.c - Corrected the location of the "Directory Service" object | Matthias Dieter Wallnöfer | 1 | -1/+1 | |
I wonder why nobody noticed this since for sure this "tombstone" functionality was broken till now. | |||||
2010-02-13 | s4:server.c - use always "return" instead of "exit" in the ↵ | Matthias Dieter Wallnöfer | 1 | -4/+4 | |
"binary_smbd_main" function Just to be consistent - no functional change | |||||
2010-02-13 | libwbclient: Fix s4 build failure by fixing up includes. | Kai Blin | 6 | -3/+4 | |
Sorry about this, folks. | |||||
2010-02-13 | s3: Fix Coverity ID 629: DEADCODE | Volker Lendecke | 1 | -3/+0 | |
We have already returned if (argc < 1) above | |||||
2010-02-13 | s3: Fix bug 5198 -- parse chfn(1)-change gecos field | Volker Lendecke | 1 | -1/+34 | |
2010-02-13 | s3: Fix typo found by jhell <jhell@DataIX.net> | Volker Lendecke | 1 | -2/+2 | |
2010-02-13 | libwbclient: Separate out the async functions | Kai Blin | 11 | -1769/+2078 | |
2010-02-13 | s3: Remove unused comparison fn from "struct sorted_tree" | Volker Lendecke | 3 | -10/+4 | |
2010-02-13 | s3: Make adt_tree data definitions private to adt_tree.c | Volker Lendecke | 2 | -16/+15 | |
2010-02-13 | s3: SORTED_TREE -> struct sorted_tree | Volker Lendecke | 3 | -14/+16 | |
2010-02-13 | s3: TREE_NODE -> struct tree_node | Volker Lendecke | 2 | -17/+23 | |
2010-02-13 | s3: Fix some nonempty blank lines | Volker Lendecke | 1 | -69/+68 | |
2010-02-13 | use ZERO_STRUCT | Volker Lendecke | 1 | -1/+2 | |
2010-02-13 | Use ZERO_STRUCTP | Volker Lendecke | 1 | -1/+1 | |
2010-02-13 | s3: Fix a typo | Volker Lendecke | 1 | -1/+1 | |
2010-02-13 | s3: Fix a C++ warning | Volker Lendecke | 1 | -1/+1 | |
2010-02-13 | s4-smbd: fix crash in notify code on client termination | Andrew Tridgell | 1 | -2/+2 | |
We need to free the lp_ctx after we free the event context, otherwise the teardown code in the notify backend dies when it tries to use the iconv_convenience ptr Fixes bug 7053 | |||||
2010-02-13 | s4-rpc: be more careful about DCERPC auth padding | Andrew Tridgell | 6 | -137/+107 | |
Cope with a wider range of auth padding in dcerpc bind_ack and alter_context packets. We now use a helper function that calculates the right auth padding. | |||||
2010-02-13 | s4: use LDB_TYPESAFE_QSORT() instead of ldb_qsort() | Andrew Tridgell | 6 | -16/+8 | |
2010-02-13 | s4-ldb: added LDB_TYPESAFE_QSORT() | Andrew Tridgell | 1 | -0/+18 | |
Like TYPESAFE_QSORT() but for the ldb_qsort() function | |||||
2010-02-13 | s4-wrepl: use TYPESAFE_QSORT() in wins repl code | Andrew Tridgell | 1 | -1/+2 | |
2010-02-13 | s4-torture: use TYPESAFE_QSORT() in smbtorture | Andrew Tridgell | 4 | -26/+15 | |
2010-02-13 | s4-rpcserver: use TYPESAFE_QSORT() in rpc servers | Andrew Tridgell | 3 | -24/+19 | |
2010-02-13 | s4-ntvfs: use TYPESAFE_QSORT() in notify code | Andrew Tridgell | 1 | -3/+2 | |
2010-02-13 | s4-socket: use TYPESAFE_QSORT() in netif code | Andrew Tridgell | 1 | -1/+2 | |
2010-02-13 | s4-auth: use TYPESAFE_QSORT() in gensec | Andrew Tridgell | 1 | -1/+2 | |
2010-02-13 | s4-dsdb: use TYPESAFE_QSORT() in dsdb code | Andrew Tridgell | 7 | -52/+28 | |
2010-02-13 | tdb: use fdatasync() instead of fsync() in transactions | Andrew Tridgell | 1 | -1/+1 | |
This might help on some filesystems | |||||
2010-02-13 | libreplace: add fdatasync() if not available | Andrew Tridgell | 2 | -1/+5 | |
2010-02-13 | util: added TYPESAFE_QSORT() macro | Andrew Tridgell | 1 | -0/+38 | |
This makes it much harder to get the type of a qsort comparison function wrong. | |||||
2010-02-13 | tdb: Apply some const, just for clarity | Volker Lendecke | 1 | -1/+1 | |
2010-02-12 | Use sec_initial_uid() in the places where being root doesn't matter, | Jeremy Allison | 5 | -5/+5 | |
and 0 in the places where it does. Jeremy | |||||
2010-02-12 | Simplify the logic in make_connection_snum(), and make it match Windows ↵ | Jeremy Allison | 1 | -41/+63 | |
behavior. Cause all exit paths to go through one place, where all cleanup is done. change_to_root_user() for pathname operations that should succeed if the path exists, even if the connecting user has no access. For example, a share can now be defined with a path of /root/only/access (where /root/only/access is a directory path with all components only accessible to root e.g. root owned, permissions 700 on every component). Non-root users will now correctly connect, but get ACCESS_DENIED on all activities (which matches Windows behavior). Previously, non-root users would get NT_STATUS_BAD_NETWORK_NAME on doing a TConX to this share, even though it's a perfectly valid share path (just not accessible to them). This change was inspired by the research I did for bug #7126, which was reported by bepi@adria.it. As this is a change in a core function, I'm proposing to leave this only in master for 3.6.0, not back-port to any existing releases. This should give us enough time to decide if this is the way we want this to behave (as Windows) or if we prefer the previous behavior. Jeremy. | |||||
2010-02-12 | Fix warning messages on compile in g_lock.c Volker & Michael please check. | Jeremy Allison | 1 | -14/+4 | |
Jeremy. | |||||
2010-02-12 | Fix error in docs. Should be milliseconds, not microseconds. | Jeremy Allison | 1 | -1/+1 | |
2010-02-12 | s3/smbd: change locking behavior when "lock spin time = 0". | Steven Danneman | 2 | -7/+16 | |
The "lock spin time" parameter mimics the following Windows setting which by default is 250ms in Windows and 200ms in Samba. HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Services\LanmanServer\Parameters\LockViolationDelay When a client sends repeated, non-blocking, contending BRL requests to a Windows server, after the first Windows starts treating these requests as timed blocking locks with the above timeout. As an efficiency, I've changed the behavior when this setting is 0, to skip this logic and treat all requests as non-blocking locks. This gives the smbd server behavior similar to the 3.0 release with the do_spin_lock() implementation. I've also changed the blocking lock parameter in the call from push_blocking_lock_request() to true as all requests made in this path are blocking by definition. | |||||
2010-02-12 | Remove #if SOFTLINK_OPTIMIZATION code. | Jeremy Allison | 1 | -17/+0 | |
This hasn't been turned on or been capable of doing so for many years now. Makes this jumbo function smaller... Jeremy. | |||||
2010-02-12 | Revert "Fix bug #7126 - [SMBD] With access denied error smbd return wrong ↵ | Jeremy Allison | 1 | -16/+9 | |
NT_STATUS_OBJECT_PATH_INVALID error" This reverts commit 2fdd8b10c6abadd27c579e772c0482214d2363a5. This fix is incorrect. The original code works as desired, I made a mistake here. Jeremy. | |||||
2010-02-12 | Fix bug #7126 - [SMBD] With access denied error smbd return wrong ↵ | Jeremy Allison | 1 | -9/+16 | |
NT_STATUS_OBJECT_PATH_INVALID error As tridge's comment says, we should be ignoring ACCESS_DENIED on the share path in a TconX call, instead allowing the mount and having individual SMB calls fail (as Windows does). The original code erroneously caught SMB_VFS_STAT != 0 and errored out on that. Jeremy. | |||||
2010-02-12 | packaging(RHEL-CTDB): adapt configure.rpm to match the spec-file configure call | Michael Adam | 1 | -1/+2 | |
Michael | |||||
2010-02-12 | v3-4-ctdb: Do not do any logrotation | Volker Lendecke | 1 | -5/+2 | |
2010-02-12 | s3:registry: eliminate race condition in creating/scanning sorted subkeys | Michael Adam | 1 | -0/+17 | |
Called, from key_exists, scan_sorted_subkeys re-creates the sorted subkeys record of the given key and then searches through it. The race is that between creation and parsing of the sorted subkey record, another process that stores some other subkey of the same parent key will delete the sorted subkey record, resulting in an WERR_BADFILE of an operation that should actually succeed. This patch fixes the issue by wrapping the creation and parsing into a transaction. Michael | |||||
2010-02-12 | s3:make "net conf addshare" atomic by wrapping all writes in one transaction | Michael Adam | 1 | -6/+36 | |
Michael |