summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2011-03-28Fix inspired by work done by David Disseldorp for bug #8040 - smbclient ↵Jeremy Allison7-26/+73
segfaults when a Cyrillic netbios name or workgroup is configured. Change msrpc_gen to return NTSTATUS and ensure everywhere this is used it is correctly checked to return that status. Jeremy.
2011-03-28s3: Fix Coverity ID 2143: DEADCODEVolker Lendecke1-4/+0
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Mon Mar 28 12:06:19 CEST 2011 on sn-devel-104
2011-03-28s3: Fix Coverity ID 2143: DEADCODEVolker Lendecke1-4/+0
2011-03-28s3: Fix Coverity ID 2173: FORWARD_NULLVolker Lendecke1-1/+1
2011-03-28Revert "Change strict allocate to default to true.Stefan Metzmacher2-7/+6
This reverts commit ecf48af135e4c1ebc5aafe4b3dad785162f5949a. This makes Samba unusable on systems without Linux and a modern Filesystem. This was discussed with Jeremy on IRC: http://irclog.samba.org/2011/01/20110126-Wed.log metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Mon Mar 28 09:00:09 CEST 2011 on sn-devel-104
2011-03-27s3: Fix Coverity ID 2188: MISSING_BREAKVolker Lendecke1-0/+2
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sun Mar 27 23:11:10 CEST 2011 on sn-devel-104
2011-03-27s3: Fix Coverity ID 2189: MISSING_BREAKVolker Lendecke1-1/+3
2011-03-27tdb: Fix Coverity ID 2192: NO_EFFECTVolker Lendecke1-1/+1
(ret < 0) can never be true
2011-03-27s3: Fix Coverity ID 2195: NO_EFFECTVolker Lendecke1-1/+1
level is unsigned
2011-03-27librpc: Add some error checking to dcerpc_floor_pack_rhs_if_version_dataVolker Lendecke1-1/+5
2011-03-27librpc: Fix Coverity ID 2198: NULL_RETURNSVolker Lendecke1-3/+14
2011-03-27s3: Fix Coverity ID 2200: NULL_RETURNS (cut&paste error)Volker Lendecke1-1/+1
2011-03-27s3: Fix Coverity ID 2228: RESOURCE_LEAKVolker Lendecke1-0/+1
Holger, please check!
2011-03-27s3: Fix Coverity ID 2226: RESOURCE_LEAKVolker Lendecke1-0/+1
Holger, please check!
2011-03-27s3: Fix Coverity ID 976: BAD_SIZEOFVolker Lendecke1-1/+1
2011-03-27s3: Fix Coverity ID 958: BAD_SIZEOFVolker Lendecke1-1/+1
This is supposed to wipe out the md5 context, not only the first bytes of it. Others, please check!
2011-03-27s3: Fix Coverity ID 682: NEGATIVE_RETURNSVolker Lendecke1-1/+4
2011-03-27s3: Fix Coverity ID 590: DEADCODEVolker Lendecke1-4/+0
2011-03-27s3: Fix Coverity ID 585: NEGATIVE_RETURNSVolker Lendecke1-1/+1
2011-03-27s3: Fix Coverity ID 513: UNINITVolker Lendecke1-1/+1
2011-03-27s3: Fix Coverity ID 83: RESOURCE_LEAKVolker Lendecke1-0/+3
2011-03-27s3: Convert cli_raw_tcon to cli_smbVolker Lendecke2-26/+24
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sun Mar 27 19:50:21 CEST 2011 on sn-devel-104
2011-03-27s3: Fix a memleakVolker Lendecke1-0/+2
2011-03-27s3: Replace a use of cli_errstrVolker Lendecke1-1/+1
2011-03-27s3: Replace cli_negprot_sendsync() by cli_negprot_send()Volker Lendecke3-38/+22
2011-03-27s3: Remove a pointless staticVolker Lendecke1-1/+1
2011-03-27s3: Remove a use of cli_send_smbVolker Lendecke3-39/+50
2011-03-27s3: Remove two calls to cli_errstrVolker Lendecke1-4/+8
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sun Mar 27 13:17:47 CEST 2011 on sn-devel-104
2011-03-27s3: Fix Coverity ID 2296: UNUSED_VALUEVolker Lendecke1-3/+0
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sun Mar 27 12:12:35 CEST 2011 on sn-devel-104
2011-03-27s3: Fix Coverity ID 2327: FORWARD_NULLVolker Lendecke1-0/+2
Make check_ft_info robust against an invalid type. Günther, please check!
2011-03-27s3: Fix Coverity ID 2328: FORWARD_NULLVolker Lendecke1-0/+3
Make startsmbfilepwent robust against an invalid open type
2011-03-27s3: Fix Coverity ID 2329: RESOURCE_LEAKVolker Lendecke1-0/+1
2011-03-27s3: Fix Coverity ID 2330: RESOURCE_LEAKVolker Lendecke1-0/+1
2011-03-27s3: Fix Coverity ID 2331: RESOURCE_LEAKVolker Lendecke1-0/+1
2011-03-26s3: Fix an uninitialized variable readVolker Lendecke1-1/+2
The "is_valid_policy_handle" in the exit path reads uninitialized data Lets see if this fixes Coverity ID 2172 which complains about h being dereferenced in the dcerpc_winreg_CloseKey. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sat Mar 26 14:24:28 CET 2011 on sn-devel-104
2011-03-26s3: Fix Coverity ID 2326, CHECKED_RETURNVolker Lendecke1-1/+1
2011-03-26Revert "Fix bug 8021 - Incorrect string termination in volume/volume_name ↵Jeremy Allison1-1/+1
for TRANS2-QUERY_FS_INFO/Info Volume." This reverts commit 042aafb87df6c05877b8fc7ef0d44877689d860a. I need to test against OS/2 to see if this is something Win28K breaks for older clients before allowing this. Jeremy. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sat Mar 26 01:19:55 CET 2011 on sn-devel-104
2011-03-25Fix bug 8040 - smbclient segfaults when a Cyrillic netbios name or workgroup ↵Jeremy Allison1-2/+23
is configured. As discovered by David Disseldorp <ddiss@suse.de>, convert_string_talloc() doesn't always return consistent results for a zero length string. The API states an incoming string must *always* contain the terminating null, but unfotunately too much code expects passing in a zero source length to return a null terminated string, so at least ensure we return a correct null string in the required character set and return the correct length. Also ensure we cannot return a zero length for a converted string (we ensure that the returned buffer is always allocated and zero terminated anyway) as calling code depends on the fact that returning true from this function will *always* return a non-zero length (as it must include the terminating null). Jeremy. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Mar 25 23:25:40 CET 2011 on sn-devel-104
2011-03-25s3-netapi: fix memoryleak while not using talloc_tos() in ↵Günther Deschner2-6/+6
cli_get_session_key() usage. Thanks Volker! Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Fri Mar 25 18:21:18 CET 2011 on sn-devel-104
2011-03-25s3: Compile IDL files in autogen, some configure tests need thisVolker Lendecke2-0/+12
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Fri Mar 25 16:35:30 CET 2011 on sn-devel-104
2011-03-25Revert "s3-includes: fixed CONST_DISCARD() to actually discard const"Volker Lendecke1-1/+1
This reverts commit 37261928bec145f4cbd85f3e409063563c00ac9e. In source3 this creates a warning of the form passdb/pdb_ldap.c:4565: warning: passing argument 2 of ‘pull_utf8_talloc’ from incompatible pointer type include/proto.h:444: note: expected ‘char **’ but argument is of type ‘char ***’ for every use of CONST_DISCARD. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Fri Mar 25 13:16:35 CET 2011 on sn-devel-104
2011-03-25charcnv: ensure convert_string_error doesn't conflict with s3 functionAndrew Tridgell1-5/+5
use _handle for handle based functions Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Fri Mar 25 05:22:24 CET 2011 on sn-devel-104
2011-03-25s3-charcnv: fixed converted_size return in fast pathsAndrew Tridgell1-9/+20
2011-03-25s3-charcnv: removed unused functionAndrew Tridgell2-8/+0
lp_failed_convert_char() is not needed any more
2011-03-25lib/util/charset rename iconv_convenience to iconv_handleAndrew Bartlett15-108/+108
This better reflects what this structure is Andrew Bartlett
2011-03-25s3-charcnv: convert_string_internal() should not display errorsAndrew Tridgell1-31/+4
debug error display happens in the convert_string() outer function
2011-03-25s3-string: removed the conv_silent globalAndrew Tridgell1-29/+17
use convert_string_error() instead Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-25s3-string: removed last use of conv_silentAndrew Tridgell1-31/+11
This replaces the push_ascii_nstring() implementation with a call to convert_string_error() Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-25s3-charcnv Add convert_string_error()Andrew Bartlett2-18/+75
This function returns errors rather than printing them. Andrew Bartlett
2011-03-25charcnv: added convert_string_error()Andrew Tridgell1-33/+57
this will allow us to remove conv_silent Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
generated by cgit (git 2.34.1) at 2024-12-02 23:02:42 +0000