Age | Commit message (Collapse) | Author | Files | Lines |
|
NBT server code remains reabable. Also fixed the copyright header to
include Volker, as he wrote the getdc server function
(This used to be commit a973197d3e0045a76a2f14153f5541b9e36e6c8a)
|
|
problem was that the return string was declared as:
[out] astring dcname
which means "this is a non-NULL string". The server code sometimes
returned NULL however (on getdc lookup failure), which caused the NDR
marshalling code to crash. When you declare a non-pointer return value
you are promising that the value can never be NULL.
The trivial fix is to use:
[out] astring *dcname
which leaves the API alone, but includes a pointer in the wire format,
which in turn means it is valid to send a NULL string as a response.
(This used to be commit e39bac61960f6ce8957f148a482e39499a8e9096)
|
|
(This used to be commit 2c3a9f04db5d61305f4eca8b44e33c2dd15a6dc4)
|
|
SAMLOGON test.
The semantics for the user account are very odd, the old password is
still valid, but the session keys appear to be blanked out.
Andrew Bartlett
(This used to be commit bbfaf4821d81116efa91313655acb75d6f577953)
|
|
fault...
Andrew Bartlett
(This used to be commit 0fa6d040f287dbf6b0588e3507d53037a04f85d4)
|
|
Andrew Bartlett
(This used to be commit 732b247a498e0b90b9f0c711baaac51ad6402496)
|
|
pipe is safe while inside a rpc callback
(This used to be commit 5d752a519416c7a0c8c7d166f43eadc75cb5c37f)
|
|
within a callback on the pipe. This should fix a problem volker
encountered with winbind. The fix invoolves making the recv_data
handler free the memory for a packet, instead of having the transport
layer free it after calling recv_data. When the transport layer freed
it, it had no way of knowing if the callback had shutdown the pipe, so
it had no way of knowing if it could safely use the pointer.
Also changed the pipe shutdown hook for the smb transport to use an
async SMB close. This ensures that when you shutdown the pipe, you
don't block waiting for the server to ack the close of the pipe fnum.
(This used to be commit c87d7f580e39245db181605f50883de07dd9632e)
|
|
(This used to be commit 9fac8dfeb393212e16be7156de466077bc90232d)
|
|
that is what most of the callers want anyway.
Remove and re-add the account for the torture case, rather than just
modify it.
Test with a user account (needs work to change the password).
Andrew Bartlett
(This used to be commit 38bebef02454164cbe882347d80e03abee656205)
|
|
Also return an indication of if the join was of a new account, or
reworking an existing account.
Andrew Bartlett
(This used to be commit b6e4b36c4f1f90e42dd0543538956a1d89e3724b)
|
|
Andrew Bartlett
(This used to be commit b1bcc0dc0b3c6d4d931100dee21ba16cb5521978)
|
|
RPC parsers. Currently the following files can be generated:
- include/rpc_BASENAME.h
- rpc_server/srv_BASENAME.c
- rpc_server/srv_BASENAME_nt.c (template only, user has to fill in functions)
- rpc_client/cli_BASENAME.c
- rpc_parse/parse_BASENAME.c
So far, I have been working on getting DFS working. Currently still to do
(all in rpc_parse/parse_BASENAME.c):
- Proper handling of declarations
- Proper handling of scalar/buffer parts of structs and unions
- Subcontexts
- Proper handling of arrays
- Support for custom (non-scalar) types
I hope to have a somewhat more working version later this week.
Some files as currently generated are available from:
http://samba.org/~jelmer/pidl_samba3/
(This used to be commit 8af8eaeeef6d46f4d25ccb1d25890e1eef063e4f)
|
|
queryinfopolicy. Idea is to get a consistency check between that and our
notion of the domain name and sid, and take the lsa pipe as the holder of the
central smbcli_tree that netlogon and samr use as well.
Volker
(This used to be commit 126c80aefc4f53c4ba79afc12d70602ef9055ddb)
|
|
around
prevents the memory from being freed.
Thanks,
Volker
(This used to be commit df8eeb01f498568207a4a8d5d12348c473f41799)
|
|
(This used to be commit d18f7edf92e8420f30cae01649d18f0ae20a80aa)
|
|
(This used to be commit a7137fd3ec2e484c8feb73fa228031c8b75107bf)
|
|
(This used to be commit 820b4180dd3c1d07dd529fcb654ea01407a481cb)
|
|
proper fix
for it pending.
Also fix a bug with timed events: Don't call the same event recursively in the
handler's inner semi-async event loop.
Volker
(This used to be commit e38e50127a3414461578421e676a9c58c106c272)
|
|
Tridge, if you have time, you might want to look at the segfault I was still
seeing. Now I store the handle to the netlogon pipe in the global winbind
state and free it on the next entry into check_machacc. The problem seems to
be that talloc_free()ing a pipe struct from within a callback function on that
pipe is not possible. I think I can live with that, but it has been not really
obvious. To reproduce the segfault you might want to look at putting a
talloc_free(state->getcreds->out.netlogon) into
wbsrv_samba3_check_machacc_receive_creds. This is called from a dcerpc
callback function.
In particular if the check failed it would be nice if I could delete the pipe
directly and not post a different event to some winbind queue.
I tried to delete the pipe from a timed event triggered immediately, but this
also fails because the inner loop seems to hit the same event again, calling
it twice.
Volker
(This used to be commit 5436d7764812bb632ba865e633005ed07923b57f)
|
|
ensures
destructors hanging off the stream connection don't trip more socket
events.
this should help with the problem volker described
(This used to be commit fd8eccd5bf0c742a7809f3991101f4ac75b5e037)
|
|
Volker
(This used to be commit 42ff218ac98fab00bd58c4f50f11843ef32b4698)
|
|
rafal
(This used to be commit b3b4059efeb7f5d2795b4bb93cf8ab95aad54c8e)
|
|
Also a bit of formatting.
rafal
(This used to be commit 1fefca2c172085d6bc05bfac1c10e52066e42606)
|
|
Fix push for non-fixed length strings
(This used to be commit 821b0bb56f6d6b9df7bbdeeddc206505f3f0a7c2)
|
|
once, use the
first one that replies correctly.
Add a talloc context to smb_composite_connect()
Volker
(This used to be commit 6b88de182e40cb00a833c085f801fd47c92bbe94)
|
|
Volker
(This used to be commit c7557884843a5b2bac9e21ec81cafcaadf436bca)
|
|
Andrew Bartlett
(This used to be commit 5b2114bb9c604e8d36887e1131175da327eabc84)
|
|
'make test'
I also think the method of getting rid of pstring isn't the right
one. I certainly do want to get rid of pstring/fstring, but the reason
for removing them is the use of arbitrary sized fixed length strings
on the stack and in structures. Changing to another fixed length stack
string format isn't really a win, and moving to use strncpy() is
actually worse than pstrcpy() as strncpy() has the absolutely awful
semantics of always zeroing all remaining bytes, so it ends up taking
a lot of cpu doing pointless memory writes.
I'd rather move to more use of asprintf()/talloc_asprintf() and
similar functions for dynamic string allocation.
You also have to be very careful about some of these system defined
string limits. One some systems PATH_MAX could be 64k or even larger,
which can quickly blow the stack out when you allocate a few of them.
(This used to be commit 194efd26e42d621b239052ed1fec8da916bd2144)
|
|
(This used to be commit fd6d895ebdb201ac6afaf5c8ec84d003765cdff6)
|
|
(This used to be commit 26ff53857802ae4a63f2b6e46c9caa7ca2fbbe89)
|
|
directly, and expression based searches are converted to trees. This
makes for less conversions.
- allow the caller to supply a set of credentials via the ldb opaque
name 'credentials'. I will be using this in my ldb proxy module.
(This used to be commit af24f3d7faac6ef74feef73a23345d8c484da07c)
|
|
in the expression parsing code
(This used to be commit 0d4a900ce5705856d61c6dd4ccb8fdbd049d22b7)
|
|
(This used to be commit dc3dc796746de672dbf3ad0e4715e8b30ae4afb7)
|
|
(This used to be commit 57cfbe51e61e27098fad3f9b1113c6f8f69f9a55)
|
|
(This used to be commit ecef1ee6cd0bdae2fcbff3f57edaa26eb72f3481)
|
|
that the update or inform should be propagaded to all servers
metze
(This used to be commit 33c7c101c024818694830ac11fefe70bd2edb1d4)
|
|
directory now looks like the config.mk file but with different
punctuation.
The only weird bit is that it creates a proto.h file for each subsystem.
(This used to be commit 09d4abecb01fa9159243cfcb33051092f92cef3b)
|
|
(This used to be commit c394a4a602edba49f00252d0376050c0bdc2f6a8)
|
|
(This used to be commit e80d42933fe3cbc18cb229e47fffb9ca8068aca5)
|
|
of an existing socket, that is needed to handle WREPL_REPL_UPDATE
in the server, because we need to flig the connection and act as client on it
metze
(This used to be commit 131e5dfe695d427e992b840439743f880b14d82d)
|
|
to build the talloc hierachie correct
metze
(This used to be commit afd9dda5773d381550bdb061a8e345b33e1fc371)
|
|
rafal
(This used to be commit ef29863d999089c47140bd37731c60659a200421)
|
|
rafal
(This used to be commit 7b3a4096b5922e4a98ea0a74c0b92bc10d18cddd)
|
|
rafal
(This used to be commit 0e45dc3bac0e699b2da5b7f8df9d4bf7bd80a0f5)
|
|
rafal
(This used to be commit 426797f7b0d0321f6842db0b8d94c193726e8008)
|
|
- the unknown flag 0x10 seems to mean that this name was localy registered on this
currently asked server, that flag is not present in replica records
metze
(This used to be commit ba3685c41dc934692bd653f4fe9c0ee451146c40)
|
|
make wrepl_nbt_name a scalar type that is another
wire representation of struct nbt_name
give wrepl_name->flags a meaning
metze
(This used to be commit 5fa13d6c2bd4cff9540ee97b3aa4c8a9c8e51fc5)
|
|
- add wrepl_nbt_name scalar type and do the pull/push in the ndr layer
instead of the caller
- give the flags and group_flag in the wrepl_name a meaning
metze
(This used to be commit b98efc2905e1147eb97111b46a877bdb9d8dd154)
|
|
(This used to be commit 441419a08f0845af2b4c8023e1e5bcfda24a6d62)
|