Age | Commit message (Collapse) | Author | Files | Lines | |
---|---|---|---|---|---|
2011-03-16 | s3: Fix Coverity ID 2232, REVERSE_INULL | Volker Lendecke | 1 | -2/+4 | |
No point checking for !cli after dereferencing it | |||||
2011-03-16 | s3: Fix Coverity ID 2233, REVERSE_INULL | Volker Lendecke | 1 | -1/+1 | |
We have dereferenced h already in dcerpc_lsa_open_policy2 in line 425 | |||||
2011-03-16 | s3: Fix Coverity ID 2234: REVERSE_INULL | Volker Lendecke | 1 | -2/+2 | |
We have dereferenced "b" already in dcerpc_samr_Connect2 in line 521 | |||||
2011-03-16 | s3: Fix Coverity ID 2140, DEADCODE | Volker Lendecke | 1 | -1/+1 | |
This routine was never executed after f0dcc90f because "netname" was always NULL. Jeremy, please check! | |||||
2011-03-16 | s3: Fix Coverity ID 2144, DEADCODE | Volker Lendecke | 1 | -1/+1 | |
We could never have assigned the real value in line 481. Andreas, please check! | |||||
2011-03-16 | s3: Fix Coverity ID 2147, FORWARD_NULL | Volker Lendecke | 1 | -1/+1 | |
How could this ever have worked??? | |||||
2011-03-16 | s3: Fix Coverity ID 2148, FORWARD_NULL | Volker Lendecke | 1 | -3/+2 | |
Further down we unconditionally reference *info | |||||
2011-03-16 | s3: Fix Coverity ID 1402: PASS_BY_VALUE | Volker Lendecke | 1 | -11/+11 | |
There's no point in passing GROUP_MAP on the stack Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Mar 16 21:58:08 CET 2011 on sn-devel-104 | |||||
2011-03-16 | s3: Fix Coverity ID 2213, PASS_BY_VALUE | Volker Lendecke | 1 | -6/+6 | |
There's little point to pass a copy of this structure on the stack. Günther, please check! | |||||
2011-03-16 | s3: Fix Coverity ID 1012, CHECKED_RETURN | Volker Lendecke | 1 | -6/+5 | |
This is probably more or less taste. Removing the necessity for a comment is a good thing though IMO. | |||||
2011-03-16 | s3: Fix Coverity ID 1013, CHECKED_RETURN | Volker Lendecke | 1 | -6/+5 | |
This is probably more or less taste. Removing the necessity for a comment is a good thing though IMO. | |||||
2011-03-16 | s3: Fix Coverity ID 1017, CHECKED_RETURN | Volker Lendecke | 1 | -1/+3 | |
Günther, please check! | |||||
2011-03-16 | s3: Fix Coverity ID 1018, CHECKED_RETURN | Volker Lendecke | 1 | -3/+5 | |
2011-03-16 | s3: Fix Coverity ID 1034, CHECKED_RETURN | Volker Lendecke | 1 | -3/+1 | |
In all other places we check the result of secrets_init. | |||||
2011-03-16 | s3: Fix Coverity ID 2100, BAD_SIZEOF | Volker Lendecke | 1 | -1/+1 | |
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Mar 16 18:52:18 CET 2011 on sn-devel-104 | |||||
2011-03-16 | s3: Fix Coverity ID 2317: Uninitialized read | Volker Lendecke | 1 | -1/+1 | |
We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue. | |||||
2011-03-16 | s3: Fix Coverity ID 2318: Uninitialized read | Volker Lendecke | 1 | -1/+1 | |
We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue. | |||||
2011-03-16 | s3: Fix Coverity ID 2319: Uninitialized read | Volker Lendecke | 1 | -1/+1 | |
We passed the structure including the uninitialized elements to dcerpc_winreg_SetValue. | |||||
2011-03-16 | s4-smbtorture: use torture_assert in torture_samba3_rpc_sharesec(). | Günther Deschner | 1 | -23/+18 | |
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Wed Mar 16 17:47:11 CET 2011 on sn-devel-104 | |||||
2011-03-16 | s4-smbtorture: use torture_fail and _assert in torture_samba3_rpc_getusername(). | Günther Deschner | 1 | -48/+16 | |
Guenther | |||||
2011-03-16 | s4-smbtorture: remove explicit mem_ctx from torture_samba3_rpc_getusername(). | Günther Deschner | 1 | -20/+14 | |
Guenther | |||||
2011-03-16 | s3-packet: only include packet.h where needed. | Günther Deschner | 3 | -1/+2 | |
Guenther | |||||
2011-03-16 | s3-interfaces: only include interfaces.h where needed. | Günther Deschner | 5 | -1/+4 | |
Guenther | |||||
2011-03-16 | s3-msdfs: avoid global inclusion of msdfs.h. | Günther Deschner | 5 | -1/+5 | |
Guenther | |||||
2011-03-16 | s4-smbtorture: use torture_assert in samr large-dc test. | Günther Deschner | 1 | -14/+38 | |
Guenther | |||||
2011-03-16 | s3-printing: fix memory leak in print_cups.c | David Disseldorp | 1 | -16/+9 | |
As found by valgrind, tmp_pcap_cache is not freed following printer list tdb update. Signed-off-by: Andreas Schneider <asn@samba.org> Autobuild-User: Andreas Schneider <asn@cryptomilk.org> Autobuild-Date: Wed Mar 16 16:37:58 CET 2011 on sn-devel-104 | |||||
2011-03-16 | s3-printing: remove duplicate cups response processing code | David Disseldorp | 1 | -147/+94 | |
There is currently a lot of duplicate code included for processing responses to CUPS_GET_PRINTERS and CUPS_GET_CLASSES requests. This change splits this code into a separate function. Signed-off-by: Andreas Schneider <asn@samba.org> | |||||
2011-03-16 | s3-printing: use printcap IDL for IPC | David Disseldorp | 3 | -132/+109 | |
Use printcap IDL for marshalling and unmarshalling messages between cups child and parent smbd processes. This simplifies the IPC and ensures the parent is notified of cups errors encountered by the child. https://bugzilla.samba.org/show_bug.cgi?id=7994 Signed-off-by: Andreas Schneider <asn@samba.org> | |||||
2011-03-16 | idl: define printcap IPC message format | David Disseldorp | 3 | -1/+24 | |
Signed-off-by: Andreas Schneider <asn@samba.org> | |||||
2011-03-16 | s4-smbtorture: use torture_fail and _assert macros in torture_netlogon_samba3(). | Günther Deschner | 1 | -30/+16 | |
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Wed Mar 16 15:51:12 CET 2011 on sn-devel-104 | |||||
2011-03-16 | s4-smbtorture: remove explicit mem_ctx from torture_netlogon_samba3(). | Günther Deschner | 1 | -12/+3 | |
Guenther | |||||
2011-03-16 | s4-smbtorture: use torture_fail and _skip in raw.write test. | Günther Deschner | 1 | -54/+30 | |
Guenther | |||||
2011-03-16 | s4-smbtorture: remove duplicate if branch in raw.write test. | Günther Deschner | 1 | -5/+0 | |
Guenther | |||||
2011-03-16 | s4-smbtorture: use torture_fail/-assert api in torture_samba3_hide(). | Günther Deschner | 1 | -59/+26 | |
Guenther | |||||
2011-03-16 | s3-build: stop including ldap and lber headers everywhere in the code. | Günther Deschner | 8 | -51/+67 | |
Instead use new header smb_ldap.h where all LDAP API related things are handled, while smbldap.h only deals with our smbldap_X() API. Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Wed Mar 16 10:54:51 CET 2011 on sn-devel-104 | |||||
2011-03-16 | s3-includes: avoid global include of gssapi headers. | Günther Deschner | 3 | -12/+20 | |
Guenther | |||||
2011-03-16 | s3-libsmb: move smb encryption structs into own header. | Günther Deschner | 7 | -28/+67 | |
Guenther | |||||
2011-03-16 | libcli/security: move display_sec headers to own header file and add to | Günther Deschner | 8 | -10/+40 | |
security.h grouping header. Guenther | |||||
2011-03-16 | s4:ldb: don't install .pc files when building a private library | Stefan Metzmacher | 1 | -2/+6 | |
metze Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Wed Mar 16 09:58:22 CET 2011 on sn-devel-104 | |||||
2011-03-16 | headers: cope with non-system popt in test_headers | Andrew Tridgell | 1 | -1/+4 | |
Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Wed Mar 16 09:09:40 CET 2011 on sn-devel-104 | |||||
2011-03-16 | headers: include Python.h first to avoid warnings | Andrew Tridgell | 1 | -1/+1 | |
2011-03-16 | s3: Fix a cut&paste error in pdb_ads_connect | Volker Lendecke | 1 | -1/+1 | |
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Wed Mar 16 08:22:28 CET 2011 on sn-devel-104 | |||||
2011-03-16 | s3: Use jenkins hash for str_checksum, fix bug 8010 | Volker Lendecke | 1 | -11/+2 | |
From the bugreport: I have a folder with ~90 photos: IMG_XXXX.JPG where XXXX is a four digit number, almost consecutive (photos from camera for one day). Current implementation gives about 30 different checksums for this set of files. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Mar 16 01:15:41 CET 2011 on sn-devel-104 | |||||
2011-03-16 | libcli: openchange doesn't need these headers any more | Andrew Tridgell | 1 | -2/+0 | |
thanks to Simo for pointing this out Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Wed Mar 16 00:25:10 CET 2011 on sn-devel-104 | |||||
2011-03-15 | s3-build: try to silence annoying "Ignoring invalid value 'vlp' for ↵ | Günther Deschner | 2 | -5/+6 | |
parameter 'printing'" warning on the buildfarm. Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Tue Mar 15 23:38:43 CET 2011 on sn-devel-104 | |||||
2011-03-15 | s4-rap: remove last iconv_convenience traces from rap client and test code. | Günther Deschner | 2 | -7/+3 | |
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Tue Mar 15 22:01:51 CET 2011 on sn-devel-104 | |||||
2011-03-15 | s4-rap: decouple rap client code from torture binary, add new LIBCLI_RAP ↵ | Günther Deschner | 10 | -1510/+1567 | |
subsystem. Guenther | |||||
2011-03-15 | s4-smbtorture: check for username and computername presence in ↵ | Günther Deschner | 1 | -1/+20 | |
rap_netsessionenum test. Guenther | |||||
2011-03-15 | s3-libsmb: only include rap client when needed. | Günther Deschner | 20 | -180/+226 | |
Guenther | |||||
2011-03-15 | s3-build: share smbtorture4 build rules with s3-waf build. | Günther Deschner | 3 | -20/+33 | |
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Tue Mar 15 16:10:17 CET 2011 on sn-devel-104 |