summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2011-04-13lib/util/charset Make ASCII conversion validate it's inputAndrew Bartlett1-4/+69
We should not just strip the high bits off unicode strings being converted to ASCII, we need to actually fail the conversion. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13s3-selftest Add workaround for RAP test failureAndrew Bartlett1-0/+2
The rap.sam test reads 0xFFFFFFFF as a string in the level 2 r->HomeDir attribute, which once we start validating ASCII strings fails. This restores a unchecked dos charset for this test only, until it is determined if the client or server RAP code is at fault. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13lib/util/charset Rename convert_string test to allow a 'non_handle' testAndrew Bartlett2-4/+3
A future commit will test (with a subset of tests) the varient of this function without _handle. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13lib/util/charset Add more tests for convert_string_error_handle()Andrew Bartlett1-0/+101
This helps define the semantics of this function very clearly, particularly for partial and invalid inputs. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13lib/util/charset Preserve 'pull' errors even when converting via UTF16Andrew Bartlett1-3/+8
When we do not have a direct iconv handle between any two charsets, we must go iva UTF16. However, we should still return the same buffer and error code as if we were able to go direct - including the partial conversion and the error code. This is important for locating the invalid multibyte character in the stream, for example. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13lib/util/charset Add tests for convert_string_error_handleAndrew Bartlett1-1/+68
These confirm that the errno is set correctly and that we stop on a partial multibyte character Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13lib/util/charset Add expected values for upper/lower case testsAndrew Bartlett1-0/+16
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13lib/util/charset Fix and add public interface for convert_string_error_handleAndrew Bartlett2-7/+14
It makes much more sense for this to match the source3/ interface and return a bool. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13s4/torture Fix calls to charcnv functions to always supply converted_sizeAndrew Bartlett2-2/+3
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13lib/util: Make string_replace from s3 commonAndrew Bartlett3-53/+43
The s4 implementation didn't do multibyte strings, so was only good for '/' which is known to be safe in all multibyte charsets. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13lib/util ucs2_align is identical, put it in commonAndrew Bartlett3-14/+7
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13lib/util Move simple string routines into common code.Andrew Bartlett6-105/+84
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13lib/util/charset Move source3/lib/util_unistr.c to the common code.Andrew Bartlett7-74/+73
This file (largely) contains functions to deal with UTF16 strings. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13s3-lib Move strdup_w to it's only user in mangle_hash.cAndrew Bartlett3-19/+19
Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13s3-lib Move isvalid83_w to mangle_hash.cAndrew Bartlett5-54/+34
This means that there is no need for the 'valid.dat' table to be loaded by anything other than smbd, so the unloader is also removed. The concept of a 'valid dos character' has been replaced by the hash2 mangle method. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13s3-lib make static and remove more _w functionsAndrew Bartlett2-16/+2
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13s3-lib Remove unused #defineAndrew Bartlett1-4/+0
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13s3-lib Remove unused skip_unibuf()Andrew Bartlett2-21/+0
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13s3-lib: Remove unused _w functions.Andrew Bartlett3-226/+1
In general we don't manipulate UTF16 strings internally, particularly as they are also multibyte, so are no easier to work with than UTF8. Andrew Bartlett Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13s3-lib Correct comment in strlen_w()Andrew Bartlett1-1/+1
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13s3-lib Remove more unused fstring.c functionsAndrew Bartlett2-47/+0
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13s3-charcnv: make pull_ucs2 staticAndrew Bartlett2-2/+1
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13s3-lib: Remove unused pull_ucs2_fstring()Andrew Bartlett2-5/+0
Signed-off-by: Andrew Tridgell <tridge@samba.org>
2011-04-13build: use readelf as a replacement for lddAndrew Tridgell1-33/+77
using readelf allows us to do a non-recursive library listing, which is important to remove false positive symbol duplication Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Wed Apr 13 04:37:33 CEST 2011 on sn-devel-104
2011-04-13libds: Make flag_mapping a libraryAndrew Bartlett1-3/+5
This is a tiny library, but otherwise the functions end up in multiple other libraries. Andrew Bartlett
2011-04-13lib/util make UTIL_TDB a libraryAndrew Bartlett1-2/+3
2011-04-13libcli/ldap pull LIBCLI_LDAP_MESSAGE and LIBCLI_LDAP_NDR into a libraryAndrew Bartlett5-22/+14
This reduces symbol duplication Andrew Bartlett
2011-04-13build: speed up SYMBOLCHECK codeAndrew Tridgell1-6/+41
this uses a nm and ldd cache to speed up the duplicate symbol checking code Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-04-12s3: For net ads join, create a krb5.confVolker Lendecke1-0/+5
Signed-off-by: Günther Deschner <gd@samba.org> Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Tue Apr 12 14:10:05 CEST 2011 on sn-devel-104
2011-04-12s3: Initialize output in libnet_JoinVolker Lendecke1-0/+2
Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-12s3: Retry the join with the short nameVolker Lendecke1-0/+5
Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-12s3-util: separate out cmdline helpers.Günther Deschner5-287/+314
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Tue Apr 12 13:06:27 CEST 2011 on sn-devel-104
2011-04-12s3: add some forward declarations.Günther Deschner3-3/+6
Guenther
2011-04-12s3-netapi: use dcerpc_try_samr_connects().Günther Deschner1-4/+18
Guenther
2011-04-12s3-netapi: use libnetapi_get_binding_handle().Günther Deschner6-108/+54
Guenther
2011-04-12s3-netapi: add libnetapi_get_binding_handle().Günther Deschner2-0/+27
Guenther
2011-04-12s3-librpc: let librpc/rpc/dcerpc.h include ndr and generated dcerpc headers.Günther Deschner1-0/+2
Guenther
2011-04-12s3-rpc_client: move rpc_cli_transport structs and protos to rpc_transport.hGünther Deschner6-80/+111
Guenther
2011-04-12s3/selftest Tear down the environment if we fail to connectAndrew Bartlett1-12/+36
This removes the exit(1) that previously didn't tear down the environment correctly, and instead just fails to set it up, allowing the rest of the script handle that with more grace. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Tue Apr 12 01:53:37 CEST 2011 on sn-devel-104
2011-04-11s3-printing: Use become_user_by_session() function.Andreas Schneider1-3/+3
We create a fake connection here and don't have an vuid. So work with the session_info directly here. Signed-off-by: Jeremy Allison <jra@samba.org> Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Mon Apr 11 22:56:12 CEST 2011 on sn-devel-104
2011-04-11s3-smbd: Added a become_user_by_session() function.Andreas Schneider2-0/+19
This uses the provided session_info instead of searching the user via the vuid. This is useful to work with fake connnection you need to create if someone connects directly to a rpc service. Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-11s3-smbd: Added a change_to_user_by_session() function.Andreas Schneider2-74/+98
Signed-off-by: Jeremy Allison <jra@samba.org>
2011-04-11s3: Wrap creating the svcctl keys in a transactionVolker Lendecke1-0/+28
This makes the startup of smbd in make test much quicker and thus more reliable (cherry picked from commit f1aa38b414e97d8687d0bebf65baa384f75301b4) Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Mon Apr 11 22:09:58 CEST 2011 on sn-devel-104
2011-04-11s3: Make reg_backend_db.h includable by itselfVolker Lendecke1-0/+1
(cherry picked from commit 6ba31d3bd29dd11b1b98859f4d8a65d9be7dac60)
2011-04-11s3: Fix Coverity ID 2472, UNINITVolker Lendecke1-2/+1
Signed-off-by: Günther Deschner <gd@samba.org> Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Mon Apr 11 17:14:35 CEST 2011 on sn-devel-104
2011-04-11s3: Fix Coverity ID 2473, UNINITVolker Lendecke1-2/+1
Signed-off-by: Günther Deschner <gd@samba.org>
2011-04-11s3: Fix timeout calculation in event_add_to_poll_argsVolker Lendecke1-1/+1
In the initial phase nmbd does not yet have timed events. This led to nmbd not correctly registering its names in make test and certainly everywhere else. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Mon Apr 11 14:35:45 CEST 2011 on sn-devel-104
2011-04-11s3-modules: Fix debug messageBjörn Baumbach1-1/+1
Print child descriptor instead of parent. Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Mon Apr 11 11:48:42 CEST 2011 on sn-devel-104
2011-04-09Fix bug 8072 - PANIC: create_file_acl_common frees handle two times.Jeremy Allison1-51/+48
Caused by premature optimisation storing the parent ACL on the module handle instead of (correctly) on the file fsp. Previous code wasn't reentrant safe. This is less optimal but doesn't crash in the specific case :-). Jeremy. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sat Apr 9 02:05:15 CEST 2011 on sn-devel-104
2011-04-08Subtle change. Microsoft SMB2 tests return different access mask than for ↵Jeremy Allison1-1/+12
SMB1 with raw.acls.