Age | Commit message (Collapse) | Author | Files | Lines |
|
rpc_server/srv_lsa_hnd.c: Remove back pointer from policy handle list as the pipe
that opened the handle may have been closed. We were dereferencing
into something that had been closed.
rpc_parse/parse_spoolss.c: Sync up with Gerald's changes in 2.2.
lib/replace.c: Don't do proto on setlinebuf as it differs between systems.
Jeremy.
(This used to be commit 887ef3e12dc56b89b2284d42b16a81f03e15110b)
|
|
Jeremy
(This used to be commit 181d41572ceb17dc765d3c0f1a05934e35f56a61)
|
|
replacement
for setlinebuf which apparantly doesn't exist on HPUX 11.
include/byteorder.h:
rpc_parse/parse_prs.c:
Ding Dong the witch is dead ! :-). Ok, I'm happy 'cos I've finally deleted
all the *HORRIBLE* DBG_RW_XXX and RW_XXX macros from include/byteorder.h.
They were macros that included macros that had conditional macros included.
No one understood them (they were the cause of most of the bigendian issue
bugs). Finally, I went into parse_prs.c and inlined all of that stuff with
regular function calls. They're understandable, they're easy to edit and
they don't include macros !
JF - please look at the one comment I added (JF PLEASE CHECK). I have
tested this partly with IRIX (a bigendian system) running with AS/U on
a Solaris box in SGI's lab, and I've also confirmed these new changes
work with W2K (vmware) but there may be the odd bug lurking. Herb, if
you could re-checkout and test again with this code that would help.
Extra. Fixed bug spotted by the sharp eyes of JF - big endian unicode
packet would cause a early truncate of string parsing as we were checking for a char *
0, not a uint16 * 0.
Jeremy.
(This used to be commit 13765eca71e54aa5d048ce36cd8066b8406777c8)
|
|
added srvstr_push_ascii() and srvstr_pull_ascii() as convenience
routines to replace the current usage of strncpy() like fns
for packet pull/push. We need to do this in *lots* of places
in Samba in order to get our codepage handling right
(This used to be commit 8b0e3679a6dc479c0e3177707dff386559779b69)
|
|
smbd/notify_kernel.c: This code was wrong I believe. It was structured to only
return a changenotify event on being called from timeout processing (t != 0).
The kernel changenotify events should fire on *asynchronous* processing (EINTR
return from select caused by the realtime signal delivery) with t == 0.
Reported by Juergen Hasch (Hasch@t-online.de).
ANDREW PLEASE CHECK THIS !
Currently the hash style changenotify is done on async processing as well
as timeout processing. As this is expensive we may want to revisit doing this
and maybe set it to fire only on timeout processing.
Jeremy.
(This used to be commit f952380c5d0cfbbec1e7de98b712952f302cddfd)
|
|
Jeremy.
(This used to be commit fe38692643ad7c163c30d9c031a8bd3dec81ffee)
|
|
when copying to a full disk problem, I discovered that we were not allowing
the delete on close flag to be set properly, this led to other things, and
after investigation of the proper delete on close semantics and their relationship
to the file_share_delete flag I discovered there were some cases where we
weren't doing the deny modes properly. And this after only 5 years working
on them..... :-) :-).
So here's the latest attempt. I realised the delete on close flag needs to
be set across all smbds with a dev/ino pair open - in addition, the delete
on close flag, allow share delete and delete access requested all need to
be stored in the share mode tdb.
The "delete_on_close" entry in the fsp struct is now redundant and should
really be removed. This may also mean we can get rid of the "iterate_fsp"
calls that I didn't like adding in the first place. Whilst doing this patch,
I also discovered we needed to do the se_map_generic() call for file opens
and POSIX ACL mapping, so I added that also.
This code, although ugly, now passes the deny mode torture tests plus the
delete on close tests I added. I do need to add one more multiple connection
delete on close test to make sure I got the semantics exactly right, plus we
should also (as Andrew suggested) move to random testing here.
The good news is that NT should now correctly delete the file on disk
full error when copying to a disk :-).
Jeremy.
(This used to be commit 51987684bd231c744da2e5f3705fd236d5616173)
|
|
Jeremy.
(This used to be commit 54960b9c8d6be6646a0c0e8ef9ee6c61a4b69cf8)
|
|
this and the FILE_SHARE_DELETE flag exactly. The bad news is it means our
share mode handling is broken (again :-).
Jeremy.
(This used to be commit a55ed1a91d91beafb2f199d1da530169715dbe0e)
|
|
delete test explicit.
Jeremy.
(This used to be commit cb5963af0ecabab928aafacd27714e337b9bb37e)
|
|
behaves in this situation.
Jeremy.
(This used to be commit b0266fe0a8c707cb7e818269dc7fe52da709fdab)
|
|
Jeremy.
(This used to be commit 6f7d9e29e4d3a17254ff0ae20c0da63eacded7fe)
|
|
Used in smbtorture mods. Re-cast cli_nt_create() as a call to cli_nt_create_full().
Jeremy.
(This used to be commit f602fa1205e99541e825ccae8502c35cd0e7ccfc)
|
|
Jeremy.
(This used to be commit 3f9cf2e07bb6d429858e47ab6989ea8cf30d0217)
|
|
be returned.
Jeremy.
CVS ----------------------------------------------------------------------
(This used to be commit 5b7f4cf271ad449277c0ea7a825ed4d50205d729)
|
|
(merge from 2.2)
(This used to be commit ea963a648b889da9e47661c61c7fafe13b277e75)
|
|
(This used to be commit 4fc385ca6830cb2ac6198501966088fbed27330e)
|
|
convert names to rids yet.
(This used to be commit cea13dff759dfb7efb5d2a248dd77905e16b1605)
|
|
reporting imaginary "default" inheritable ACLs on directories, otherwise,
when you add an entry and click on apply without noticing there's no
default entry associated with it, it applies a null acl on the files
within the directory (hey, that's what you told NT you wanted, right ! :-).
Also ensure that minimum permissions for a directory are r-x for owner,
not just r--.
Jeremy.
(This used to be commit 4fa8cf68c3921f93a27d290d6dd1ed4423dfcf1c)
|
|
(This used to be commit 0799b272a07cc288be29e0f606b80219e3a029a3)
|
|
(This used to be commit 817258f1174d27d74e8b21ffb5f1384db2238007)
|
|
Also fixed an error return for smbc_rmdir so that we can distinguish
between EACCES and ENOTEMPTY
(This used to be commit f204901fcc11eb3299cc6c7f3793fc3c7bd6bc57)
|
|
Jeremy.
(This used to be commit 13c9823eb19baa4b1262ad0fd416d9ecbc92b160)
|
|
Jeremy
(This used to be commit 40bccf26dbdb88c639d272d511bfce510a43de2a)
|
|
sun1.samba.org is down at the moment so I can't test the compile on this. I'm
sure Solaris people using quotas will scream if I've meesed anything up :-).
Jeremy.
(This used to be commit 3d2c59bfe0bc30d8cecf0af81b74d4232b09bdb2)
|
|
Jeremy.
(This used to be commit 80ce12d95396bac53b2303955e5081d9632cbf55)
|
|
problems with smbd failing to create a log file. If we can't create a log
file keep using the old file.
Jeremy.
(This used to be commit c4e6aa1322fa7bc59708163c42eef6ccbd6c2305)
|
|
Jeremy.
(This used to be commit 55fcd71eecf4477c56fc4a01bda6d452d3b0caa4)
|
|
Jeremy.
(This used to be commit 7c718fc85e3dbfaf0195e352d06a8c682a6036fc)
|
|
(This used to be commit 3a03065b43d073205e421434bc32082c0f9f64da)
|
|
connection fail.
Jeremy.
(This used to be commit 07cee46d1de1caaf6f9f1b6139dd21bcc5d67e8e)
|
|
smb.conf
file in utf8.
Jeremy.
(This used to be commit 42052d6079479452aa43eb37ad3d679d28337779)
|
|
Jeremy.
(This used to be commit 0c9a92a0557b2595e520cbaf2feaa587f9e7502d)
|
|
Jeremy.
(This used to be commit 799e043ae3a4478b9e42604a3d1c88abbb74f047)
|
|
any code that could modify errno is called.
Jeremy.
(This used to be commit 109a174de9e23ccc89ae17d6b5b425b5947c8565)
|
|
Jeremy.
(This used to be commit 4a3d2a13d3b0acab69c27b5b6522575b949eb5e6)
|
|
From Robert Montjoy <Rob_Montjoy@ECECS.UC.EDU>.
Jeremy.
(This used to be commit 1fe60064bddf29fd778918d3f1a7026002029bd7)
|
|
to the places where [f]chmod_acl is called instead.
Jeremy.
(This used to be commit 641ada44ae6429761c1fd0dbcafabc69f897fac7)
|
|
Jeremy.
(This used to be commit d43d907c38008bb02042cb4bc2d899f62bdc115b)
|
|
smbd/vfs.c: Don't call [f]chmod_acl if no acl support.
Jeremy.
(This used to be commit 83f52394e688b4be3ac4cef67d8980a5b8ed3192)
|
|
(This used to be commit b6227751f117ad507838db0cf0032093f6251646)
|
|
Jeremy.
(This used to be commit be825b07464f54d717333318a08154cff632f706)
|
|
advantages:
- memory is trackable by insure
- a very simple talloc_realloc() is possible (I've added it)
It is slower than the previous talloc code, but I don't think that
is going to be a problem. If it is a problem then there are
some ways we can make it faster but I'd like to leave those
until we have tested this a bit and can see what performance
problems might show up in profiling
(This used to be commit 1ab63cf3a6f62c3e4ca19a549bde78dad0eb4340)
|
|
Jeremy.
(This used to be commit 38b19fad2851a65268b31c7e0240ed36a8407be4)
|
|
Jeremy.
(This used to be commit 2f658691e47406f38bec2fc20951f82043fbf894)
|
|
Jeremy.
(This used to be commit 1391aa6a6fbe8391a4421f5770da40556f011bb8)
|
|
First one adds a new info level into the lanman printing and an ioctl to the trans2 code.
Andrew - this uses ASCII only. It looks ok to me but please check !
Second one adds a parameter "os2 driver map" that allows OS/2 driver names to be mapped.
Jeremy.
(This used to be commit da79b519e0b6b4317d7fb5260d74e0e74a7e0b46)
|
|
include/proto.h: Fix missing (void) in proto.
rpc_server/srv_samr_nt.c: Fix user private group problem by filtering out groups that
clash with users.
smbd/posix_acls.c: Ensure default ACE's are sensible.
utils/pdbedit.c: Fix from Simo Sorce.
Jeremy.
(This used to be commit 29414fe0d6665642d9b5f88a35e712426376c47f)
|
|
J.F.
(This used to be commit 287d9fb06899fe7721fdfcd5ccaa566935d31c4d)
|
|
Jeremy.
(This used to be commit 5b9a88c2d0da3479f91131f66ff741e88f9760ee)
|