summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2008-06-19Remove the "current_user" arg from fsp_belongs_connVolker Lendecke3-6/+6
fsp_belongs_conn only used the vuid struct member anyway, and this is available in the smb_request structure as well. (This used to be commit 64e9372ab997739d46669c0cc4a4c6edb11d5e64)
2008-06-19Remove the "current_user" arg from check_fspVolker Lendecke4-26/+26
check_fsp only used the vuid struct member anyway, and this is available in the smb_request structure as well. (This used to be commit 8d364c4c3311b406847158fc37e9208d298cf8ba)
2008-06-19loadparm: use the return value of the special handlers in lp_load().Michael Adam1-2/+2
Up to now, the bool return value was silently ignored. Michael (This used to be commit c65d425fec964bc0b8778b596615a8bcce0378aa)
2008-06-19loadparm: don't treat a missing include file as an error in handle_include().Michael Adam1-1/+1
Michael (This used to be commit a8ef8870beb91fcd2745aa59de6c59b49ea00e39)
2008-06-19testsuite: enable the testparm_s3 tests.Michael Adam1-0/+7
Michael (This used to be commit 0f5c13e5735990f4325f98156a7dc410276372fe)
2008-06-19testsuite: add a testparm_s3 test script.Michael Adam1-0/+90
This is a first testparm/lp_load test that runs testparm on a couple of configuration files. The main purpose for now is to test the options that have special handlers (to check whether the handlers succeed). In particular, all the Macro expansions that are available via alloc_sub_basic() are tested with the include handler. This is to catch such crashbugs as #5548 where %m expansion led to a segfault. The tests now are very simple. Just check if testparm completes successfully on the given config files. This can (and should) be elaborated in the future. Michael (This used to be commit eb28146d40b8a8bc2c20b8d222abf191ea178d5a)
2008-06-19testsuite: update introductory comment to test_net_regsistry.shMichael Adam1-1/+2
This is now used to test rpc and local access depending on command line parameters. Michael (This used to be commit 73c17b630317b5019e5d5f2b989b8de081a73e07)
2008-06-19Remove current_user_info reference from vfs_recycle.cVolker Lendecke1-3/+1
(This used to be commit fdc03c0a5ba0da4fbc4610880e06150c11d4c737)
2008-06-19Remove current_user_info reference from vfs_fake_perms.cVolker Lendecke1-6/+4
(This used to be commit a227181e8d2ed0824a323a3d4b4cfda5e438f8ce)
2008-06-19Remove current_user_info reference from vfs_expand_msdfs.cVolker Lendecke1-3/+1
(This used to be commit 05a66980a9b5a7c6222ceb038d819d23fd172186)
2008-06-19current_user is not used in vfs_aixacl2.cVolker Lendecke1-1/+0
(This used to be commit 407136abdf45ad832382dba44e1c9a3b4f253f09)
2008-06-19RWX on a file does not imply DELETE accessVolker Lendecke1-1/+1
Without this the changed checks in can_delete_file_in_directory give DELETE access where there is none. So we can end up granting the ntcreate&x preparing the unlink where we should not, which leads to a NT_STATUS_ACCESS_DENIED at close time later, which in turn does *not* give the access denied error message in the Windows GUI. can_delete_file_in_directory will grant access now by looking at the directory permissions. (This used to be commit 51b5364c2afb3a18df4bec2bc1624760ccc01676)
2008-06-19Fix checks in can_delete_file_in_directory()Volker Lendecke1-6/+15
With at least NFSv4 ACLs around the write permission for the owner is a bogus check if we can delete a file in a directory. Like in Windows, there are two ways which can grant us such: First, the DELETE permission on the file itself, or if that does not help, the DELETE_CHILD permission on the directory. It might be a bit more code that runs, but essentially we should end up with the same set of syscalls in the non-acl case. (This used to be commit daa9b056645a45edfb3a70e3536011ebe5678970)
2008-06-19Remove some codeVolker Lendecke1-12/+4
Did not measure it, but I think a single write is better than a read and a conditional branch (This used to be commit abe1bed665ad8d1dbf9177dcbb9344b25df9594c)
2008-06-19Fix typoVolker Lendecke1-1/+1
(This used to be commit 2eef2c682c18ad37b78214c755b9dd7c8b607cb8)
2008-06-19Fix the build on FreeBSD 4.6.2Volker Lendecke1-4/+5
(This used to be commit 4f50cb63e9b565ae0747127baa651a1a1874298b)
2008-06-18Fix 'make distclean'. delheaders: no longer exists as a dependency.Jeremy Allison1-1/+1
Jeremy. (This used to be commit 8b26afdcddc75d3b9a97309757a97314b406cb59)
2008-06-18Remove prototype of unimplemented smbc_chown() function.Derrell Lipman1-26/+0
(This used to be commit 0e84e3bb800cec2b63df4692afbf9c40850b108f)
2008-06-18Revert "Fix a memleak in svcctl_init_keys()"Volker Lendecke1-10/+1
This reverts commit b1afb31f3cadd4749bf6e3eb5d8935588bf8ebfc. This one is very strange: I need to investigate why valgrind showed it as leaking, and why in my initial tests this did not fail. (cherry picked from commit 24730f5981efb920811e7929a9483bd72bb0984c) (This used to be commit b1e8e5d173cdaa3fb9c1fb1d9aacf8e665bc5d61)
2008-06-18Fix Bug #5548 (segfauls in handle_include with %m macro expansion).Michael Adam1-1/+4
In alloc_sub_basic, when expanding '%m', substitute "" instead of NULL for remote_machine when this is NULL. Else a NULL string is returned. Michael (This used to be commit c65b456c6a145d15b7fd27a2a3440a0709fc3277)
2008-06-18file_access: add a function header comment for can_access_file_acl().Michael Adam1-0/+3
Michael (This used to be commit 7d5fb873bde0a84de522650945effeaf602c759e)
2008-06-18smbd/dir.c: remove unneeded stat buf parameter from user_can_read_file()Michael Adam1-4/+2
This is not needed anymore since user_can_access_file_acl() ist used. Michael (This used to be commit 3c349f773a52e3de693d3bb79f5060c9f1e01e41)
2008-06-17file_access: remove unneeded stat buf parameter from can_access_file_acl().Michael Adam3-5/+5
This is a security descriptor level function only. Michael (This used to be commit 5931540fa1681f026fed42df387d17e43c493c47)
2008-06-17net sam: fix typo in commentMichael Adam1-1/+1
Michael (This used to be commit b9f6904044889328ded229b7ff04d31218f4fef8)
2008-06-17net sam: fix typo in debug message.Michael Adam1-1/+1
Michael (This used to be commit 6d7f64c3481d3aa7ec6b0d468f3d6218f62cd92e)
2008-06-17testsuite: give admin rights to testuser only for the "net rpc registry" test.Michael Adam1-0/+41
Remove the user from BUILTIN\Administrators at the end of the tests. Note: BUILTIN\Administrators is not deletet at the end because that functionality is not implemented. Michael (This used to be commit 1734f9305a38eff05f0147d9c7391ef34085e7b2)
2008-06-17testsuite: don't give the testuser administrative rights globally.Michael Adam1-9/+0
It breaks RPC-SAMBA3-GETUSERNAME for reasons I have not quite understood yet. Somhow loosing rights fails when the user belogns to BUILTIN\Administrators at some point. Michael (This used to be commit 9fe99c69f35b005b66c1eacb5d999cc73f1bb521)
2008-06-17Fix a brown paper bag segfault in clitarVolker Lendecke2-2/+2
Thanks to "No Body is Perfect" from gmail, whoever that is :-) Volker (cherry picked from commit 679d8dfa390601f777bfb43c02cd921eae5edcf4) (This used to be commit b8e1d62b8e8f724b855c8ab9801abee0b2791e36)
2008-06-17rpcclient: add more generic internal dscracknames call.Günther Deschner1-26/+57
Guenther (This used to be commit 2351b0845ca78707901daca6a6d0425959c6f28e)
2008-06-17netapi: use NetUserEnum filter in example code.Günther Deschner1-1/+1
Guenther (This used to be commit ad105177686da823ef9cce1c1bedaf0f84a49b8c)
2008-06-17netapi: add NetUserEnum filter constants to public headers.Günther Deschner1-0/+6
Guenther (This used to be commit 32a66131eb56e1c66b89e348141047c6b98cf35e)
2008-06-17netapi: implement NetUserEnum filters.Günther Deschner1-1/+22
Guenther (This used to be commit 0bd69df7704789888eba2a07aba505dce037c4eb)
2008-06-17re-run make idl.Günther Deschner1-0/+5
Guenther (This used to be commit 383636aaca0e59fef8a010ba697e5edf9ce2648b)
2008-06-17netapi: add NetUserEnum filter constants to IDL.Günther Deschner1-0/+6
Guenther (This used to be commit 12669b12c25a64b02c0e49b3ef96cf317992b18c)
2008-06-17netapi: some IDL cosmetics.Günther Deschner1-0/+96
Guenther (This used to be commit 4fd6bc61d0034659c5a89bf2eae188a04a3b41eb)
2008-06-17netapi: add NetRemoteTOD example code.Günther Deschner2-1/+90
Guenther (This used to be commit 2b82779a401dd1d14f5842872ac37b2454efc92b)
2008-06-17netapi: implement NetRemoteTOD().Günther Deschner1-2/+32
Guenther (This used to be commit 76877680a8a6400bc2d3b5e3b788b7d5fc683850)
2008-06-17netapi: make NetRemoteTOD() headers public.Günther Deschner1-0/+31
Guenther (This used to be commit 1262ab1843a8a8cb794f6bbfb113bd2d99ffba22)
2008-06-17netapi: add NetRemoteTOD() skeleton.Günther Deschner3-0/+67
Guenther (This used to be commit 78bc98cb55e36ef175f9c0f6fcd943781a514005)
2008-06-17re-run make idl.Günther Deschner3-1/+65
Guenther (This used to be commit 782ab0f1c1c0957a1111a76c2c1ea7bd99d38311)
2008-06-17netapi: add NetRemoteTOD() to IDL.Günther Deschner1-0/+19
Guenther (This used to be commit 8dd1a5fabffaea847a348d1467a75d005a16b0bd)
2008-06-17net_vampire: add error and result_message to samsync_context.Günther Deschner4-43/+82
Guenther (This used to be commit e0b117200441f842fbc11cc817ab2cde4d63a22e)
2008-06-17net_vampire: add domain_name to samsync_context.Günther Deschner4-0/+9
Guenther (This used to be commit 7e7f07ec59d23e909809ed32adc8fc399826310d)
2008-06-17libads: add ads_get_machine_kvno() to make ads_get_kvno() a bit more generic.Günther Deschner3-13/+36
Guenther (This used to be commit cb7ace209c2051ae02647188715fa6ee324c2bf6)
2008-06-17clikrb5: remove unrequired create_kerberos_key_from_string_direct() prototype.Günther Deschner2-11/+10
Guenther (This used to be commit ec86852fc6ce2d88ad5835c8fcb337c68fd6f6bc)
2008-06-17dsgetdcname: allow to use NULL mem_ctx.Günther Deschner1-1/+1
Guenther (This used to be commit d20353d30c2e08a6c6d67ae8b8c2faa26004249c)
2008-06-17libads: fix logic error in ads_get_kvno().Günther Deschner1-1/+1
Guenther (This used to be commit 132b038581a1a91b4e70c7c44f97f52866609812)
2008-06-17Fix a memleak in svcctl_init_keys()Volker Lendecke1-1/+10
(This used to be commit 675bb53398ba29c53d2dcf3c7122cf4770c2f938)
2008-06-17Fix a segfault in wbcLookupRidsVolker Lendecke1-16/+21
The done: part could access uninitialized memory if intermediate BAIL_ON_WBC_ERROR fire. Jerry, please check! Thanks, Volker (cherry picked from commit 31f4c33dcc744e81be54389756378e25aa2bb75e) (This used to be commit 5b12d8aa510689114e5413be5afe6aeb6ec2d9db)
2008-06-17Fix a segfault in wbcLookupSidVolker Lendecke1-19/+29
If the BAIL_ON_WBC_ERROR directly after wbcRequestResponse kicks in, *domain and *name have not been initialized yet. So the cleanup routine in the done: part of the routine (which did not check for domain!=NULL etc) would access uninitialized memory. Jerry, please check! Thanks, Volker (cherry picked from commit 3d7e0cc40b1992f4555807acec4f00450e30e2de) (This used to be commit ac5ba26bb0488c3fb95072d84898c02b72c5b819)