summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2011-03-26s3: Fix an uninitialized variable readVolker Lendecke1-1/+2
The "is_valid_policy_handle" in the exit path reads uninitialized data Lets see if this fixes Coverity ID 2172 which complains about h being dereferenced in the dcerpc_winreg_CloseKey. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Sat Mar 26 14:24:28 CET 2011 on sn-devel-104
2011-03-26s3: Fix Coverity ID 2326, CHECKED_RETURNVolker Lendecke1-1/+1
2011-03-26Revert "Fix bug 8021 - Incorrect string termination in volume/volume_name ↵Jeremy Allison1-1/+1
for TRANS2-QUERY_FS_INFO/Info Volume." This reverts commit 042aafb87df6c05877b8fc7ef0d44877689d860a. I need to test against OS/2 to see if this is something Win28K breaks for older clients before allowing this. Jeremy. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Sat Mar 26 01:19:55 CET 2011 on sn-devel-104
2011-03-25Fix bug 8040 - smbclient segfaults when a Cyrillic netbios name or workgroup ↵Jeremy Allison1-2/+23
is configured. As discovered by David Disseldorp <ddiss@suse.de>, convert_string_talloc() doesn't always return consistent results for a zero length string. The API states an incoming string must *always* contain the terminating null, but unfotunately too much code expects passing in a zero source length to return a null terminated string, so at least ensure we return a correct null string in the required character set and return the correct length. Also ensure we cannot return a zero length for a converted string (we ensure that the returned buffer is always allocated and zero terminated anyway) as calling code depends on the fact that returning true from this function will *always* return a non-zero length (as it must include the terminating null). Jeremy. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Fri Mar 25 23:25:40 CET 2011 on sn-devel-104
2011-03-25s3-netapi: fix memoryleak while not using talloc_tos() in ↵Günther Deschner2-6/+6
cli_get_session_key() usage. Thanks Volker! Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Fri Mar 25 18:21:18 CET 2011 on sn-devel-104
2011-03-25s3: Compile IDL files in autogen, some configure tests need thisVolker Lendecke2-0/+12
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Fri Mar 25 16:35:30 CET 2011 on sn-devel-104
2011-03-25Revert "s3-includes: fixed CONST_DISCARD() to actually discard const"Volker Lendecke1-1/+1
This reverts commit 37261928bec145f4cbd85f3e409063563c00ac9e. In source3 this creates a warning of the form passdb/pdb_ldap.c:4565: warning: passing argument 2 of ‘pull_utf8_talloc’ from incompatible pointer type include/proto.h:444: note: expected ‘char **’ but argument is of type ‘char ***’ for every use of CONST_DISCARD. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Fri Mar 25 13:16:35 CET 2011 on sn-devel-104
2011-03-25charcnv: ensure convert_string_error doesn't conflict with s3 functionAndrew Tridgell1-5/+5
use _handle for handle based functions Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Fri Mar 25 05:22:24 CET 2011 on sn-devel-104
2011-03-25s3-charcnv: fixed converted_size return in fast pathsAndrew Tridgell1-9/+20
2011-03-25s3-charcnv: removed unused functionAndrew Tridgell2-8/+0
lp_failed_convert_char() is not needed any more
2011-03-25lib/util/charset rename iconv_convenience to iconv_handleAndrew Bartlett15-108/+108
This better reflects what this structure is Andrew Bartlett
2011-03-25s3-charcnv: convert_string_internal() should not display errorsAndrew Tridgell1-31/+4
debug error display happens in the convert_string() outer function
2011-03-25s3-string: removed the conv_silent globalAndrew Tridgell1-29/+17
use convert_string_error() instead Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-25s3-string: removed last use of conv_silentAndrew Tridgell1-31/+11
This replaces the push_ascii_nstring() implementation with a call to convert_string_error() Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-25s3-charcnv Add convert_string_error()Andrew Bartlett2-18/+75
This function returns errors rather than printing them. Andrew Bartlett
2011-03-25charcnv: added convert_string_error()Andrew Tridgell1-33/+57
this will allow us to remove conv_silent Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-25s3-includes: fixed CONST_DISCARD() to actually discard constAndrew Tridgell1-1/+1
a cast is not enough Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-25unistr: moved some UCS2 macros into util_unistrAndrew Tridgell2-9/+9
we need to move towards eliminating smb_ucs2_t. This moves a couple of the related macros into the only file they are used in Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-25libcli: created smb_constants.hAndrew Tridgell5-27/+44
this starts the (long!) process of moving some of the SMB constants into common files. This just moves the FLAGS2_ defines, which are needed for common string routines (for FLAGS2_UNICODE_STRINGS)
2011-03-25tdb: rename convert_string() to tdb_convert_string()Andrew Tridgell1-5/+5
this prevents a conflict with the convert_string() in samba
2011-03-25s3-libsmb: work our correct length for EA stringsAndrew Tridgell1-1/+1
2011-03-25s3-string: sec_len==-1 support is no longer neededAndrew Tridgell1-41/+20
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-25s3-dfs: removed the last user of sec_len==-1 in pull_*_base_talloc()Andrew Tridgell1-1/+2
hopefully there aren't any others lurking in the code
2011-03-25s3-lib: make pull_ucs2_base_talloc staticAndrew Tridgell2-12/+6
it is local to charcnv.c
2011-03-25lib: remove unused pieces of string_wrappers.hAndrew Tridgell3-14/+8
2011-03-25lib: move the string wrappers from source3/include to common lib/utilAndrew Tridgell2-105/+133
this will allow the common charcnv library to use the string wrappers Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-25s3-string: moved fstring functions into their own fileAndrew Tridgell4-107/+133
Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org>
2011-03-25s3:dbwrap_ctdb: fix non-locked fetch on persistent db's causing corruptionMichael Adam1-2/+34
When doing a non-locking fetch on a record of a persistent db when no transaction is running, the old behaviour was to fetch locally and do a ctdb call when the record was not found in the local db. The call is useless for persistent dbs anyway since they are only written to using transactions and hence kept in sync, but it is also harmful, because a ctdb call will bump the record RSN when it does actually migrate the record from one node to another. Recently, ctdb has been changed to make all calls do a migration. This uncovered the client misbehaviour for persistent dbs, because now _each_ non-locking fetch will render the persistent db inconsistent: A subsequent transaction which touches the record in question will fail because the RSNs are out of sync. This patch fixes this old bug. Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Fri Mar 25 01:26:32 CET 2011 on sn-devel-104
2011-03-24s3-charcnv: remove unused labels.Günther Deschner1-6/+0
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Thu Mar 24 23:54:25 CET 2011 on sn-devel-104
2011-03-24s3-rpc_server: remove two uneeded include registry/reg_parse_prs.hGünther Deschner2-2/+0
Guenther
2011-03-24s3-ldapsam: fix ldapsam_create_user() with existing posix accounts.Günther Deschner1-1/+1
We were not taking into account the existing posix attributes and thus failed while trying to add a 2nd uid attribute. Found by Sumit. Guenther
2011-03-24s3-netapi: use cli_get_session_key() in netapi.Günther Deschner2-6/+53
Guenther
2011-03-24Fix bug 8021 - Incorrect string termination in volume/volume_name for ↵Volodymyr Khomenko1-1/+1
TRANS2-QUERY_FS_INFO/Info Volume. Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu Mar 24 23:07:09 CET 2011 on sn-devel-104
2011-03-24Fix is_myname_or_ipaddr() to be robust against strange DNS setups.Jeremy Allison1-30/+56
If IPv6 DNS names are turned on, but Samba isn't configured to listen on an IPv6 interface, then is_myname_or_ipaddr() can return false on a valid DNS name that it should detect is our own. If the IPv6 addr is returned by preference, then looking at the first addr only causes is_myname_or_ipaddr() to fail. We need to look at all the addresses returned by the DNS lookup and check all of them against our interface list. This is an order N^2 lookup, but there shouldn't be enough addresses to make this a practical problem. Jeremy.
2011-03-24s3-epmapper: fix vars init and return errorsSimo Sorce1-11/+18
Properly initialize variables at each cycle. Convert to the right error when returning EPMAPPER ones. Autobuild-User: Simo Sorce <idra@samba.org> Autobuild-Date: Thu Mar 24 20:43:49 CET 2011 on sn-devel-104
2011-03-24librpc: Return an error if we a broken floor.Andreas Schneider1-4/+9
Pair-Programmed-With: Simo Sorce <idra@samba.org>
2011-03-24cleanup: fix some trailing spacesSimo Sorce1-4/+4
2011-03-24s3-epmapper: Fix allocation of data on the wrong contextSimo Sorce1-1/+1
p->mem_ctx is the short-lived per request context, while this data is long lived, allocate on p instead.
2011-03-24s3-epmapper: Make sure we work on a description duplicate.Andreas Schneider1-1/+5
2011-03-24librpc: Added a dcerpc_binding_dup() function.Andreas Schneider2-0/+82
2011-03-24s3-epmapper: Refactor the cleanup of endpoints.Andreas Schneider1-11/+11
2011-03-24s3-epmapper: Use strcmp instead of strequal and check IPv6.Andreas Schneider1-1/+2
2011-03-24s3-epmapper: Increase debug levels.Andreas Schneider1-8/+8
2011-03-24s3: Fix some errno assignments in SMBC_opendir_ctxVolker Lendecke1-13/+13
Do the assignment as the last action to make sure it's not overwritten Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Thu Mar 24 17:31:57 CET 2011 on sn-devel-104
2011-03-24s3: Fix Coverity ID 2325: RESOURCE_LEAKVolker Lendecke1-0/+4
2011-03-24charcnv: removed the allow_badcharcnv and allow_bad_conv options to ↵Andrew Tridgell52-348/+152
convert_string*() we shouldn't accept bad multi-byte strings, it just hides problems Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Thu Mar 24 01:47:26 CET 2011 on sn-devel-104
2011-03-24charset: remove another allow_badcharcnv check Andrew Tridgell1-3/+0
better to fail only if there is a bad character
2011-03-24s3-prototypes: remove protos of some dead functions.Günther Deschner7-35/+0
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Thu Mar 24 00:52:01 CET 2011 on sn-devel-104
2011-03-23librpc: bring more librpc prototypes in common.Günther Deschner3-33/+12
Guenther
2011-03-23s3-rpc_client: actually call lsa_open_policy2() in rpccli_lsa_open_policy2().Günther Deschner1-6/+7
Found by Sumit Bose <sbose@redhat.com>, thanks! Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Wed Mar 23 20:12:38 CET 2011 on sn-devel-104
generated by cgit (git 2.34.1) at 2024-11-09 17:25:35 +0000