summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2002-01-18Ensure we log tdb open fails. Patch from Alexander Bokovoy ↵Jeremy Allison1-4/+2
<a.bokovoy@sam-solutions.net> Jeremy. (This used to be commit eb99e7f29c2d6041054331425cb245da86bedaa4)
2002-01-18Added prs_mem_clear(). Clear memory on buffer reallocation. That wayJeremy Allison2-11/+19
we're not returning what the client gave us. Jeremy. (This used to be commit 9a969069f132019cdd8a11be2b00356a3f09b64d)
2002-01-18Always clear malloced memory for parse structs.Jeremy Allison1-0/+1
Jeremy. (This used to be commit 6deb4caca5b45f87be84032fe0588db8d73b901a)
2002-01-17A nice *big* change to the fundemental way we do things.Andrew Bartlett19-72/+243
Samba (ab)uses the returns from getpwnam() a lot - in particular it keeps them around for a long time - often past the next call... This adds a getpwnam_alloc and a getpwuid_alloc to the collection. These function as expected, returning a malloced structure that can be free()ed with passwd_free(&passwd). This patch also cuts down on the number of calls to getpwnam - mostly by taking advantage of the fact that the passdb interface is already case-insensiteve. With this patch most of the recursive cases have been removed (that I know of) and the problems are reduced further by not using the sys_ interface in the new code. This means that pointers to the cache won't be affected. (This is a tempoary HACK, I intend to kill the password cache entirly). The only change I'm a little worried about is the change to rpc_server/srv_samr_nt.c for private groups. In this case we are getting groups from the new group mapping DB. Do we still need to check for private groups? I've toned down the check to a case sensitve match with the new code, but we might be able to kill it entirly. I've also added a make_modifyable_passwd() function, that copies a passwd struct into the form that the old sys_getpw* code provided. As far as I can tell this is only actually used in the pass_check.c crazies, where I moved the final 'special case' for shadow passwords (out of _Get_Pwnam()). The matching case for getpwent() is dealt with already, in lib/util_getent.c Also included in here is a small change to register the [homes] share at vuid creation rather than just in one varient of the session setup. (This picks up the SPNEGO cases). The home directory is now stored on the vuid, and I am hoping this might provide a saner way to do %H substitions. TODO: Kill off remaining Get_Pwnam_Modify calls (they are not needed), change the remaining sys_getpwnam() callers to use getpwnam_alloc() and move Get_Pwnam to return an allocated struct. Andrew Bartlett (This used to be commit 1d86c7f94230bc53daebd4d2cd829da6292e05da)
2002-01-17Move the bang (!) command back to the bottom of the list, allowing smbclientAndrew Bartlett1-1/+3
to function again. Add comment to warn anybody that wants to 'Alphabetize' the list to read crh's existing comment on the issue. Andrew Bartlett (This used to be commit d123d79060caf3ad084e733dac02aa2f67bda35f)
2002-01-17Made a debug look nicer.Tim Potter1-1/+2
(This used to be commit aca0edc819e892944c65b3feb60250994a79e88a)
2002-01-17Added some guards.Tim Potter1-0/+4
(This used to be commit 967c68858001cd620d2524d56180497c4b479c6b)
2002-01-17Fixed typo.Tim Potter1-1/+1
(This used to be commit e675d34dbfe1435150faf5af4bb97f01d311f5b0)
2002-01-17new config files for winbindd startupHerb Lewis2-0/+39
(This used to be commit 4ab2a775438f4266d270c626a9ad547c97c4eb62)
2002-01-17fixed a typo in the error map for WRONG_PASSWORDAndrew Tridgell1-1/+1
(This used to be commit fb300e411bb385dcba2c3ca166598a71ed693b35)
2002-01-17don't use O_NONBLOCK in open(). This was added erroneously for kernelAndrew Tridgell1-4/+0
oplocks and really shouldn't be used (This used to be commit c3a83002cfc2e0b5158cae1898eda8bafcb41e48)
2002-01-16Separate out get_user_home_dir() from get_user_home_service_dir().Jeremy Allison4-44/+51
Jeremy. (This used to be commit c1b97226db63daf64359e79083a4754e7c7f8054)
2002-01-16Merged in %S fixes and XX_NOT_CHANGED fixes from 2.2.Jeremy Allison4-27/+67
Jeremy. (This used to be commit 0fcca6c627a5c9c2219ec9714df5e0bc1a44cc29)
2002-01-16Fixup error mapping so we have only one table containing errno -> dos error ↵Jeremy Allison4-66/+48
-> NT STATUS maps. Fixes problem with disk full returning incorrect error. Jeremy. (This used to be commit 16fcbf3c1ccf1d704765653f68395dd596c0d841)
2002-01-16Alphabetize.Jeremy Allison1-3/+3
Jeremy. (This used to be commit 64301bc5f75283c948630d2b78d28e3869db39a2)
2002-01-16Added CIFS UNIX extension code to client.Jeremy Allison3-0/+316
Jeremy. (This used to be commit 794c3e2c76aae57d054e46b185def104ca02977c)
2002-01-16Fix name register bug with non-existent wins server.Jeremy Allison1-32/+29
Jeremy. (This used to be commit 4e41780c21d9a6c056104f952e720a79c830c65e)
2002-01-16At leadt don't lose this - I need to re-sync trans2.c between 2.2.x andJeremy Allison1-27/+66
HEAD soon. Jeremy. (This used to be commit 2f57257558b67b4a5106fece269ce55643464683)
2002-01-16Roll back PSTRING_SANCTIFY patch; just leave non-controversial typeMartin Pool5-59/+30
and constness changes. (This used to be commit cee0ec72746122c962e6c5278a736266a7f2c424)
2002-01-16Quieten some pointer cast warnings.Tim Potter1-3/+4
(This used to be commit 1906903f063de526045be68d19cf39de3c029c6f)
2002-01-16much better support for organisational units in ADS joinAndrew Tridgell3-15/+53
(This used to be commit 7e876057d5e392f85e6fdb0f2c233b0fe76df688)
2002-01-16Roll back PSTR insertion.Martin Pool1-23/+21
Just leave the fstrcpy/pstrcpy bugfix, and conversion to pstr_sprintf rather than manual calculation of length. (This used to be commit e38e7a2bdcf2901359035ac4aa79ebf33599e0c8)
2002-01-16Merge of name_status_find() debugs.Tim Potter1-5/+18
(This used to be commit cfac669017afa763100e335d1516fbed18049e00)
2002-01-15Fix from 2.2. It didn't break on HEAD because it isn't being compiled. Herb?Jim McDonough1-10/+10
(This used to be commit 4fcaec53de18220ff6662f62a1430f67757cdcc5)
2002-01-15Missing assign fix from Bernt Nilsson bkn@ida.liu.se.Jeremy Allison1-1/+1
Jeremy. (This used to be commit adf24a90e8b4d970d71fa8a6854edcf6deff9688)
2002-01-15For some reason I wasn't thinking about failure cases this morning...Andrew Bartlett1-0/+72
Anyway, this makes it slightly sane, but we may decide to smb_panic() here instead. Andrew Bartlett (This used to be commit 724109a33bf2f06bcb97cdd31c0442c6035ff6a6)
2002-01-15Convert to the new pstring interface. This diff is a pretty goodMartin Pool1-26/+29
example of the scope of change the new pstrings would entail: basically inserting PSTR() or FSTR() everywhere you need to coerce one to a char*. It's also a good example of the kind of bug we might catch: on about line 540, we were doing a pstrcpy into an fstring, which might overflow. It's not a problem in this particular case, but it is in general. (This used to be commit 5a403da4a735a8fb8d118a0a67f3a15127152e18)
2002-01-15Split pstring definitions into their own header.Martin Pool2-53/+72
(This used to be commit 04e3082f7d45c1b304adff5a46106136cff0e09e)
2002-01-15Integrate with PSTRING_SANCTIFY.Martin Pool1-4/+4
(This used to be commit 20a03facb6acf6329acc1645d4e9ead863a1a57c)
2002-01-15#ifdef variable that's not used without dmallocMartin Pool1-0/+2
(This used to be commit bf513668cb76fd20b04b8142c86c263280b05bb6)
2002-01-15Add constness to parametersMartin Pool1-1/+1
(This used to be commit e0105974c06e210e7565555d4b673c484de32907)
2002-01-15adding wins commands to winbindd - will check in the rest of the changesHerb Lewis1-0/+211
after further testing in 2.2 branch. (This used to be commit d5cdbc7e4ff48273bd7616694eef98c61e6f1f33)
2002-01-15Add constness to parametersMartin Pool1-2/+2
(This used to be commit a61abaec063d00afe13ce0baa356245fb6e21bc0)
2002-01-15Add constness to filenames passed to functions.Martin Pool3-3/+28
(This used to be commit 8d106dc1f4a51112516d72ae68747ca6b5b904b7)
2002-01-15Commit the auth associated changes I missed from the last commit.Andrew Bartlett4-3/+21
Also set the default value of all the allocated strings to "" to avoid changing the interface (becouse pdb_get...() would point to a null string, rather than a null pointer and parts of samba rely on that). Andrew Bartlett (This used to be commit 5b4079f748e25f21162e21b439063249baf8dca6)
2002-01-15Change the passdb interface to use allocated strings.Andrew Bartlett6-129/+180
These strings are allocated using talloc(), either using its own memory context stored on the SAM_ACCOUNT or one supplied by the caller. The pdb_init_sam() and pdb_free_sam() function have been modifed so that a call to pdb_free_sam() will either clean up (remove hashes from memory) and destroy the TALLOC_CTX or just clean up depending on who supplied it. The pdb_init_sam and pdb_free_sam functions now also return an NTSTATUS, and I have modified the 3 places that actually checked these returns. The only nasty thing about this patch is the small measure needed to maintin interface compatability - strings set to NULL are actually set to "". This is becouse there are too many places in Samba that do strlen() on these strings without checking if they are NULL pointers. A supp patch will follow to set all strings to "" in pdb_default_sam(). Andrew Bartlett (This used to be commit 144345b41d39a6f68d01f62b7aee64ca0d328085)
2002-01-14rerun autoconfAndrew Bartlett1-802/+812
(This used to be commit d6bd9f1005496753333c3d8dec5e1a8069f1ce7b)
2002-01-14I like --enable-developer, but I find it rather usless when all it gets me is aAndrew Bartlett1-1/+5
screen-full of kerberos warnings. This is almost as good, and I can actually see the Samba warnings. Andrew Bartlett (This used to be commit 35a6275e186cbd7b1f2190265b47112f1d082c06)
2002-01-14Initialise cli variables and try not to do a cli_shutdown() of uninitialsedAndrew Bartlett1-4/+10
memory. The winbind connection caching code isn't exactly a plesent beast, and there is more work that needs to be done to nail this properly. Andrew Bartlett (This used to be commit dd40ce54b7f170854d63e08ac737f1b4306bd95b)
2002-01-14Fix a segfault in auth/auth_domain.c error cases.Andrew Bartlett1-2/+1
This occured when the attempt to contact the PDC failed. The connection code has already shut down the connection, and 'free'ed the cli or has never initialised it in the first place. Andrew Bartlett (This used to be commit 37ce7630434c1afae5164c64438f428dd8e1b731)
2002-01-14Removed MAXSTATUS which was set incorrectly - thus causing tdb traversalJeremy Allison5-33/+19
of the connections db on smbd startup. This should fix the Solaris large load bug.... (fingers crossed). Jeremy. (This used to be commit 5b2b9c25af28543e67762805d1387524cbb6c39d)
2002-01-14FIXME We should turn the global list off when using Insure++,Martin Pool1-0/+3
otherwise all the memory will be seen as still reachable. (This used to be commit 682e7cd394c1e1cc9a83f7e8e5e3694e083946c4)
2002-01-14Move local variable to avoid warning when compiled without GSSAPI.Martin Pool1-1/+2
(This used to be commit 312c6d906e64d231ff3c2f37e61d752cc948ee7b)
2002-01-14PSTRING_SANCTIFY:Martin Pool1-3/+50
If you define this, pstring and fstring become distinguished types, so that it's harder to accidentally overflow them by for example passing an fstring on the lhs of pstrcpy. The types are defined as one-element union arrays so that with "fstring f" the name "f" will be a pointer and with a big hammer you can cast it to (char *). So code that tries to just use it directly will get a loud warning, but hopefully nothing worse. To pass them to non-pstring-aware functions, use PSTR and check that the function takes a const. They should almost never be modified except by special calls. In those unusual cases, use PSTR_MUTABLE. This is off by default so as not to produce too many warnings. As the code is vetted it can become the default. (This used to be commit ca233bc8b30d7d0626039b2769c4e1ae92dafd50)
2002-01-14Removed fprintf(stderr, ...); calls which should not be present in libraryTim Potter1-4/+0
functions. (This used to be commit e69a22290e5c923f31223906461df4874e3b2aac)
2002-01-13A couple of coding syle updates to follow the re-indent.Andrew Bartlett1-5/+5
(This used to be commit 7417d6f9310188d2ad3d8f41d3dcbe55862c72ac)
2002-01-13Re-indent these two functions to make it actually possible to understand theirAndrew Bartlett1-161/+161
contents... Andrew Bartlett (This used to be commit e20d69d51862ea3fd5a7317a9592bd4dc6e68bfd)
2002-01-13don't try to allocate zero bytesAndrew Tridgell1-10/+7
(This used to be commit d09616da6823b69a03a8a008987c4eb02ca0061b)
2002-01-13I'm doing some things towards the NamedPipes game with lckl and he has asked meAndrew Bartlett2-87/+105
to move this from being a static to matching its mate in lib/util_sock.c. In any case, this should discorage anybody from using the 'wrong' version of this function. (ie the one from TNG, which needs a bit more error checking depending on use). Andrew Bartlett (This used to be commit e6a3a01f795a85d908180ff19469ce09a2803512)
2002-01-12Many thanks to Alexander Bokovoy <a.bokovoy@sam-solutions.net>.Andrew Bartlett7-2/+173
This work was sponsored by Optifacio Software Services, Inc. Andrew Bartlett (various e-mails announcements merged into some form of commit message below:) This patch which adds basics of universal groups support into Samba 3. Currently, only Winbind with RPC calls supports this, ADS support requires additional (possibly huge) work on KRB5 PAC. However, basic infrastructure is here. This patch adds: 1. Storing of universal groups for particular user logged into Samba software (smbd/ two winbind-pam methods) into netlogon_unigrp.tdb as array of uint32 supplemental group rids keyed as DOMAIN_SID/USER_RID in tdb. 2. Fetching of unversal groups for given user rid and domain sid from netlogon_unigrp.tdb. Since this is used in both smbd and winbindd, main code is in source/lib/netlogon_uingrp.c. Dependencies are added to AUTH_OBJ as UNIGRP_OBJ and WINBINDD_OBJ as UNIGRP_OBJ. This patch has had a few versions, the final version in particular: Many thanks to Andrew Bartlett for critics and comments, and partly rewritten code. New: - updated fetching code to changed byte order macros - moved functions to proper namespace - optimized memory usage by reusing caller's memory context - enhanced code to more follow Samba coding rules Todo: - proper universal group expiration after timeout (This used to be commit 80c2aefbe7c1aa363dd286a47d50c5d8b4595f43)