Age | Commit message (Collapse) | Author | Files | Lines |
|
(MORIYAMA Masayuki).
Don't use nstrings to hold workgroup and netbios names. The problem with them is that MB netbios
and workgroup names in unix charset (particularly utf8) may be up to 3x bigger than the name
when represented in dos charset (ie. cp932). So go back to using fstrings for these but
translate into nstrings (ie. 16 byte length values) for transport on the wire.
Jeremy.
(This used to be commit b4ea493599ab414f7828b83f40a5a8b43479ff64)
|
|
fix up netbios names with mb strings. Includes reformat of libsmb/nmblib.c
so it's readable.
Jeremy.
(This used to be commit 966e49a48c352563cdd7f75fe2768f2d6612ec7e)
|
|
there are multiple "."'s in the name.
This code is protected with an #ifdef TRUNCATE_NETBIOS_NAME and this
is #define'd to 1 directly above. Should we also get rid of the #ifdef?
(This used to be commit 0375dace248eb3dc660fa2bca2808552e502b3f7)
|
|
when mangled names are turned off.
Jeremy.
(This used to be commit 29909ce26ac9a0d8e631b1ed884c525674ee5606)
|
|
It appears that we pass filename through resolve_wildcards() as pstring and use fstring temporary buffer there.
As result, a long filename in unix charset (UTF-8 by default) can easily expand over 255 bytes while
Windows is able to send to us such names (e.g. Japanese name of ~190 mb chars) which we unable to process through
this small fstring buffer. Tested with W2K and smbclient, Japanese and Cyrillics.
(This used to be commit 83dac6571f99b854ac607d4313cc3f742c1fae2e)
|
|
updated
(This used to be commit 9acd46ab462cb4aee9938658dda594ef8b8ddcbd)
|
|
(This used to be commit e1d0b8fc7bbe075dd817e3816f29640cda980732)
|
|
what it was :-). Allow msdfs links to now look like UNC paths : eg.
sym_link -> msdfs://server/share/path/in/share
or :
sym_link -> msdfs:\\server\share\path\in\share
Jeremy.
(This used to be commit 2979c3e388400fb030b94da5c711f803f81ae0b9)
|
|
"allow_bad_conv"
boolean parameter that allows broken iconv conversions to work. Gets rid of the
nasty errno checks in mangle_hash2 and check_path_syntax and allows correct
return code checking.
Jeremy.
(This used to be commit 7b96765c23637613f079d37566d95d5edd511f05)
|
|
I know this isn't pretty, but neither was our assumption that all strings
from the directory fit inside a pstring. There was no way this worked
before will all versions of usrmgr (for example, the only version of
mine that has the TS Confic button).
(This used to be commit d275c0e384db08c2a6efc28e52844f676ff71fb6)
|
|
(This used to be commit 9ea0560b0b62dbefaedd640cf9f4f58a0d337abe)
|
|
strchr_m() for query_host (smbclient -L)
(This used to be commit bc6992c4bffed043dd8ad58d721202091cd14cd3)
|
|
Jeremy
(This used to be commit 28f1e21c583ea9a7771d6e0134b09a7acd5f054d)
|
|
character set. Because of the allowing of "broken conversions" for people
who have broken iconv libraries we can't rely on the return from convert_string()
to be valid - we must check errno instead. This is ripe for revisiting at
some stage. I prefer adding a bool parameter to all convert_string_XX varients
to specify if we will allow broken conversions or not. With "allow_broken_conversions"
set to false we could then rely on the return from convert_string rather than
checking errno.
Jeremy.
(This used to be commit 74722f28659ac369676e898fda48d3d9ab265045)
|
|
(This used to be commit e6c2d9a3f7b5e427c6e7139726160d79e1dfc16d)
|
|
in 3.0.2a actually). We now send a correct referral back, but the client
refuses to follow it... Not sure why. Will do more tests.. Maybe unicode
character count is wrong (it looks it).
Jeremy.
(This used to be commit e2709f99fc4e603897472d3ba3bf1ca2e7ca728f)
|
|
Jeremy.
(This used to be commit 80fde09fc4a5d7e72611fd587777151adc5c890d)
|
|
(This used to be commit 2367d988ae8d33397cd255d39100ae5791401558)
|
|
dfs code.
Jeremy.
(This used to be commit 42175b4518764e484d33d9fbfba3b78ba4102ead)
|
|
rafal
(This used to be commit 3e57c2c6850655da77e25de4cb047cc27741ca9c)
|
|
rafal
(This used to be commit 2a7dd469430459d124cb48d516b82766a2a249bc)
|
|
(This used to be commit 11fc4da07f232c38e04c6443e5d0f829e16b0a18)
|
|
Big thanks to tpot and mbp for showing how easy it can be to write a simple
unit test, and for providing the STF.
This also changes the strstr_m() code to use strstr_w() (avoiding
duplication) and fixes it so that it passes the STF.
(We now always restart before doing the unicode run, until sombody can
show me why the testsuite is wrong).
Andrew Bartlett
(This used to be commit a893a324f37e6a171719db8ffffe66df31c2dbaa)
|
|
For example:
strstr_m("%v foo bar", "%v") would fail...
only strstr_m("foo %v", "%v") could work.
I wonder what else this broke...
Fix is to move to using strncmp() inside the strstr_m function.
Tested on ASCII only.
Andrew Bartlett
(This used to be commit 44d304f84c4ba5a832d5e3848ae0d04d5438ac15)
|
|
(should fix the mb service name problem, can't remember the bugid).
Jeremy.
(This used to be commit 94a272b9a881ec0004c5da2a7242b0a818da5630)
|
|
need to try and convert 1 byte, then 2 bytes if that fails. Fixes bug
reported by Simo.
Jeremy.
(This used to be commit 8702d0089619c7321b93e59d35f43ef32dce7b78)
|
|
A windows DC does not reply to DCNAME\\Administrator, only to
DOMAIN\\Administrator. Fix that.
Without winbind we are wrong as domain members, we should forward the request
DOMAIN\\Username to the DC on behalf of the asking client. Winbind fixes that
nicely.
Volker
(This used to be commit 7ed61edbbedbdee25f750aa30c13479764aa1af2)
|
|
(This used to be commit 97a6a67b34201dda7715f5f23b1b9af3bcf3705f)
|
|
should work as expected :-)
Fix wb_delgrpmember.
Volker
(This used to be commit 9fc0025d12d17b0c68956af481a836eebc32e675)
|
|
(This used to be commit e6e8b59f53d5ac618dcec13a46c356f0abe5950a)
|
|
(This used to be commit 89f3173f4f4e9a16f24b25f550065b50577f3f4c)
|
|
(This used to be commit 1bba071126b46032c97154fbf77242e15bcc5fa3)
|
|
Jeremy.
(This used to be commit 92c3ae3458177ec7f721598311a8ad04b2db5138)
|
|
active connections
(This used to be commit d77d38560d1bdc10a58408f449fbc320275bcacc)
|
|
(This used to be commit df19b6066e1f4e200adcd80f9526aa1a68509580)
|
|
Bas van Sisseren <bas@dnd.utwente.nl>
(This used to be commit cc164e5afb0f6100bde547674b3de88b7e45f31f)
|
|
(This used to be commit 737b3a5a9286777b0ea38bed5f1e20a3c3859304)
|
|
so breaks when substitution '/' and '\'). It's used by unix_clean_name(),
which is used by reduce_name, which is used by check_name() (phew!).
Now that we know all filenames passed to check_name() are in a "good"
format (no double slashes, all '\\' chars translated to '/' etc.) due
to the new check_path_syntax() we can avoid calling reduce_name unless
widelinks are denied. After this check-in I can fix all_string_sub() to
handle mb chars correctly as it won't be in the direct path in the
main path handling code.
Jeremy.
(This used to be commit 6080186fc4c2e7c59dd12a177539bfb77eb525cb)
|
|
original srvstr_pull_buf() function to get the pipename not srvstr_get_path().
Jeremy.
(This used to be commit 2a263873fd6bbbf03a32136981e433dc43374da9)
|
|
(This used to be commit fafb243278cd33d696487e477d4685bb79e2e357)
|
|
(This used to be commit 810bc1e2a02c6ab11ef00bf67b49929c596bee33)
|
|
(This used to be commit f0d99f318c67852ac5bf9b606faa115ad36a5f80)
|
|
(This used to be commit 3e39d157cb94928a036f0497a9e255f6dbad1771)
|
|
Volker
(This used to be commit 8ba5bdc330114efbc86c851b71c58ac91ada7f31)
|
|
right in the middle of the code.
I just love catching jra on stuff like this, after all the crap
I've done. :-)
(This used to be commit dc7dc5175847243d821dd33c1678af1b785dfaf7)
|
|
(This used to be commit 89da3df07b7d90ad19852046d0533673cff8fdc6)
|
|
(This used to be commit d58139d64f37fe9fec34492d7857257d9ad4a808)
|
|
Added hardlink_internals() code - UNIX extensions now use this too.
Jeremy.
(This used to be commit aad6eb2240393931940c982e25a981ce32264f38)
|
|
much closer emulation of Win2k3 error return codes.
Jeremy.
(This used to be commit c9f31fafeda6ad79e590276f36e03ecd2e93f818)
|
|
(This used to be commit c800b5c2f99c27dd0a3f526dfdac0980412e1694)
|