summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2007-10-10r14051: Add remaining (documented) userAccountControl bits, thanks to LukeGünther Deschner1-2/+2
Howard for pointing this out. Guenther (This used to be commit 170038f4cdfa51ea31b2255a020740d28dfbfba2)
2007-10-10r14050: Add the ACB_PWEXPIRED bit abartlet has found.Günther Deschner1-0/+1
Guenther (This used to be commit 5fa3f26b4c39d612243319fc0729078c50439d6b)
2007-10-10r14049: Found some more MSV1_0 bits and their behaviour;Günther Deschner1-2/+14
just for documentation purpose. Guenther (This used to be commit 0b00424e07f3f9c815664c619e2d7a670a838b93)
2007-10-10r14047: Coverity fix #17. Ensure srv_name and info cannotJeremy Allison1-0/+4
be zero before deref. Jeremy. (This used to be commit fbf9db6624d9584a26ae302df3c76555bbd2bb1e)
2007-10-10r14045: Coverity fix #14. Ensure if len is set buf != NULL.Jeremy Allison1-0/+5
Jeremy. (This used to be commit fb1a6073321840fecf22f3e0f7541f5ad87f5e49)
2007-10-10r14043: After discussion with Jerry revert part of theJeremy Allison1-26/+15
Coverity null-ref patch - put prs_rpcbuffer_p back to the way it was (with an additional coverity paranoia check) - move the real test into rpcbuf_alloc_size instead. Jeremy. (This used to be commit f74993e65c01bc0ef73d3e8710bb2f840910161a)
2007-10-10r14042: check that create_local_nt_token() succeeds before dereferncing the ↵Gerald Carter1-0/+4
NT_USER_TOKEN* (This used to be commit 4e5df4cb643886144d0fff4cac303e493c825955)
2007-10-10r14036: Ok, the last one generated a const warning. Also fix Coverity # 119.Volker Lendecke1-6/+13
net rpc vampire is ugly.... Volker (This used to be commit c1ea48949d2692c839f6ced68165cabd76b580ea)
2007-10-10r14035: Fix Coverity bug # 124Volker Lendecke1-0/+1
(This used to be commit 9fe21fd0326e67a4b1006d2b4a24e39e2d57d796)
2007-10-10r14034: Fix Coverity id # 125.Volker Lendecke1-0/+2
Jeremy, you might want to take a look here. Volker (This used to be commit e6e29937e8ccfc84afca0ee440bd3f10a7d10e8a)
2007-10-10r14033: Fix Coverity bug # 126Volker Lendecke1-0/+1
(This used to be commit bb6d678575faac050376607a5c778b8a10805061)
2007-10-10r14031: Coverity bug CID #110. Free all resources correctlyJeremy Allison1-0/+2
on pipe initialization failure. Jeremy. (This used to be commit daa919a94b3d81401654004bc0f32c45451203c1)
2007-10-10r14030: Fix resource leak in error codepath. Coverity CID #64.Jeremy Allison1-2/+6
Jeremy. (This used to be commit b51edde4d63e9b2f241f41b6780b026487890a7f)
2007-10-10r14026: Fix resource leak on error exit. Coverity CID #65.Jeremy Allison1-0/+2
Jeremy. (This used to be commit 3a1c4cb93dc262028ffbebd9ebeed69f4816cf09)
2007-10-10r14025: Remove unused code. When we want to export samsync, we better first portVolker Lendecke1-80/+0
pidl... Fix Coverity # 15. Volker (This used to be commit 29b4b986cc225a98d263c883fd52e8b210099b9e)
2007-10-10r14023: My last bug fix still left a potential null deref.Jeremy Allison1-8/+9
C- "must try harder" :-). Jeremy. (This used to be commit 9c55bf74ca28530045c5cb3cbfffad242039ca75)
2007-10-10r14022: Fix Coverity bug # 92Volker Lendecke1-0/+1
(This used to be commit b824245c4e04353f0d3fd0ccf6bc5776a601daed)
2007-10-10r14020: Coverity bug CID #66. Missing free on error exit.Jeremy Allison1-1/+4
Jeremy. (This used to be commit b9980bddf5ee74b2887196d6d1a0cf393720ba3a)
2007-10-10r14018: Coverity error CID #27. Missing return -1 on error condition.Jeremy Allison1-0/+1
Jeremy. (This used to be commit 94e869d9c6d1a1c1df0d072530bf8d4452bd10bb)
2007-10-10r14017: Okay, okay, I have turned a double-free into dead code :-)Volker Lendecke1-2/+0
Fix Coverity # 214. Volker (This used to be commit 4a75edf9deca2be18670d7f9f2e383ed0898512c)
2007-10-10r14014: Coverity paranoia. Shut it up by making the guarenteeJeremy Allison1-2/+7
in the code explicit - but this was a false positive (CID #16). Jeremy. (This used to be commit 43a0e869f2aee9b4e22d0d7fc92051e82f7536ad)
2007-10-10r14009: Remove last const warning (have to use CONST_DISCARD).Jeremy Allison1-1/+3
Jeremy. (This used to be commit af0ade470f2fac3509a44207b4572e279ba30e34)
2007-10-10r14007: Coverity bug CID #197. Don't compare against 0, weJeremy Allison1-1/+1
mean the ttl instead. Jeremy. (This used to be commit ccb2a52e29de7e2847ccd93aa99236f63202a4af)
2007-10-10r14006: Fix a couple of irritating warnings.Jeremy Allison1-2/+2
Jeremy. (This used to be commit ead13ca522d7b8cbb47d660d3cb73c3582088985)
2007-10-10r14003: Clarify code that lead to Coverity report #13.Jeremy Allison2-13/+16
Not a bug, but better to remove false positives. Jeremy. (This used to be commit f9a75d76546bc4618736f0d48646e77d7572db25)
2007-10-10r14002: Quick fix for Coverity CID #12.Jeremy Allison1-0/+4
Jeremy (This used to be commit 7c6e274cd578521192a0b0c4e6a4fb5dc7d722ac)
2007-10-10r13999: Quick fix for Coverity bug #11.Jeremy Allison1-1/+7
Jeremy. (This used to be commit b9de6c926953b3321fa3850d501c807c6eabf230)
2007-10-10r13997: Prefix $prefix by default even to rootsbindir as we else run in troubleLars Müller1-2/+2
if we use ./configure --prefix=dir && make install Vendors might use ./configure --with-rootsbindir=/sbin && make DESTDIR=/var/tmp/samba/ install if they use a buildroot. Thanks to Björn Jacke for pointing me at the stderr output of the build farm. (This used to be commit 75c95d149a22eba4a5afedcec7ba5e2a28cccf01)
2007-10-10r13994: Belt and braces - ensure RPC_BUFFER is valid.Jeremy Allison1-44/+75
Jeremy. (This used to be commit d993797191865878ebfd2ff9028d341017605cd6)
2007-10-10r13991: Fix Coverity bug # 69Volker Lendecke1-0/+1
(This used to be commit 6dc79e6b12e221e9af85a1edf487b5fb5aae222b)
2007-10-10r13989: Fix for Coverity bug #45 and associated spoolss RPC_BUFFERJeremy Allison1-7/+22
problems. Ensure that if the parse succeeds on UNMARSHALL we have a valid (although possibly empty) RPC_BUFFER returned. Jeremy. (This used to be commit d319cc9c08bfa865a6431a8631a9c609f589be1f)
2007-10-10r13987: Fix Coverity bug # 74. This tool is good...Volker Lendecke1-0/+1
Thanks, Volker (This used to be commit 86f62484dd7db43e036d9edf29e459b8bd0e5fbe)
2007-10-10r13984: Fix Coverity bug # 98Volker Lendecke1-1/+3
(This used to be commit 0a2aa3a48bd5fd7e5a9aa06068ddd621b19c1dbe)
2007-10-10r13983: Fix Coverity bug # 111Volker Lendecke1-0/+1
(This used to be commit 08d7fd31ab250bc6ba3922b36aa7b0cfef1e5bf1)
2007-10-10r13981: Fix Coverity bug # 138Volker Lendecke1-1/+1
(This used to be commit 303067ba3bdf34ab501f0d99e386cfdb6ab10233)
2007-10-10r13980: Fix Coverity bug # 63. Jeremy, could you take a look at this?Volker Lendecke1-5/+16
Thanks, Volker (This used to be commit 49043a756dfa6a973d5605f42068df351a4a9ab5)
2007-10-10r13979: We've dereferenced my_methods already, so there's no point in ↵Volker Lendecke1-1/+1
checking for != NULL. Coverity #149. Volker (This used to be commit d38e05329a77650d8fbb8611ca148964f62c9ba4)
2007-10-10r13978: Here is why it's essential to use SAFE_FREE instead of free.Jeremy Allison1-6/+6
If we use free(data.dptr) and then the subsequent tdb_open fails in _reg_perfcount_get_counter_data() then data.dptr is left as a non-zero pointer that has been freed. This would cause it to be reused later on. Coverity bug #162. Jeremy. (This used to be commit 053efc20981e0280c6af0ebb9e17cea07da85fe8)
2007-10-10r13975: Re-fix Coverity #156 - I had left the hidden arg. inconsistentJeremy Allison3-5/+6
between Realloc and realloc_array. Jeremy. (This used to be commit 841c9b1847ae12656b827e3d35b8bf0c3f68b8b4)
2007-10-10r13971: Fix Coverity bugs #209 - #213 - it detected mistakesJeremy Allison1-56/+67
in the pointer aliasing once realloc could change a pointer. This was in the bugzilla.samba.org database as #687 but we never figured out what it was ! Jeremy. (This used to be commit 8d183441403524fe39e79af843d6cfe65898f7d3)
2007-10-10r13968: fix typo, caught by GuentherJim McDonough1-1/+1
(This used to be commit 217d3fbe7923115ae610a39e586ceb93df7683f5)
2007-10-10r13965: Make sure we always reset the userAccountControl bits when re-joiningGünther Deschner1-1/+1
with an existing account. Guenther (This used to be commit e4c12ab167ee83772a2bdd1946b8d73613fc0d7e)
2007-10-10r13958: Fix Coverity Bug # 141Volker Lendecke1-1/+1
(This used to be commit 598513d1d3e23cc71ea0fd53230d393b6724b534)
2007-10-10r13957: Based on patch from Richard Renard <richard.renard@idealx.com>:Jim McDonough1-15/+18
Fix machine accounts (should not have valid shells) and users with no home directory (were getting previous user's directory). (This used to be commit f629f8a7b972f09fe959c68843b9cd5a03abfc76)
2007-10-10r13955: Fix Coverity ID 139.Volker Lendecke1-1/+1
Not a bug in the strictest sense, more a clarification. This whole routine assumes new_gid != NULL anyway, so there's no point in checking. Volker (This used to be commit dfbf09c772b9588271e2d8e053c7494bb087c544)
2007-10-10r13951: Fix Coverity Bug #163.Volker Lendecke1-28/+0
This code was not used anyway :-) Volker (This used to be commit bbfb20569380529d60e3c61cd0be63a09eecfd17)
2007-10-10r13950: Fix Coverity bug #168Volker Lendecke1-0/+1
(This used to be commit cbf894c0e37964df57bd6a91ac10dfff571b1b3c)
2007-10-10r13948: Fix the build. Remove rpcclient.h include.Jim McDonough1-1/+0
(This used to be commit 6bf879bee3c59ba54b1b4c465c777e3dd0043f83)
2007-10-10r13947: Use tabs instead of spaces for indention.Lars Müller1-3/+3
(This used to be commit fb76390c6ae5928a2a222d61cbadf825611999ef)
2007-10-10r13946: Link pam_smbpass with the required object files. Fix bug #3565.Lars Müller1-1/+2
(This used to be commit 426c8fe0bdacbf218d4cf4a10af789afbc0e53f2)