summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2012-09-22s3:smbd:smb2: initialize variable in vfs_default_durable_reconnect()Michael Adam1-1/+1
Found by Ambi's state-of-the-art compiler!
2012-09-22selftest: we fail samba3.smb2.compound.interim2Michael Adam1-0/+1
We currently return NT_STATUS_CANCELLED where we should return NT_STATUS_INTERNAL_ERROR.
2012-09-22s4:torture:smb2:compound: remove two unused macrosMichael Adam1-3/+0
2012-09-22s4:torture:smb2: don't skip the compound.interim2 test for non win7/win2k8Michael Adam1-4/+0
2012-09-22s4:torture:smb2: don't skip the compound.interim1 test for non win7/win2k8Michael Adam1-4/+0
2012-09-22s3:smbd: remove struct member smbd_smb2_request.cancelled - it was only writtenMichael Adam6-8/+0
2012-09-22s3:smb2_lock: let smbd_smb2_create_cancel() trigger NT_STATUS_CANCELEDStefan Metzmacher1-14/+2
Instead of violating the tevent_req layers. metze
2012-09-22s3:smb2_lock: smbd_smb2_notify_recv() can already return NT_STATUS_CANCELEDStefan Metzmacher1-18/+0
That's why we can remove the code that violates the tevent_req layers. metze
2012-09-22s3:smb2_notify: make use of tevent_req_defer_callback() instead of custom ↵Stefan Metzmacher1-34/+1
tevent_immediate metze
2012-09-22s3:smb2_notify: don't call tevent_req_done() from smbd_smb2_notify_cancel()Stefan Metzmacher1-2/+1
smbd_notify_cancel_by_smbreq() will already trigger this via smbd_smb2_notify_reply() and smbd_smb2_notify_reply_trigger(). metze
2012-09-22s3:smb2_lock: let smbd_smb2_lock_cancel() trigger NT_STATUS_CANCELEDStefan Metzmacher1-26/+3
Instead of violating the tevent_req layers. metze
2012-09-22s3:smb2_server: avoid segfault in smbd_smb2_request_pending_queue()Stefan Metzmacher1-2/+6
Because we should not call smbd_smb2_request_error() on an request that is still running. If the subreq implementes a cancel function, this should take care of triggering smbd_smb2_request_error. metze Signed-off-by: Michael Adam <obnox@samba.org>
2012-09-22s4:torture:smb2: extend the compound.invalid1 testStefan Metzmacher1-3/+8
Test that when turning the related flag back off for the last compound request, the return code changes from invalid parameter to file closed. Pair-Programmed-With: Michael Adam <obnox@samba.org>
2012-09-22s3:smbd:smb2: simplify smbd_smb2_request_validate() and ↵Michael Adam2-51/+3
smbd_smb2_request_dispatch() removes unnneccary checks/assignments for compound_related and next_status and duplicate setting of error status. And remove (now) unused next_status from struct smbd_smb2_request. Pair-Programmed-With: Stefan Metzmacher <metze@samba.org>
2012-09-22s3:smbd:smb2: add check for session_status for compound requestsMichael Adam1-3/+3
2012-09-22s3:smb2_server: do the req->next_status check before the signing checksStefan Metzmacher1-15/+15
Windows 2012 returns NT_STATUS_INVALID_PARAMETER to the smb2.compound.invalid1 test if that uses signing (instead of NT_STATUS_ACCESS_DENIED). metze
2012-09-22s3:smb2_server: reset req->last_session_id and req->last_tid after using itStefan Metzmacher1-0/+4
If we can find a valid session or tcon we'll set it after the lookup, but it need to make sure to reset it if we don't find the session. This fixes a problem where a compound unrelated request between related requests doesn't reset the session. If we have 3 requests in a compound chain, request 3 should never use the id's cached from request 1. It should only every inherit handles from request 2. metze
2012-09-22s4:torture:smb2: fix the compound.invalid3 test to work against windowsMichael Adam1-2/+2
2012-09-22s4:torture:smb2: fix compound.related3 test to work against windowsMichael Adam1-2/+2
2012-09-22s3: Compound requests should continue processing.Ira Cooper1-3/+2
This patch addresses #9173. Signed-off-by: Michael Adam <obnox@samba.org>
2012-09-22build: Fix enabled handling for HAVE_LDAP, we need to use bld.CONFIG_SETAndrew Bartlett3-9/+9
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Sat Sep 22 09:09:17 CEST 2012 on sn-devel-104
2012-09-22build: Try not build with LDAP if we do not have ldap.hAndrew Bartlett1-1/+1
2012-09-22s4:dns.py: reproducer for (bug #9184)Stefan Metzmacher1-0/+29
metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Sat Sep 22 06:08:05 CEST 2012 on sn-devel-104
2012-09-22lib/tsocket: fix receiving of udp packets from 0 bytes (bug #9184)Stefan Metzmacher1-4/+1
It's possible for a client to send 0 bytes in a UDP packet, we need still need to call recvfrom() and skip the invalid packet at a higher level. Otherwise the kernel receive queue is blocked. metze
2012-09-22libcli/echo: validate the message lengthStefan Metzmacher1-0/+5
metze
2012-09-22s3:pdb_ldap remove unused functionChristian Ambach1-23/+0
Autobuild-User(master): Christian Ambach <ambi@samba.org> Autobuild-Date(master): Sat Sep 22 04:28:37 CEST 2012 on sn-devel-104
2012-09-22s3:rpcclient fix a compiler warningChristian Ambach1-0/+2
2012-09-22s3:utils/net fix a compiler warningChristian Ambach1-1/+1
ret might be used uninitialized in out-of-memory condition
2012-09-22auth/kerberos: add HAVE_KRB5 guard to fix non-krb5 build after winbindd pac ↵Andrew Bartlett1-0/+3
changes Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Sat Sep 22 02:44:07 CEST 2012 on sn-devel-104
2012-09-21s3:smbd: release the share mode lock before calling exit_server() (bug #9191)Stefan Metzmacher1-0/+2
metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Fri Sep 21 22:36:57 CEST 2012 on sn-devel-104
2012-09-21s3:dbwrap_ctdb: set errno = ENOSYS if clustering is not supportedGregor Beck1-0/+1
Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Fri Sep 21 18:05:56 CEST 2012 on sn-devel-104
2012-09-21libtorture: factor out simple ui backendGregor Beck4-65/+88
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-09-21s3:dbwrap: remove unused args from db_open_file()Gregor Beck2-6/+2
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-09-21s3:dbwrap: let dbwrap_fetch_uint32 distinguish between "not found" and ↵Gregor Beck1-2/+5
"wrong format" Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-09-21dynconfig/config.m4: disallow --prefix=/usr and --prefix=/usr/local without ↵Stefan Metzmacher1-0/+4
--enable-fhs This matches the waf configure behavior and catches the case where old build scripts try '--with-fhs' instead of '--enable-fhs'. metze
2012-09-21libwbclient: bump ABI to 0.11 as wbcAuthenticateUserEx now provides PAC parsingAndrew Bartlett3-2/+79
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org> Autobuild-Date(master): Fri Sep 21 06:37:15 CEST 2012 on sn-devel-104
2012-09-20s4-torture: Complete test for winbindd PAC parsingChristof Schmitt1-6/+86
Decode the PAC through the wbcAuthenticateUserEx call, also decode it locally and compare the result. Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2012-09-20auth/kerberos: Adjust log level for failed PAC signature verificationChristof Schmitt1-1/+1
With winbindd trying to verify the signature of an application provided PAC, this message can be easily triggered. Adjust the debug level to avoid filling up the logs. Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2012-09-20winbind: Extend wbcAuthenticateUserEx to provide PACChristof Schmitt6-27/+191
With this new interface, external applications that have authenticated to an ADS can pass the PAC from the Kerberos ticket to wbcAuthenticateUserEx. winbindd decodes and extracts the info3 information for the external application. If winbindd can verify the PAC signature, the info3 from the PACis also added to the netsamlogon_cache. The info3 data can be used by the external application to get the uid and primary gid. The data in netsamlogon_cache allows to retrieve the complete group list through the NSS function getgrouplist. Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2012-09-20auth: Fix some nonempty blank linesVolker Lendecke1-61/+59
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2012-09-20waf: Make samba "ok" with directories for install being symlinksIra Cooper1-2/+2
stat -> lstat conversion. This allows people for whom $PREFIX/var is a symlink to complete make install. Autobuild-User(master): Ira Cooper <ira@samba.org> Autobuild-Date(master): Thu Sep 20 23:26:26 CEST 2012 on sn-devel-104
2012-09-20vfs: fix acl_blob_get* in vfs_full_auditDavid Disseldorp1-9/+11
Plumb-in functions and use correct return types. Autobuild-User(master): David Disseldorp <ddiss@samba.org> Autobuild-Date(master): Thu Sep 20 20:42:09 CEST 2012 on sn-devel-104
2012-09-20vfs: fix lock logging in vfs_full_auditDavid Disseldorp1-4/+4
2012-09-20Correct command help messageDaniele Dario1-1/+1
Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Thu Sep 20 16:55:17 CEST 2012 on sn-devel-104
2012-09-20s3-printing: Increase debug level for info that the db is empty.Andreas Schneider1-1/+2
Autobuild-User(master): Andreas Schneider <asn@cryptomilk.org> Autobuild-Date(master): Thu Sep 20 12:01:48 CEST 2012 on sn-devel-104
2012-09-20s3:smb2_server: fix usage of invalid memory in smb2_signing_check_pdu()Stefan Metzmacher1-1/+1
metze Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Thu Sep 20 07:18:31 CEST 2012 on sn-devel-104
2012-09-20s3:winbind:idmap_tdb_common: improve readability of assignment by adding an "if"Michael Adam1-3/+5
in idmap_tdb_common_sids_to_unixids()
2012-09-20s3:winbind:idmap_tdb_common: improve readability of assignment by adding an "if"Michael Adam1-3/+5
in idmap_tdb_common_unixids_to_sids()
2012-09-20s3: Fix idmap_hashVolker Lendecke1-1/+1
Calling be_init with NULL safely crashes, because we dereference NULL. We don't need to call it here, this is called in all workers anyway. Thanks to Jiri Sasek <jiri.sasek@oracle.com> for finding this. Autobuild-User(master): Volker Lendecke <vl@samba.org> Autobuild-Date(master): Thu Sep 20 05:03:54 CEST 2012 on sn-devel-104
2012-09-19selftest: we currently fail smb2.durable-v2-open.app-instanceMichael Adam1-0/+1
Autobuild-User(master): Stefan Metzmacher <metze@samba.org> Autobuild-Date(master): Wed Sep 19 23:05:43 CEST 2012 on sn-devel-104