summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2011-08-26s3: Fix a winbind race leading to 100% CPUVolker Lendecke1-2/+3
This fixes a race condition that leads to the winbindd_children list becoming corrupted. It happens when on a busy winbind SIGCHLD is a bit late. Imagine a winbind with multiple requests in the queue for a single child. Child dies, and before the SIGCHLD handler is called we find the socket to be dead. wb_child_request_done is called, receiving an error from wb_simple_trans_recv. It closes the socket. Then immediately the wb_child_request_trigger will do another fork_domain_child before the signal handler is called. This means that we do another fork_domain_child, we have child->sock==-1 at this point. fork_domain_child will do a DLIST_ADD(winbindd_children, child) a second time where the child is already part of that list. This corrupts the list. Then the signal handler kicks in, spinning in for (child = winbindd_children; child != NULL; child = child->next) { forever. Not good. This patch makes sure that both conditions (sock==-1 and not part of the list) for a winbindd_child struct match up. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Fri Aug 26 18:51:24 CEST 2011 on sn-devel-104
2011-08-26s3: Fix two int/enum mixupsVolker Lendecke1-2/+2
2011-08-26s4-drsuapi Allow DsAddEntry of normal objectsAndrew Bartlett1-1/+6
We previously only allowed objects of class ntDSDSA Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Fri Aug 26 15:34:21 CEST 2011 on sn-devel-104
2011-08-26s4-messaging ensure we do not segfault on a NULL msg context in cleanupAndrew Bartlett1-0/+4
2011-08-26selftest: Allow a krb5.conf to be generated that covers multiple realmsAndrew Bartlett3-23/+38
2011-08-26build: Add dcerpc-binding to dcerpc.pcAndrew Bartlett1-1/+1
This will help projects like OpenChange that depend on this code, now that it has been split between two libraries. Andrew Bartlett
2011-08-26s4-dsdb Return ACL errors as ldb_errstring()Andrew Bartlett3-17/+33
This string is reported to the caller, which makes debugging much easier. Andrew Bartlett
2011-08-26s4-provision Use samba.dns_name_to_dnAndrew Bartlett2-2/+6
2011-08-26s3-passdb: Allocate talloc stackframe before calling pdb_get_group_sid()Amitay Isaacs1-5/+6
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26s3-param: Allocate talloc stackframe before calling s3 param routinesAmitay Isaacs1-2/+26
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26s3: Use sys_write in fork_domain_childVolker Lendecke1-1/+1
Counterpart for last checkin. A lot less likely, but not impossible in a child. Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Fri Aug 26 13:14:27 CEST 2011 on sn-devel-104
2011-08-26s3: Use sys_read in fork_domain_childVolker Lendecke1-1/+1
I've seen [2011/08/26 01:44:10.872057, 1] winbindd/winbindd_dual.c:1336(fork_domain_child) fork_domain_child: Could not read child status: nread=-1, error=Interrupted system call on a customer box. Not good.
2011-08-26py-samba3-test: Copy sample database in tempdir before running testAmitay Isaacs1-7/+11
Samba3 python module using passdb api modifies the database files, to upgrade them to latest version. So copy the sample database before running tests on it. Signed-off-by: Andrew Bartlett <abartlet@samba.org> Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Fri Aug 26 07:04:15 CEST 2011 on sn-devel-104
2011-08-26samba3dump: Update the code using modified samba3 module with passdb apiAmitay Isaacs1-40/+53
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26s3_upgrade: Set lock directory to correct directoryAmitay Isaacs2-1/+3
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26py-samba3-test: Set lock directory to the datadirAmitay Isaacs1-0/+1
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26testdata: Set netbios name in the samba3 configuationAmitay Isaacs1-0/+1
To correctly find the domain sid, passdb api uses netbios name to look up secrets database. If no nebios name is configured, passdb uses current hostname and adds entry for hostname in secrets and uses that instead of the intended one. Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26s3_upgrade: Update commandline options and use updated samba3 python moduleAmitay Isaacs3-166/+140
upgrade_from_s3 script now requires samba3 configuration file and target directory for samba4 database. In addition, it either uses --libdir option or --testparm option to correctly guess the paths for samba3 databases (private dir and state directory). Usage: upgrade_from_s3 [options] <configuration_file> <targetdir> Input arguments are: <configuration_file> - path to existing smb.conf <targetdir> - directory in which samba4 database will be created In addition, specify either samba3 database directory (with --libdir) or samba3 testparm utility (with --testparm). Before using passdb interface, initialize s3 loadparm context using correct path settings for private dir and state directory. Export account policy from s3 to s4. Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26py-samba3: Use passdb/param wrapper for samba3 moduleAmitay Isaacs2-567/+117
Instead of parsing samba3 database files (password, group mapping, account policy, secrets), use passdb python wrapper. Similarly for parsing configuration, use samba3 param python wrapper. Other databases (idmap, registry, wins) are still parsed in python. Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26s3-passdb: Make domain_sid argument optional for search_aliases methodAmitay Isaacs1-5/+10
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26s3-passdb: Return assigned number of hours and not MAX_HOURS_LENAmitay Isaacs1-3/+4
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26s3-passdb: Convert lm_pw and nt_pw to python string using lengthAmitay Isaacs1-2/+2
lm_pw and nt_pw are fixed length strings and convert them to python strings as fixed length strings. Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26script: Fix the name of the script in autogenerated header fileAmitay Isaacs1-1/+1
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26s4-param: Use s3 dump method if s3 context is definedAmitay Isaacs1-0/+4
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26s3-param: Add a dump() method to output parametersAmitay Isaacs2-0/+2
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26s3_upgrade: Let python generate backtrace for unknown exceptionsAmitay Isaacs1-15/+4
Catch known exceptions only. Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26s3_upgrade: Add document strings for python methodsAmitay Isaacs1-9/+23
Signed-off-by: Andrew Bartlett <abartlet@samba.org>
2011-08-26werror: remove duplicate definition of WERR_INVALID_OWNERMichael Adam1-1/+0
Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Fri Aug 26 01:23:52 CEST 2011 on sn-devel-104
2011-08-25s3:dbwrap_tdb: correctly catch the error from the return code of tdb_parse ↵Michael Adam1-1/+6
in db_tdb_fetch()
2011-08-25s3:smbd: remove an unused variable in dptr_create()Michael Adam1-1/+0
2011-08-25s3:registry: fix the v2_to_v3 upgrade code so that it does not create value ↵Michael Adam1-0/+6
list security records for the INFO/version key ...
2011-08-25s3:registry: fix the v1_to_v2 upgrade code so that it does not normalize the ↵Michael Adam1-0/+6
INFO/version key ...
2011-08-25s3:registry: define a constant REGDB_VERSION_KEYNAME for the key ↵Michael Adam1-7/+6
INFO/version (and use it)
2011-08-25s3:registry: hand db context in to v2_to_v3 upgrade code via private_dataMichael Adam1-4/+9
This also fixes the earlier faulty handing in of a useless stackframe memory context via private_data.
2011-08-25s3:registry: fix broken use of dbwrap store record in v1_to_v2 upgrade codeMichael Adam1-8/+10
This also fixes broken private_data parameter for the traverse function (making use of it): Originally a memory context was handed in but was not used.
2011-08-25s3: Fix the build of vfs_aixacl2.cSATOH Fumiyasu1-0/+1
Autobuild-User: Volker Lendecke <vlendec@samba.org> Autobuild-Date: Thu Aug 25 23:06:12 CEST 2011 on sn-devel-104
2011-08-25s3: Remove a bogus commentVolker Lendecke1-4/+0
2011-08-25s3: Pass smbd_server_connection to (unused) server_encryption_shutdownVolker Lendecke2-2/+2
2011-08-25s3: Pass smbd_server_connection to srv_encrypt_bufferVolker Lendecke3-3/+5
2011-08-25s3: Pass smbd_server_connection to srv_decrypt_bufferVolker Lendecke3-4/+3
2011-08-25s3: Pass smbd_server_connection to srv_free_enc_bufferVolker Lendecke3-4/+4
2011-08-25s3: Pass smbd_server_connection to is_encrypted_packetVolker Lendecke4-8/+11
2011-08-25s3: Pass sconn to valid_smb_headerVolker Lendecke1-4/+5
2011-08-25s3: Explicitly pass smb_srv_trans_enc_ctx to srv_enc_ctxVolker Lendecke1-3/+3
2011-08-25s3: Fix some nonempty blank linesVolker Lendecke2-6/+6
2011-08-25s3: Fix bug 8385Volker Lendecke1-26/+14
Poll and select behave differently regarding error handling. When doing the connect(2), we can not rely on poll telling us both readability and writability upon error. Just always try a second connect(2). At least on Linux it returns 0 when it succeeded. Signed-off-by: Jeremy Allison <jra@samba.org> Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Thu Aug 25 19:39:12 CEST 2011 on sn-devel-104
2011-08-25s3-waf: fix some unresolved symbols in idmap ad modules.Günther Deschner1-0/+2
Guenther Autobuild-User: Günther Deschner <gd@samba.org> Autobuild-Date: Thu Aug 25 15:15:57 CEST 2011 on sn-devel-104
2011-08-25s3-registry: fix bug #8401 - registry/reg_format.c must include includes.h.Günther Deschner1-0/+1
Guenther
2011-08-25s4-dsdb: fixed use of RMD flags in ldb search in dirsync moduleAndrew Tridgell1-2/+2
I'm pretty sure a SHOW_DELETED was wanted here Pair-Programmed-With: Andrew Bartlett <abartlet@samba.org> Autobuild-User: Andrew Tridgell <tridge@samba.org> Autobuild-Date: Thu Aug 25 01:10:13 CEST 2011 on sn-devel-104
2011-08-25s4-dns: fixed dns_update_list for multi-domain forestsAndrew Tridgell1-13/+28
this should now match the DNS entries of w2k8r2c Pair-Programmed-With: Amitay Isaacs <amitay@gmail.com>
generated by cgit (git 2.34.1) at 2024-11-12 22:28:24 +0000