| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
metze
|
|
This should avoid confusion between smbd_server_connection
and connection_struct variables.
metze
|
|
|
|
Some recent versions of Inkscape (0.47 or around) have bug when export file name
is treated as relative against the directory of original .svg if it wasn't specified
as an absolute path. Fix it by always using absolute paths during conversion.
|
|
layer (as it's done in onefs). This simplifies greatly the
code in smb_set_file_time() w.r.t. changenotify messages.
Jeremy.
|
|
"change time" has no notify message, so don't send anything
out when we change it. Use FILE_NOTIFY_CHANGE_CREATION correctly
when changing the create time.
Jeremy.
|
|
easier way
|
|
metze
|
|
metze
|
|
metze
|
|
metze
|
|
metze
|
|
So that we can reuse it for SMB2 Find.
metze
|
|
metze
|
|
They're both only used in the context of a function,
so we can make them stack variables.
metze
|
|
metze
|
|
metze
|
|
metze
|
|
metze
|
|
This can be NULL for faked connection structs used in the rpc server
or printing code.
metze
|
|
|
|
metze
|
|
metze
|
|
metze
|
|
metze
|
|
metze
|
|
We now use 'named_pipe' instead.
metze
|
|
metze
|
|
wkssvc_Netr{Join,Unjoin}Domain2.
Guenther
|
|
|
|
|
|
This reverts commit 57b5269038624b70e117025af9b977e0addcdc8e,
6e044a22cf232798efbd40a2b55fd9556483d403 and
c9803ee26ad1b2f92f2ce7653ce16ac84d0b3eb6.
The correct location for net .po files is in locale/net/
|
|
|
|
|
|
|
|
During the creation of the 3 RPC pipes in winbind we try to steal the
RPC binding structure to be a child of the pipe once the pipe is
established. This fails with a talloc warning as the rpc connection
code already holds a reference to the binding.
The fix is to use talloc_reparent() instead.
|
|
Previously we relied on process groups and SIGTERM to ensure that
child tasks died in the standard process model when the parent task
died. This doesn't work when the server is run in interactive mode, as
in that case we don't call become_daemon() and don't get a separate
process group.
The fix is to have a pipe held open by the parent server process, and
inherited by child tasks. If the parent exits then the write side of
the pipe is implicitly closed, which causes an event in the child
tasks that causes them to exit
|
|
While testing the use of the standard process model with 'make test' I
found that testing was much slower (by several times) with the
standard model than with the single model. The primary problem was
that each SMB connection would open a new sam ldb context, and all of
those would reload the full AD schema.
The fix is to pre-open the SAM during server startup, before any child
processes are forked. This sets up the global schema context which is
inherited by all connections.
The standard model is still slower at make test than the single model,
but not by nearly as much. I am working on further reducing the gap.
|
|
Before this change, the first opener of the sam ldb context would
become the owner of the global schema, then the autofree context got a
reference to the schema. Any subsequent opens of the sam ldb also got
a reference. This meant that the talloc hierarchy was inconsistent
between the first sam ldb open and subsequent opens. With this change
the autofree context becomes the owner of the global schema, and all
ldb contexts get a reference.
|
|
These references were triggering the ambiguous talloc_free errors from
the recent talloc changes when the server is run using the 'standard'
process model instead of the 'single' process model. I am aiming to
move the build farm to use the 'standard' process model soon, as part
of an effort to make our test environment better match the real
deployment of Samba4.
The references are not needed as the way that the event context is
used is as the 'top parent', so when the event context is freed then
all of the structures that were taking a reference to the event
context were actually freed as well, thus making the references
redundent.
|
|
Signed-off-by: Bo Yang <boyang@samba.org>
|
|
Signed-off-by: Bo Yang <boyang@samba.org>
|
|
This fixes a bug in the samba3sam test with the python libraries as
noticed by abartlet
|
|
|
|
|
|
|
|
Recently code was added to match windows semantics of denying the
rename of a directory if there are open files underneath it. This
does partly match windows semantics, but it turns out the rename
should be allowed if the open file handle is for the directory being
renamed, or for a stream on the directory being renamed. This patch
refines the check to better follow these rename semantics.
|
|
The existing test was only covering files opened underneath the
directory that was being renamed. It is not uncommon for windows
clients to actually hold a read-only handle to a directory open across
the rename, which it turns out doesn't return NT_STATUS_ACCESS_DENIED.
Additionally, holding a handle open to a stream on the directory is
also allowed.
|
|
Jeremy.
|
|
Jeremy.
|
