summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2012-02-16lib/util: Remove sys_poll as it is no longer neededAndrew Bartlett8-110/+14
sys_poll() is only needed if the signal pipe is set up and used, but as no signal handler ever writes to the pipe, this can all be removed. signal based events are now handled via tevent. Andrew Bartlett Signed-off-by: Jeremy Allison <jra@samba.org>
2012-02-16lib/util: Remove unused sys_select_signal()Andrew Bartlett2-19/+0
Now sys_poll needs to be cleaned up not to refer to the pipe that is now not used. Andrew Bartlett Signed-off-by: Jeremy Allison <jra@samba.org>
2012-02-16s3-librpc: Remove gse_verify_server_auth_flagsAndrew Bartlett1-50/+0
gensec_update() ensures that DCE-style and sign/seal are negotiated correctly for DCE/RPC pipes. Also, the smb sealing client/server already check for the gensec_have_feature(). This additional check just keeps causing trouble, and is 'protecting' an already secure negoitated exchange. Andrew Bartlett Signed-off-by: Stefan Metzmacher <metze@samba.org> Autobuild-User: Stefan Metzmacher <metze@samba.org> Autobuild-Date: Thu Feb 16 21:19:44 CET 2012 on sn-devel-104
2012-02-16docs-xml: remove docs for "send spnego principal"Stefan Metzmacher1-28/+0
metze
2012-02-16s3-param Remove off-by-default and unused "send spnego principal"Andrew Bartlett2-11/+0
This is not honoured by the common SPNEGO code. This matches mondern windows versions which do not send this value, as it would be insecure for a client to rely on it. (See also the depricated client use spnego principal directive). Andrew Bartlett Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-02-16s3-smbd Remove unused code now we always have SPNEGO via gensecAndrew Bartlett4-49/+7
This was previously needed because SPNEGO was only available in the AD DC. Andrew Bartlett Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-02-16s3-librpc: Use gensec_spnego for DCE/RPC authenticationAndrew Bartlett10-1009/+42
This ensures that we use the same SPNEGO code on session setup and on DCE/RPC binds, and simplfies the calling code as spnego is no longer a special case in cli_pipe.c A special case wrapper function remains to avoid changing the application layer callers in this patch. Andrew Bartlett Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-02-16s3-gse: Use the session key type, not the lucid context to set NEW_SPNEGOAndrew Bartlett1-67/+69
Using gss_krb5_export_lucid_sec_context() is a problem with MIT krb5, as it (reasonably, I suppose) invalidates the gssapi context on which it is called. Instead, we look to the type of session key which is negotiated, and see if it not AES (or newer). If we negotiated AES or newer, then we set GENSEC_FEATURE_NEW_SPENGO so that we know to generate valid mechListMic values in SPNEGO. Andrew Bartlett Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-02-16s3-librpc: Remove unused bool gensec_hookAndrew Bartlett1-2/+0
Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-02-16s3:rpc_client: fix commentStefan Metzmacher1-1/+1
metze
2012-02-16s3-librpc: make gensec result handling more genericAndrew Bartlett1-11/+11
This prepares us for handling SPNEGO via gensec Signed-off-by: Stefan Metzmacher <metze@samba.org>
2012-02-16wafsamba: exclude '.brzignore' from "make dist"Michael Adam1-1/+1
.bzrignore can cause unwanted effects, if one e.g. maintains a packaging (like debian) of the generated distribution in bzr. Autobuild-User: Michael Adam <obnox@samba.org> Autobuild-Date: Thu Feb 16 13:47:52 CET 2012 on sn-devel-104
2012-02-16wafsamba: exclude '.gitignore' from "make dist"Michael Adam1-0/+1
.gitignore can cause unwanted effects, if one e.g. maintains a packaging (like debian) of the generated distribution in git
2012-02-16wafsamba: fix blacklist handling in "make dist"Michael Adam1-1/+1
2012-02-16s4:provision: only print the adminpass if it was generated (not user-provided)Michael Adam1-1/+5
2012-02-16s4:provision: generate the adminpass provision() instead of provision_fill()Michael Adam1-2/+3
so that the adminpass can be logged at the end (otherwise we get "None")
2012-02-16s4:provision: don't log the ldap admin password - it is internal onlyMichael Adam1-3/+0
2012-02-16s4-scripting: samba-tool: Fix domain info usage messageBjörn Baumbach1-1/+1
Signed-off-by: Michael Adam <obnox@samba.org>
2012-02-16s4-selftest: fix output of opened connections in torture_holdconBjörn Baumbach1-1/+1
Signed-off-by: Michael Adam <obnox@samba.org>
2012-02-16Rename obscure defined constants.Christopher R. Hertel (crh)11-25/+27
Replaced the undescriptive SMB_PORT1 and SMB_PORT2 defined constants with the slightly more descriptive names NBT_SMB_PORT and TCP_SMB_PORT. Also replaced several hard-coded references to the well-known port numbers (139 and 445, respectively) as appropriate. Small changes to clarify some comments regarding the two transport types. Signed-off-by: Simo Sorce <idra@samba.org> Autobuild-User: Simo Sorce <idra@samba.org> Autobuild-Date: Thu Feb 16 08:29:41 CET 2012 on sn-devel-104
2012-02-16s3-selftest: Remove .posix_s3 from s3 test namesAndrew Bartlett3-10/+10
As far as I can tell, this simply referred to the posix_s3.sh script that originally ran these tests. Andrew Bartlett Autobuild-User: Andrew Bartlett <abartlet@samba.org> Autobuild-Date: Thu Feb 16 06:57:09 CET 2012 on sn-devel-104
2012-02-16selftest: Remove 'if have_ads_support:' from tests.pyAndrew Bartlett2-64/+41
The selftest system now skips launching these if the environment is not available. Andrew Bartlett
2012-02-16s3-smbd: Avoid starting log lines with the word 'error'Andrew Bartlett1-2/+10
2012-02-16selftest: skip plugin_s4_dc if we do not have ADSAndrew Bartlett1-0/+5
2012-02-16selftest: Run nsstest against more environmentsAndrew Bartlett1-4/+5
2012-02-16selftest: skip targets that are not compiled in if we do not have ADSAndrew Bartlett1-0/+25
2012-02-16s3-selftest: Require SMB signing for ktest environmentAndrew Bartlett1-0/+1
This will help weed out session key errors in the krb5 code. Andrew Bartlett
2012-02-16selftest: Do not start up an already-running test environmentAndrew Bartlett2-0/+8
Otherwise we may re-provision the dc just because we started it via s3member or s4member first. Andrew Bartlett
2012-02-16selftest: Make plugin_s4_dc set the cached environment correctlyAndrew Bartlett1-10/+12
2012-02-16wintest: update WinXP-1 snapshotAndrew Bartlett1-1/+1
2012-02-16wintest: Change Windows 7 VMAndrew Bartlett1-3/+3
2012-02-16wintest: Give the Windows VM a little more time to start back upAndrew Bartlett1-1/+1
2012-02-16wintest: Samba is now all version 4.0Andrew Bartlett1-4/+4
2012-02-16wintest: Cope with nc not timing out even when -w 1 is specifiedAndrew Bartlett1-2/+16
2012-02-16wintest: s3 moved smb.conf to /etcAndrew Bartlett1-2/+2
2012-02-16wintest: Update VM used for W2K8R2AAndrew Bartlett1-2/+2
2012-02-16wintest: Allow access denied when turning off the firewallAndrew Bartlett1-2/+2
2012-02-16wintest: Retry joining the domain a few timesAndrew Bartlett1-4/+12
2012-02-16wintest: connect to correct hostname in test_net_useAndrew Bartlett2-4/+4
2012-02-16s3-nmbd: Initialise newly non-static variablesAndrew Bartlett1-4/+4
Found by testing with wintest. When the variables were made non-static in c21f6a1c6869a5086634bb830d6c3689dea539a3 the implicit initialisation to 0 was lost. Andrew Bartlett
2012-02-15s3: Add SERVERID_UNIQUE_ID_NOT_TO_VERIFY, bug 8760Volker Lendecke4-6/+40
Autobuild-User: Jeremy Allison <jra@samba.org> Autobuild-Date: Wed Feb 15 21:10:22 CET 2012 on sn-devel-104
2012-02-15s3-printing: fix crash in printer_list_set_printer()David Disseldorp1-1/+1
The printer list database format was recently changed to accommodate for the printcap location field. One of the tdb_pack calls is not provided with a location string argument, this causes a crash on some platforms. https://bugzilla.samba.org/show_bug.cgi?id=8762 Signed-off-by: Günther Deschner <gd@samba.org> Signed-off-by: Jim McDonough <jmcd@samba.org> Signed-off-by: Lars Müller <lars@samba.org> Autobuild-User: David Disseldorp <ddiss@samba.org> Autobuild-Date: Wed Feb 15 19:34:38 CET 2012 on sn-devel-104
2012-02-15tevent_signal: Fix a valgrind errorVolker Lendecke1-1/+2
This fixes an uninitialized read introduced by my fix for the tevent_signal destructors. From looking at the code you might believe that this kicks in only when talloc failed. But with -O3 I do see it in normal operations. Sorry for that. Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Wed Feb 15 17:58:37 CET 2012 on sn-devel-104
2012-02-14s3: files_struct->mode is only written, remove itVolker Lendecke4-5/+0
Autobuild-User: Volker Lendecke <vl@samba.org> Autobuild-Date: Tue Feb 14 19:14:29 CET 2012 on sn-devel-104
2012-02-14tdb: build and run unit tests in tdb/test/Rusty Russell1-7/+87
Now we can build the test binaries: the CCAN style is to compile everything called "compile_ok*.c", compile and run everything called "run*.c", compile, link with the module, and run everything called "api*.c", and link any other C files (presumably test helpers) into all the tests. Unfortunately, actually passing that between the various parts of wscript is painful, so I open-coded the names. Also, the tests expect to be run in a (temporary) directory they can pollute, with the test directory found in test/ (to find the canned TDB files, for example). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Autobuild-User: Rusty Russell <rusty@rustcorp.com.au> Autobuild-Date: Tue Feb 14 06:53:46 CET 2012 on sn-devel-104
2012-02-14tdb/test: fix up tests for use in SAMBA tdb code.Rusty Russell5-13/+16
1) Make sure we include "tdb_private.h" first, to get the right headers (esp. the correct setting of _FILE_OFFSET_BITS before unistd.h). 2) Fix 3G file test since expand logic has changed. 3) Fix nested transaction test, since default is to allow nesting. 4) Capture fdatasync, which was slowing down transaction expand. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2012-02-14tdb: wean CCAN-style unit tests off of tap.Rusty Russell25-23/+64
We could use subunit, but that's overkill. Just print messages when we fail, and use exit status. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2012-02-14tdb: import unit tests from CCAN into tdb/test/Rusty Russell35-1/+2567
I pulled tdb into CCAN as an experiment a while ago; it doesn't belong there, but it has accumulated some important unit tests. These are copied from CCAN version init-1486-gc438ec1 with #include "../" changed to #include "../common/". Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2012-02-14tdb: make tdb_private.h idempotent.Rusty Russell1-0/+3
The most convenient way to write unit tests in C is to directly #include the C files (CCAN uses this, for example). That works quite well, but it means that tdb_private.h now needs to be protected against multiple inclusions. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
2012-02-13s4:torture: add another SMB2 rename testChristian Ambach2-0/+131
this mimics Word 2010 saving a file Autobuild-User: Christian Ambach <ambi@samba.org> Autobuild-Date: Mon Feb 13 18:33:43 CET 2012 on sn-devel-104