summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2008-12-09s4: [2/3] Fix a delete on close divergence from windows and the associated ↵Tim Prouty1-5/+18
torture test This second patch fixes the deltest17 BASE-DELETE torture test to pass against win2k3/win2k8/winXPsp2
2008-12-09s3: [1/3] Fix a delete on close divergence from windows and the associated ↵Tim Prouty1-4/+2
torture test smbtorture4's BASE-DELETE:deltest17 was failing against win2k8, win2k3, and winXPsp2 but passing against samba. deltest17 does the following: 1. open file -> file is created 2. closes file 3. open file with DOC -> fnum1 4. check that DOC is not reported as being set from fnum1 5. opens file again Read Only -> fnum2 6. check that DOC is not reported as being set from either file handle 7. close fnum1 (the file handle that requested DOC to be set) 8. check if DOC is reported as being set from fnum2 * This is where windows and samba begin to diverge. Windows reports that the DOC bit is set, while samba reports that it is not set. 9. close fnum2 (the last remaining open handle for the file) 10.See if the file has been deleted. * On samba the file still exists. On windows the file was deleted. The way open_file_ntcreate is written now, if an open has the DOC bit set on the wire, DOC (fsp->initial_delete_on_close) is not set unless: a. the open creates the file, or b. there is an open file handle with a share_entry in the struct lck that has the SHARE_MODE_ALLOW_INITIAL_DELETE_ON_CLOSE bit set (let's call it SM_AIDOC). My understanding of SM_AIDOC is that it was added to differentiate between DOC being set on an open that creates a file vs an open that opens an existing. As described in step 8/10 above, it appears that windows does not make this differentiation. To resolve this issue there are three patches. This first patch is a simple proof of concept change that is sufficient to fix the bug. It removes the differentiation in open_file_ntcreate, and updates deltest17 to allow it to pass against win2k3/xp. This makes open_file_ntcreate more closely match the semantics in open_directory and rename_internals_fsp. This change also does not break any other tests in BASE-DELETE or "make test". Specifically test deltest20b which verifies the CIFSFS rename DOC semantics still passes :).
2008-12-10s4-samr: Fix Bug #5946. userparameters handling in torture test.Matthias Dieter Wallnöfer1-1/+7
Signed-off-by: Günther Deschner <gd@samba.org>
2008-12-10s4-samr: Fix Bug #5946. userparameters handling in samr server.Matthias Dieter Wallnöfer1-4/+6
Signed-off-by: Günther Deschner <gd@samba.org>
2008-12-09s3: Add the OneFS SMB_VFS_CREATE_FILE implementationTim Prouty6-711/+1162
This is the first pass at extending the onefs vfs module to support the CIFS-specific enhancements available on OneFS. Most of this patch is massaging the sama open path to work with ifs_createfile. ifs_createfile is a CIFS-specific syscall for opening/files and directories. It adds support for: - Full in-kernel access checks using a windows access_mask - Cluster-coherent share mode locks - Cluster-coherent oplocks - Streams - Setting security descriptors at create time - Setting dos_attributes at create time This patch does not implement the samba side of the streams support or oplocks support. Tests that expect oplocks to be granted or streams to be supported will fail. This will be remedied in upcoming patches.
2008-12-09s3: Add onefs_open.c with code copied verbatim from smbd/open.cTim Prouty1-0/+2028
This is an intermediate step that makes it much easier to see how the OneFS SMB_VFS_CREATE_FILE implementation diverges from stock samba. The goal is that more common code can be refactored into utility functions.
2008-12-09s3: Call fd_close from close_directoryTim Prouty1-0/+7
Some implementations of SMB_VFS_CREATE_FILE implementations actually keep an fd open for directories just as files. In this case it is necessary to call fd_close when closing directories. This is safe because fd_close is a no-op when fd == -1, which is true for directory opens originating from open.c (the default SMB_VFS_CREATE_FILE implementation).
2008-12-09s3: Refactor calculating path from relative_fid into a separate functionTim Prouty2-78/+100
2008-12-09s3: Refactor getting sec_info from a security_descriptor into separate functionTim Prouty3-13/+30
2008-12-09s3: Make a few open utility functions non-staticTim Prouty3-17/+49
This allows vfs modules that implement SMB_VFS_CREATE_FILE to access some of the useful utility functions.
2008-12-09Fix bug #5688 LPQ process is orphaned if socket address parameter is invalidSATOH Fumiyasu1-6/+33
2008-12-09s3-ldapsam: Fix Bug 5957: do not abort rename process on valid rename script.Günther Deschner1-1/+1
Guenther (cherry picked from commit 26139344fd0fac4fdd2a6752628b252fbd9b7450) (cherry picked from commit 866efa63a26f75bbf17cd4bebf639594e2feafba)
2008-12-09s4:rpc_server: don't keep half finished dcesrv_connection_contextsStefan Metzmacher1-41/+42
metze
2008-12-09s3-libnet: fix build warning (missing prototype).Günther Deschner1-2/+2
Guenther
2008-12-09s4:rpc_server: initialize rpc server module also for the named pipe caseStefan Metzmacher3-33/+49
This fixes bug #5878. metze
2008-12-09s3-samr: a level 18 password set needs to set the pwdlastset as well.Günther Deschner1-0/+4
Guenther
2008-12-09s3-srvsvc: fix build warning.Günther Deschner1-2/+2
Guenther
2008-12-08s3: Add support for access based share enumerationTodd Stecher4-19/+71
2008-12-08Fix bug #5953 - smbclient crashes: cli_list_new segmentation fault.Jeremy Allison1-1/+1
Jeremy.
2008-12-08Add wb_trans_send/revcVolker Lendecke2-33/+166
2008-12-08Add infrastructure to transfer winbindd_request/response asynchronouslyVolker Lendecke3-0/+583
2008-12-08Simplify async programming a bit with helper routinesVolker Lendecke7-31/+43
Introduce async_req_is_error() and async_req_simple_recv()
2008-12-08Streamline the async_sock API a bitVolker Lendecke2-42/+49
2008-12-08Add a "bytes_padding" parameter to smb_splice_chainVolker Lendecke2-12/+29
For example open&x and write&x needs the bytes to be aligned relative to the SMB header. In particular for write&x we should not have to move stuff around.
2008-12-08Factor out smb_splice_chain(), to be used by chain_reply() in smbdVolker Lendecke2-46/+101
2008-12-08s4:rpc_server: fix crash bugs in 26200f4fb1db81be7a9da51f317e46405351b170Stefan Metzmacher1-7/+13
call->context needs to be valid. metze
2008-12-08s4:rpc_server: make it possible for iface->bind() to specify the assoc_group_idStefan Metzmacher2-5/+25
This helps the openchange mapiproxy plugin to work correctly. metze
2008-12-07Replace some pointless variables in reply_open_pipe_and_X by commentsVolker Lendecke1-12/+6
2008-12-07Fix nonempty blank linesVolker Lendecke3-44/+44
2008-12-07Slightly simplify cli_session_setup_ntlmsspVolker Lendecke1-10/+2
Remove three pointless variables
2008-12-06s4:winbind: fill in the correct variable...Stefan Metzmacher1-1/+1
metze
2008-12-06s4:secrets: remove unused structureStefan Metzmacher1-7/+0
metze
2008-12-06RPC-BROWSER: send the correct data in later requestsStefan Metzmacher1-0/+2
metze
2008-12-06s4:torture: add simple RPC-BROWSER testStefan Metzmacher3-2/+125
metze
2008-12-06s4:librpc: add SUBSYSTEM::RPC_NDR_BROWSERStefan Metzmacher1-0/+5
metze
2008-12-06s4:loadparm: start 'browser' rpc_serverStefan Metzmacher1-1/+1
metze
2008-12-06s4:dcesrv_browser: implement dcesrv_BrowserrQueryOtherDomains()Stefan Metzmacher1-1/+24
metze
2008-12-06s4:rpc_server: add dcesrv_browser templateStefan Metzmacher3-0/+163
metze
2008-12-06s4:brwoser.idl: add idl for BrowserrQueryOtherDomains()Stefan Metzmacher2-15/+43
metze
2008-12-06s4:winbind: move setting up the primary_sid into a new function ↵Stefan Metzmacher3-7/+46
wbsrv_setup_domains() metze
2008-12-05Fix logging to syslogDan Sledz1-1/+1
2008-12-05Fix bug #5928 - Option --version in testparm does not work.Tomasz Krasuski1-1/+1
2008-12-05Fix lp_socket_address() prototype.Jeremy Allison1-1/+1
Jeremy.
2008-12-05Fix bug #5944 - nmbd does not boot if socket adress = "" is defined in smb.confYasuma Takeda2-4/+17
2008-12-05Fix for crash bug freeing a non-malloc'ed buffer if the client sends a ↵Volker Lendecke1-0/+7
non-encrypted packet with the crypto state set.
2008-12-05s3-samr: fix samr_SetUserInfo level 18 server-side.Günther Deschner1-16/+46
Guenther
2008-12-05s4-smbtorture: do full level 18, 21, 23, 24, 25, 26 testing in pwdlastset test.Günther Deschner1-75/+33
Guenther
2008-12-05s4-smbtorture: add support for level 18 and 21 in test_SetUserPass_level_ex.Günther Deschner1-20/+73
Guenther
2008-12-05s4-smbtorture: more tests for RPC-SAMR-PASSWORDS-PWDLASTSET.Günther Deschner1-108/+181
Guenther
2008-12-05s4-smbtorture: add test for setting passwords via samr_UserInfo21.Günther Deschner1-1/+134
Guenther