Age | Commit message (Collapse) | Author | Files | Lines |
|
Of particular note is the change to pdb_free_sam() to take its sam argument by
reference, allowing it to be NULLified by the SAFE_FREE() macro, and the
changed to local_password_change() both to make it work and to remove the
duplicate code that caused so much breakage over the last few days.
- Small change in behaviour: when LOCAL_ADD_USER is set, the user doesn't
actually exist locally but does exist in the passdb we don't attempt to do a
GetPwnam(). (How the entry got there is another matter, and most passdbs won't
allow this anyway).
Andrew Bartlett
(This used to be commit 6b45e342fd1ed82d7f5bd613048fe862a6a6f2a1)
|
|
The big one is a global change to allow us to NULLify the free'ed pointer to a
former passdb object. This was done to allow idra's SAFE_FREE() macro to do
its magic, and to satisfy the input test in pdb_init_sam() for a NULL pointer
to start with.
This NULL pointer test was what was breaking the adding of accounts up until
now, and this code has been reworked to avoid duplicating work - I hope this
will avoid a similar mess-up in future.
Finally, I fixed a few nasty bugs where the pdb_ fuctions's return codes were
being ignored. Some of these functions malloc() and are permitted to fail.
Also, this caught a nasty bug where pdb_set_lanman_password(sam, NULL) acheived
precisely didilly-squat, just returning False. Now that we check the returns
this bug was spotted. This could allow different LM and NT passwords.
- the pdbedit code needs to start checking these too, but I havn't had a
chance to fix it.
I have also fixed up where some of the password changing code was using the
pdb_set functions to store *internal* data. I assume this is from a previous
lot of mass conversion work...
Most likally (and going on past experience) I have missed somthing, probably in
the LanMan password change code which I havn't yet been able to test, but this
lot is in much better shape than it was before.
If all this is too much to swallow (particularly for 2.2.2) then just adding a
sam_pass = NULL to the particular line of passdb.c should do the trick for the
ovbious bug.
Andrew Bartlett
(This used to be commit 762c8758a7869809d89b4da9c2a5249678942930)
|
|
(This used to be commit d38bc1dceccaa4cbdaf3ac4d561225229161714a)
|
|
warnings)
(This used to be commit b648cc669d16eb40b477c8dc51efeab485a15de5)
|
|
to support 2.0.x style WIn9x driver download.
(This used to be commit d0628d0d2d5f5366179d2508456ae06ce3879be3)
|
|
Jeremy.
(This used to be commit 4c5158d1e5620ccc3f2812a3fbedcb60a67caecc)
|
|
error in here...
Now you can change local passwords again. There is stil somthing broken about
remote (via windows/sampasswd) password changing.
I shall have to revise my testing, I honestly don't know how this slipped
through the net.
MERGE for 2.2.2.
Sorry,
Andrew Bartlett
(This used to be commit 1f83184f881d0cabb698947660a12f729e625fae)
|
|
these yesterday ?).
Jeremy.
(This used to be commit e25dc68843ed10d8454cb8166c39ff4b2e6a4159)
|
|
Jeremy.
(This used to be commit 76fac3eb945c7ced28c5685849d3616bb7c89ca2)
|
|
Jeremy.
(This used to be commit 65bf4a36ef5967b0844ab985d7b3ea31138dd4c5)
|
|
"Always compile before commit" :-((
Volker
(This used to be commit 69a3277fc5be35536168ba195968b8b76f0b5954)
|
|
store mangled filename in dos charset and unmangled in unicode.
clean ups
still lot to do.
againg compiled but not yet tested.
(This used to be commit 2d1aabb6d4bf23985a9ce0f7e065292aacedc80a)
|
|
to use the pdb_ formatting functions.
Similarly, it now uses pdb_set...() rather than accessing passdb members
directly.
Andrew Bartlett
(This used to be commit e3b7cac47f4fd9dff289a367ef6649b14c117d17)
|
|
(This used to be commit 758d923fa183b50acab9928e402f17bd25ba8f41)
|
|
- call pdb_reset_sam() after each getent call.
Fix bug in get_group_alias_entries(), were if num_entries was zero this caused
talloc() to return NULL, failing a test below with NT_STATUS_NO_MEMORY.
Fix pdb_reset_sam() to correctly initalise the sam structure.
Move default value code into a single place, likewise for sam freeing code.
- should make things easier if we decide to malloc other strings, or get more
non-zero default values.
Finally, add a function in init a sam struct from a getpwnam() return.
Andrew Bartlett
(This used to be commit a41fb44f5e90cf8734d57217e836e14f4a80bd47)
|
|
(This used to be commit 9d8cbf3d5db35df6aa50636a48444caf10441c8c)
|
|
(This used to be commit 57e639bbdd115b51362caf7e3db4ba34ccdeddc2)
|
|
(This used to be commit 2f44756233e2655856f003bb15c3898118756b98)
|
|
(This used to be commit efc6df5a3914da9e7b792ccaccd1403c72c09f78)
|
|
Volker
(This used to be commit 50ea73426f58070859bbbe769c8353a11ff33dc9)
|
|
(This used to be commit 247b9c3eba78f0ddd26d836e5e18f6630bf302c7)
|
|
Fix the NT errror codes, this time in line with WinXP/2k.
- Return the normal error codes, expect for bad user/bad password. These map
to logon failure, as a quick security hack. We follow suit.
Simplfy some of the password extraction code, the auth subsytem has the
intelegence to sort this stuff out, no need to do it here.
Move to 'global_encrypted_passwords_negotiated' to determine the use of
unencrypted hacks, replacing the current mess.
Andrew Bartlett
(This used to be commit c04f063573c61d8ef3f43815bbb9b6b076dc23eb)
|
|
just like any other logon. Matching code removal in reply.c to follow.
Andrew Bartlett
(This used to be commit da4873d889928e9bd88e736e26e4e77e87bcd931)
|
|
first.
Add password expiry and 'must change before first logon' support.
- This requires that the passdb be up to the job to supply the info.
(This used to be commit 53c1c5091ea4e3ccc294f8b6f132be78c11c431f)
|
|
This whole area needs to be cleaned up. Should this kind of passowrd
change/check be permitted with encrypt passwords = yes?
In any case I've also had trouble testing this, as I can't find the right
software/configuration to exersise this behaviour. But its better than the
previous situation. Any assistance greatly appriciated.
Andrew Bartlett
(This used to be commit 37655b42897031f754d436435e64a2548de756b5)
|
|
(This used to be commit ce676f8bfc6222df1e05b164420efab30eb1b2e1)
|
|
decode_pw_buffer() and the samr password changing routines.
And yes, I know that we can lost some information in the Unicode->UTF->Unicode
bit of this, but its worth the code cleanup.
This also takes into account the possability of multibyte passwords.
Andrew Bartlett
(This used to be commit 42402c87d6bcff71b700e497b74d2600d7ce8b95)
|
|
Merge for 2.2.2
Should TDB cope with TDB pointers itself?
Andrew Bartlett
(This used to be commit 27f0510a0b458792293d5ce2957f61383569f62f)
|
|
Also attempt to make some of the syntax clearer, its confusing enought for the
compiler... (it thinks that there is use of an unitilaised variable)
In fact there is, see next patch...
(This used to be commit 540abc8125f1b821bd362dc0d8c19a107382479f)
|
|
therfore ensuring sensible defaults for some values, notably account expriries
which mean 'locked out' if == 0.
This NEEDS to be merged into 2.2.2 or people can get wrongly initilaised TDB
records. (which will only fail on future versions of samba).
Andrew Bartlett
(This used to be commit f0f315f31533bb5dc47d27cd6823ad0b146f1ff9)
|
|
interfaces to the existing set NT and LM functions, but ensures we always do it
in the same way.
This also allows for the possibility for the unix password sync code to be
hidden behind the passdb interface as some stage.
(This used to be commit 33e3591b2db377e720ec484872e2cbe7343350b1)
|
|
This moves the check that ensures that the account being looked up is the same
account as the machine logged in as to the front, before we even start with
passdb.
Merge for 2.2.2?
Andrew Bartlett
(This used to be commit f7ed0ecc14aeba5ad260f24a76ced70cf52f8e48)
|
|
(This used to be commit e0e05cb5a51e0e46162febd0a45ea4f59b6f6573)
|
|
(This used to be commit 3f10b045666479e3e1981b09fcaa0d0810422fcb)
|
|
(fix up configure.in for default (smbpasswd) option)
Rerun autoconf.
(This used to be commit 0b9e13530d728ef3c19d6ff05d74b7e594bf9a4c)
|
|
Jeremy.
(This used to be commit bca6419447e926e51aeecf3e484228f640cecb84)
|
|
Jeremy.
(This used to be commit 611bf806d569b70edabbc04a2f5408142370a550)
|
|
(This used to be commit 322ba52f71045002c6b969fb87932ee8b7d578c8)
|
|
used by SWAT into $swatdir/$ln/{help,images,include}
we have still points which needs to discuss, that is how to archive
and install lots of HTML help files and Using Samba files.
-- monyo
(This used to be commit 9ec2d5e96ebb907e66250772057bf5e2601f8ec9)
|
|
the one in the sampass anyway.
Andrew Bartlett
(This used to be commit 29b7434293d7778376486b241f9458a71fa843a6)
|
|
Subject:
Re: bugs in installman.sh script
Date:
Tue, 25 Sep 2001 16:02:11 +0200 (CEST)
From:
Rafal Szczesniak <mimir@spin.ict.pwr.wroc.pl>
To:
Andrew Bartlett <abartlet@pcug.org.au>
CC:
<samba-technical@lists.samba.org>
On Tue, 25 Sep 2001, Andrew Bartlett wrote:
> Its broken for BSDs and was broken for many others. You might want to
> re-checkout. Any fixes appricatiated.
OK. Here's the patch for configure.in. Replaces illegal, under [t]csh,
substitution with more general sed construction. Apply it, please, and
I'll see if I can clean up the installman.sh further.
(This used to be commit cad971f4c37042c4e9b6e6332e55757473f6da78)
|
|
(This used to be commit 7f07004571ad1b8d1ce787f6788b4c4d8685db37)
|
|
- some more utils for unicode string manipulation
(This used to be commit 4ade36446e7dee1c3828d8c822f047c6e891a644)
|
|
ran out of primes and used a power of two hash modulus. It ended up
sticking all the entries in just a few buckets. Yuck!
(This used to be commit fdc9952391027e209fbd24f7794b1c2b551b1f9f)
|
|
(This used to be commit 11a2808e10bb7885da04c19c261d3876c31ac08d)
|
|
server. This is just a framework right now - I want this to eventually
replace the win32 test code from monyo
The interesting this about this test is that it shows up a really
horrible performance bug in our stat cache code. I'll see if I can fix
it.
(This used to be commit eb668b54af4925194c07b217724657f406ec00d0)
|
|
'./config.status --recheck' by making it a real configure option.
reran autoconf
(This used to be commit 23173125cd124508a080cfc11436273efcbeedb6)
|
|
char like libiconv does
(This used to be commit e13e8b190c70136cb2c3588bdcf7328a7f61d152)
|
|
(This used to be commit b2eb7feb7f5bafe953fdeb92daaf9e4f08e44983)
|
|
(This used to be commit a302bb20e28ea2e4d04eca34a23ff42e9bc07b05)
|