Age | Commit message (Collapse) | Author | Files | Lines |
|
Debug1() was being called like this:
Debug1( format_bufr );
but if format_bufr contains any %s or other % arguments (such as when
processing a smb.conf file containing % macros) then smbd dies a
horrible death.
The quick fix is to use:
Debug1( "%s", format_bufr);
(This used to be commit 5ae04012819ae3e63102d6875088ef00c27492b4)
|
|
causing seg faults on my machine and because the fault code calls
DEBUG() it is looping!
now to find the bug in the Debug1() code ...
(This used to be commit 83122bae2253221f085118c6e7e914982656bd64)
|
|
manpath in (although we don't currently use it).
client/client.c: Added John Blair's fixes for "put -".
include/nterr.h: Added NT_STATUS_NOTIFY_ENUM_DIR error code.
smbd/nttrans.c: Added in devious fix for one-shot NT change notify bug.
Jeremy.
(This used to be commit 4ac3091e57e9ab234b3c051333ba521a92defa99)
|
|
(This used to be commit 5fc8b4a1d5d973028396b667daaa119d21f0c0f0)
|
|
include/smb.h: Fixed bugs in Debug macro's with SGI compiler.
smbd/trans2.c: Fixed bug reported by Zoltan Palmai <ZSPA@chevron.com>
PR#8903 where get_lanman2_dir_entry() could return a
mangled name as a resume key and call_trans2findnext()
wasn't doing the same.
Jeremy.
(This used to be commit 9d010e721c27af1d9498fd1e147993ba8ac8b41e)
|
|
modified it not to need any smbd specific structures and instead pass
things from smbd.
(This used to be commit 162141d3b3fcf53fbc6a1f18702df85c2b7f1781)
|
|
into passdb/pass_check.c. This means SWAT no longer needs to link to
smbd/password.c
(This used to be commit 90d93889d722670cbb517017531264630af759bf)
|
|
utilities
(This used to be commit 745d38bfe7a989a602d14b8a04757893ae40ba8e)
|
|
(This used to be commit 12c8028eb45d3e274e3496da1a2e4f6d18c117fd)
|
|
(This used to be commit 60cdb83f3f6dfd7755e46254662245a82a8ef498)
|
|
(This used to be commit 7fecc3d5a2fb641237f24a3f39c6556fde648a8a)
|
|
I'll do the rest tomorrow.
(This used to be commit b92ce41c54fa187bce3287257996f7a3e9c9b9ff)
|
|
something about our dependencies between seemingly unrelated code.
(This used to be commit 3ecfd271de5e6f7b4868800e7c06d51ed69278fd)
|
|
illogical places. Once I get everything compiled these will need to be
revisited, but at least the new Makefile.in makes it really obvious
what is out of place.
(This used to be commit beef5341fc313249bf1117deccb9c21c510c4697)
|
|
(This used to be commit 34dd9b79457ab01637e0d7374d33cafe2f859c99)
|
|
(This used to be commit d08fa39cec5c71a9034dbf4241fc7e195f1bbaa5)
|
|
Chris, you should never put if statements in macros, use the ugly
(a?b:c) form instead, otherwise you can produce incorrect code when
you have things like:
if (foo)
DEBUG((blah));
else
DEBUG((blooh));
(This used to be commit ab912448c1ff2487b6a313574d72f389baa65e6d)
|
|
(This used to be commit 251213898077a11d71b208434c65748f922d7e9a)
|
|
(This used to be commit 687f76a17d6d3ebd33b4d9a848deef56f3c1f56a)
|
|
(This used to be commit be762dc3de6c1ef768790522dfe93007a61ce5d7)
|
|
now the Makefile .....
(This used to be commit 4fae7f129e46930960831af0da28496f9766f6ae)
|
|
(This used to be commit 7067261760516c01c2dd4fa7f0a717e9c48e1554)
|
|
functions (notably innetgr) to ensure we don't replace them if they
are in -lsocket
(This used to be commit d1212048903fff8725e501001ac84b019c21b939)
|
|
(This used to be commit 70000c21909a154344b489e8aa18a5868ff52865)
|
|
(This used to be commit 8bf365a54a5aedbd1b2aa373aa6b26a9708d7156)
|
|
update make scripts to use new autoconfigure setup
(This used to be commit 737a58c1568fd76afe32a78895ee09b1543a595d)
|
|
Jeremy.
(This used to be commit 996c5ac97a8d1443bc8abc59b9a10ff3aeb77389)
|
|
the correct directory before doing the stat. Doh !
uid.c: Fix for performance in security=share mode. Invalid vuid meant
that in security=share mode Samba was always doing the become_user/
undebome_user pairs for *every* smb. This code fixes it, but tridge
should review for security implications.
Jeremy.
(This used to be commit c3663379fdcec487feea2e5d848ee012ee6c6baf)
|
|
nttrans.c: Moved common code into function in server.c
Removed left over debug level 0.
server.c: Moved common code into function in server.c
Jeremy.
(This used to be commit 34ef55b7228155cef40cbdfcdc1fe623c1037bd6)
|
|
so that we wouldn't get too many timestamps.
Chris -)-----
(This used to be commit 3e7e5fad378cf144927d9f2ffc82f80e150d44ab)
|
|
for changes in the directory modify timestamps. A better version
will look at the requested client flags, and create a hash that
represents the current state of the directory, and check against
this instead.
debug.c: Added lp_timestamp_logs() function.
loadparm.c: Added "change notify timeout" in seconds (default 60)
- this is the scan rate for a directory.
Added ""timestamp logs" boolean - default True. Turns
off log timestamps (so I can read them :-).
nttrans.c: ChangeNotify implementation.
server.c: ChangeNotify implementation.
shmem_sysv.c: Added exits on shmem errors (without them smbd can
core dump if some calls fail).
smb.h: Added ChangeNotify flags for future use.
util.c: Tidied up typedef.
Jeremy.
(This used to be commit a0748c3f53974483680ebe2ea4f556ece8d7fa43)
|
|
very long output line in become_domain_master_query_success().
Chris -)-----
(This used to be commit 9b5d431661c55056c31bedf9ef3900f27e1c5292)
|
|
through and changed some DEBUG() calls to DEBUGADD() to combine output
under a single timestamp. There were too many timestamps.
Note that Jeremy has told me that he's working on adding a config parameter
to turn timestamps off. Cool.
Chris -)-----
(This used to be commit 247dbc9a24987035a47f1ba4fa143b1e2c050e92)
|
|
Replaced printfs with DEBUG(0. Tested ... Works.
Hope I didn't disturb the autoconf code ... It feels
great to be able to run configure for Samba at long last!
Regards
Richard Sharpe
(This used to be commit b968aa31ba15742a9eadc010e03781583feb6455)
|
|
when Andrew and I were both working with util.c. I really don't know
how I lost the autoconfigure changes (honest, I *did* run frequent
updates).
Chris -)-----
(This used to be commit bedefc2066ac86199b29ccd7f65ad5f1d8a899c4)
|
|
for the rest. I've found that only debug.h seems to be out of sync (i.e.,
util.c itself appears to be okay).
Chris -)-----
(This used to be commit b41cdbffb7233f73ac15526f7b5499658256cd82)
|
|
timestamps from several DEBUG messages. The timestamps are redundant now
that DEBUG() provides them automatically.
There are still a few more files to do, but I've got to get home for dinner.
Chris -)-----
(This used to be commit 60286ccecaa6028d687e6406755016455e3b3a26)
|
|
Chris -)-----
(This used to be commit 2c6dc2779647bbc0c27a102632882e617ef7643e)
|
|
Makefile.in: I've added debug.o.
proto.h : Rebuilt, as is standard for these sorts of things.
smb.h : New macros, etc.
util.c : Debug code removed.
I'll check in debug.c in the next step.
Chris -)-----
(This used to be commit 653c17c1b8e34bfbd05ea35ada9436a50d5a7ba4)
|
|
(This used to be commit 4eb28f7148f61a215ca644cbe704a4e8dbd83a77)
|
|
loadparm.c: Added "ole locking compatibility" option (default "true").
locking.c: Changes to implement union in files_struct.
locking_shm.c: Changes to implement union in files_struct.
nttrans.c: Made opening a directory explicit (we have to).
Added create directory code for nttrans.
reply.c: Changes to implement union in files_struct.
server.c: Changes to implement union in files_struct. Added create directory code.
trans2.c: Changes to implement union in files_struct.
smb.h: Changes to implement union in files_struct.
util.c: Changed linked list code to UNIQX linked list. This will make
the other lists I need to implement for ChangeNotify and blocking
locks easier.
Jeremy.
(This used to be commit 3a5eea850bb256b39cff8ace1e4fb4e0c1f5472b)
|
|
I also need to know if the __FILE__ macro exists. I followed the example,
but ran into two problems:
1) I don't have the autoconf tools installed.
2) The instructions did not say which files should be checked in after
running autoheader and autoconf.
So I'm checking in the modified acconfig.h and configure.in on the
assumption that the next time someone runs autoheader and autoconf my
new tests will be included.
Hope that's not a problem (and I'll try to grab a copy of autoconf from
somewhere).
Chris -)-----
(This used to be commit 0637a49d5d6c03f10d462be4e92c4e4bbf7ff6c2)
|
|
(This used to be commit cae580ccc397ea33fdb24a777bdedef6e8271244)
|
|
(This used to be commit 15b666a0cebb994b6ed96c75716946afdbfa2861)
|
|
(This used to be commit fc1947b52a37bf2c0739091f3dbd84c4a9781d93)
|
|
(This used to be commit 0bdb51af3199eb32cd3da4c4b8d31fbed5d2ae85)
|
|
(This used to be commit 32bd7137122eedf44dbb092da5ae3106d8fe994e)
|
|
IRIX+gcc-2.8.1)
(This used to be commit ddffbcbcb1284b6ead5f7f7b6665ba2456c0071a)
|
|
(This used to be commit f4c629bde2bbcb0cfa4d6f5cb1aa7edddf569fac)
|
|
from committing changes to it.
(This used to be commit a7d4e6697fb724def740b8bbfc3e88ae651cc20e)
|